Re: [PATCH v3 2/3] media: au0828 - convert to use videobuf2

2015-01-22 Thread Lad, Prabhakar
Hi Shuah, Thanks for the patch. On Tue, Jan 13, 2015 at 2:56 AM, Shuah Khan shua...@osg.samsung.com wrote: Convert au0828 to use videobuf2. Tested with NTSC. Tested video and vbi devices with xawtv, tvtime, and vlc. Ran v4l2-compliance to ensure there are no regressions. video now has no

Re: [PATCH v3 2/3] media: au0828 - convert to use videobuf2

2015-01-22 Thread Shuah Khan
Hi Prabhakar, thanks for the review, please see in-line. On 01/22/2015 05:41 AM, Lad, Prabhakar wrote: Hi Shuah, Thanks for the patch. On Tue, Jan 13, 2015 at 2:56 AM, Shuah Khan shua...@osg.samsung.com wrote: Convert au0828 to use videobuf2. Tested with NTSC. Tested video and vbi

Re: [PATCH v3 2/3] media: au0828 - convert to use videobuf2

2015-01-22 Thread Shuah Khan
On 01/22/2015 01:47 PM, Lad, Prabhakar wrote: Hi Shuah, On Thu, Jan 22, 2015 at 4:16 PM, Shuah Khan shua...@osg.samsung.com wrote: Hi Prabhakar, [snip] + buf-vb.v4l2_buf.field = V4L2_FIELD_INTERLACED; + v4l2_get_timestamp(buf-vb.v4l2_buf.timestamp); +

Re: [PATCH v3 2/3] media: au0828 - convert to use videobuf2

2015-01-22 Thread Devin Heitmueller
- fh-type = type; - fh-dev = dev; - v4l2_fh_init(fh-fh, vdev); - filp-private_data = fh; + dprintk(1, + %s called std_set %d dev_state %d stream users %d users %d\n, + __func__, dev-std_set_in_tuner_core, dev-dev_state, +

Re: [PATCH v3 2/3] media: au0828 - convert to use videobuf2

2015-01-22 Thread Shuah Khan
On 01/22/2015 08:00 AM, Devin Heitmueller wrote: - fh-type = type; - fh-dev = dev; - v4l2_fh_init(fh-fh, vdev); - filp-private_data = fh; + dprintk(1, + %s called std_set %d dev_state %d stream users %d users %d\n, + __func__,

Re: [PATCH v3 2/3] media: au0828 - convert to use videobuf2

2015-01-22 Thread Lad, Prabhakar
Hi Shuah, On Thu, Jan 22, 2015 at 4:16 PM, Shuah Khan shua...@osg.samsung.com wrote: Hi Prabhakar, [snip] + buf-vb.v4l2_buf.field = V4L2_FIELD_INTERLACED; + v4l2_get_timestamp(buf-vb.v4l2_buf.timestamp); + vb2_buffer_done(buf-vb, VB2_BUF_STATE_DONE); } Why not just have