Re: [PATCH v2 2/2] adv7604: Use DT parsing in dummy creation

2014-08-31 Thread Laurent Pinchart
100644 --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt @@ -10,8 +10,12 @@ Required Properties: - compatible: Must contain one of the following - adi,adv7611 for the ADV7611 +- adi,adv7604 for the ADV7604

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Hans Verkuil
Hi Valentine, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 It adds adv761x support to the adv7604 in a pretty clean way. Thinking it over I prefer to use that code (although you will have to add the soc-camera

[PATCH 00/47] ADV7611 support

2014-02-05 Thread Laurent Pinchart
Hello, This patch set implements support for the ADV7611 in the adv7604 driver. It also comes up with new features such as output format configuration through pad format operations, hot-plug detect control through GPIO and DT support. Patches 06/47 to 27/47 replace the subdev video DV timings

Re: [GIT PULL FOR v3.16] adv7604: ADV7611 and DT support

2014-03-20 Thread Laurent Pinchart
20:26:59 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git adv7611 for you to fetch changes up to 240801bf4f2ca98bd41b45a186330797048529af: adv7604: Add endpoint properties to DT bindings (2014-03-20 15:33:50 +0100

[GIT PULL v2 FOR v3.16] adv7604: ADV7611 and DT support

2014-04-28 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 393cbd8dc532c1ebed60719da8d379f50d445f28: [media] smiapp: Use %u for printing u32 value (2014-04-23 16:05:06 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git linuxtv/adv7611 for you to fetch changes up

[GIT PULL v3 FOR v3.16] adv7604: ADV7611 and DT support

2014-05-25 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 85ac1a1772bb41da895bad83a81f6a62c8f293f6: [media] media: stk1160: Avoid stack-allocated buffer for control URBs (2014-05-24 17:12:11 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git linuxtv/adv7611 for you

[PATCH 1/2] media: adv7604: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
rties: - "adi,adv7611" for the ADV7611 - "adi,adv7612" for the ADV7612 - - reg: I2C slave address + - reg: I2C slave addresses +The ADV76xx has up to thirteen 256-byte maps that can be accessed via the +main I²C ports. Each map has it own I²C address and acts as a

Re: [PATCH] media: i2c: ADV7604: Rename adv7604 prefixes.

2015-02-04 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Wednesday 04 February 2015 10:55:21 Hans Verkuil wrote: On 02/03/15 18:13, Pablo Anton wrote: It is confusing which parts of the driver are adv7604 specific, adv7611 specific or common for both. This patch renames any adv7604 prefixes (both

[PATCH 23/35 linux-next] [media] constify of_device_id array

2015-03-16 Thread Fabian Frederick
of_device_id adv7604_of_id[] __maybe_unused = { { .compatible = adi,adv7611, .data = adv7604_chip_info[ADV7611] }, { } }; diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c index bbf4281..5b76e3d 100644 --- a/drivers/media/platform/fsl-viu.c +++ b/drivers/media

Re: [PATCH 0/3] media: Add SH-Mobile RCAR-H2 Lager board support

2013-09-24 Thread Guennadi Liakhovetski
- no problem with me either way. Thanks Guennadi On Tue, 24 Sep 2013, Valentine Barshak wrote: The following patches add ADV7611/ADV7612 HDMI receiver I2C driver and add RCAR H2 SOC support along with ADV761x output format support to rcar_vin soc_camera driver. These changes are needed for SH

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Laurent Pinchart
On Wednesday 25 September 2013 12:21:04 Laurent Pinchart wrote: Hi Valentine, Thank you for the patch. Please see below for a couple of comments (in addition to Hans' and Guennadi's comments). On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612

Re: [PATCH 0/3] media: Add SH-Mobile RCAR-H2 Lager board support

2013-11-11 Thread Laurent Pinchart
Hi Valentine, On Tuesday 24 September 2013 17:38:33 Valentine Barshak wrote: The following patches add ADV7611/ADV7612 HDMI receiver I2C driver and add RCAR H2 SOC support along with ADV761x output format support to rcar_vin soc_camera driver. These changes are needed for SH-Mobile R8A7790

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4a fa42af2daa12 No, I missed that one somehow, although I did search for the adv7611/7612 before implementing this one. I'm going to look closer

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4a fa42af2daa12 No, I missed that one somehow, although I did search for the adv7611/7612 before

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4a fa42af2daa12 No, I missed that one somehow, although I did

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
interrupt event, the ADV7611 does not generate a second interrupt signal. However, the interrupt_service_routine doesn't account for that. For example, in case fmt_change interrupt happens while fmt_change_digital interrupt is being processed by the adv7604_isr routine. If fmt_change status is set

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Laurent Pinchart
, + ADV7604_PAD_HDMI_PORT_D = 3, + ADV7604_PAD_VGA_RGB = 4, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit: ADV7604_PAD_SOURCE = 6, ADV7611_PAD_SOURCE = 1, I can do that, but those two constants won't

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Hans Verkuil
, + ADV7604_PAD_HDMI_PORT_C = 2, + ADV7604_PAD_HDMI_PORT_D = 3, + ADV7604_PAD_VGA_RGB = 4, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit: ADV7604_PAD_SOURCE = 6, ADV7611_PAD_SOURCE = 1, I can do that, but those two

Re: i.MX6 status for IPU/VPU/GPU

2014-07-28 Thread Robert Schwebel
Hi, On Mon, Jul 28, 2014 at 06:24:45PM +0200, Jean-Michel Hautbois wrote: We have a custom board, based on i.MX6 SoC. We are currently using Freescale's release of Linux, but this is a 3.10.17 kernel, and several drivers are lacking (adv7611 for instance) or badly written (all the MXC part

Re: [PATCH 2/2] adv7604: Add support for i2c_new_secondary_device

2014-10-22 Thread Laurent Pinchart
/Documentation/devicetree/bindings/media/i2c/adv7604.txt @@ -12,7 +12,10 @@ Required Properties: - adi,adv7611 for the ADV7611 - adi,adv7604 for the ADV7604 Given that I'll have comment on the independent patch that adds support for the adv7604, you should rebase this series to remote

Re: [PATCH 2/2] adv7604: Add support for i2c_new_secondary_device

2014-10-23 Thread Jean-Michel Hautbois
/i2c/adv7604.txt index 5c8b3e6..8486b5c 100644 --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt @@ -12,7 +12,10 @@ Required Properties: - adi,adv7611 for the ADV7611 - adi,adv7604 for the ADV7604 Given

Re: Preliminary HDCP code available in my tree

2015-12-18 Thread Hans Verkuil
missing documentation, it's tested with HDCP 1.4 only (not 2.2), and > it needs some > TLC, but it was working at the time. So this could be a good starting > point for someone. > > If someone decides to work on this, please contact me first. > > > I will give

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2016-12-29 Thread Jean-Michel Hautbois
ll asynchronous subdevices with >> > both >> > inputs and outputs would propagate s_stream to their source subdevices. > > > What is the status of this work ? I saw Steve's patches before yours, so > both are implementing pretty much the same functionnality but different

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2017-12-18 Thread Chen-Yu Tsai
t; > > +< CLK_CSI1_SCLK>, >> > > >> > > CSI also has an MCLK. Do you need that one? >> > >> > MCLK is not needed if the front end is not a sensor (like adv7611). >> > I will add it as an option. >> >> I guess th

Re: [PATCH] adv7604: add CEC support for adv7611/adv7612

2018-10-15 Thread Hans Verkuil
On 10/15/2018 05:15 PM, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your patch. > > On 2018-10-12 13:30:02 +0200, Hans Verkuil wrote: >> The CEC IP is very similar between the three HDMI receivers, but >> not identical. Add support for all three variants. >> >> Tested with an adv7604 and

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 12:21 PM, Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/27/13 11:29, Valentine wrote: On 11/27/2013 12:21 PM, Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Hi Hans, Did you ever look at this adv7611 driver

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https

HDMI input on i.MX6 using IPU

2015-01-08 Thread Jean-Michel Hautbois
Hi, I have modified both Steve's and Philipp's code, in order to get something able to get frames from an ADV7611. Right now, I am back to Philipp's base of code, rebased on top of media-tree, and everything works fine, except the very last link between SFMC and IDMAC (using media controller

[GIT PULL FOR v3.16]

2014-03-20 Thread Laurent Pinchart
Hi Mauro, The following changes since commit ed97a6fe5308e5982d118a25f0697b791af5ec50: [media] af9033: Don't export functions for the hardware filter (2014-03-14 20:26:59 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git adv7611 for you to fetch changes

Re: i.MX6 status for IPU/VPU/GPU

2014-09-15 Thread Jean-Michel Hautbois
are interesting. I easily added adv76xx devices to Steve's work, but there is no media controller support, as you previously said. I cannot get adv7611 working on Philip's branch. I tried to do the same as your add OV5642 parallel camera commit, but I don't see a link between csi and adv even though I

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-02 Thread Hans Verkuil
ADV76XX_REGISTER_5AH: + case ADV7611_HPA_DELAY_SEL_3_0: + case ADV7611_DSD_MAP_ROT_2_0: + case ADV7611_DDC_PAD: + case ADV7611_HDMI_REGISTER_02: Hmm, shouldn't ADV7611-specific registers be checked only if it really is an ADV7611? This is also a very small subset of all

Re: [Device-drivers-devel] [RFCv1 PATCH 0/7] Add adv7604/ad9389b drivers

2012-07-06 Thread Lars-Peter Clausen
the most testing. I've also have some code which adds adv7611 support to your adv7604 driver. As the commit message of says these drivers do not implement the full functionality of these devices, but that can be added later, either by Cisco or by others. A lot of work has been put

Re: [Device-drivers-devel] [RFCv1 PATCH 0/7] Add adv7604/ad9389b drivers

2012-07-06 Thread Hans Verkuil
the most testing. I've also have some code which adds adv7611 support to your adv7604 driver. Let's try and get this driver in first, before we start adding patches other than fixes. The main purpose is to get the new API elements merged in the kernel, after that the drivers can easily

Re: [PATCH 0/3] media: Add SH-Mobile RCAR-H2 Lager board support

2013-10-04 Thread Hans Verkuil
for v2. Regards, Hans Thanks Guennadi On Tue, 24 Sep 2013, Valentine Barshak wrote: The following patches add ADV7611/ADV7612 HDMI receiver I2C driver and add RCAR H2 SOC support along with ADV761x output format support to rcar_vin soc_camera driver. These changes are needed

Re: [PATCH 0/3] media: Add SH-Mobile RCAR-H2 Lager board support

2013-10-04 Thread Valentine
2013, Valentine Barshak wrote: The following patches add ADV7611/ADV7612 HDMI receiver I2C driver and add RCAR H2 SOC support along with ADV761x output format support to rcar_vin soc_camera driver. These changes are needed for SH-Mobile R8A7790 Lager board video input support. Valentine Barshak

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
, the ADV7611 does not generate a second interrupt signal. However, the interrupt_service_routine doesn't account for that. For example, in case fmt_change interrupt happens while fmt_change_digital interrupt is being processed by the adv7604_isr routine. If fmt_change status is set just

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Laurent Pinchart
{ + ADV7604_PAD_HDMI_PORT_A = 0, + ADV7604_PAD_HDMI_PORT_B = 1, + ADV7604_PAD_HDMI_PORT_C = 2, + ADV7604_PAD_HDMI_PORT_D = 3, + ADV7604_PAD_VGA_RGB = 4, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit: ADV7604_PAD_SOURCE

[GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-05 Thread Mauro Carvalho Chehab
-25 13:10:16 -0300) Lars-Peter Clausen (3): [media] adv7604: Add support for asynchronous probing [media] adv7604: Don't put info string arrays on the stack [media] adv7604: Add adv7611 support Laurent Pinchart (18

Re: i.MX6 status for IPU/VPU/GPU

2014-07-28 Thread Steve Longerbeam
On 07/28/2014 11:59 AM, Robert Schwebel wrote: Hi, On Mon, Jul 28, 2014 at 06:24:45PM +0200, Jean-Michel Hautbois wrote: We have a custom board, based on i.MX6 SoC. We are currently using Freescale's release of Linux, but this is a 3.10.17 kernel, and several drivers are lacking (adv7611

Re: [Linux-kernel] Renesas Lager: Device Tree entries for VIN HDMI input, version 2

2015-09-22 Thread William Towle
able [in future], no action would be taken where an ADV7612 is present and one would need to arrange for applications in userland to actively make a choice where the device tree does not have an appropriate value. In our particular case we don't differentiate between hardware with ADV7611/7612 in t

Re: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

2018-01-11 Thread Maxime Ripard
, they are all documented in the same way. However, I really start to wonder whether the polarity shouldn't be reversed. At least the fact that VSYNC is clearly active low on the oscilloscope, while I have to set it active high in the controller seems like a strong hint :) > No. I only tested with

Re: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

2018-01-10 Thread Yong
you test the V3S CSI driver with a parallel interface? With > what sensor driver? Have you found some polarities issues like this? Did you try it with Allwinner SoCs? No. I only tested with a BT1120 signal generated by FPGA or ADV7611. HSYNC and VSYNC are not used. F

[GIT PULL FOR v4.21] Various fixes

2018-11-07 Thread Hans Verkuil
v7604: add CEC support for adv7611/adv7612 cec: report Vendor ID after initialization cec: add debug_phys_addr module option cec: keep track of outstanding transmits vivid: fix error handling of kthread_run vivid: set min width/height to a value > 0

[GIT PULL FOR v4.21 v2] Various fixes

2018-11-23 Thread Hans Verkuil
- Hans Verkuil (7): adv7604: add CEC support for adv7611/adv7612 cec: report Vendor ID after initialization cec: add debug_phys_addr module option cec: keep track of outstanding transmits vivid: fix error handling of kthread_run vivid: set min width/height to a

[PATCH 35/47] adv7604: Add sink pads

2014-02-05 Thread Laurent Pinchart
{ * ** */ +enum adv7604_pad { + ADV7604_PAD_HDMI_PORT_A = 0, + ADV7604_PAD_HDMI_PORT_B = 1, + ADV7604_PAD_HDMI_PORT_C = 2, + ADV7604_PAD_HDMI_PORT_D = 3, + ADV7604_PAD_VGA_RGB = 4, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611

[PATCH 33/47] adv7604: Add adv7611 support

2014-02-05 Thread Laurent Pinchart
From: Lars-Peter Clausen l...@metafoo.de This patch adds support for the Analog Devices ADV7611 HDMI receiver. The adv7611 is quite similar to the adv7604. It has only one instead of four HDMI inputs and no analog frontend though. Also some register bits have been shuffled around, but large parts

Re: [PATCH 00/47] ADV7611 support

2014-02-05 Thread Hans Verkuil
Hi Laurent! On 02/05/2014 05:41 PM, Laurent Pinchart wrote: Hello, This patch set implements support for the ADV7611 in the adv7604 driver. It also comes up with new features such as output format configuration through pad format operations, hot-plug detect control through GPIO and DT

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Hans Verkuil
, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit: ADV7604_PAD_SOURCE = 6, ADV7611_PAD_SOURCE = 1, + ADV7604_PAD_MAX = 7, +}; Wouldn't it make more sense to have this in the header? I would really like to use

[PATCH v2 00/48] ADV7611 support

2014-03-10 Thread Laurent Pinchart
Hello, This patch set implements support for the ADV7611 in the adv7604 driver. It also comes up with new features such as output format configuration through pad format operations, hot-plug detect control through GPIO and DT support. Patches 06/48 to 24/48 and 39/48 replace the subdev video DV

[PATCH v2 35/48] adv7604: Add sink pads

2014-03-10 Thread Laurent Pinchart
, .num_dv_ports = 4, .edid_enable_reg = 0x77, .edid_status_reg = 0x7d, @@ -2460,7 +2462,7 @@ static const struct adv7604_chip_info adv7604_chip_info[] = { [ADV7611] = { .type = ADV7611, .has_afe = false, - .max_port

[PATCH v2 00/48] ADV7611 support

2014-03-10 Thread Laurent Pinchart
Hello, This patch set implements support for the ADV7611 in the adv7604 driver. It also comes up with new features such as output format configuration through pad format operations, hot-plug detect control through GPIO and DT support. Patches 06/48 to 24/48 and 39/48 replace the subdev video DV

[PATCH v2 33/48] adv7604: Add adv7611 support

2014-03-10 Thread Laurent Pinchart
From: Lars-Peter Clausen l...@metafoo.de This patch adds support for the Analog Devices ADV7611 HDMI receiver. The adv7611 is quite similar to the adv7604. It has only one instead of four HDMI inputs and no analog frontend though. Also some register bits have been shuffled around, but large parts

Re: [PATCH v2 00/48] ADV7611 support

2014-03-11 Thread Hans Verkuil
for the op_ch_sel field which I really need on my system. So that needs to be resolved. I've tested the whole lot (with an ugly workaround for patch 36) on my hardware successfully. Regards, Hans On 03/11/14 00:15, Laurent Pinchart wrote: Hello, This patch set implements support for the ADV7611

[PATCH v4 00/49] ADV7611 support

2014-04-17 Thread Laurent Pinchart
Hello, This patch set implements support for the ADV7611 in the adv7604 driver. It also comes up with new features such as output format configuration through pad format operations, hot-plug detect control through GPIO and DT support. I believe I've addressed all comments received on v3

[PATCH v4 34/49] adv7604: Add sink pads

2014-04-17 Thread Laurent Pinchart
= ADV7604_PAD_VGA_COMP, .num_dv_ports = 4, .edid_enable_reg = 0x77, .edid_status_reg = 0x7d, @@ -2460,7 +2462,7 @@ static const struct adv7604_chip_info adv7604_chip_info[] = { [ADV7611] = { .type = ADV7611, .has_afe

[PATCH v4 32/49] adv7604: Add adv7611 support

2014-04-17 Thread Laurent Pinchart
From: Lars-Peter Clausen l...@metafoo.de This patch adds support for the Analog Devices ADV7611 HDMI receiver. The adv7611 is quite similar to the adv7604. It has only one instead of four HDMI inputs and no analog frontend though. Also some register bits have been shuffled around, but large parts

Re: [GIT PULL v2 FOR v3.16] adv7604: ADV7611 and DT support

2014-05-25 Thread Mauro Carvalho Chehab
repository at: git://linuxtv.org/pinchartl/media.git linuxtv/adv7611 for you to fetch changes up to 89d3226804151fb97049ecc2170ea46aaa6f7f60: adv7604: Set HPD GPIO direction to output (2014-04-28 21:03:58 +0200) Lars

Re: [GIT PULL v2 FOR v3.16] adv7604: ADV7611 and DT support

2014-05-25 Thread Laurent Pinchart
:05:06 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git linuxtv/adv7611 for you to fetch changes up to 89d3226804151fb97049ecc2170ea46aaa6f7f60: adv7604: Set HPD GPIO direction to output (2014-04-28 21:03:58 +0200

Re: i.MX6 status for IPU/VPU/GPU

2014-10-24 Thread Jean-Michel Hautbois
, or rotation. Yes, exactly. I have tried both of your branches (Steve and Philip) and they both are interesting. I easily added adv76xx devices to Steve's work, but there is no media controller support, as you previously said. I cannot get adv7611 working on Philip's branch. I tried to do the same

Re: i.MX6 status for IPU/VPU/GPU

2015-01-27 Thread Carlos Sanmartín Bustos
tried both of your branches (Steve and Philip) and they both are interesting. I easily added adv76xx devices to Steve's work, but there is no media controller support, as you previously said. I cannot get adv7611 working on Philip's branch. I tried to do the same as your add OV5642 parallel

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Hans Verkuil
On 09/25/2013 12:21 PM, Laurent Pinchart wrote: Hi Valentine, Thank you for the patch. Please see below for a couple of comments (in addition to Hans' and Guennadi's comments). On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port

RFC: add FMT_CHANGE event and VIDIOC_G/S_EDID ioctls

2013-11-27 Thread Hans Verkuil
This RFC addresses some HDTV-related features that are missing in the API. The reason they were missing is that there were no bridge drivers in the kernel that needed them, but with the work done on soc_camera + adv7611/2 by Valentine this is now really needed. The two missing pieces are how

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
controller has cleared or masked the first interrupt event, the ADV7611 does not generate a second interrupt signal. However, the interrupt_service_routine doesn't account for that. For example, in case fmt_change interrupt happens while fmt_change_digital interrupt is being processed

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Hans Verkuil
adv7604_pad { + ADV7604_PAD_HDMI_PORT_A = 0, + ADV7604_PAD_HDMI_PORT_B = 1, + ADV7604_PAD_HDMI_PORT_C = 2, + ADV7604_PAD_HDMI_PORT_D = 3, + ADV7604_PAD_VGA_RGB = 4, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Laurent Pinchart
, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit: ADV7604_PAD_SOURCE = 6, ADV7611_PAD_SOURCE = 1, I can do that, but those two constants won't be used in the driver as they computed dynamically

Re: [PATCH 35/47] adv7604: Add sink pads

2014-02-11 Thread Hans Verkuil
, + ADV7604_PAD_VGA_COMP = 5, + /* The source pad is either 1 (ADV7611) or 6 (ADV7604) */ How about making this explicit: ADV7604_PAD_SOURCE = 6, ADV7611_PAD_SOURCE = 1, I can do that, but those two constants won't be used in the driver as they computed dynamically

Re: i.MX6 status for IPU/VPU/GPU

2014-08-04 Thread Tim Harvey
of Linux, but this is a 3.10.17 kernel, and several drivers are lacking (adv7611 for instance) or badly written (all the MXC part). As we want to have nice things :) we would like to use a mainline kernel, or at least a tree which can be mainlined. It seems (#v4l told me so) that some people

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-03 Thread Hans Verkuil
, as these are declared at init. I have one other general comment: it is a bit confusing at the moment which parts of the driver are adv7604 specific, adv7611 specific or common for both. It might be a good idea to create a separate patch that renames any adv7604 prefixes (both for functions and defines) to adv76xx

[GIT PULL for v3.21] Various fixes

2015-02-16 Thread Hans Verkuil
on adv7604 and adv7611 Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml | 2 +- drivers/input/ff-memless.c | 18 +- drivers/media/i2c/adv7604.c | 915 drivers/media/pci

[GIT PULL FOR v3.21] Various fixes

2015-02-16 Thread Hans Verkuil
): media: i2c: ADV7604: In free run mode, signal is locked media: adv7604: CP CSC uses a different register on adv7604 and adv7611 Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml | 2 +- drivers/input/ff-memless.c | 18 +++-- drivers/media/i2c/adv7604.c

[GIT PULL FOR v4.3] Various fixes

2015-07-28 Thread Hans Verkuil
in bus_info field media: rcar_vin: Reject videobufs that are too small for current format William Towle (5): media: adv7604: fix probe of ADV7611/7612 media: adv7604: reduce support to first (digital) input media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 input support

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2017-12-18 Thread Yong
port > > + node with one endpoint and parallel bus is supported. > > + > > +Example: > > + > > + csi1: csi@01cb4000 { > > Drop the leading zero in the address part. OK. > > > + compatible = "allwinner,sun8i-v3s-csi"; >

Re: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

2018-01-11 Thread Yong
, I really > start to wonder whether the polarity shouldn't be reversed. > > At least the fact that VSYNC is clearly active low on the > oscilloscope, while I have to set it active high in the controller > seems like a strong hint :) The BSP code of Allwinner also treat V4L2_MBUS

Re: [GIT PULL FOR v4.21] Various fixes

2018-11-22 Thread Mauro Carvalho Chehab
Tag branch > > ---- > Hans Verkuil (7): > adv7604: add CEC support for adv7611/adv7612 > cec: report Vendor ID after initialization > cec: add debug_phys_addr module option > cec: keep track

[PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-01 Thread Jean-Michel Hautbois
ADV76XX_EQ_DYNAMIC_ENABLE: + return true; + } + + return false; +} + +/* Default register values for the adv7611 device */ +static const struct reg_default adv7611_hdmi_reg_defaults[] = { + {}, +}; + +static const struct regmap_config adv76xx_regmap

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Laurent Pinchart
:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Signed-off-by: Valentine Barshak valentine.bars

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
, Hans Thanks, Val. On 11/15/13 13:54, Valentine Barshak wrote: This adds ADV7611/ADV7612 Xpressview HDMI Receiver base support. Only one HDMI port is supported on ADV7612. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Changes

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
correctly. According to the docs: If an interrupt event occurs, and then a second interrupt event occurs before the system controller has cleared or masked the first interrupt event, the ADV7611 does not generate a second interrupt signal. However, the interrupt_service_routine doesn't account

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Laurent Pinchart
letter enclosed in parentheses are connected together. Let's start with the on-board input paths, with an HDMI input connector and a camera sensor. ,---. ,--. | HDMI | | ADV7611 | | Connector | --- | HDMI | --- (A) | | | Decoder

Re: HDMI input on i.MX6 using IPU

2015-01-14 Thread Jean-Michel Hautbois
Hi, 2015-01-08 17:53 GMT+01:00 Jean-Michel Hautbois jean-michel.hautb...@vodalys.com: Hi, I have modified both Steve's and Philipp's code, in order to get something able to get frames from an ADV7611. Right now, I am back to Philipp's base of code, rebased on top of media-tree

Re: HDMI input on i.MX6 using IPU

2015-02-23 Thread Carlos Sanmartín Bustos
...@vodalys.com: Hi, 2015-01-08 17:53 GMT+01:00 Jean-Michel Hautbois jean-michel.hautb...@vodalys.com: Hi, I have modified both Steve's and Philipp's code, in order to get something able to get frames from an ADV7611. Right now, I am back to Philipp's base of code, rebased on top of media-tree

[GIT PULL FOR v4.2] Various fixes

2015-04-24 Thread Hans Verkuil
: Improvements for I2C handling saa7164: Add Digital TV support for the HVR2255 and HVR2205 saa7164: Copyright update saa7164: fix HVR2255 ATSC inversion issue jean-michel.hautb...@vodalys.com (1): media: adv7604: Fix masks used for querying timings in ADV7611 Documentation

[PATCH v3] media: i2c: ADV7604: Migrate to regmap

2015-06-19 Thread Pablo Anton
the RD_INFO register only * identifies the revision, while on ADV7611 it identifies the model as * well. Use the HDMI slave address on ADV7604 and RD_INFO on ADV7611. */ if (state-info-type == ADV7604) { - val = adv_smbus_read_byte_data_check(client, 0xfb

[PATCH] adv7604: add CEC support for adv7611/adv7612

2018-10-12 Thread Hans Verkuil
The CEC IP is very similar between the three HDMI receivers, but not identical. Add support for all three variants. Tested with an adv7604 and an adv7612. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7604.c | 63 +++-- 1 file changed, 53 insertions(+),

Re: [PATCH] media: i2c: ADV7604: Rename adv7604 prefixes.

2015-02-04 Thread Hans Verkuil
On 02/03/15 18:13, Pablo Anton wrote: It is confusing which parts of the driver are adv7604 specific, adv7611 specific or common for both. This patch renames any adv7604 prefixes (both for functions and defines) to adv76xx whenever they are common. Signed-off-by: Pablo Anton pablo.an

Re: [PATCH] media: i2c: ADV7604: Rename adv7604 prefixes.

2015-02-04 Thread Jean-Michel Hautbois
Hi Hans, and thanks for reviewing. 2015-02-04 10:55 GMT+01:00 Hans Verkuil hverk...@xs4all.nl: On 02/03/15 18:13, Pablo Anton wrote: It is confusing which parts of the driver are adv7604 specific, adv7611 specific or common for both. This patch renames any adv7604 prefixes (both

[PATCH] media: i2c: ADV7604: Rename adv7604 prefixes.

2015-02-03 Thread Pablo Anton
It is confusing which parts of the driver are adv7604 specific, adv7611 specific or common for both. This patch renames any adv7604 prefixes (both for functions and defines) to adv76xx whenever they are common. Signed-off-by: Pablo Anton pablo.an...@vodalys-labs.com Signed-off-by: Jean-Michel

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Guennadi Liakhovetski
Hi Valentine, On Wed, 25 Sep 2013, Valentine wrote: On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Wed, 25 Sep 2013, Valentine wrote: On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port

Re: [PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-19 Thread Hans Verkuil
; + } + /* * Verify that the chip is present. On ADV7604 the RD_INFO register only * identifies the revision, while on ADV7611 it identifies the model as * well. Use the HDMI slave address on ADV7604 and RD_INFO on ADV7611. */ if (state-info-type == ADV7604

[PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-16 Thread Pablo Anton
) { + v4l2_info(sd, Error configuring IO regmap region\n); + return -ENODEV; + } + /* * Verify that the chip is present. On ADV7604 the RD_INFO register only * identifies the revision, while on ADV7611 it identifies the model as * well. Use the HDMI slave

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Guennadi Liakhovetski
Hi Valentine, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Signed-off-by: Valentine Barshak

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara

Re: [PATCH v3 36/48] adv7604: Make output format configurable through pad format operations

2014-03-18 Thread Hans Verkuil
(5 5) Note that these values are shifted 5 bits to the left... + +#define ADV7604_OP_SWAP_CB_CR(1 0) + enum adv7604_type { ADV7604, ADV7611, @@ -63,6 +85,14 @@ struct adv7604_reg_seq { u8 val; }; +struct

[PATCH v4 08/10] cec: adv7604: add cec support.

2015-04-23 Thread Kamil Debski
@@ MODULE_LICENSE(GPL); #define ADV76XX_OP_SWAP_CB_CR (1 0) +#define ADV76XX_MAX_ADDRS (3) + enum adv76xx_type { ADV7604, ADV7611, @@ -159,6 +162,10 @@ struct adv76xx_state { u16 spa_port_a[2]; struct v4l2_fract aspect_ratio; u32

[PATCH v5 08/11] cec: adv7604: add cec support.

2015-04-29 Thread Kamil Debski
@@ MODULE_LICENSE(GPL); #define ADV76XX_OP_SWAP_CB_CR (1 0) +#define ADV76XX_MAX_ADDRS (3) + enum adv76xx_type { ADV7604, ADV7611, @@ -159,6 +162,10 @@ struct adv76xx_state { u16 spa_port_a[2]; struct v4l2_fract aspect_ratio; u32

[PATCH v6 09/11] cec: adv7604: add cec support.

2015-05-04 Thread Kamil Debski
@@ MODULE_LICENSE(GPL); #define ADV76XX_OP_SWAP_CB_CR (1 0) +#define ADV76XX_MAX_ADDRS (3) + enum adv76xx_type { ADV7604, ADV7611, @@ -159,6 +162,10 @@ struct adv76xx_state { u16 spa_port_a[2]; struct v4l2_fract aspect_ratio; u32

[PATCH v6b 09/11] cec: adv7604: add cec support.

2015-05-08 Thread Hans Verkuil
-ctrls.h #include media/v4l2-device.h #include media/v4l2-dv-timings.h @@ -77,6 +78,8 @@ MODULE_LICENSE(GPL); #define ADV76XX_OP_SWAP_CB_CR (1 0) +#define ADV76XX_MAX_ADDRS (3) + enum adv76xx_type { ADV7604, ADV7611, @@ -173,6 +176,10 @@ struct

<    1   2   3   >