Hi Jacek,
On Tue, Apr 28, 2015 at 09:18:46AM +0200, Jacek Anaszewski wrote:
...
+enum ctrl_init_data_id {
+ LED_MODE,
+ TORCH_INTENSITY,
+ FLASH_INTENSITY,
+ INDICATOR_INTENSITY,
+ FLASH_TIMEOUT,
+ STROBE_SOURCE,
+ /*
+ * Only above values are applicable
On Tue, Apr 28, 2015 at 09:18:45AM +0200, Jacek Anaszewski wrote:
This patch adds a driver for the 1.5A Step-Up Current Regulator
for Flash LEDs. The device is programmed through a Skyworks proprietary
AS2Cwire serial digital interface.
Signed-off-by: Jacek Anaszewski
On Tue 2015-04-28 09:03:41, Mauro Carvalho Chehab wrote:
drivers/staging/media/bcm2048/radio-bcm2048.c: In function
'bcm2048_i2c_driver_probe':
drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable
'skip_release' set but not used [-Wunused-but-set-variable]
int err,
Hi Jacek,
On Tue, Apr 28, 2015 at 09:18:50AM +0200, Jacek Anaszewski wrote:
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash class device.
Signed-off-by: Jacek Anaszewski
drivers/media/dvb-frontends/lgdt3306a.c:2104 lgdt3306a_DumpRegs() warn:
inconsistent indenting
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/dvb-frontends/lgdt3306a.c
b/drivers/media/dvb-frontends/lgdt3306a.c
index d9a2b0e768e0..0e2e43e9ede5 100644
---
drivers/media/usb/gspca/benq.c:239 sd_isoc_irq() warn: inconsistent indenting
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/usb/gspca/benq.c b/drivers/media/usb/gspca/benq.c
index 05f406deae13..790baed33963 100644
--- a/drivers/media/usb/gspca/benq.c
+++
drivers/media/dvb-frontends/dib3000mc.c:134 dib3000mc_setup_pwm_state() warn:
inconsistent indenting
drivers/media/dvb-frontends/dib3000mc.c:144 dib3000mc_setup_pwm_state() warn:
inconsistent indenting
drivers/media/dvb-frontends/dib3000mc.c:420 dib3000mc_sleep() warn:
inconsistent indenting
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up to 7 values:
drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd()
error: buffer overflow 'cmd-msg' 6 = 7
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up much more values:
drivers/media/dvb-frontends/cx24116.c:983 cx24116_send_diseqc_msg()
error: buffer overflow 'd-msg' 6 = 23
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro
drivers/media/dvb-frontends/bcm3510.c:688 bcm3510_reset() warn: inconsistent
indenting
drivers/media/dvb-frontends/bcm3510.c:711 bcm3510_clear_reset() warn:
inconsistent indenting
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/dvb-frontends/bcm3510.c
drivers/media/dvb-frontends/stv0288.c:137 stv0288_set_symbolrate() warn:
inconsistent indenting
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/dvb-frontends/stv0288.c
b/drivers/media/dvb-frontends/stv0288.c
index 632b25156e4c..ecf4bb3a3b6b 100644
---
As reported by smatch:
drivers/media/usb/go7007/go7007-driver.c:452 frame_boundary() warn:
variable dereferenced before check 'vb' (see line 449)
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/usb/go7007/go7007-driver.c
On Tue, Apr 28, 2015 at 3:09 AM, Lee Jones lee.jo...@linaro.org wrote:
On Tue, 28 Apr 2015, Jacek Anaszewski wrote:
This patch adds device tree binding documentation for
the flash cell of the Maxim max77693 multifunctional device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
If userspace sends an invalid bandwidth, it should either return
EINVAL or switch to auto mode.
This driver will go past an array and program the hardware on a
wrong way if this happens.
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git
drivers/media/platform/vivid/vivid-radio-rx.c:198
vivid_radio_rx_s_hw_freq_seek() error: buffer overflow 'vivid_radio_bands' 3 =
3
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/platform/vivid/vivid-radio-rx.c
As reported by smatch:
drivers/media/usb/gspca/zc3xx.c:5994 transfer_update() info: ignoring
unreachable code.
That happens because there's a return that it is never called,
as the work queue runs an infinite loop, except when the device is
put to sleep or an error happens.
When an
drivers/media/usb/gspca/zc3xx.c:6363 zcxx_s_ctrl() error: buffer overflow
'jpeg_qual' 3 = 3
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/usb/gspca/zc3xx.c b/drivers/media/usb/gspca/zc3xx.c
index d3e1b6d8bf49..3762a045f744 100644
---
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up much more values:
drivers/media/dvb-frontends/cx24116.c:983 cx24116_send_diseqc_msg()
error: buffer overflow 'd-msg' 6 = 23
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up much more values:
drivers/media/dvb-frontends/cx24116.c:983 cx24116_send_diseqc_msg()
error: buffer overflow 'd-msg' 6 = 23
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro
On Tue, Apr 28, 2015 at 4:36 AM, Sakari Ailus sakari.ai...@iki.fi wrote:
On Tue, Apr 28, 2015 at 09:18:45AM +0200, Jacek Anaszewski wrote:
This patch adds a driver for the 1.5A Step-Up Current Regulator
for Flash LEDs. The device is programmed through a Skyworks proprietary
AS2Cwire serial
On Tue, Apr 28, 2015 at 12:18 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Part of led-trigger API was in the private drivers/leds/leds.h header.
Move it to the include/linux/leds.h header to unify the API location
and announce it as public. It has been already exported from
On April 28, 2015 11:43:41 AM EDT, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
As reported by smatch:
drivers/media/pci/cx18/cx18-driver.c:807 cx18_init_struct2() error:
buffer overflow 'cx-card-video_inputs' 6 = 6
That happens because nof_inputs and nof_audio_inputs can be
On Tue, Apr 28, 2015 at 12:18 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds device tree binding documentation for
1.5A Step-Up Current Regulator for Flash LEDs.
Applied, thanks,
-Bryan
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park
drivers/staging/media/bcm2048/radio-bcm2048.c: In function
'bcm2048_i2c_driver_probe':
drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable
'skip_release' set but not used [-Wunused-but-set-variable]
int err, skip_release = 0;
^
Signed-off-by: Mauro Carvalho
On Tue, Apr 28, 2015 at 09:18:48AM +0200, Jacek Anaszewski wrote:
Add support for V4L2 Flash sub-device to the max77693 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash class device.
Signed-off-by: Jacek Anaszewski
Hi Hans,
Thank you for your quick feedback.
I have read your remarks and I shall be able to take care of all of them.
I need some rework days now.
Regarding v4l2-compliance (latest), here is the current status summary.
v4l2-compliance (no option) returns:
Total: 42, Succeeded: 42, Failed: 0,
Fix the 0x0x prefix in integer constants.
In this case a padding 0 must also be inserted to make the constants
look like all the other 16 bits ones.
Signed-off-by: Antonio Ospite a...@ao2.it
Cc: Mauro Carvalho Chehab mche...@osg.samsung.com
Cc: linux-media@vger.kernel.org
---
Hi Jacek,
On Tue, Apr 28, 2015 at 09:18:43AM +0200, Jacek Anaszewski wrote:
This patch adds led-flash support to Maxim max77693 chipset.
A device can be exposed to user space through LED subsystem
sysfs interface. Device supports up to two leds which can
work in flash and torch mode. The leds
Hi Jacek,
On Tue, Apr 28, 2015 at 09:18:47AM +0200, Jacek Anaszewski wrote:
...
+On remove the v4l2_flash_release function has to be called, which takes one
+argument - struct v4l2_flash pointer returned previously by v4l2_flash_init.
+
+Please refer to drivers/leds/leds-max77693.c for an
On Tuesday 28 April 2015 09:03:41 Mauro Carvalho Chehab wrote:
drivers/staging/media/bcm2048/radio-bcm2048.c: In function
'bcm2048_i2c_driver_probe':
drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable
'skip_release' set but not used [-Wunused-but-set-variable]
int
drivers/media/platform/am437x/am437x-vpfe.c:513 vpfe_ccdc_set_params() warn:
inconsistent indenting
Cc: Benoit Parrot bpar...@ti.com
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/platform/am437x/am437x-vpfe.c
drivers/media/platform/am437x/am437x-vpfe.c: In function
'vpfe_get_subdev_input_index':
drivers/media/platform/am437x/am437x-vpfe.c:1679:27: warning: variable 'sdinfo'
set but not used [-Wunused-but-set-variable]
struct vpfe_subdev_info *sdinfo;
^
Cc: Benoit Parrot
drivers/media/platform/am437x/am437x-vpfe.c: In function
'vpfe_ccdc_update_raw_params':
drivers/media/platform/am437x/am437x-vpfe.c:430:38: warning: variable
'config_params' set but not used [-Wunused-but-set-variable]
struct vpfe_ccdc_config_params_raw *config_params =
On April 28, 2015 11:43:47 AM EDT, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
As reported by smatch:
drivers/media/pci/ivtv/ivtv-driver.c:832 ivtv_init_struct2() error:
buffer overflow 'itv-card-video_inputs' 6 = 6
That happens because nof_inputs and nof_audio_inputs can be
On Tue, Apr 28, 2015 at 4:36 AM, Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Jacek,
On Tue, Apr 28, 2015 at 09:18:43AM +0200, Jacek Anaszewski wrote:
This patch adds led-flash support to Maxim max77693 chipset.
A device can be exposed to user space through LED subsystem
sysfs interface.
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Apr 29 04:00:18 CEST 2015
git branch: test
git hash: bb17141cc57c40065462c64d61c0ae362466c0c0
gcc
As reported by smatch:
drivers/media/pci/zoran/zoran_device.c:1594 zoran_init_hardware() warn:
inconsistent indenting
Fix indent. While here, fix CodingStyle and remove dead code, as it
can always be recovered from git logs.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
As reported by smatch:
drivers/media/pci/ivtv/ivtv-driver.c:832 ivtv_init_struct2() error:
buffer overflow 'itv-card-video_inputs' 6 = 6
That happens because nof_inputs and nof_audio_inputs can be initialized
as IVTV_CARD_MAX_VIDEO_INPUTS, instead of IVTV_CARD_MAX_VIDEO_INPUTS - 1.
As reported by smatch:
drivers/media/pci/ngene/ngene-core.c:1529 init_channel() error: we
previously assumed 'chan-fe' could be null (see line 1521)
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/pci/ngene/ngene-core.c
As reported by smatch:
drivers/media/radio/radio-si476x.c:571
si476x_radio_do_post_powerup_init() warn: inconsistent indenting
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/radio/radio-si476x.c
b/drivers/media/radio/radio-si476x.c
index
As reported by smatch:
drivers/media/pci/cx18/cx18-driver.c:807 cx18_init_struct2() error:
buffer overflow 'cx-card-video_inputs' 6 = 6
That happens because nof_inputs and nof_audio_inputs can be initialized
as CX18_CARD_MAX_VIDEO_INPUTS, instead of CX18_CARD_MAX_VIDEO_INPUTS - 1.
The series
Tested-by: Mikko Perttunen mikko.perttu...@kapsi.fi
on Jetson-TK1.
I rebased my cpufreq series on top of this and everything's working well
now. :)
Thanks,
Mikko.
On 04/17/2015 10:29 AM, Boris Brezillon wrote:
...
--
To unsubscribe from this list: send the line unsubscribe
As reported by smatch:
drivers/media/pci/saa7134/saa7134-cards.c:7197
saa7134_xc2028_callback() warn: inconsistent indenting
drivers/media/pci/saa7134/saa7134-cards.c:7846 saa7134_board_init2()
warn: inconsistent indenting
drivers/media/pci/saa7134/saa7134-cards.c:7913
There are some false-positive warnings produced by smatch:
drivers/media/rc/ir-sony-decoder.c:129 ir_sony_decode() warn: missing
break? reassigning 'data-state'
drivers/media/rc/ir-sony-decoder.c:137 ir_sony_decode() warn: missing
break? reassigning 'data-state'
As reported by smatch:
drivers/media/i2c/saa717x.c:155 saa717x_read() warn: mask and shift to
zero
drivers/media/i2c/saa717x.c:155 saa717x_read() warn: mask and shift to
zero
This is done right at saa717x_write(), but the read function is
broken. Thankfully, there's just one
As reported by smatch:
drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup()
warn: variable dereferenced before check 'fmt' (see line 460)
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/platform/s3c-camif/camif-capture.c
The streg_cbdata can have a negative error value. So, it should be
an integer, and not u8, as reported by smatch:
drivers/media/radio/wl128x/fmdrv_common.c:1517 fmc_prepare() warn:
assigning (-115) to unsigned variable 'fmdev-streg_cbdata'
Signed-off-by: Mauro Carvalho Chehab
As reported by smatch:
drivers/media/pci/saa7164/saa7164-core.c:631 saa7164_irq() warn:
variable dereferenced before check 'dev' (see line 621)
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/pci/saa7164/saa7164-core.c
Using static const allows the compiler to optimize the code.
Before static const:
textdata bss dec hex filename
4982 524156870741ba2 drivers/media/tuners/qt1010.o
After static const:
textdata bss dec hex filename
4714 5241568
As reported by smatch:
drivers/media/platform/s5p-mfc/s5p_mfc.c:1340 s5p_mfc_runtime_resume()
warn: this array is probably non-NULL. 'm_dev-alloc_ctx'
alloc_ctx can never be NULL, as it is embeeded inside the struct
s5p_mfc_dev.
Signed-off-by: Mauro Carvalho Chehab
drivers/media/rc/rc-main.c:749 rc_close() warn: inconsistent indenting
There's an extra space there.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index f8c5e47a30aa..0ff388a16168 100644
---
Hi,
I'm facing a problem on BeagleBoneBlack. For capturing pictures on a
USB UVC capture board camera I have to stick with a camera preview
streaming with a very low resolution of 320x240 otherwise I cannot get
the camera preview streaming.
I'm using Rowboat Android and a v4l2 camera hardware
Part of led-trigger API was in the private drivers/leds/leds.h header.
Move it to the include/linux/leds.h header to unify the API location
and announce it as public. It has been already exported from
led-triggers.c with EXPORT_SYMBOL_GPL macro. The no-op definitions are
changed from macros to
This is a sixth non-RFC version of LED / flash API integration
series [1]. It is based on linux_next-20150427.
Changes since v5
- renamed v4l2-flash module to v4l2-flash-led-class and applied
other related modifications spotted by Sakari
- fixed not released
You must use static inline otherwise you get these errors if CONFIG_OF is not
defined:
In file included from drivers/media/platform/soc_camera/soc_camera.c:39:0:
include/media/v4l2-of.h:112:13: warning: 'v4l2_of_free_endpoint' defined but
not used [-Wunused-function]
static void
On Tue, 28 Apr 2015, Jacek Anaszewski wrote:
This patch adds device tree binding documentation for
the flash cell of the Maxim max77693 multifunctional device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Acked-by: Kyungmin Park
This patch adds device tree binding documentation for
1.5A Step-Up Current Regulator for Flash LEDs.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
Cc: Bryan Wu coolo...@gmail.com
Cc:
This patch extends LED Flash class documention by
the description of interactions with v4l2-flash sub-device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Bryan Wu coolo...@gmail.com
Cc: Richard Purdie rpur...@rpsys.net
---
This patch adds led-flash support to Maxim max77693 chipset.
A device can be exposed to user space through LED subsystem
sysfs interface. Device supports up to two leds which can
work in flash and torch mode. The leds can be triggered
externally or by software.
Signed-off-by: Jacek Anaszewski
This patch adds helper functions for registering/unregistering
LED Flash class devices as V4L2 sub-devices. The functions should
be called from the LED subsystem device driver. In case the
support for V4L2 Flash sub-devices is disabled in the kernel
config the functions' empty versions will be
This patch adds documentation for a pinctrl-names property.
The property, when present, is used for switching the source
of the strobe signal for the device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Bryan Wu coolo...@gmail.com
Add support for V4L2 Flash sub-device to the max77693 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash class device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Bryan Wu
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash class device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Bryan Wu
This patch adds a driver for the 1.5A Step-Up Current Regulator
for Flash LEDs. The device is programmed through a Skyworks proprietary
AS2Cwire serial digital interface.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Sakari
This patch adds device tree binding documentation for
the flash cell of the Maxim max77693 multifunctional device.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Sakari Ailus
Hi Mauro,
Could you please pull the following OMAP4 ISS regression fox for v4.1 ? If
fixes a compilation breakage due to a change in the OMAP4 API.
The following changes since commit cb0c9e1f6777287e81d9b48c264d980bf5014b48:
[media] smiapp: Use v4l2_of_alloc_parse_endpoint() (2015-04-27
Hi Hans,
On Tue, Apr 28, 2015 at 08:41:00AM +0200, Hans Verkuil wrote:
You must use static inline otherwise you get these errors if CONFIG_OF is not
defined:
In file included from drivers/media/platform/soc_camera/soc_camera.c:39:0:
include/media/v4l2-of.h:112:13: warning:
Hi Sakari,
On 04/28/2015 04:02 PM, Sakari Ailus wrote:
Hi Jacek,
On Tue, Apr 28, 2015 at 09:18:50AM +0200, Jacek Anaszewski wrote:
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash
68 matches
Mail list logo
