Added a newline character to remove a coding style warning detected
by checkpatch.
The warning is given below:
drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
across lines
Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
On Wed, Aug 12, 2015 at 08:41:42PM +0530, Aparna Karuthodi wrote:
Added a newline character to remove a coding style warning detected
by checkpatch.
The warning is given below:
drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
across lines
Signed-off-by: Aparna
Hi,
On 12 August 2015 at 13:42, Marek Szyprowski m.szyprow...@samsung.com wrote:
Hello Hans,
I'm sorry for a delay. Once again I've been busy with some other internal
stuff.
On 2015-07-28 11:02, Hans Verkuil wrote:
Kamil, Marek,
Why does v4l2_m2m_poll unlock and lock in that function?
Currently, media_entity_init() creates an array with the links,
allocated at init time. It provides a parameter (extra_links)
that would allocate more links than the current needs, but this
is not used by any driver.
As we want to be able to do dynamic link allocation/removal,
we'll need to
As we'll need to create links between entities and interfaces,
we need to identify the link endpoints by the media_graph_obj.
Please note that, while we're now using graph_obj to reference
the link endpoints, we're still assuming that all endpoints are
pads at the existing drivers. This is true
Due to the MC API proposed changes, we'll need to:
- have an unique object ID for all graph objects;
- be able to dynamically create/remove objects;
- be able to group objects;
- keep the object in memory until we stop use it.
Due to that, create a struct
PAD embedded objects also need to be initialized. Those are
currently created via media_entity_init() and, once created,
never change.
While this will likely change in the future, for now we can
just initialize those objects once, when registering the
entity.
Signed-off-by: Mauro Carvalho Chehab
When a new link is created, we need to initialize the object
inside it.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 56724f7853bf..9fb3f8958265 100644
--- a/drivers/media/media-device.c
+++
Change the internal namespace for links between two pads to
have the pad there.
We're also numbering it, as a common constructor is to do
things like:
if (link-port1.type != MEDIA_GRAPH_PAD)
continue;
if (link-pad1_sink-entity == entity)
/* do
Hi,
On Wed, Aug 12, 2015 at 10:42 PM, Boaz Harrosh b...@plexistor.com wrote:
On 08/12/2015 10:05 AM, Christoph Hellwig wrote:
It turns out most DMA mapping implementation can handle SGLs without
page structures with some fairly simple mechanical work. Most of it
is just about consistently
Using memory realloc to increase the size of an array
is complex and makes harder to remove links. Also, by
embedding the link inside an array at the entity makes harder
to change the code to add interfaces, as interfaces will
also need to use links.
So, convert the links from arrays to lists.
On Wed, Aug 12, 2015 at 2:14 PM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Removing a link is simple. Yet, better to have a separate
function for it, as we'll be also sharing it with a
public API call.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
One thing to think
On 11.08.2015 00:40, Antti Palosaari wrote:
On 08/11/2015 12:46 AM, poma wrote:
Furthermore, to fix this issue - AF9015 DVB-T USB2.0 stick brokenness - is
the responsibility of developers.
I am here only proven tester.
I hope we understand each other, and this problem will be resolved in
Em Wed, 12 Aug 2015 14:45:52 -0600
Shuah Khan shuahk...@gmail.com escreveu:
On Wed, Aug 12, 2015 at 2:14 PM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Removing a link is simple. Yet, better to have a separate
function for it, as we'll be also sharing it with a
public API call.
Now that a link can be either between two different graph
objects, we'll need to add more functions to create links.
So, rename the existing one that create links only between
two pads as media_create_pad_link().
No functional changes.
This patch was created via this shell script:
for i
As we need __media_entity_remove_link() earlier, move it to
happen earlier, to avoid needing to have a function prototype.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index
Interfaces are different than entities: they represent a
Kernel-userspace interaction, while entities represent a
piece of hardware/firmware/software that executes a function.
Let's distinguish them by creating a separate structure to
store the interfaces.
Latter patches should change the
As entities will also have links to interfaces, we need to
rename the existing functions that remove links, to avoid
namespace collision and confusion.
No functional changes.
The rename was made by this script:
for i in $(find drivers/media -name '*.[ch]' -type f) $(find
In preparation to add a public function to add links, let's
make the internal function that creates link more generic.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index eafd26a741e5..b8991d38c565 100644
---
All objects need an object ID. However, as v4l2 subdevs embeed
entities internally, the code needs to manually check if the
entity objects were not properly initialized and do it at
entity register time.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git
This is the third version of an initial set of patches showing
the approach I'm taking in order to fulfill all the MC needs that
was discussed on the 3 day MC summit in Helsinki.
This version comes with the changes requested at the ML:
- added unions at links for source/port0/entity and
Removing a link is simple. Yet, better to have a separate
function for it, as we'll be also sharing it with a
public API call.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index b8991d38c565..f43af2fda306
We need to initialize the common media_graph_obj that
it is now embedded inside each media controller object.
Latter patches will use those functions to ensure that
the object will be properly initialized.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git
We'll need unique IDs for graph objects and a way to associate
them with the media interface.
So, add an atomic var to be used to create unique IDs and
a list to store such objects.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/media-device.c
On 08/12/2015 02:52 PM, Mauro Carvalho Chehab wrote:
Em Wed, 12 Aug 2015 14:45:52 -0600
Shuah Khan shuahk...@gmail.com escreveu:
On Wed, Aug 12, 2015 at 2:14 PM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Removing a link is simple. Yet, better to have a separate
function for it,
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Aug 13 04:00:15 CEST 2015
git branch: test
git hash: 2696f495bdc046d84da6c909a1e7f535138a2a62
gcc
Use sg_phys() instead of page_to_phys(sg_page(sg)) so that we don't
require a page structure for all DMA memory.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/s390/pci/pci_dma.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/ia64/hp/common/sba_iommu.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/arch/ia64/hp/common/sba_iommu.c b/arch/ia64/hp/common/sba_iommu.c
index 344387a..9e5aa8e 100644
---
Shut up this compiler warning that I get during the daily build:
horus3a.c: In function 'horus3a_set_params':
horus3a.c:308:24: warning: 'rolloff' may be used uninitialized in this function
[-Wmaybe-uninitialized]
symbol_rate * (100 + rolloff), 20) + 5;
^
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/nios2/mm/dma-mapping.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git
Hi Mauro,
The following changes since commit 2696f495bdc046d84da6c909a1e7f535138a2a62:
[media] Staging: media: lirc: use USB API functions rather than constants
(2015-08-11 18:00:30 -0300)
are available in the git repository at:
git://linuxtv.org/pinchartl/media.git omap3isp/next
for you
Dan Williams started to look into addressing I/O to and from
Persistent Memory in his series from June:
http://thread.gmane.org/gmane.linux.kernel.cross-arch/27944
I've started looking into DMA mapping of these SGLs specifically instead
of the map_pfn method in there. In addition to
Use sg_pfn to get a the PFN and skip checks that require a kernel
virtual address.
Signed-off-by: Christoph Hellwig h...@lst.de
---
lib/dma-debug.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index dace71f..a215a80 100644
---
Signed-off-by: Christoph Hellwig h...@lst.de
---
include/linux/scatterlist.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
index 9b1ef0c..b1056bf 100644
--- a/include/linux/scatterlist.h
+++ b/include/linux/scatterlist.h
From: Dan Williams dan.j.willi...@intel.com
Coccinelle cleanup to replace open coded sg to physical address
translations. This is in preparation for introducing scatterlists that
reference __pfn_t.
// sg_phys.cocci: convert usage page_to_phys(sg_page(sg)) to sg_phys(sg)
// usage: make
Just remove a BUG_ON, the code handles them just fine as-is.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/x86/kernel/pci-nommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/pci-nommu.c b/arch/x86/kernel/pci-nommu.c
index da15918..a218059 100644
---
Hi Mauro,
The following changes since commit 2696f495bdc046d84da6c909a1e7f535138a2a62:
[media] Staging: media: lirc: use USB API functions rather than constants
(2015-08-11 18:00:30 -0300)
are available in the git repository at:
git://linuxtv.org/pinchartl/media.git v4l2/next
for you to
Hi Ezequiel,
OTOH I don't see any reason preventing you from sending a pull request
for the inclusion of the TW686x driver, Mauro could merge this stuff
then (assuming it's ready).
You don't have to wait for me and a driver doesn't need to be a single
patch from a single person.
--
Krzysztof
Only call kmap_atomic_primary when the SG entry is mapped into
kernel virtual space.
XXX: the code already looks odd due to the lack of pairing between
kmap_atomic_primary and kunmap_atomic_primary. Does it work either
before or after this patch?
Signed-off-by: Christoph Hellwig h...@lst.de
---
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/openrisc/kernel/dma.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/openrisc/kernel/dma.c
Make all cache invalidation conditional on sg_has_page().
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/powerpc/kernel/dma.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c
index 35e4dcc..cece40b 100644
Use sg_phys() instead of virt_to_phys(sg_virt(sg)) so that we don't
require a kernel virtual address.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/alpha/kernel/pci-noop.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/alpha/kernel/pci-noop.c
Use sg_phys() instead of virt_to_phys(sg_virt(sg)) so that we don't
require a kernel virtual address, and switch a few debug printfs to
print physical instead of virtual addresses.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/alpha/kernel/pci_iommu.c | 36
Switch from sg_virt to sg_phys as blackfin like all nommu architectures
has a 1:1 virtual to physical mapping.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/blackfin/kernel/dma-mapping.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Make all cache invalidation conditional on sg_has_page().
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/metag/include/asm/dma-mapping.h | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/arch/metag/include/asm/dma-mapping.h
Make all cache invalidation conditional on sg_has_page().
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/sh/kernel/dma-nommu.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/sh/kernel/dma-nommu.c b/arch/sh/kernel/dma-nommu.c
index 5b0bfcd..3b64dc7
Make all cache invalidation conditional on sg_has_page().
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/xtensa/include/asm/dma-mapping.h | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/arch/xtensa/include/asm/dma-mapping.h
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/arc/include/asm/dma-mapping.h | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly, bypassing the noop
page_to_bus.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/avr32/include/asm/dma-mapping.h | 14 +++---
1 file changed, 7 insertions(+), 7
For the iommu offset we just need and offset into the page. Calculate
that using the physical address instead of using the virtual address
so that we don't require a virtual mapping.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/powerpc/kernel/iommu.c | 14 +++---
1 file
For the iommu offset we just need and offset into the page. Calculate
that using the physical address instead of using the virtual address
so that we don't require a virtual mapping.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/sparc/mm/io-unit.c | 23 ---
1 file
Use sg_phys() instead of __pa(sg_virt(sg)) so that we don't
require a kernel virtual address.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/sparc/kernel/iommu.c| 2 +-
arch/sparc/kernel/iommu_common.h | 4 +---
arch/sparc/kernel/pci_sun4v.c| 2 +-
3 files changed, 3
Just remove a BUG_ON, the code handles them just fine as-is.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/mn10300/include/asm/dma-mapping.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/mn10300/include/asm/dma-mapping.h
Use sg_phys() instead of virt_to_phys(sg_virt(sg)) so that we don't
require a kernel virtual address.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/ia64/sn/pci/pci_dma.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/ia64/sn/pci/pci_dma.c
For the iommu offset we just need and offset into the page. Calculate
that using the physical address instead of using the virtual address
so that we don't require a virtual mapping.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/x86/kernel/pci-calgary_64.c | 10 --
1 file
Pass a PFN to iommu_get_one instad of calculating it locall from a
page structure so that we don't need pages for every address we can
DMA to or from.
Also further restrict the cache flushing as we now have a non-highmem
way of not kernel virtual mapped physical addresses.
Signed-off-by:
Use sg_phys() instead of virt_to_phys(sg_virt(sg)) so that we don't
require a kernel virtual address.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/c6x/kernel/dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/c6x/kernel/dma.c b/arch/c6x/kernel/dma.c
index
Use
sg_phys(sg) PAGE_MASK
instead of
page_to_pfn(sg_page(sg)) PAGE_SHIFT
to get at the page-aligned physical address ofa SG entry, so that
we don't require a page backing for SG entries.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/sparc/kernel/ldc.c | 4 ++--
1 file
Just remove a BUG_ON, the code handles them just fine as-is.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/iommu/intel-iommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 3541d65..ae10573 100644
---
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
arch/parisc/kernel/pci-dma.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly. To do this consolidate
the two platform callouts using pages and virtual addresses into a
single one using a physical address.
Signed-off-by: Christoph Hellwig h...@lst.de
---
Signed-off-by: Christoph Hellwig h...@lst.de
---
include/asm-generic/dma-mapping-common.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/asm-generic/dma-mapping-common.h
b/include/asm-generic/dma-mapping-common.h
index 940d5ec..afc3eaf 100644
---
If device has no DMA max_seg_size set, we assume that there is no limit
and it is safe to force it to use DMA_BIT_MASK(32) as max_seg_size to
let DMA-mapping API always create contiguous mappings in DMA address
space. This is essential for all devices, which use dma-contig
videobuf2 memory
On Wednesday 12 August 2015 12:39 PM, Christoph Hellwig wrote:
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly.
Signed-off-by: Christoph Hellwig h...@lst.de
With a minor nit below.
Acked-by: Vineet Gupta vgu...@synopsys.com
---
Around Wed 12 Aug 2015 09:05:39 +0200 or thereabout, Christoph Hellwig wrote:
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly, bypassing the noop
page_to_bus.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: Hans-Christian
On Wed, 2015-08-12 at 09:05 +0200, Christoph Hellwig wrote:
Just remove a BUG_ON, the code handles them just fine as-is.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: David Woodhouse david.woodho...@intel.com
--
David WoodhouseOpen Source Technology
On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
From: Yash Shah ysh...@visteon.com
Fix line over 80 characters warning as detected by checkpatch.pl
Signed-off-by: Yash Shah ysh...@visteon.com
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
1 file changed, 2
On Wed, Aug 12, 2015 at 12:05 AM, Christoph Hellwig h...@lst.de wrote:
Make all cache invalidation conditional on sg_has_page() and use
sg_phys to get the physical address directly.
So this worries me a bit (I'm just reacting to one random patch in the series).
The reason?
I think this wants
Christoph,
On 12 August 2015 at 08:05, Christoph Hellwig h...@lst.de wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
---
include/asm-generic/dma-mapping-common.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/asm-generic/dma-mapping-common.h
This makes the failure error message a little more useful.
Signed-off-by: Baruch Siach bar...@tkos.co.il
---
contrib/test/v4l2grab.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/test/v4l2grab.c b/contrib/test/v4l2grab.c
index 3e1be3de6353..778c51cc391a 100644
---
On Wed, 2015-08-12 at 09:05 +0200, Christoph Hellwig wrote:
Dan Williams started to look into addressing I/O to and from
Persistent Memory in his series from June:
http://thread.gmane.org/gmane.linux.kernel.cross-arch/27944
I've started looking into DMA mapping of these SGLs
On Wed, Aug 12, 2015 at 12:05 AM, Christoph Hellwig h...@lst.de wrote:
+ for_each_sg(sg, s, nents, i) {
+ if (sg_has_page(s))
+ kmemcheck_mark_initialized(sg_virt(s), s-length);
+ }
[ Again, I'm responding to one random patch - this pattern was
Hello Hans,
I'm sorry for a delay. Once again I've been busy with some other
internal stuff.
On 2015-07-28 11:02, Hans Verkuil wrote:
Kamil, Marek,
Why does v4l2_m2m_poll unlock and lock in that function?
I've checked the code and indeed the poll_wait() function doesn't do
anything that
From: Yash Shah ysh...@visteon.com
Fix line over 80 characters warning as detected by checkpatch.pl
Signed-off-by: Yash Shah ysh...@visteon.com
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Wed, 12 Aug 2015, Christoph Hellwig wrote:
Use sg_phys() instead of page_to_phys(sg_page(sg)) so that we don't
require a page structure for all DMA memory.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: Sebastian Ott seb...@linux.vnet.ibm.com
---
arch/s390/pci/pci_dma.c | 20
On 08/12/2015 10:05 AM, Christoph Hellwig wrote:
Dan Williams started to look into addressing I/O to and from
Persistent Memory in his series from June:
http://thread.gmane.org/gmane.linux.kernel.cross-arch/27944
I've started looking into DMA mapping of these SGLs specifically
On 08/11/2015 05:18 PM, Mauro Carvalho Chehab wrote:
drivers/media/i2c/tc358743.c:148:19: warning: Variable length array is used.
As the maximum size is 1026, we can't use dynamic var, as it
would otherwise spend 1056 bytes of the stack at i2c_wr() function.
So, allocate a buffer with the
On Wed, Aug 12, 2015 at 1:19 PM, Pali Rohár pali.ro...@gmail.com wrote:
On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
From: Yash Shah ysh...@visteon.com
Fix line over 80 characters warning as detected by checkpatch.pl
Signed-off-by: Yash Shah ysh...@visteon.com
---
On Wed, Aug 12, 2015 at 10:00 AM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Wed, 2015-08-12 at 09:05 +0200, Christoph Hellwig wrote:
...
However the ccio (parisc) and sba_iommu (parisc ia64) IOMMUs seem
to be operate mostly on virtual addresses. It's a fairly odd concept
79 matches
Mail list logo
