[v4l-utils PATCH 1/1] libv4l2subdev: Allow extra spaces between format strings

2016-03-11 Thread Sakari Ailus
It's possible to pass more than one format string (and entity) to v4l2_subdev_parse_setup_formats(), yet v4l2_subdev_parse_pad_format() does not parse the string until the next non-space character. v4l2_subdev_parse_setup_formats() expects to find a comma right after that leading spaces before the

[v4l-utils PATCH] libv4lconvert: Add support for V4L2_PIX_FMT_NV16

2016-03-11 Thread Niklas Söderlund
NV16 are two-plane versions of the YUV 4:2:2 format (V4L2_PIX_FMT_YUVU). Support it by merging the two planes into a one YUVU plane and falling through to the V4L2_PIX_FMT_YUVU code path. Signed-off-by: Niklas Söderlund --- I'm sorry this is a bit of a

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Niklas Söderlund
On 2016-03-11 12:16:30 +0100, Hans Verkuil wrote: > On 03/11/2016 12:03 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: > >> Hi Niklas, > >> > >> On 02/29/2016 10:52 AM, Hans Verkuil wrote: > >>> Hi Niklas, > >>> > >>> Thanks for your patch! Much

Re: [v4l-utils PATCH] libv4lconvert: Add support for V4L2_PIX_FMT_NV16

2016-03-11 Thread Hans Verkuil
On 03/11/2016 09:40 PM, Niklas Söderlund wrote: > NV16 are two-plane versions of the YUV 4:2:2 format (V4L2_PIX_FMT_YUVU). > Support it by merging the two planes into a one YUVU plane and falling > through to the V4L2_PIX_FMT_YUVU code path. s/YUVU/YUYV/g Can you add support for NV61 as well?

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Hans Verkuil
On 03/11/2016 09:55 PM, Niklas Söderlund wrote: > On 2016-03-11 12:16:30 +0100, Hans Verkuil wrote: >> On 03/11/2016 12:03 PM, Niklas Söderlund wrote: >>> Hi Hans, >>> >>> On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: Hi Niklas, On 02/29/2016 10:52 AM, Hans Verkuil wrote: >

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Niklas Söderlund
On 2016-03-11 22:04:17 +0100, Hans Verkuil wrote: > On 03/11/2016 09:55 PM, Niklas Söderlund wrote: > > On 2016-03-11 12:16:30 +0100, Hans Verkuil wrote: > >> On 03/11/2016 12:03 PM, Niklas Söderlund wrote: > >>> Hi Hans, > >>> > >>> On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: > Hi

[patch] [media] em28xx-i2c: rt_mutex_trylock() returns zero on failure

2016-03-11 Thread Dan Carpenter
The code is checking for negative returns but it should be checking for zero. Fixes: aab3125c43d8 ('[media] em28xx: add support for registering multiple i2c buses') Signed-off-by: Dan Carpenter --- Is -EBUSY correct? -EAGAIN? diff --git

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-11 Thread Andrey Utkin
On Fri, 11 Mar 2016 09:00:18 +0100 Hans Verkuil wrote: > The reason is likely to be the tw5864_queue_setup function which has > not been updated to handle CREATE_BUFS support correctly. It should > look like this: > > static int tw5864_queue_setup(struct vb2_queue *q, >

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-11 Thread Hans Verkuil
On 03/09/2016 03:29 PM, Andrey Utkin wrote: > Hi Hans! > > Some improvements took place on the driver, including cleaner > v4l2-compliance tests passing. But there's a single test failure I > don't understand. > > In the code of v4l2-compliance, it seems like an API > call CREATE_BUFS is

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Hans Verkuil
Hi Niklas, On 02/29/2016 10:52 AM, Hans Verkuil wrote: > Hi Niklas, > > Thanks for your patch! Much appreciated. > > I have more comments for the v2, but nothing really big :-) > Just checking, you are working on a v3, right? I'd really like to get this in for kernel 4.7. Regards,

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-11 Thread Hans Verkuil
On 03/11/2016 09:40 AM, Andrey Utkin wrote: > On Fri, 11 Mar 2016 09:00:18 +0100 > Hans Verkuil wrote: >> The reason is likely to be the tw5864_queue_setup function which has >> not been updated to handle CREATE_BUFS support correctly. It should >> look like this: >> >> static

Re: [PATCH v3 1/2] media: soc_camera: rcar_vin: add R-Car Gen 2 and 3 fallback compatibility strings

2016-03-11 Thread Geert Uytterhoeven
On Fri, Mar 11, 2016 at 4:25 AM, Simon Horman wrote: > From: Yoshihiro Kaneko > > Add fallback compatibility string for R-Car Gen 1 and 2. > > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, e.g. Gen 2 and 3.

cron job: media_tree daily build: WARNINGS

2016-03-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 12 04:00:17 CET 2016 git branch: test git hash: 840f5b0572ea9ddaca2bf5540a171013e92c97bd gcc

[v4l-utils PATCHv2] libv4lconvert: Add support for V4L2_PIX_FMT_{NV16,NV61}

2016-03-11 Thread Niklas Söderlund
NV16 and NV61 are two-plane versions of the YUV 4:2:2 formats YUYV and YVYU. Support both formats by merging the two planes into a one and falling through to the V4L2_PIX_FMT_{YUYV,YVYU} code path. Signed-off-by: Niklas Söderlund --- I'm sorry this is a

Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

2016-03-11 Thread Sylwester Nawrocki
On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: > The fimc_md_parse_port_node() function return 0 if an endpoint node is > not found but according to Documentation/devicetree/bindings/graph.txt, > a port must always have at least one enpoint. > > So return an -EINVAL errno code to the

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Hans Verkuil
Hi Robert, A quick review below. I assume this is the first step to moving the pxa_camera driver out of soc-camera? On 03/09/2016 06:17 PM, Robert Jarzmik wrote: > Convert pxa_camera from videobuf to videobuf2. > > As the soc_camera was already compatible with videobuf2, the port is > quite

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-11 Thread Andrey Utkin
On Fri, 11 Mar 2016 10:59:02 +0100 Hans Verkuil wrote: > While userspace may specify FIELD_ANY when setting a format, the > driver should always map that to a specific field setting and should > never return FIELD_ANY back to userspace. > > In this case, the 'field' field of

Re: [RFT 2/2] [media] exynos4-is: Add missing port parent of_node_put on error paths

2016-03-11 Thread Sylwester Nawrocki
On 01/26/2016 01:41 AM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() remote port parent node is get with > of_graph_get_remote_port_parent() but it is not put on error path. > > Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for > asynchronous subdevices registration") >

[PATCH] Driver for Intersil/Techwell TW686x-based PCIe frame grabbers again

2016-03-11 Thread Krzysztof Hałasa
Signed-off-by: Krzysztof Halasa diff --git a/MAINTAINERS b/MAINTAINERS index f9c1a0f..c1759ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11071,6 +11071,12 @@ W: https://linuxtv.org S: Odd Fixes F: drivers/media/pci/tw68/ +TW686x VIDEO4LINUX DRIVER +M:

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

2016-03-11 Thread Sylwester Nawrocki
On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Robert Jarzmik
Hans Verkuil writes: > Hi Robert, > > A quick review below. > > I assume this is the first step to moving the pxa_camera driver out of > soc-camera? Hi Hans, It probably is. The next step would be the soc_camera adherence removal. I already began the work, but it's still in

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Hans Verkuil
On 03/11/2016 12:03 PM, Niklas Söderlund wrote: > Hi Hans, > > On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: >> Hi Niklas, >> >> On 02/29/2016 10:52 AM, Hans Verkuil wrote: >>> Hi Niklas, >>> >>> Thanks for your patch! Much appreciated. >>> >>> I have more comments for the v2, but nothing

Re: [RFT 1/2] [media] exynos4-is: Add missing endpoint of_node_put on error paths

2016-03-11 Thread Sylwester Nawrocki
On 01/26/2016 01:41 AM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() endpoint node is get with of_get_next_child() > but it is not put on error path. "is get" doesn't sound right to me, how about rephrasing this to: "In fimc_md_parse_port_node() reference count of the endpoint node

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Hans Verkuil
On 03/11/2016 02:41 PM, Robert Jarzmik wrote: > Hans Verkuil writes: > >> Hi Robert, >> >> A quick review below. >> >> I assume this is the first step to moving the pxa_camera driver out of >> soc-camera? > Hi Hans, > > It probably is. The next step would be the soc_camera

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

2016-03-11 Thread Javier Martinez Canillas
Hello Sylwester, On Fri, Mar 11, 2016 at 10:09 AM, Sylwester Nawrocki wrote: > On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: >> Thanks, I just noticed another similar issue in the driver now and is >> that fimc_is_parse_sensor_config() uses the same struct

Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

2016-03-11 Thread Javier Martinez Canillas
Hello Sylwester, On Fri, Mar 11, 2016 at 10:03 AM, Sylwester Nawrocki wrote: > On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: >> The fimc_md_parse_port_node() function return 0 if an endpoint node is >> not found but according to

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Niklas Söderlund
Hi Hans, On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: > Hi Niklas, > > On 02/29/2016 10:52 AM, Hans Verkuil wrote: > > Hi Niklas, > > > > Thanks for your patch! Much appreciated. > > > > I have more comments for the v2, but nothing really big :-) > > > > Just checking, you are working

[GIT PULL] Exynos/S5P SoC driver updates

2016-03-11 Thread Sylwester Nawrocki
Hi Mauro, This includes a few minor fixes and some long awaiting clean up patches for exynos/s5p drivers. The following changes since commit de08b5a8be0df1eb7c796b0fe6b30cf1d03d14a6: [media] v4l: exynos4-is: Drop unneeded check when setting up fimc-lite links (2016-03-05 09:10:01 -0300) are

[PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Mauro Carvalho Chehab
For au0828_enable_source() to work, the tuner links should be disabled and the tuner/decoder should be cached at au0828 struct. Fixes: 9822f4173f84 ('[media] au0828: use v4l2_mc_create_media_graph()') Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 2/2] [media] v4l2-mc: cleanup a warning

2016-03-11 Thread Mauro Carvalho Chehab
A previous patch removing dtv_demod needed to be rebased, but the hunk removing the data was not merged by mistake. Fixes: 840f5b0572ea ('media: au0828 disable tuner to demod link in au0828_media_device_register()'] Signed-off-by: Mauro Carvalho Chehab ---

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Robert Jarzmik
Hans Verkuil writes: > On 03/11/2016 02:41 PM, Robert Jarzmik wrote: >> Hans Verkuil writes: > One area where I would like to see some helper functions is with respect to > format/media bus processing. I played with this a little bit but it is >

Re: [PATCH] [media] au0828: disable tuner->decoder on init

2016-03-11 Thread Mauro Carvalho Chehab
Em Thu, 10 Mar 2016 14:56:30 -0700 Shuah Khan escreveu: > On 03/10/2016 12:57 PM, Mauro Carvalho Chehab wrote: > > As au0828 assumes that all links to ATV decoder and DTV demod > > should be disabled, make sure this is the case. > > > > Signed-off-by: Mauro Carvalho

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Hans Verkuil
On 03/11/2016 04:40 PM, Robert Jarzmik wrote: > Hans Verkuil writes: > >> On 03/11/2016 02:41 PM, Robert Jarzmik wrote: >>> Hans Verkuil writes: >> One area where I would like to see some helper functions is with respect to >> format/media bus processing.

Re: [PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Mauro Carvalho Chehab
Em Fri, 11 Mar 2016 09:27:40 -0700 Shuah Khan escreveu: > On 03/11/2016 08:55 AM, Mauro Carvalho Chehab wrote: > > For au0828_enable_source() to work, the tuner links should be > > disabled and the tuner/decoder should be cached at au0828 struct. > > hmm. are you sure

Re: [PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Shuah Khan
On 03/11/2016 08:55 AM, Mauro Carvalho Chehab wrote: > For au0828_enable_source() to work, the tuner links should be > disabled and the tuner/decoder should be cached at au0828 struct. hmm. are you sure about needing to cache decoder in au0828 struct. It gets cached in

Re: [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)"

2016-03-11 Thread Sylwester Nawrocki
On 12/06/2015 11:44 AM, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu The patch looks OK, but could you also provide a proper commit message? > Signed-off-by: Zeng Zhaoxiu > --- > drivers/media/platform/exynos4-is/fimc-is-regs.c | 3 ++- > 1 file

€950,000.00

2016-03-11 Thread Qatar Charity
Guten Tag, (€ 950,000.00 Euro) wurde Ihnen von der Qatar Foundation Endowment 2016 zugeordnet Bitte kontaktieren Sie das Vorstandsvorsitzender der Qatar Foundation für mehr Info. Kontakt e-mail für weitere Informationen: qforg...@gmail.com Mit freundlichen Grüßen, Herr Rashid Al-Naimi. Chief

Re: [PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Shuah Khan
On 03/11/2016 09:52 AM, Shuah Khan wrote: > On 03/11/2016 09:34 AM, Mauro Carvalho Chehab wrote: >> Em Fri, 11 Mar 2016 09:27:40 -0700 >> Shuah Khan escreveu: >> >>> On 03/11/2016 08:55 AM, Mauro Carvalho Chehab wrote: For au0828_enable_source() to work, the tuner

Re: [PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Shuah Khan
On 03/11/2016 09:34 AM, Mauro Carvalho Chehab wrote: > Em Fri, 11 Mar 2016 09:27:40 -0700 > Shuah Khan escreveu: > >> On 03/11/2016 08:55 AM, Mauro Carvalho Chehab wrote: >>> For au0828_enable_source() to work, the tuner links should be >>> disabled and the tuner/decoder

[GIT PULL for v4.4-rc8 or v4.5] media fixes

2016-03-11 Thread Mauro Carvalho Chehab
Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.5-5 For one last time fix: It adds a code that prevents some media tools like media-ctl to hide some entities that have their IDs out of the range expected by those apps. Thanks! Mauro

[PATCH 1/2 v2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Mauro Carvalho Chehab
For au0828_enable_source() to work, the tuner links should be disabled and the tuner/decoder should be cached at au0828 struct. While here, put dev->decoder cache together with dev->tuner, as it makes easier to drop both latter if/when we move the enable routines to the V4L2 core. Fixes: