Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-25 Thread Sakari Ailus
Hi Marek, On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: > Hi Laurent, > > On 2017-04-20 12:25, Laurent Pinchart wrote: > >Hi Marek, > > > >(CC'ing Sakari Ailus) > > > >Thank you for the patches. > > > >On Thursday 20 Apr 2017 11:13:36 Marek Szyprowski wrote: > >>Dear all, >

Re: [PATCH] dma-buf: avoid scheduling on fence status query

2017-04-25 Thread Andres Rodriguez
CC a few extra lists I missed. Regards, Andres On 2017-04-25 09:36 PM, Andres Rodriguez wrote: When a timeout of zero is specified, the caller is only interested in the fence status. In the current implementation, dma_fence_default_wait will always call schedule_timeout() at least once for an

cron job: media_tree daily build: ERRORS

2017-04-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Apr 26 05:00:15 CEST 2017 media-tree git hash:3622d3e77ecef090b5111e3c5423313f11711dfa media_build

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-25 Thread Alexandre Courbot
On Wed, Apr 26, 2017 at 4:15 AM, Jacek Anaszewski wrote: > Hi Alexandre, > > Thanks for the patch. > > On 04/25/2017 08:19 AM, Alexandre Courbot wrote: >> v4l2_m2m_job_finish(), which is called from the interrupt handler with >> slock acquired, can call the

[PATCH v2 02/21] libiscsi: Add an internal error code

2017-04-25 Thread Logan Gunthorpe
This is a prep patch to add a new error code to libiscsi. We want to rework some kmap calls to be able to fail. When we do, we'd like to use this error code. This patch simply introduces ISCSI_TCP_INTERNAL_ERR and prints "Internal Error." when it gets hit. Signed-off-by: Logan Gunthorpe

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Nicolas Dufresne
Le mardi 25 avril 2017 à 13:30 +0200, Pali Rohár a écrit : > Pinos (renamed from PulseVideo) > > https://blogs.gnome.org/uraeus/2015/06/30/introducing-pulse-video/ > https://cgit.freedesktop.org/~wtay/pinos/ > > But from git history it looks like it is probably dead now... This is also

[PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-25 Thread Logan Gunthorpe
This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support sgls that contain io memory. In order for that to

[PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe Cc: Alasdair Kergon Cc: Mike Snitzer --- drivers/md/dm-crypt.c | 39 ++- 1 file changed, 26

[PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This is a single straightforward conversion from kmap to sg_map. We also create the i915_gem_object_unmap function to common up the unmap code. Signed-off-by: Logan Gunthorpe Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 27

[PATCH v2 20/21] mmc: tifm_sd: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of

[PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to the new helper, except due to the lack of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Boris Ostrovsky Cc: Juergen Gross

[PATCH v2 13/21] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe Cc: Adaptec OEM Raid Solutions Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S

[PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Achim Leubner Cc: John Garry --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14

[PATCH v2 19/21] mmc: sdricoh_cs: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Cc: Sascha Sommer Cc: Ulf Hansson --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5

[PATCH v2 10/21] RDS: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion except there's no error path, so we make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Santosh Shilimkar Cc: "David S. Miller"

[PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Brian King Cc: Artur Paszkiewicz --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42

[PATCH v2 17/21] mmc: spi: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe Cc: Ulf Hansson ---

[PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Acked-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[PATCH v2 21/21] memstick: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion, but we have to make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Alex Dubov --- drivers/memstick/host/jmb38x_ms.c | 11 ++-

[PATCH v2 06/21] crypto: hifn_795x: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but

[PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion to the new function in the caam driver and shash library. Signed-off-by: Logan Gunthorpe Cc: Herbert Xu Cc: "David S. Miller" --- crypto/shash.c| 9 ++---

[PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

2017-04-25 Thread Logan Gunthorpe
These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe Cc: Johannes Thumshirn

[PATCH v2 00/21] Introduce common scatterlist map function

2017-04-25 Thread Logan Gunthorpe
Changes since v1: * Rebased onto next-20170424 * Removed the _offset version of these functions per Christoph's suggestion * Added an SG_MAP_MUST_NOT_FAIL flag which will BUG_ON in future cases that can't gracefully fail. This removes a bunch of the noise added in v1 to a couple of the

[PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We use ISCSI_TCP_INTERNAL_ERR error type that was prepared earlier for this. Signed-off-by: Logan Gunthorpe Cc: Lee Duncan

[PATCH v2 04/21] target: Make use of the new sg_map function at 16 call sites

2017-04-25 Thread Logan Gunthorpe
Fairly straightforward conversions in all spots. In a couple of cases any error gets propogated up should sg_map fail. In other cases a warning is issued if the kmap fails seeing there's no clear error path. This should not be an issue until someone tries to use unmappable memory in the sgl with

[PATCH v2 16/21] mmc: sdhci: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion, except due to the lack of an error path we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Adrian Hunter Cc: Ulf Hansson ---

[PATCH v2 18/21] mmc: tmio: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to sg_map helper. Seeing there is no cleare error path, SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Wolfram Sang Cc: Ulf Hansson

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Nicolas Dufresne
Le mardi 25 avril 2017 à 10:08 +0200, Pali Rohár a écrit : > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > It would be nice if more than one application could be > > > > accessing the > > > > camera at the same time... (I.e. something graphical running > > > > preview > > > > then

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Nicolas Dufresne
Le mardi 25 avril 2017 à 10:05 +0200, Pavel Machek a écrit : > Well, fd's are hard, because application can do fork() and now > interesting stuff happens. Threads are tricky, because now you have > locking etc. > > libv4l2 is designed to be LD_PRELOADED. That is not really feasible > with

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-25 Thread Jacek Anaszewski
Hi Alexandre, Thanks for the patch. On 04/25/2017 08:19 AM, Alexandre Courbot wrote: > v4l2_m2m_job_finish(), which is called from the interrupt handler with > slock acquired, can call the device_run() hook immediately if another > context was in the queue. This hook also acquires slock,

[PATCH] [media] cx18: fix spelling mistake: "demodualtor" -> "demodulator"

2017-04-25 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake and add in a white space in a CX18_ERR error message Signed-off-by: Colin Ian King --- drivers/media/pci/cx18/cx18-dvb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

2017-04-25 Thread Christophe JAILLET
Le 24/04/2017 à 22:29, Sakari Ailus a écrit : Hi Christophe, On Mon, Apr 24, 2017 at 10:00:24PM +0200, Christophe JAILLET wrote: Le 24/04/2017 à 16:16, Sakari Ailus a écrit : On Sun, Apr 23, 2017 at 11:32:57PM +0200, Christophe JAILLET wrote: We should ensure that 'plane_no' is '<

[PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-25 Thread Alexandre Courbot
v4l2_m2m_job_finish(), which is called from the interrupt handler with slock acquired, can call the device_run() hook immediately if another context was in the queue. This hook also acquires slock, resulting in a deadlock for this scenario. Fix this by releasing slock right before calling

[PATCH] ARM64: defconfig: enable IR core, decoders and Meson IR device

2017-04-25 Thread Neil Armstrong
This patch enables the MEDIA Infrared RC Decoders and Meson Infrared decoder for ARM64 defconfig. These drivers are selected as modules by default. Signed-off-by: Neil Armstrong --- arch/arm64/configs/defconfig | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH] media: rc: meson-ir: switch config to NEC decoding on shutdown

2017-04-25 Thread Neil Armstrong
From: Alex Deryskyba On the Amlogic SoCs, the bootloader firmware can handle the IR hardware in order to Wake up or Power back the system when in suspend on shutdown mode. This patch switches the hardware configuration in a state usable by the firmware to permit powering the

[PATCH] media: rc: meson-ir: store raw event without processing

2017-04-25 Thread Neil Armstrong
From: Jonas Karlman This patch fixes meson-it driver by storing event without processing to avoid losing key pressed events when system is loaded and events are occurring too fast. This issue was reported at [1] [1] https://github.com/LibreELEC/linux-amlogic/pull/42

Re: [PATCH] rc-core: use the full 32 bits for NEC scancodes in wakefilters

2017-04-25 Thread David Härdeman
April 24, 2017 6:02 PM, "Sean Young" wrote: > On Tue, Apr 18, 2017 at 10:31:04PM +0200, David Härdeman wrote: > >> The new sysfs wakefilter API will expose the difference between the NEC >> protocols to userspace for no good reason and once exposed, it will be much >> more

Re: [PATCH] rc-core: use the full 32 bits for NEC scancodes

2017-04-25 Thread David Härdeman
April 24, 2017 5:58 PM, "Sean Young" wrote: > On Tue, Apr 18, 2017 at 05:50:27PM +0200, David Härdeman wrote: >> Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core >> and the nec decoder without any loss of functionality. At the same time >> it ensures that

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pavel Machek
Hi! > > > > For focus to be useful, we need autofocus implmented > > > > somewhere. Unfortunately, v4l framework does not seem to provide good > > > > place where to put autofocus. I believe, long-term, we'll need some > > > > kind of "video server" providing this kind of services. > > > > > > >

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pali Rohár
On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > It would be nice if more than one application could be accessing the > > > camera at the same time... (I.e. something graphical running preview > > > then using command line tool to grab a picture.) This one is > > > definitely not

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pavel Machek
Hi! > > > Please don't add a new application under lib/. It is fine if you want > > > some testing application, if the ones there aren't enough, but please > > > place it under contrib/test/. > > > > > > You should likely take a look at v4l2grab first, as it could have > > > almost everything

Re: [PATCH v3 0/7] V4L2 fwnode support

2017-04-25 Thread Hans Verkuil
On 10/04/17 15:02, Sakari Ailus wrote: > Hello everyone, > > This patchset adds support for fwnode to V4L2. Besides OF, also ACPI based > systems can be supported this way. By using V4L2 fwnode, the individual > drivers do not need to be aware of the underlying firmware implementation. > The

Re: [PATCH] [media] ov2640: make GPIOLIB an optional dependency

2017-04-25 Thread Sakari Ailus
Hi Mauro, On Mon, Apr 24, 2017 at 11:05:29PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 24 Apr 2017 20:38:47 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Mon, Apr 24, 2017 at 12:50:36PM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 24 Apr 2017 17:44:02

[PATCH] ov2640: print error if devm_*_optional*() fails

2017-04-25 Thread Mauro Carvalho Chehab
devm_gpiod_get_optional() can return -ENOSYS if GPIOLIB is disabled, causing probe to fail. Warn the user if this happens. Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ov2640.c | 30

Re: [PATCH] ov2640: print error if devm_*_optional*() fails

2017-04-25 Thread Hans Verkuil
On 25/04/17 11:45, Mauro Carvalho Chehab wrote: > devm_gpiod_get_optional() can return -ENOSYS if GPIOLIB is > disabled, causing probe to fail. Warn the user if this > happens. > > Acked-by: Sakari Ailus > Signed-off-by: Mauro Carvalho Chehab

[PATCH] [RFC] em28xx: allow setting the eeprom bus at cards struct

2017-04-25 Thread Mauro Carvalho Chehab
Right now, all devices use bus 0 for eeprom. However, it seems that newer versions of Terratec H6 uses a different buffer for eeprom. So, add support to use a different I2C address for eeprom and add a new card ID for the board described at: http://forum.kodi.tv/showthread.php?tid=312902

stih-cec: can you check if it works when there is no HPD?

2017-04-25 Thread Hans Verkuil
Hi Benjamin, The CEC specification allows sending certain CEC messages even if there is no HPD signal. This is for displays that turn off the HPD when they go into standby or switch to another input, but still keep the CEC bus alive. Support for this was added to 4.12. But does your driver

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pavel Machek
Hi! > > Umm, and it looks like libv4l can not automatically convert from > > GRBG10.. and if it could, going through RGB24 would probably be too > > slow on this device :-(. > > I suspect it shouldn't be hard to add support for GRBG10. It already > supports 8 and 16 bits Bayer formats, at

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pavel Machek
Hi! On Tue 2017-04-25 10:08:15, Pali Rohár wrote: > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > It would be nice if more than one application could be accessing the > > > > camera at the same time... (I.e. something graphical running preview > > > > then using command line tool

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pali Rohár
On Tuesday 25 April 2017 13:23:30 Pavel Machek wrote: > Hi! > On Tue 2017-04-25 10:08:15, Pali Rohár wrote: > > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > > It would be nice if more than one application could be accessing the > > > > > camera at the same time... (I.e. something

Re: [git:media_tree/master] [media] uvcvideo: Don't record timespec_sub

2017-04-25 Thread Kieran Bingham
Hi Mauro On 10/04/17 11:42, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued: > > Subject: [media] uvcvideo: Don't record timespec_sub In my submission, this subject line was "uvcvideo: Don't recode timespec_sub" I

[PATCH v3.1 4/7] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-04-25 Thread Sakari Ailus
Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. Async OF matching is replaced by fwnode matching and OF matching support is removed. Signed-off-by: Sakari Ailus Acked-by: Benoit Parrot # i2c/ov2569.c, am437x/am437x-vpfe.c

Re: [PATCH v3 4/7] v4l: Switch from V4L2 OF not V4L2 fwnode API

2017-04-25 Thread Sakari Ailus
Changes since v3: - Convert recently merged ov5645 and ov5647 to V4L2 fwnode -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pavel Machek
On Tue 2017-04-25 13:30:09, Pali Rohár wrote: > On Tuesday 25 April 2017 13:23:30 Pavel Machek wrote: > > Hi! > > On Tue 2017-04-25 10:08:15, Pali Rohár wrote: > > > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > > > It would be nice if more than one application could be accessing

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pali Rohár
On Tuesday 25 April 2017 14:28:20 Pavel Machek wrote: > On Tue 2017-04-25 13:30:09, Pali Rohár wrote: > > On Tuesday 25 April 2017 13:23:30 Pavel Machek wrote: > > > Hi! > > > On Tue 2017-04-25 10:08:15, Pali Rohár wrote: > > > > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > > > >

Re: [PATCH 1/2] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr'

2017-04-25 Thread Dan Carpenter
Gar... No. The 3.6+ from a9ae4692eda4 ("[media] vb2: fix plane index sanity check in vb2_plane_cookie()") feels totally arbitrary to me. No need to be consistent. Just do: Cc: sta...@vger.kernel.org Fixes: e23ccc0ad925 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework") Fixes

Re: TW686x Linux Main Line Driver Issue

2017-04-25 Thread Ezequiel Garcia
Hi Krishan, On 25 April 2017 at 03:46, Krishan Nilanga wrote: > Hi All, > > gst-launch-1.0 --gst-debug=3 v4l2src device=/dev/video0 ! > video/x-raw,width=640,height=480,pixelformat=UYVY ! imxeglvivsink > > I have tried to run the above gstreamer pipeline and I'm getting >

Re: [PATCH 2/2] rcar-vin: group: use correct of_node

2017-04-25 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. On 2017-04-24 19:14:26 +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The unbind function dereferences the subdev->dev node to obtain the > of_node. In error paths, the subdev->dev can be set to NULL, whilst

Re: [PATCH 2/2] rcar-vin: group: use correct of_node

2017-04-25 Thread Kieran Bingham
Hi Niklas, On 25/04/17 15:30, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > On 2017-04-24 19:14:26 +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> The unbind function dereferences the subdev->dev node to obtain the >>

[PATCH -next] [media] s5p-cec: remove unused including

2017-04-25 Thread Wei Yongjun
From: Wei Yongjun Remove including that is not needed. Signed-off-by: Wei Yongjun --- drivers/media/platform/s5p-cec/s5p_cec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/s5p-cec/s5p_cec.h

[PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-25 Thread Kieran Bingham
From: Kieran Bingham The rvin_digital_notify_bound() call dereferences the subdev->dev pointer to obtain the of_node. On some error paths, this dev node can be set as NULL. The of_node is mapped into the subdevice structure on initialisation, so this is a