Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

On 05/08/2017 02:41 AM, Philipp Zabel wrote: Hi Steve, On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: This patch adds a call to imx_media_fill_empty_mbus_fields() in the *_try_fmt() functions at the sink pads, to set empty field order and colorimetry parameters. If the field

Re: [PATCH 0/4] DMA-buf: Fine-tuning for four function implementations

Hello Markus, On 8 May 2017 at 14:40, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 8 May 2017 11:05:05 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 9 05:00:19 CEST 2017 media-tree git hash:3622d3e77ecef090b5111e3c5423313f11711dfa media_build

Unknown symbol put_vaddr_frames when using media_build

Hi! Whenever I compile the media drivers using media_build against a recent kernel, I get this message when loading them: [5.848537] media: Linux media interface: v0.10 [5.881440] Linux video capture interface: v2.00 [5.881441] WARNING: You are using an experimental version of the

lening bieden

Goede dag,  Dit is het beveiligingsnetwerk van de kredietverstrekking.   SAFETY NET CREDIT biedt flexibele en betaalbare leningen voor elk doel om u te helpen uw doelen te bereiken. We lenen tegen een lage rente van 3%. Hier zijn enkele belangrijke kenmerken van de persoonlijke lening

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

Hi Philipp, Sorry for the very long delay, but I finally had some time to think about this. On 04/06/2017 03:55 PM, Philipp Zabel wrote: > If the the field order is set to ANY in set_fmt, choose the currently > set field order. If the colorspace is set to DEFAULT, choose the current >

[PATCH 2/4] dma-buf: Improve a size determination in dma_buf_attach()

From: Markus Elfring Date: Mon, 8 May 2017 10:50:09 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/4] dma-buf: Combine two function calls into one in dma_buf_debug_show()

From: Markus Elfring Date: Mon, 8 May 2017 10:32:44 +0200 A bit of data was put into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

[PATCH 3/4] dma-buf: Adjust a null pointer check in dma_buf_attach()

From: Markus Elfring Date: Mon, 8 May 2017 10:54:17 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!attach" Thus adjust this expression. Signed-off-by: Markus Elfring

[PATCH 4/4] dma-buf: Use seq_putc() in two functions

From: Markus Elfring Date: Mon, 8 May 2017 10:55:42 +0200 Three single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

Hi Hans, On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: > Hi Philipp, > > Sorry for the very long delay, but I finally had some time to think about > this. Thank you for your thoughts. > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt,

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

Hi Steve, On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and > colorimetry parameters. > > If the field order is set to ANY, choose the currently

Re: [PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

Em Sun, 7 May 2017 23:23:24 +0200 "Jasmin J." escreveu: > From: Jasmin Jessich > > Rename STATUSREG_?? -> STATREG_?? to reduce the line length. That sounds a bad idea. We use "stat" on the DVB subsystem as an alias for statistics. > > Signed-off-by: Jasmin

Re: [PATCH 2/3] [media] doc-rst: add IPU3 raw10 bayer pixel format definitions

On 04/30/2017 01:34 AM, Yong Zhi wrote: > The formats added by this patch are: > > V4L2_PIX_FMT_IPU3_SBGGR10 > V4L2_PIX_FMT_IPU3_SGBRG10 > V4L2_PIX_FMT_IPU3_SGRBG10 > V4L2_PIX_FMT_IPU3_SRGGB10 > > Signed-off-by: Yong Zhi > --- >

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong Zhi, See my review comments below. Nothing earth-shattering, you'll be pleased to hear :-) On 04/30/2017 01:34 AM, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > The V4L2 fwnode matching depends on the following work: > >

[PATCH 0/4] DMA-buf: Fine-tuning for four function implementations

From: Markus Elfring Date: Mon, 8 May 2017 11:05:05 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Combine two function calls into one in dma_buf_debug_show() Improve a size determination in

Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support

On 06/05/17 14:58, Hans Verkuil wrote: > My assumption was that hdmi_display_disable() was called when the hotplug > would go > away. But I discovered that that isn't the case, or at least not when X is > running. > It seems that the actual HPD check is done in hdmic_detect() in >

Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support

On 05/08/2017 12:26 PM, Tomi Valkeinen wrote: > On 06/05/17 14:58, Hans Verkuil wrote: > >> My assumption was that hdmi_display_disable() was called when the hotplug >> would go >> away. But I discovered that that isn't the case, or at least not when X is >> running. >> It seems that the actual

Re: [PATCH v2 1/7] [media] vimc: sen: Integrate the tpg on the sensor

Hi Helen, A quick review: On 04/08/2017 12:37 AM, Helen Koike wrote: > Initialize the test pattern generator on the sensor > Generate a colored bar image instead of a grey one > > Signed-off-by: Helen Koike > > --- > > Changes in v2: > [media] vimc: sen: Integrate

Re: [PATCH v2 2/7] [media] vimc: Add vimc_ent_sd_* helper functions

On 04/08/2017 12:37 AM, Helen Koike wrote: > As all the subdevices in the topology will be initialized in the same > way, to avoid code repetition the vimc_ent_sd_{register, unregister} > helper functions were created > > Signed-off-by: Helen Koike > > --- > >

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On 05/08/2017 11:36 AM, Philipp Zabel wrote: > Hi Hans, > > On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: >> Hi Philipp, >> >> Sorry for the very long delay, but I finally had some time to think about >> this. > > Thank you for your thoughts. > >> On 04/06/2017 03:55 PM, Philipp Zabel

Re: [PATCH 2/4] media: platform: dwc: Support for DW CSI-2 Host

Hi Ramiro, My sincere apologies for the long delay in reviewing this. The good news is that I should have more time for reviews going forward, so I hope I'll be a lot quicker in the future. On 03/07/2017 03:37 PM, Ramiro Oliveira wrote: > Add support for the Synopsys DesignWare CSI-2 Host > >

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Rajmohan, Thanks for the patch! A quick code review: On 05/07/2017 01:33 PM, rajmohan.m...@intel.com wrote: > From: Rajmohan Mani > > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides

Re: [PATCH v2 4/7] [media] vimc: sen: Support several image formats

On 04/08/2017 12:37 AM, Helen Koike wrote: > Allow user space to change the image format as the frame size, the > media bus pixel format, colorspace, quantization, field YCbCr encoding > and the transfer function > > Signed-off-by: Helen Koike > > --- > > Changes in

Re: [PATCH v2 5/7] [media] vimc: cap: Support several image formats

On 04/08/2017 12:37 AM, Helen Koike wrote: > Allow user space to change the image format as the frame size, the > pixel format, colorspace, quantization, field YCbCr encoding > and the transfer function > > Signed-off-by: Helen Koike > > --- > > Changes in v2: >

Re: [PATCH v2 6/7] [media] vimc: deb: Add debayer filter

On 04/08/2017 12:37 AM, Helen Koike wrote: > Implement the debayer filter and integrate it with the core > > Signed-off-by: Helen Koike > > --- > > Changes in v2: > [media] vimc: deb: Add debayer filter > - Using MEDIA_ENT_F_ATV_DECODER in function > -

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, On Mon, May 08, 2017 at 11:06:29AM +0200, Hans Verkuil wrote: ... > > +static void cio2_queue_event_sof(struct cio2_device *cio2, struct > > cio2_queue *q) > > +{ > > + struct v4l2_event event = { > > + .type = V4L2_EVENT_FRAME_SYNC, > > +

Re: [PATCH v2 0/7] [media]: vimc: Virtual Media Control VPU's

Hi Helen, On 04/08/2017 12:37 AM, Helen Koike wrote: > This patch series improves the current video processing units in vimc > (by adding more controls to the sensor and capture node, allowing the > user to configure different frame formats) and also adds a debayer > and a scaler node. > The

Re: [RFC v2 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors

On Fri, May 05, 2017 at 11:48:30AM +0300, Sakari Ailus wrote: > Many camera sensor devices contain EEPROM chips that describe the > properties of a given unit --- the data is specific to a given unit can > thus is not stored e.g. in user space or the driver. > > Some sensors embed the EEPROM chip

Re: [PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

Hello Mauro! >> Rename STATUSREG_?? -> STATREG_?? to reduce the line length. > That sounds a bad idea. We use "stat" on the DVB subsystem as an > alias for statistics. At the beginning of the style fixes, I thought it is a good idea to reduce as much as possible to get more characters, but at

Re: [PATCH v2 0/2] rcar-du, vsp1: rcar-gen3: Add support for colorkey alpha blending

On Mon, May 08, 2017 at 09:33:37AM -0700, Eric Anholt wrote: > Alexandru Gheorghe writes: > > > Currently, rcar-du supports colorkeying only for rcar-gen2 and it uses > > some hw capability of the display unit(DU) which is not available on gen3. > > In order to

Re: [RFC v2 2/3] dt: bindings: Add lens-focus binding for image sensors

On Fri, May 05, 2017 at 11:48:29AM +0300, Sakari Ailus wrote: > The lens-focus property contains a phandle to the lens voice coil driver > that is associated to the sensor; typically both are contained in the same > camera module. > > Signed-off-by: Sakari Ailus >

[PATCH] staging: media: fix one code style problem

this patch will fix one code style problem (ctx:WxE), space prohibited before that Signed-off-by: Remco Verhoef --- .../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/4] v4l: vsp1: Calculate partition sizes at stream start.

Hi Laurent, Thanks for the review, V2 to be posted after testing. On 13/02/17 21:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 04 Nov 2016 18:19:29 Kieran Bingham wrote: >> Previously the active window and partition sizes for each partition is > >

Re: [RFC v2 1/3] dt: bindings: Add a binding for flash devices associated to a sensor

On Fri, May 05, 2017 at 11:48:28AM +0300, Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > > Signed-off-by: Sakari Ailus

Re: [PATCH v2 0/2] rcar-du, vsp1: rcar-gen3: Add support for colorkey alpha blending

Alexandru Gheorghe writes: > Currently, rcar-du supports colorkeying only for rcar-gen2 and it uses > some hw capability of the display unit(DU) which is not available on gen3. > In order to implement colorkeying for gen3 we need to use the colorkey > capability

[RFC v4 12/18] vb2: dma-sg: Let drivers decide DMA attrs of MMAP and USERPTR bufs

The desirable DMA attributes are not generic for all devices using Videobuf2 scatter-gather DMA ops. Let the drivers decide. As a result, also the DMA-BUF exporter must provide ops for synchronising the cache. This adds begin_cpu_access and end_cpu_access ops to vb2_dc_dmabuf_ops. Signed-off-by:

[RFC v4 14/18] vb2: Improve struct vb2_mem_ops documentation; alloc and put are for MMAP

The alloc() and put() ops are for MMAP buffers only. Document it. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- include/media/videobuf2-core.h | 20

[RFC v4 05/18] vb2: Anticipate queue specific DMA attributes for USERPTR buffers

The DMA attributes were available for the memop implementation for MMAP buffers but not for USERPTR buffers. Do the same for USERPTR. This patch makes no functional changes. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/videobuf2-core.c | 2 +-

Re: [PATCH v4 6/7] dt-bindings: media: Add Renesas R-Car DRIF binding

On Tue, May 02, 2017 at 02:26:14PM +0100, Ramesh Shanmugasundaram wrote: > Add binding documentation for Renesas R-Car Digital Radio Interface > (DRIF) controller. > > Signed-off-by: Ramesh Shanmugasundaram > > --- > v4: > - port property description

[PATCH v3] staging: media: atomisp: Fix indentation to tabs

Fixing following checkpatch warnnings/errors: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Gideon Sheril --- Changed from previuos version: - Fixed alignment issues - Verified no new warning or errors

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, On Mon, May 08, 2017 at 02:32:22PM +0200, Hans Verkuil wrote: > On 05/08/2017 02:10 PM, Sakari Ailus wrote: ... > >>> +/* .complete() is called after all subdevices have been located */ > >>> +static int cio2_notifier_complete(struct v4l2_async_notifier *notifier) > >>> +{ > >>> +

Re: [PATCH 4/4] dma-buf: Use seq_putc() in two functions

Hi Markus, Thank for your patches. 2017-05-08 SF Markus Elfring : > From: Markus Elfring > Date: Mon, 8 May 2017 10:55:42 +0200 > > Three single characters (line breaks) should be put into a sequence. > Thus use the corresponding

[RFC v4 00/18] vb2: Handle user cache hints, allow drivers to choose cache coherency

Hello, This is a rebased and partially reworked version of the vb2 cache hints support patch series posted by first myself, then Laurent and then myself again. I'm still posting this as RFC primarily because more testing and driver changes will be needed. In particular, a lot of platform drivers

[RFC v4 02/18] vb2: Move buffer cache synchronisation to prepare from queue

The buffer cache should be synchronised in buffer preparation, not when the buffer is queued to the device. Fix this. Mmap buffers do not need cache synchronisation since they are always coherent. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[RFC v4 04/18] v4l: Unify cache management hint buffer flags

The V4L2_BUF_FLAG_NO_CACHE_INVALIDATE and V4L2_BUF_FLAG_NO_CACHE_CLEAN buffer flags are currently not used by the kernel. Replace the definitions by a single V4L2_BUF_FLAG_NO_CACHE_SYNC flag to be used by further patches. Different cache architectures should not be visible to the user space which

[RFC v4 11/18] vb2: dma-contig: Add WARN_ON_ONCE() to check for potential bugs

The scatterlist should always be present when the cache would need to be flushed. Each buffer type has its own means to provide that. Add WARN_ON_ONCE() to check the scatterist exists. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil ---

[RFC v4 17/18] docs-rst: Document precise V4L2_BUF_FLAG_NO_CACHE_SYNC flag behaviour

Document when should the user specify V4L2_BUF_FLAG_NO_CACHE_SYNC flag. Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/buffer.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/Documentation/media/uapi/v4l/buffer.rst

[RFC v4 18/18] v4l: Use non-consistent DMA mappings for hardware that deserves it

Set DMA_ATTR_NON_CONSISTENT for hardware that uses non-consistent memory. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/ispvideo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/omap3isp/ispvideo.c

[RFC v4 13/18] vb2: Don't sync cache for a buffer if so requested

From: Samu Onkalo The user may request to the driver (vb2) to skip the cache maintenance operations in case the buffer does not need cache synchronisation, e.g. in cases where the buffer is passed between hardware blocks without it being touched by the CPU. Also document

[RFC v4 06/18] vb2: dma-contig: Assign DMA attrs for a buffer unconditionally

attrs used to be a pointer and the caller of vb2_dc_alloc() could optionally provide it, or NULL. This was when struct dma_attrs was used to describe DMA attributes rather than an unsigned long value. There is no longer a need to maintain the condition, assign the value unconditionally. There is

[RFC v4 07/18] vb2: dma-contig: Remove redundant sgt_base field

The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used by USERPTR. Unify the two, leaving dma_sgt. MMAP buffers do not need cache flushing since they have been allocated using dma_alloc_coherent().

[RFC v4 09/18] vb2: dma-contig: Allocate sgt as part of struct vb2_dc_buf

The scatterlist table is needed in the vast majority of the cases. Allocate struct sg_table as part of the struct. This has the benefit of making managing the buffer data structure allocation, setup and release more simple. Signed-off-by: Sakari Ailus ---

[RFC v4 15/18] vb2: Dma direction is always DMA_TO_DEVICE in buffer preparation

The patch changes the DMA direction from DMA_FROM_DEVICE to DMA_TO_DEVICE for capture buffers. The DMA API does not require that any synchronisation is done to the buffer when it is passed to hardware for writing _but_ there's a caveat: the user *must not* have written to the buffer. The V4L2

[RFC v4 01/18] vb2: Rename confusingly named internal buffer preparation functions

Rename __qbuf_*() functions which are specific to a buffer type as __prepare_*() which matches with what they do. The naming was there for historical reasons; the purpose of the functions was changed without renaming them. Signed-off-by: Sakari Ailus Acked-by: Hans

[RFC v4 08/18] vb2: dma-contig: Don't warn on failure in obtaining scatterlist

vb2_dc_get_base_sgt() which obtains the scatterlist already prints information on why the scatterlist could not be obtained. Also, remove the useless warning of a failed kmalloc(). Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart

[RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA attrs") added support for driver specific DMA attributes to videobuf2-dma-contig but it had several issues in it. In particular, - cache operations were only performed on USERPTR buffers, - DMA attributes were set only for MMAP

[RFC v4 16/18] vb2: Do sync plane cache only for CAPTURE buffers in finish memop

There is no need synchronise buffer cache for OUTPUT devices when the buffer is dequeued as the hardware only reads from the buffer. Only sync for capture buffers. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 5 +++--

[RFC v4 03/18] vb2: Move cache synchronisation from buffer done to dqbuf handler

The cache synchronisation may be a time consuming operation and thus not best performed in an interrupt which is a typical context for vb2_buffer_done() calls. This may consume up to tens of ms on some machines, depending on the buffer size. Signed-off-by: Sakari Ailus

Re: [PATCH v4 1/2] [media] dt-bindings: Add bindings for video-multiplexer device

On Thu, May 04, 2017 at 05:17:18PM +0200, Philipp Zabel wrote: > Add bindings documentation for the video multiplexer device. > > Signed-off-by: Sascha Hauer > Signed-off-by: Philipp Zabel > Signed-off-by: Steve Longerbeam

Re: [PATCH 3/4] dma-buf: Adjust a null pointer check in dma_buf_attach()

2017-05-08 SF Markus Elfring : > From: Markus Elfring > Date: Mon, 8 May 2017 10:54:17 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > Comparison to NULL could be written "!attach" > > Thus

[PATCH v2] dw9714: Initial driver for dw9714 VCM

DW9714 is a 10 bit DAC, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Rajmohan Mani --- Changes in v2: - Addressed review comments from Hans Verkuil -

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On 05/08/2017 02:10 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, May 08, 2017 at 11:06:29AM +0200, Hans Verkuil wrote: > ... >>> +static void cio2_queue_event_sof(struct cio2_device *cio2, struct >>> cio2_queue *q) >>> +{ >>> + struct v4l2_event event = { >>> + .type =

[RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling

From: Hans Verkuil The type field in struct v4l2_selection is supposed to never use the _MPLANE variants. E.g. if the driver supports V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, then userspace should still pass V4L2_BUF_TYPE_VIDEO_CAPTURE. The reasons for this are lost in the mists

[RFC PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior

From: Hans Verkuil Unfortunately the use of 'type' was inconsistent for multiplanar buffer types. Starting with 4.12 both the normal and _MPLANE variants are allowed, thus making it possible to write sensible code. Yes, we messed up :-( Signed-off-by: Hans Verkuil

RE: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Hans, Thanks for the quick review. Please see my comments inline... I will post the new v2 patch soon. > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Monday, May 08, 2017 6:59 PM > To: Mani, Rajmohan ; linux- >

Re: [PATCH 1/4] dma-buf: Combine two function calls into one in dma_buf_debug_show()

2017-05-08 SF Markus Elfring : > From: Markus Elfring > Date: Mon, 8 May 2017 10:32:44 +0200 > > A bit of data was put into a sequence by two separate function calls. > Print the same data by a single function call instead. > > This

Re: [PATCH 2/4] dma-buf: Improve a size determination in dma_buf_attach()

2017-05-08 SF Markus Elfring : > From: Markus Elfring > Date: Mon, 8 May 2017 10:50:09 +0200 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

On 05/08/2017 02:56 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, May 08, 2017 at 02:32:22PM +0200, Hans Verkuil wrote: >> On 05/08/2017 02:10 PM, Sakari Ailus wrote: > > ... > > +/* .complete() is called after all subdevices have been located */ > +static int

Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

On Mon, May 08, 2017 at 07:36:48AM -0700, Rajmohan Mani wrote: > + dev_dbg(dev, "%s ret = %d\n", __func__, ret); Please remove such debug prints. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

Hi Rajmohan, A few comments below... On Sun, May 07, 2017 at 04:33:24AM -0700, rajmohan.m...@intel.com wrote: > From: Rajmohan Mani > > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides

[PATCH] ATOMISP: Tidies up code warnings and errors in file

Cleared up some errors and warnings in drivers/staging/media/atomisp/i2c/ap1302.c Signed-off-by: Mark Railton --- drivers/staging/media/atomisp/i2c/ap1302.c | 83 ++ 1 file changed, 50 insertions(+), 33 deletions(-) diff --git

[patch, libv4l]: fix integer overflow

Hi! This bit me while trying to use absolute exposure time on Nokia N900: Can someone apply it to libv4l2 tree? Could I get some feedback on the other patches? Is this the way to submit patches to libv4l2? Thanks, Pavel commit

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Hans, On Mon, May 08, 2017 at 03:08:26PM +0200, Hans Verkuil wrote: > On 05/08/2017 02:56 PM, Sakari Ailus wrote: ... > >> The USERPTR mode is more dubious. Has this been tested? Can the DMA handle > >> partially > >> filled pages? (I.e. there must be no requirements such as that the DMA has