[PATCH] media: ddbridge: fix build warnings

2017-11-06 Thread Randy Dunlap
From: Randy Dunlap Fix 2 build warnings. These functions are void, so drop the "return"s. ./drivers/media/pci/ddbridge/ddbridge-io.h: warning: 'return' with a value, in function returning void [enabled by default]: => 50:2, 55:2 Signed-off-by: Randy Dunlap

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-06 Thread Nicolas Dufresne
Le lundi 06 novembre 2017 à 10:28 +0100, Marek Szyprowski a écrit : > Hi Nicolas, > > On 2017-11-03 14:45, Nicolas Dufresne wrote: > > Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : > > > MFC driver supports only MMAP operation mode mainly due to the hardware > > >

RE: [PATCH v7 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-11-06 Thread Mani, Rajmohan
Hi Sakari, Yong, > Subject: Re: [PATCH v7 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver > > Hi Yong, > > Thanks for the update! > > I took a final glance, there are a few matters that still need to be > addressed but > then I think we're done. Please see below. > > Then we'll need an entry

Re: [PATCH][V2] bdisp: remove redundant assignment to pix

2017-11-06 Thread Fabien DESSENNE
Hi Colin Thank you for the patch. On 29/10/17 14:43, Colin King wrote: > From: Colin Ian King > > Pointer pix is being initialized to a value and a little later > being assigned the same value again. Remove the initial assignment to > avoid a duplicate assignment.

Re: [PATCH 2/4] dma-buf/fence: Sparse wants __rcu on the object itself

2017-11-06 Thread Daniel Vetter
On Thu, Nov 02, 2017 at 10:03:34PM +0200, Ville Syrjala wrote: > From: Chris Wilson > > In order to silent sparse in dma_fence_get_rcu_safe(), we need to mark s/silent/silence/ On the series (assuming sparse is indeed happy now, I didn't check that): Reviewed-by:

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-06 Thread Marek Szyprowski
Hi Nicolas, On 2017-11-03 14:45, Nicolas Dufresne wrote: Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : MFC driver supports only MMAP operation mode mainly due to the hardware restrictions of the addresses of the DMA buffers (MFC v5 hardware can access buffers only in

Re: [RESEND PATCH 1/1] of: Make return types of to_of_node and of_fwnode_handle macros consistent

2017-11-06 Thread Rob Herring
On Thu, Nov 02, 2017 at 11:59:18AM +0200, Sakari Ailus wrote: > (Fixed Mauro's e-mail.) > > to_of_node() macro checks whether the fwnode_handle passed to it is not an > OF node, and if so, returns NULL in order to be NULL-safe. Otherwise it > returns the pointer to the OF node which the

[PATCH v2] uvc: Add D3DFMT_L8 support

2017-11-06 Thread Nicolas Dufresne
Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when exposing formats. This adds support for D3DFMT_L8 as exposed from the Acer Windows Mixed Reality Headset. Signed-off-by: Nicolas Dufresne --- drivers/media/usb/uvc/uvc_driver.c | 5 +

Re: [PATCH] vimc: add test_pattern and h/vflip controls to the sensor

2017-11-06 Thread Helen Koike
Hi Hans, On 2017-11-06 08:19 AM, Hans Verkuil wrote: > Hi Helen, > > On 09/27/2017 08:30 PM, Helen Koike wrote: >> Hi Hans, >> >> Thanks for your patch and sorry for my late reply. > > Sorry for my late reply to your reply :-) > >> Please see my comments and questions below >> >> On 2017-07-28

Re: broken build against 4.4.0

2017-11-06 Thread Vincent McIntyre
On Sun, Nov 05, 2017 at 01:55:22PM +0100, Jasmin J. wrote: > Hello Vincent! > > > can someone take a look please? > Well, Matthias may have fixed that (I didn't try). > > See: > https://www.mail-archive.com/linux-media@vger.kernel.org/msg121610.html > > Maybe you need that also: >

[PATCHv2] vimc: add test_pattern and h/vflip controls to the sensor

2017-11-06 Thread Hans Verkuil
Add support for the test_pattern control and the h/vflip controls. This makes it possible to switch to more interesting test patterns and to test control handling in v4l-subdevs. There are more tpg-related controls that can be added, but this is a good start. Signed-off-by: Hans Verkuil

Re: [PATCH] vimc: add test_pattern and h/vflip controls to the sensor

2017-11-06 Thread Hans Verkuil
Hi Helen, On 09/27/2017 08:30 PM, Helen Koike wrote: > Hi Hans, > > Thanks for your patch and sorry for my late reply. Sorry for my late reply to your reply :-) > Please see my comments and questions below > > On 2017-07-28 07:23 AM, Hans Verkuil wrote: >> Add support for the test_pattern

[PATCH 3/5] media: lirc: allow lirc device to opened more than once

2017-11-06 Thread Sean Young
This makes it possible for lircd to read from a lirc chardev, and not keep it busy. Note that this changes the default for timeout reports to on. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 280 include/media/rc-core.h

[PATCH 5/5] media: rc: iguanair: remove unnecessary locking

2017-11-06 Thread Sean Young
Since lirc now correctly locks the rcdev, this locking is no longer needed. Signed-off-by: Sean Young --- drivers/media/rc/iguanair.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index

[PATCH 0/5] lirc improvements

2017-11-06 Thread Sean Young
This patch series depend on the lirc scancode and lirc kapi removal series. This implements correct locking for lirc and allows the chardev to be opened more than once. Sean Young (5): media: rc: move ir-lirc-codec.c contents into lirc_dev.c media: rc: include rather than media: lirc:

[PATCH 1/5] media: rc: move ir-lirc-codec.c contents into lirc_dev.c

2017-11-06 Thread Sean Young
Since removing the lirc kapi, ir-lirc-codec.c only contains lirc fops so the file name is no longer correct. By moving its content into lirc_dev.c the ugly extern struct lirc_fops is not longer needed, and everything lirc related is in one file. Signed-off-by: Sean Young ---

[PATCH 4/5] media: lirc: improve locking

2017-11-06 Thread Sean Young
Once rc_unregister_device() has been called, no driver function should be called. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 255 +--- 1 file changed, 147 insertions(+), 108 deletions(-) diff --git

[PATCH 2/5] media: rc: include rather than

2017-11-06 Thread Sean Young
This removes the need for include/media/lirc.h, which just includes the uapi file. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 2 +- include/media/lirc.h| 1 - 2 files changed, 1 insertion(+), 2 deletions(-) delete mode 100644 include/media/lirc.h diff

RE: [PATCH v7 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-11-06 Thread Mani, Rajmohan
Hi Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Monday, November 06, 2017 3:38 PM > To: Mani, Rajmohan > Cc: Zhi, Yong ; linux-media@vger.kernel.org; Zheng, Jian > Xu

Re: [PATCH v7 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-11-06 Thread Sakari Ailus
Hi Rajmohan, On Mon, Nov 06, 2017 at 07:32:52PM +, Mani, Rajmohan wrote: > Hi Sakari, Yong, > > > Subject: Re: [PATCH v7 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver > > > > Hi Yong, > > > > Thanks for the update! > > > > I took a final glance, there are a few matters that still need

[PATCH 1/3] atomisp: Fix up the open v load race

2017-11-06 Thread Alan
This isn't the ideal final solution but it stops the main problem for now where an open (often from udev) races the device initialization and we try and load the firmware twice at the same time. This needless to say doesn't usually end well. Signed-off-by: Alan Cox ---

[PATCH 3/3] atomisp: hmm gives a bogus warning on unload

2017-11-06 Thread Alan
The problem is that we allocated a dummy page to ensure that 0 aka NULL isn't returned as an ISP pointer into the hmm space. The free routine rather sensibly checks for bogus NULL frees but is tripped by hmm_cleanup freeing the dummy. Split the routine so that we can keep the protection check and

[PATCH 2/3] atomisp: fix vfree of bogus data on unload

2017-11-06 Thread Alan
We load the firmware once, set pointers to it and then at some point release it. We should not be doing a vfree() on the pointers into the firmware. Signed-off-by: Alan Cox --- .../atomisp/pci/atomisp2/css2400/sh_css_firmware.c |2 -- 1 file changed, 2 deletions(-)

cron job: media_tree daily build: ERRORS

2017-11-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 7 05:00:17 CET 2017 media-tree git hash:9917fbcfa20ab987d6381fd0365665e5c1402d75 media_build

Re: [PATCH v2] uvc: Add D3DFMT_L8 support

2017-11-06 Thread Laurent Pinchart
Hi Nicolas, Thank you for the patch. On Monday, 6 November 2017 22:13:28 EET Nicolas Dufresne wrote: > Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when > exposing formats. This adds support for D3DFMT_L8 as exposed from > the Acer Windows Mixed Reality Headset. > >

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-06 Thread Tim Harvey
On Fri, Oct 20, 2017 at 7:00 AM, Tim Harvey wrote: > On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: > >>> >>> Regarding video standard detection where this chip provides me with >>> vertical-period, horizontal-period, and horizontal-pulse-width

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-06 Thread Hans Verkuil
On 11/07/2017 07:04 AM, Tim Harvey wrote: > On Fri, Oct 20, 2017 at 7:00 AM, Tim Harvey wrote: >> On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: >> Regarding video standard detection where this chip provides me with

lening bieden nu aanvragen

2017-11-06 Thread Scotwest Credit Union Limited
Groetjes aan jou, GELD BESCHIKBAAR VOOR LENING. Krijg het geld / de lening die je nodig hebt bij Scotwest Credit Union Limited. Wij zijn particuliere kredietverstrekkers / investeerders en bieden zowel persoonlijke leningen, startleningen, educatieve / agrarische leningen, onroerend goed /

[PATCH 3/3] [media] v4l2: disable filesystem-dax mapping support

2017-11-06 Thread Dan Williams
V4L2 memory registrations are incompatible with filesystem-dax that needs the ability to revoke dma access to a mapping at will, or otherwise allow the kernel to wait for completion of DMA. The filesystem-dax implementation breaks the traditional solution of truncate of active file backed mappings

[PATCH 0/3] introduce get_user_pages_longterm()

2017-11-06 Thread Dan Williams
Andrew, Here is a new get_user_pages api for cases where a driver intends to keep an elevated page count indefinitely. This is distinct from usages like iov_iter_get_pages where the elevated page counts are transient. The iov_iter_get_pages cases immediately turn around and submit the pages to a

[PATCH] usb: dvb-usb-v2: dvb_usb_core: remove redundant code in dvb_usb_fe_sleep

2017-11-06 Thread Gustavo A. R. Silva
Check on return value and goto instruction is redundant as the code that follows is the goto label err. Addresses-Coverity-ID: 1268783 Signed-off-by: Gustavo A. R. Silva --- drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH 2/6 v5] V4L: Add a UVC Metadata format

2017-11-06 Thread Guennadi Liakhovetski
Hi Hans, Thanks for the comments. On Mon, 30 Oct 2017, Hans Verkuil wrote: > Hi Guennadi, > > On 07/28/2017 02:46 PM, Hans Verkuil wrote: > > On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote: > >> Add a pixel format, used by the UVC driver to stream metadata. > >> > >> Signed-off-by:

usb/media/uvc: slab-out-of-bounds in uvc_probe

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). It seems that type == UVC_ITT_CAMERA | 0x8000, that's why the (type == UVC_ITT_CAMERA) check fails and (UVC_ENTITY_TYPE(term) == UVC_ITT_CAMERA) passes, so

usb/media/tm6000: use-after-free in tm6000_read_write_usb

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). usb 1-1: USB disconnect, device number 11 tm6000: disconnecting tm6000 #0 xc2028 0-0061: destroying instance

[PATCH] media: av7110: avoid 2038 overflow in debug print

2017-11-06 Thread Arnd Bergmann
Using the deprecated do_gettimeofday() in print_time() will overflow in 2038 on 32-bit architectures. It'sbetter to use a structure that is safe everywhere. While we're at it, fix the missing leading zeroes on the sub-second portion. Signed-off-by: Arnd Bergmann ---

[PATCH] media: rc: Replace timeval with ktime_t in imon.c

2017-11-06 Thread Arnd Bergmann
From: Chunyan Zhang This patch changes the 32-bit time type (timeval) to the 64-bit one (ktime_t), since 32-bit time types will break in the year 2038. I use ktime_t instead of all uses of timeval in imon.c This patch also changes do_gettimeofday() to ktime_get()

usb/media/technisat: slab-out-of-bounds in technisat_usb2_rc_query

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). It seems that there's no check of the received buffer length in technisat_usb2_get_ir(). ==

[PATCH] [media] Don't do DMA on stack for firmware upload in the AS102 driver

2017-11-06 Thread Michele Baldessari
Firmware load on AS102 is using the stack which is not allowed any longer. We currently fail with: kernel: transfer buffer not dma capable kernel: [ cut here ] kernel: WARNING: CPU: 0 PID: 598 at drivers/usb/core/hcd.c:1595 usb_hcd_map_urb_for_dma+0x41d/0x620 kernel: