Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

Hi Hans, On 2017-12-15 16:57, Hans Verkuil wrote: On 14/12/17 15:11, Marek Szyprowski wrote: I would like to get your opinion on this patch. Do you think it makes sense to: 1. add limited support for USERPTR and DMA-buf import? (limited means driver will accept setting buffer pointer/fd only

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

On Mon, Nov 13, 2017 at 3:32 PM, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Signed-off-by: Yong Deng > --- > .../devicetree/bindings/media/sun6i-csi.txt| 51 > ++ > 1 file changed, 51

Re: [PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

Hi Sakari, On Monday, 18 December 2017 01:33:56 EET Sakari Ailus wrote: > On Sun, Dec 17, 2017 at 07:03:17PM +0200, Laurent Pinchart wrote: > > On Wednesday, 13 December 2017 20:26:19 EET Jacopo Mondi wrote: > >> Currently, subdevice notifiers are tested against all available > >> subdevices as

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

Hi Michal, On Monday, 18 December 2017 09:32:12 EET Michal Simek wrote: > On 15.12.2017 10:27, Mauro Carvalho Chehab wrote: > > Em Fri, 15 Dec 2017 10:55:26 +0530 Dhaval Shah escreveu: > >> On Fri, Dec 15, 2017 at 3:32 AM, Laurent Pinchart wrote: > >>> On Thursday, 14 December 2017 23:50:03 EET

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

Hi, On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote: > > > + compatible = "allwinner,sun8i-v3s-csi"; > > > + reg = <0x01cb4000 0x1000>; > > > + interrupts = ; > > > + clocks = < CLK_BUS_CSI>, > > > +<

Kindly Assist Me?

Kindly Assist Me In good faith from Mr.Sonami, actually could you please consider to help me to relocate this sum of five million, three hundred thousand dollars (US$5.3 m) to your country for establishing a medium industry in your country? The said 5.3 million dollars was deposited in our

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

Hi Laurent, On 18.12.2017 09:32, Laurent Pinchart wrote: > Hi Michal, > > On Monday, 18 December 2017 09:32:12 EET Michal Simek wrote: >> On 15.12.2017 10:27, Mauro Carvalho Chehab wrote: >>> Em Fri, 15 Dec 2017 10:55:26 +0530 Dhaval Shah escreveu: On Fri, Dec 15, 2017 at 3:32 AM, Laurent

[PATCH v2 1/2] media: dt-bindings: coda: Add compatible for CodaHx4 on i.MX51

Add a compatible for the CodaHx4 VPU used on i.MX51. Signed-off-by: Philipp Zabel Reviewed-by: Rob Herring --- Changes since v1 [1]: - Fix list enumerators, suggested by Baruch [1] https://patchwork.linuxtv.org/patch/45929/ ---

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

On Mon, 18 Dec 2017 16:35:51 +0800 Chen-Yu Tsai wrote: > On Mon, Nov 13, 2017 at 3:32 PM, Yong Deng wrote: > > Add binding documentation for Allwinner V3s CSI. > > > > Signed-off-by: Yong Deng > > --- > >

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

Hi, On Mon, 18 Dec 2017 10:24:37 +0100 Maxime Ripard wrote: > Hi, > > On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote: > > > > + compatible = "allwinner,sun8i-v3s-csi"; > > > > + reg = <0x01cb4000 0x1000>; > > > > +

[PATCH v2 2/2] media: coda: Add i.MX51 (CodaHx4) support

Add support for the CodaHx4 VPU used on i.MX51. Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding h.264. MPEG-4 encoding is not enabled, it currently produces visual artifacts. Signed-off-by: Philipp Zabel --- No changes since v1 [1]. [1]

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

On Mon, Dec 18, 2017 at 5:43 PM, Yong wrote: > Hi, > > On Mon, 18 Dec 2017 10:24:37 +0100 > Maxime Ripard wrote: > >> Hi, >> >> On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote: >> > > > + compatible =

Re: [PATCH v3 3/5] media: dt-bindings: ov5640: add support of DVP parallel interface

Hi Sakari, On 12/13/2017 08:47 PM, Sakari Ailus wrote: > Hi Hugues, > > Hugues FRUCHET wrote: >> Hi Sakari, >> >> On 12/07/2017 02:59 PM, Sakari Ailus wrote: >>> Hi Hugues, >>> >>> On Thu, Dec 07, 2017 at 01:40:51PM +0100, Hugues Fruchet wrote: Add bindings for OV5640 DVP parallel interface

[PATCH v4 02/16] media: doc: add document for rkisp1 meta buffer format

From: Jacob Chen This commit add docuemnt for rkisp1 meta buffer format Signed-off-by: Jacob Chen --- Documentation/media/uapi/v4l/meta-formats.rst | 2 ++ .../media/uapi/v4l/pixfmt-meta-rkisp1-params.rst | 17

[PATCH v4 03/16] media: rkisp1: Add user space ABI definitions

From: Jeffy Chen Add the header for userspace Signed-off-by: Jeffy Chen Signed-off-by: Jacob Chen --- include/uapi/linux/rkisp1-config.h | 757 + 1 file changed, 757

[PATCH v4 00/16] Rockchip ISP1 Driver

From: Jacob Chen changes in V4: - fix some bugs during development - move quantization settings to rkisp1 subdev - correct some spelling problems - describe ports in dt-binding documents changes in V3: - add some comments - fix wrong use of

[PATCH v4 01/16] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format

From: Shunqian Zheng Add the Rockchip ISP1 specific processing parameter format V4L2_META_FMT_RK_ISP1_PARAMS and metadata format V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen

[PATCH v4 07/16] media: rkisp1: add ISP1 params driver

From: Jacob Chen Add the output video driver that accept params from userspace. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen

[PATCH v4 15/16] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

From: Shunqian Zheng It's a Designware MIPI D-PHY, used for ISP0 in rk3399. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++ 1 file changed, 10

[PATCH v4 16/16] MAINTAINERS: add entry for Rockchip ISP1 driver

From: Jacob Chen Add MAINTAINERS entry for the rockchip isp1 driver. This driver is maintained by rockchip officially and it will be used for rockchip SoC on all linux-kernel based OS. Signed-off-by: Jacob Chen --- MAINTAINERS | 10

[PATCH v4 12/16] ARM: dts: rockchip: add isp node for rk3288

From: Jacob Chen rk3288 have a Embedded 13M ISP Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v4 14/16] arm64: dts: rockchip: add isp0 node for rk3399

From: Shunqian Zheng rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15

[PATCH v4 13/16] ARM: dts: rockchip: add rx0 mipi-phy for rk3288

From: Jacob Chen It's a Designware MIPI D-PHY, used by ISP in rk3288. Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v4 11/16] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

From: Jacob Chen Add DT bindings documentation for Rockchip MIPI D-PHY RX Signed-off-by: Jacob Chen --- .../bindings/media/rockchip-mipi-dphy.txt | 88 ++ 1 file changed, 88 insertions(+) create mode 100644

[PATCH v4 08/16] media: rkisp1: add capture device driver

From: Jacob Chen This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from ISP1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong

[PATCH v4 10/16] dt-bindings: Document the Rockchip ISP1 bindings

From: Jacob Chen Add DT bindings documentation for Rockchip ISP1 Signed-off-by: Jacob Chen --- .../devicetree/bindings/media/rockchip-isp1.txt| 69 ++ 1 file changed, 69 insertions(+) create mode 100644

[PATCH v4 05/16] media: rkisp1: add Rockchip ISP1 subdev driver

From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen

[PATCH v4 04/16] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa ---

[PATCH v4 09/16] media: rkisp1: add rockchip isp1 core driver

From: Jacob Chen Add the core driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen

[PATCH v4 06/16] media: rkisp1: add ISP1 statistics driver

From: Jacob Chen Add the capture video driver for rockchip isp1 statistics block. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob

[PATCH v4 08/18] scripts: kernel-doc: get rid of unused output formats

Since there isn't any docbook code anymore upstream, we can get rid of several output formats: - docbook/xml, html, html5 and list formats were used by the old build system; - As ReST is text, there's not much sense on outputting on a different text format. After this patch, only man and rst

[PATCH v4 14/18] scripts: kernel-doc: print the declaration name on warnings

The logic at create_parameterlist()'s ancillary push_parameter() function has already a way to output the declaration name, with would help to discover what declaration is missing. However, currently, the logic is utterly broken, as it uses the var $type with a wrong meaning. With the current

[PATCH v4 12/18] scripts: kernel-doc: parse next structs/unions

There are several places within the Kernel tree with nested structs/unions, like this one: struct ingenic_cgu_clk_info { const char *name; enum { CGU_CLK_NONE = 0, CGU_CLK_EXT = BIT(0), CGU_CLK_PLL = BIT(1), CGU_CLK_GATE = BIT(2), CGU_CLK_MUX = BIT(3),

[PATCH v4 07/18] docs: get rid of kernel-doc-nano-HOWTO.txt

Everything there is already described at Documentation/doc-guide/kernel-doc.rst. So, there's no reason why to keep it anymore. Signed-off-by: Mauro Carvalho Chehab --- Documentation/00-INDEX | 2 - Documentation/kernel-doc-nano-HOWTO.txt | 322

[PATCH v4 03/18] docs: kernel-doc.rst: improve function documentation section

Move its contents to happen earlier and improve the description of return values, adding a subsection to it. Most of the contents there came from kernel-doc-nano-HOWTO.txt. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 100

[PATCH v4 00/18] kernel-doc: add supported to document nested structs

Hi Jon, This is a rebased version of my patch series that add support for nested structs on kernel-doc. With this version, it won't produce anymore hundreds of identical warnings, as patch 17 removes the warning duplication. Excluding warnings about duplicated Note: section at hash.h, before

[PATCH v4 15/18] scripts: kernel-doc: handle nested struct function arguments

Function arguments are different than usual ones. So, an special logic is needed in order to handle such arguments on nested structs. Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 38 ++ 1 file changed, 26

Re: [PATCH v2 02/17] media: v4l2-common: get rid of v4l2_routing dead struct

On Mon, Dec 18, 2017 at 12:11:13PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 13 Oct 2017 15:24:34 +0200 > Hans Verkuil escreveu: > > > > --- > > > include/media/v4l2-common.h | 14 +- > > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > > > diff

Re: [PATCH v2 05/17] media: v4l2-device.h: document ancillary macros

Em Fri, 13 Oct 2017 15:33:01 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Thursday, 28 September 2017 00:46:48 EEST Mauro Carvalho Chehab wrote: > > There are several widely macros that aren't documented using kernel-docs

[PATCH v2 1/6] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

This patch updates the sunxi-ir driver to set the base clock frequency from devicetree. This is necessary since there are different ir receivers on the market, that operate with different frequencies. So this value could be set if the attached ir receiver needs a different base clock frequency,

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: > > Currently, there's no way to document #define foo > > with kernel-doc.

Re: [PATCH v2 2/6] media: dt: bindings: Update binding documentation for sunxi IR controller

On Mon, Dec 18, 2017 at 03:11:42PM +0100, Philipp Rossak wrote: > This patch updates documentation for Device-Tree bindings for sunxi IR > controller and adds the new optional property for the base clock > frequency. > > Signed-off-by: Philipp Rossak > --- >

[PATCH v2 5/6] arm: dts: sun8i: a83t: bananapi-m3: Enable IR controller

The Bananapi M3 has an onboard IR receiver. This enables the onboard IR receiver subnode. Unlike the other IR receivers this one needs a base clock frequency of 300 Hz (3 MHz), to be able to work. Signed-off-by: Philipp Rossak Acked-by: Chen-Yu Tsai ---

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Hans, thanks for review comments On Wed, Dec 13, 2017 at 01:03:03PM +0100, Hans Verkuil wrote: > On 15/11/17 11:55, Jacopo Mondi wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > + > > + /* Register the video device */ > > + strncpy(vdev->name, DRIVER_NAME,

[PATCH v2 6/6] arm: dts: sun8i: h3-h8: ir register size should be the whole memory block

The size of the register should be the size of the whole memory block, not just the registers, that are needed. Signed-off-by: Philipp Rossak --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/6] media: dt: bindings: Update binding documentation for sunxi IR controller

This patch updates documentation for Device-Tree bindings for sunxi IR controller and adds the new optional property for the base clock frequency. Signed-off-by: Philipp Rossak --- Documentation/devicetree/bindings/media/sunxi-ir.txt | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v2 0/6] arm: sunxi: IR support for A83T

This patch series adds support for the sunxi A83T ir module and enhances the sunxi-ir driver. Right now the base clock frequency for the ir driver is a hard coded define and is set to 8 MHz. This works for the most common ir receivers. On the Sinovoip Bananapi M3 the ir receiver needs, a 3 MHz

[PATCH v2 3/6] arm: dts: sun8i: a83t: Add the cir pin for the A83T

The CIR Pin of the A83T is located at PL12. Signed-off-by: Philipp Rossak --- arch/arm/boot/dts/sun8i-a83t.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index de5119a2a91c..feffca8a9a24

[PATCH v2 4/6] arm: dts: sun8i: a83t: Add support for the cir interface

The cir interface is like on the H3 located at 0x01f02000 and is exactly the same. This patch adds support for the ir interface on the A83T. Signed-off-by: Philipp Rossak --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v2 3/6] arm: dts: sun8i: a83t: Add the cir pin for the A83T

On Mon, Dec 18, 2017 at 03:11:43PM +0100, Philipp Rossak wrote: > The CIR Pin of the A83T is located at PL12. > > Signed-off-by: Philipp Rossak > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Jacopo, On Monday, 18 December 2017 14:25:12 EET jacopo mondi wrote: > On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > [snip] > > >> + > >> +/** > >> + * ceu_buffer - Link vb2 buffer to the list of available buffers > >

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

Hi Mauro, On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote: > Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: > >> Currently, there's no way to document #define foo > >> with

Re: [PATCH 05/24] media: v4l2-dev: convert VFL_TYPE_* into an enum

Em Tue, 10 Oct 2017 21:47:04 +0100 Andrey Utkin escreveu: > On Mon, Oct 09, 2017 at 07:19:11AM -0300, Mauro Carvalho Chehab wrote: > > Using enums makes easier to document, as it can use kernel-doc > > markups. It also allows cross-referencing, with increases the > >

Re: [PATCH v3 00/17] kernel-doc: add supported to document nested structs/

Em Wed, 4 Oct 2017 08:48:38 -0300 Mauro Carvalho Chehab escreveu: > Right now, it is not possible to document nested struct and nested unions. > kernel-doc simply ignore them. > > Add support to document them. > > Patches 1 to 6 improve kernel-doc documentation to

Re: [PATCH v2 02/17] media: v4l2-common: get rid of v4l2_routing dead struct

Em Fri, 13 Oct 2017 15:24:34 +0200 Hans Verkuil escreveu: > > --- > > include/media/v4l2-common.h | 14 +- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h > > @@ -238,11 +239,6 @@

Re: [PATCH v2 2/2] media: coda: Add i.MX51 (CodaHx4) support

On Mon, Dec 18, 2017 at 8:16 AM, Philipp Zabel wrote: > Add support for the CodaHx4 VPU used on i.MX51. > > Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding > h.264. MPEG-4 encoding is not enabled, it currently produces visual > artifacts. > >

Re: [PATCH v3 07/12] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

Hi all, 2017-12-12 0:45 GMT+08:00 Laurent Pinchart : > Hello Jacob, > > Thank you for the patch. > > On Wednesday, 6 December 2017 13:19:34 EET Jacob Chen wrote: >> From: Jacob Chen >> >> Add DT bindings documentation for Rockchip

[PATCH v1] media: videobuf2: Add new uAPI for DVB streaming I/O

-Ported below mentioned patch to latest kernel: commit ace52288edf0 ("Merge tag 'for-linus-20171218' of git://git.infradead.org/linux-mtd") -Fixed few bugs in the patch, enhanced it and added polling --dvb_vb2.c:dvb_vb2_fill_buffer=> Set the size of the outgoing buffer aft

[PATCH] [VB2-CORE] Fixed bug about unnecessary calls to queue cancel and free

-When the func vb2_core_reqbufs is called first time after vb2_core_queue_init, the condition q->memory != memory always gets satisfied since q->memory = 0 in vb2_core_queue_init. -After the condition is true, unnecessary calls to __vb2_queue_cancel and __vb2_queue_free are done -In such

Re: [trivial PATCH] treewide: Align function definition open/close braces

Joe, > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. SCSI bits look OK. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [trivial PATCH] treewide: Align function definition open/close braces

On Mon, Dec 18, 2017 at 2:28 AM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work >

[PATCH v4 16/18] scripts: kernel-doc: improve nested logic to handle multiple identifiers

It is possible to use nested structs like: struct { struct { void *arg1; } st1, st2, *st3, st4; }; Handling it requires to split each parameter. Change the logic to allow such definitions. In order to test the new nested logic, the following file was used to test

[PATCH v4 11/18] scripts: kernel-doc: replace tabs by spaces

Sphinx has a hard time dealing with tabs, causing it to misinterpret paragraph continuation. As we're now mainly focused on supporting ReST output, replace tabs by spaces, in order to avoid troubles when the output is parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab

[PATCH v4 09/18] scripts: kernel-doc: improve argument handling

Right now, if one uses "--rst" instead of "-rst", it just ignore the argument and produces a man page. Change the logic to accept both "-cmd" and "--cmd". Also, if "cmd" doesn't exist, print the usage information and exit. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v4 18/18] w1_netlink.h: add support for nested structs

Now that kernel-doc can hanle nested structs/unions, describe such fields at w1_netlink_message_types. Acked-by: Evgeniy Polyakov Signed-off-by: Mauro Carvalho Chehab --- drivers/w1/w1_netlink.h | 6 +- 1 file changed, 5 insertions(+), 1

[PATCH v4 13/18] scripts: kernel-doc: get rid of $nested parameter

The check_sections() function has a $nested parameter, meant to identify when a nested struct is present. As we now have a logic that handles it, get rid of such parameter. Suggested-by: Markus Heiser Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v4 04/18] docs: kernel-doc.rst: improve structs chapter

There is a mess on this chapter: it suggests that even enums and unions should be documented with "struct". That's not the way it should be ;-) Fix it and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 48

[PATCH v4 10/18] scripts: kernel-doc: change default to ReST format

Right now, if kernel-doc is called without arguments, it defaults to man pages. IMO, it makes more sense to default to ReST, as this is the output that it is most used nowadays, and it easier to check if everything got parsed fine on an enriched text mode format. Signed-off-by: Mauro Carvalho

[PATCH v4 01/18] docs: kernel-doc.rst: better describe kernel-doc arguments

Add a new section to describe kernel-doc arguments, adding examples about how identation should happen, as failing to do that causes Sphinx to do the wrong thing. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 44

[PATCH v4 02/18] docs: kernel-doc.rst: improve private members description

The private members section can now be moved to be together with the arguments section. Move it there and add an example about the usage of public: Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 56 ++

[PATCH v4 17/18] scripts: kernel-doc: apply filtering rules to warnings

When kernel-doc is called with output selection filters, it will be called lots of time for a single file. If there is a warning present there, it means that it may print hundreds of identical warnings. Worse than that, the -function NAME actually filters only functions. So, it makes no sense at

[PATCH v4 05/18] docs: kernel-doc.rst: improve typedef documentation

Add documentation about typedefs for function prototypes and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git

[PATCH v4 06/18] docs: kernel-doc.rst: add documentation about man pages

kernel-doc-nano-HOWTO.txt has a chapter about man pages production. While we don't have a working "make manpages" target, add it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 34 ++ 1 file changed,

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Laurent, thanks for review comments... On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > [snip] > > + > > +/** > > + * ceu_buffer - Link vb2 buffer to the list of available buffers > > If you use kerneldoc comments please make

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

Hey Andi, thanks for the feedback. I will fix that in the next version of this patch series! On 18.12.2017 03:44, Andi Shyti wrote: Hi Philipp, just a couple of small nitpicks. + u32 b_clk_freq; [...] + /* Base clock frequency (optional) */ + if

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

On Mon, 18 Dec 2017 01:28:44 +0100, Joe Perches wrote: > > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these

Re: [PATCH] staging: android: ion: Fix dma direction for dma_sync_sg_for_cpu/device

On 12/15/2017 12:59 PM, Sushmita Susheelendra wrote: Use the direction argument passed into begin_cpu_access and end_cpu_access when calling the dma_sync_sg_for_cpu/device. The actual cache primitive called depends on the direction passed in. Acked-by: Laura Abbott

[PATCH 8/8] media: v4l2-subdev: use kernel-doc markups to document subdev flags

Right now, those are documented together with the subdev struct, instead of together with the definitions. Convert the definitions to an enum, use BIT() macros and document it at its right place. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-subdev.h |

[PATCH 5/8] media: v4l2-mediabus: convert flags to enums and document them

There is a mess with media bus flags: there are two sets of flags, one used by parallel and ITU-R BT.656 outputs, and another one for CSI2. Depending on the type, the same bit has different meanings. That's very confusing, and counter-intuitive. So, split them into two sets of flags, inside an

[PATCH 7/8] media: v4l2-subdev: document remaining undocumented functions

There are several undocumented v4l2-subdev functions that are part of kAPI. Document them. Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-subdev.h | 69 + 1

[PATCH 1/8] media: v4l2-device.h: document helper macros

There are several macros that aren't documented using kernel-docs markups. Document them. While here, add cross-references to structs on this file. Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME match criteria requires just a device name. So, it doesn't make sense to enclose those into structs, as the criteria can go directly into the union. That makes

[PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask, but without using Kernel's modern standards. Also, documentation looks akward. So, convert them into an enum with valid bits, adding the correspoinding kernel-doc documentation for it. In order to avoid possible conflicts, rename them

[PATCH 4/8] media: v4l2-async: better describe match union at async match struct

Now that kernel-doc handles nested unions, better document the match union at struct v4l2_async_subdev. Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-async.h | 25 + 1 file

[PATCH 6/8] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define 3 functions that have the same arguments. The code of those functions is simple enough to just declare them, de-obfuscating the code. While here, replace BUG_ON() by WARN_ON() as there's no reason why to panic the Kernel if this fails.

Re: [PATCH] media: dvb_usb_pctv452e: module refcount changes were unbalanced

On Tue, Nov 28, 2017 at 12:33 PM, Wolfgang Rohdewald wrote: > @@ -913,6 +913,14 @@ static int pctv452e_frontend_attach(struct > dvb_usb_adapter *a) > >dev->i2c_adap); > if (!a->fe_adap[0].fe) > return

[PATCH] media: fix SPDX comment on some header files

The agreed format is to use /* */ comments inside header files. Unfortunately, I ended by using // on a few ones. Reported-by: Andi Shyti Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/rc-core-priv.h| 10 ++

Re: [PATCH 15/24] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

Em Mon, 9 Oct 2017 23:23:56 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote: > > The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define > > 3 functions that have the same arguments. The code of those > >

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

For am437x/am437x-vpfe.c & ti-vpe/cal.c Acked-by: Benoit Parrot Mauro Carvalho Chehab wrote on Mon [2017-Dec-18 17:53:57 -0200]: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The

Re: [trivial PATCH] treewide: Align function definition open/close braces

On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for

Re: [PATCH/RFC v2 14/15] adv748x: csi2: add get_routing support

Hi Kieran, Thanks for your comments, On 2017-12-14 23:27:57 +, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: > > To support multiplexed streams the internal routing between the > > adv748x sink pad and its source pad needs to be described. > > The

Re: [trivial PATCH] treewide: Align function definition open/close braces

On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work >

Re: [PATCH/RFC v2 13/15] adv748x: csi2: only allow formats on sink pads

HI Kieran, Thanks for your comments. On 2017-12-14 23:16:08 +, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: > > The driver is now pad and stream aware, only allow to get/set format on > > sink pads. > > Ok - I can see the patch is doing this ... > > >

Re: [PATCH/RFC v2 09/15] adv748x: csi2: add module param for virtual channel

Hi Kieran, Thanks for your comments. On 2017-12-14 22:19:59 +, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: > > The hardware can output on any of the 4 (0-3) Virtual Channels of the > > CSI-2 bus. Add a module parameter each for TXA and TXB to allow the

Re: [RFC PATCH 9/9] media: vim2m: add request support

Hi Alex, 2017-12-15 Alexandre Courbot : > Set the necessary ops for supporting requests in vim2m. > > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/vim2m.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff

Re: [trivial PATCH] treewide: Align function definition open/close braces

On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work >

Re: [trivial PATCH] treewide: Align function definition open/close braces

On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for

Re: [trivial PATCH] treewide: Align function definition open/close braces

On 17/12/2017 at 16:28:44 -0800, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

On 18/12/2017 at 17:53:57 -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those into

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

Em Mon, 18 Dec 2017 17:32:11 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote: > > Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > > > On Thursday, 28 September 2017

  1   2   >