[PATCH] v4l2-subdev: clear reserved fields

Clear the reserved fields for these ioctls according to the specification: VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL VIDIOC_SUBDEV_ENUM_FRAME_SIZE VIDIOC_SUBDEV_ENUM_MBUS_CODE VIDIOC_SUBDEV_G_CROP, VIDIOC_SUBDEV_S_CROP VIDIOC_SUBDEV_G_FMT, VIDIOC_SUBDEV_S_FMT VIDIOC_SUBDEV_G_FRAME_INTERVAL,

[Patch v8 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements

Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size for MFCv10.10. Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda Acked-by: Kamil Debski Acked-by: Hans Verkuil ---

[Patch v8 03/12] [media] s5p-mfc: Use min scratch buffer size as provided by F/W

After MFC v8.0, mfc f/w lets the driver know how much scratch buffer size is required for decoder. If mfc f/w has the functionality, E_MIN_SCRATCH_BUFFER_SIZE, driver can know how much scratch buffer size is required for encoder too. Signed-off-by: Smitha T Murthy

[Patch v8 08/12] [media] s5p-mfc: Add support for HEVC decoder

Add support for codec definition and corresponding buffer requirements for HEVC decoder. Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda Acked-by: Hans Verkuil --- drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 1

[Patch v8 06/12] [media] v4l2-ioctl: add HEVC format description

HEVC is a video coding format Signed-off-by: Smitha T Murthy Reviewed-by: Stanimir Varbanov Acked-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] v4l2-subdev: without controls return -ENOTTY

If the subdev did not define any controls, then return -ENOTTY if userspace attempts to call these ioctls. The control framework functions will return -EINVAL, not -ENOTTY if vfh->ctrl_handler is NULL. Several of these framework functions are also called directly from drivers, so I don't want to

Re: [Patch v8 12/12] Documention: v4l: Documentation for HEVC CIDs

On 02/02/18 13:25, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy Looks good. Acked-by: Hans Verkuil Regards, Hans

v4l2-ctrls.h: remove wrong copy-and-paste comment

The __v4l2_ctrl_modify_range is the unlocked variant, so the comment about taking a lock is obviously wrong. Signed-off-by: Hans Verkuil --- diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 5253b5471897..33ce194a7481 100644 ---

Re: [RFCv2 00/17] Request API, take three

Hi Alexandre, On Wed, Jan 31, 2018 at 07:24:18PM +0900, Alexandre Courbot wrote: > This is a quickly-put together revision that includes and uses Hans' work to > use v4l2_ctrl_handler as the request state holder for V4L2 devices. Although > minor fixes have also been applied, there are still a

[PATCH] vimc: fix control event handling

The sensor subdev didn't handle control events. Add support for this. Found with v4l2-compliance. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c index 9d63c84a9876..617415c224fe 100644

[Patch v8 07/12] Documentation: v4l: Documentation for HEVC v4l2 definition

Add V4L2 definition for HEVC compressed format which is also known as H.265. Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda Reviewed-by: Stanimir Varbanov Acked-by: Hans Verkuil ---

[Patch v8 05/12] [media] videodev2.h: Add v4l2 definition for HEVC

Add V4L2 definition for HEVC compressed format Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda Reviewed-by: Stanimir Varbanov Acked-by: Hans Verkuil --- include/uapi/linux/videodev2.h |

Re: [Patch v8 11/12] [media] s5p-mfc: Add support for HEVC encoder

On 02/02/18 13:25, Smitha T Murthy wrote: > Add HEVC encoder support and necessary registers, V4L2 CIDs, > and hevc encoder parameters > > Signed-off-by: Smitha T Murthy > Acked-by: Hans Verkuil Not quite, one last comment: > --- >

Re: Adjustments for a lot of function implementations

> One last time: either post per-driver patches with all the cleanups for a > driver > in a single patch, I preferred to offer source code adjustments according to specific transformation patterns mostly for each software module separately (also in small patch series). > or a per-directory

[Patch v8 09/12] [media] s5p-mfc: Add VP9 decoder support

Add support for codec definition and corresponding buffer requirements for VP9 decoder. Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda Acked-by: Hans Verkuil --- drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 6

[Patch v8 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

Add v4l2 controls for HEVC encoder Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda Acked-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 119 +++

[PATCH] staging: media: atomisp: remove pointless string copy

gcc-8 points out that a string is copied to itself here: In file included from drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/platform_support.h:25, from

[Patch v8 00/12] Add MFC v10.10 support

This patch series adds MFC v10.10 support. MFC v10.10 is used in some of Exynos7 variants. This adds support for following: * Add support for HEVC encoder and decoder * Add support for VP9 decoder * Update Documentation for control id definitions * Update computation of min scratch buffer size

[Patch v8 01/12] [media] s5p-mfc: Rename IS_MFCV8 macro

This patch renames macro IS_MFCV8 to IS_MFCV8_PLUS so that the MFCv8 code can be resued for MFCv10.10 support. Since the MFCv8 specific code holds good for MFC v10.10 also. Signed-off-by: Smitha T Murthy Acked-by: Andrzej Hajda Acked-by: Hans Verkuil

[Patch v8 12/12] Documention: v4l: Documentation for HEVC CIDs

Added V4l2 controls for HEVC encoder Signed-off-by: Smitha T Murthy --- Documentation/media/uapi/v4l/extended-controls.rst | 410 + 1 file changed, 410 insertions(+) diff --git a/Documentation/media/uapi/v4l/extended-controls.rst

[Patch v8 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10

Adding the support for MFC v10.10, with new register file and necessary hw control, decoder, encoder and structural changes. CC: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda

[Patch v8 11/12] [media] s5p-mfc: Add support for HEVC encoder

Add HEVC encoder support and necessary registers, V4L2 CIDs, and hevc encoder parameters Signed-off-by: Smitha T Murthy Acked-by: Hans Verkuil --- drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 28 +- drivers/media/platform/s5p-mfc/s5p_mfc.c

Re: [PATCH 1/1] vb2: core: Finish buffers at the end of the stream

Hello Sakari, Thanks for proposing this patch. I'll give it a try this weekend. Regards, Devin On Fri, Feb 2, 2018 at 5:08 AM, Sakari Ailus wrote: > If buffers were prepared or queued and the buffers were released without > starting the queue, the finish mem op

Re: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

Hi Fabrizio, On Thu, Feb 01, 2018 at 05:53:18PM +, Fabrizio Castro wrote: > > Subject: [PATCH v5 4/5] media: ov5640: add support of DVP parallel interface > > > > Add support of DVP parallel mode in addition of > > existing MIPI CSI mode. The choice between two modes > > and configuration is

Re: [PATCH] media: cx25821: prevent out-of-bounds read on array card

Hi Colin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.15 next-20180202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Feb 3 05:00:16 CET 2018 media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 media_build

Re: v4l2-ctrls.h: remove wrong copy-and-paste comment

Hi Hans, On Fri, Feb 02, 2018 at 03:11:48PM +0100, Hans Verkuil wrote: > The __v4l2_ctrl_modify_range is the unlocked variant, so the comment about > taking a lock is obviously wrong. The comment is wrong but I don't think it's a good idea either to leave the matter undocumented. > >

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

Hi Jasmin, Thank you for the patch. On Sunday, 14 January 2018 12:21:43 EET Jasmin J. wrote: > From: Jasmin Jessich > > Commit 828ee8c71950 ("media: uvcvideo: Use ktime_t for timestamps") > changed to use ktime_t for timestamps. Older Kernels use a struct for > ktime_t, which

Re: [RFC PATCH 1/9] media: add request API core and UAPI

On 02/02/2018 08:33 AM, Sakari Ailus wrote: +struct media_request_entity_data * +media_request_get_entity_data(struct media_request *req, + struct media_entity *entity, void *fh) >>> >>> This makes the assumption that request data is bound to entities.

[PATCH 1/1] vb2: core: Finish buffers at the end of the stream

If buffers were prepared or queued and the buffers were released without starting the queue, the finish mem op (corresponding to the prepare mem op) was never called to the buffers. Before commit a136f59c0a1f there was no need to do this as in such a case the prepare mem op had not been called

Re: [PATCH 4/8] i2c: ov9650: fix potential integer overflow in __ov965x_set_frame_interval

On Mon, Jan 29, 2018 at 06:32:01PM -0600, Gustavo A. R. Silva wrote: > Cast fi->interval.numerator to u64 in order to avoid a potential integer > overflow. This variable is being used in a context that expects an > expression of type u64. > > Addresses-Coverity-ID: 1324146 ("Unintentional integer

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Do any contributors get into the mood to take another look at software updates from my selection of change possibilities in a more constructive way?

Re: Adjustments for a lot of function implementations

On 02/02/18 10:55, SF Markus Elfring wrote: >> ??? I did that: either one patch per directory with the same type of change, >> or one patch per driver combining all the changes for that driver. > > Do any contributors get into the mood to take another look at software updates > from my selection