Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

On 03/19/2018 11:47 AM, Mauro Carvalho Chehab wrote: > Em Mon, 19 Mar 2018 11:23:54 +0100 > Pavel Machek escreveu: > >> Hi! >> >>> I really don't want to add functions for this to libv4l2. That's just a >>> quick hack. The real solution is to parse this from a config >>> file. But

[PATCH 3/3] arm64: dts: meson-gxl-s905x-libretech-cc: add cec-disable

From: Hans Verkuil This board has two CEC controllers: the DesignWare controller and a meson-specific controller. Disable the DW controller since the CEC line is hooked up to the meson controller. Signed-off-by: Hans Verkuil ---

[PATCH 2/3] drm: bridge: dw-hdmi: check the cec-disable property

From: Hans Verkuil If the cec-disable property was set, then disable the DW CEC controller. This is needed for boards that have their own CEC controller. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- 1 file

Re: [PATCH] venus: vdec: fix format enumeration

On Thu, Mar 15, 2018 at 6:52 PM, Stanimir Varbanov wrote: > Hi Alex, > > Thanks for the patch! > > On 13.03.2018 11:11, Alexandre Courbot wrote: >> find_format_by_index() stops enumerating formats as soon as the index >> matches, and returns NULL if

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

On 03/19/2018 01:48 PM, Pavel Machek wrote: > Hi! > I really want to work with you on this, but I am not looking for partial solutions. >>> >>> Well, expecting design to be done for opensource development is a bit >>> unusual :-). >> >> Why? We have done that quite often in the past.

Re: [PATCH 1/3] dt-bindings: display: dw_hdmi.txt

Hi Hans, On Mon, Mar 19, 2018 at 8:43 AM, Hans Verkuil wrote: > From: Hans Verkuil It seems the Subject line is missing some content?

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

On 03/19/2018 01:00 PM, Pavel Machek wrote: > Hi! > >>> Pavel, >>> >>> I appreciate your efforts of adding support for mc-based devices to >>> libv4l. > > Thanks. > >>> I guess the main poin that Hans is pointing is that we should take >>> extra care in order to avoid adding new symbols to

[PATCH 1/5] v4l2-mediabus.h: add hsv_enc

From: Hans Verkuil Just like struct v4l2_pix_format add a hsv_enc field to describe the HSV encoding. It is in a union with the ycbcr_enc, since it is one or the other. Signed-off-by: Hans Verkuil --- include/uapi/linux/v4l2-mediabus.h | 8

[PATCH 2/5] subdev-formats.rst: fix incorrect types

From: Hans Verkuil The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/subdev-formats.rst | 27 +++-- 1 file changed, 21 insertions(+), 6

[PATCH 3/5] pixfmt-v4l2-mplane.rst: fix types

From: Hans Verkuil The v4l2_pix_format_mplane documentation still had 'enum's as types. Replace by __u8 and add a reference to the enum. Also put ycbcr_enc and hsv_enc in a union. Signed-off-by: Hans Verkuil ---

[PATCH 4/5] pixfmt-v4l2.rst: fix types

From: Hans Verkuil The v4l2_pix_format documentation still had 'enum's as types. Replace by __u32 and add a reference to the enum. Also put ycbcr_enc and hsv_enc in a union. Signed-off-by: Hans Verkuil ---

[PATCH 5/5] media.h: remove __NEED_MEDIA_LEGACY_API

From: Hans Verkuil The __NEED_MEDIA_LEGACY_API define is 1) ugly and 2) dangerous since it is all too easy for drivers to define it to get hold of legacy defines. Instead just define what we need in media-device.c which is the only place where we need the legacy define

[PATCH 0/5] media: fix inconsistencies

From: Hans Verkuil This patch series fixes various inconsistencies between types and documentation and removes the __NEED_MEDIA_LEGACY_API define. 1) v4l2_pix_format(_mplane) both have a hsv_enc field, but not v4l2_mbus_framefmt. It needs to be added to

Re: [PATCH v5 0/2] media: video-i2c: add video-i2c driver support

On 03/16/2018 03:47 AM, Matt Ranostay wrote: > On Fri, Mar 9, 2018 at 10:26 AM, Matt Ranostay > wrote: >> On Fri, Mar 9, 2018 at 4:45 AM, Hans Verkuil wrote: >>> Hi Matt, >>> >>> This is looking good. One request before I merge: please run the >>>

[PATCH v2] venus: vdec: fix format enumeration

find_format_by_index() stops enumerating formats as soon as the index matches, and returns NULL if venus_helper_check_codec() finds out that the format is not supported. This prevents formats to be properly enumerated if a non-supported format is present, as the enumeration will end with it. Fix

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Hi! > > Pavel, > > > > I appreciate your efforts of adding support for mc-based devices to > > libv4l. Thanks. > > I guess the main poin that Hans is pointing is that we should take > > extra care in order to avoid adding new symbols to libv4l ABI/API > > without being sure that they'll be

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Hi! > >> I really want to work with you on this, but I am not looking for partial > >> solutions. > > > > Well, expecting design to be done for opensource development is a bit > > unusual :-). > > Why? We have done that quite often in the past. Media is complex and you need > to decide on a

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Mon, 19 Mar 2018 13:15:22 +0100 Hans Verkuil escreveu: > On 03/19/2018 01:00 PM, Pavel Machek wrote: > > Hi! > > > >>> Pavel, > >>> > >>> I appreciate your efforts of adding support for mc-based devices to > >>> libv4l. > > > > Thanks. > > > >>> I guess the main

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Mon, 19 Mar 2018 13:48:55 +0100 Pavel Machek escreveu: > Hi! > > > >> I really want to work with you on this, but I am not looking for partial > > >> solutions. > > > > > > Well, expecting design to be done for opensource development is a bit > > > unusual :-). > > > >

[PATCH] staging: media: davinci_vpfe: fix spelling of resizer_configure_in_continious_mode

From: Colin Ian King Trivial fix: rename function resizer_configure_in_continious_mode to resizer_configure_in_continuous_mode to fix spelling mistake. Signed-off-by: Colin Ian King --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4

Re: [PATCH 1/3] dt-bindings: display: dw_hdmi.txt

On 03/19/2018 12:46 PM, Fabio Estevam wrote: > Hi Hans, > > On Mon, Mar 19, 2018 at 8:43 AM, Hans Verkuil wrote: >> From: Hans Verkuil > > It seems the Subject line is missing some content? Oops. That should have been: dt-bindings: display:

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Hi! > I really don't want to add functions for this to libv4l2. That's just a > quick hack. The real solution is to parse this from a config > file. But No, this is not a quick hack. These are functions that will eventually be used by the config parser. (Oh and they allow me to use camera on

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Mon, 19 Mar 2018 11:23:54 +0100 Pavel Machek escreveu: > Hi! > > > I really don't want to add functions for this to libv4l2. That's just a > > quick hack. The real solution is to parse this from a config > > file. But > > No, this is not a quick hack. These are functions

[PATCH 1/3] dt-bindings: display: dw_hdmi.txt

From: Hans Verkuil Some boards have both a DesignWare and their own CEC controller. The CEC pin is only hooked up to their own CEC controller and not to the DW controller. Add the cec-disable property to disable the DW CEC controller. This particular situation happens

[PATCH 0/3] dw-hdmi: add property to disable CEC

From: Hans Verkuil Some boards (amlogic) have two CEC controllers: the DesignWare controller and their own CEC controller (meson ao-cec). Since the CEC line is not hooked up to the DW controller we need a way to disable that controller. This patch series adds the

[PATCH 4/8] media: add 'index' to struct media_v2_pad

From: Hans Verkuil The v2 pad structure never exposed the pad index, which made it impossible to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information. It is really trivial to just expose this information, so implement this. Signed-off-by: Hans Verkuil

[PATCH 8/8] media-types.rst: rename media-entity-type to media-entity-functions

From: Hans Verkuil The MEDIA_ENT_F_* defines refer to functions, not types. Update the documentation accordingly. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/mediactl/media-ioc-enum-entities.rst | 4 ++--

[PATCH 5/8] media-ioc-g-topology.rst: document new 'index' field

From: Hans Verkuil Document the new struct media_v2_pad 'index' field. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 0/8] media: fix more inconsistencies

On 03/19/2018 04:43 PM, Hans Verkuil wrote: > From: Hans Verkuil > > This is a follow-up of my earlier "media: fix inconsistencies" > patch series > (https://www.mail-archive.com/linux-media@vger.kernel.org/msg127943.html). > > The purpose of this series is to expose

Re: [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

On Fri, Mar 16, 2018 at 02:20:45PM +0100, Christian König wrote: > Each importer can now provide an invalidate_mappings callback. > > This allows the exporter to provide the mappings without the need to pin > the backing store. > > v2: don't try to invalidate mappings when the callback is NULL,

Re: [PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls

On 03/19/2018 03:29 PM, Sylwester Nawrocki wrote: > Valid range for those controls is specified in documentation as [0, 51], > so initialize the controls to such range rather than [INT_MIN, INT_MAX]. > > Signed-off-by: Sylwester Nawrocki Acked-by: Hans Verkuil

[PATCH 7/8] media-ioc-g-topology.rst: document new 'flags' field

From: Hans Verkuil Document the new struct media_v2_entity 'flags' field. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH 3/8] media-ioc-enum-entities.rst: document new 'function' field

From: Hans Verkuil Document the new struct media_entity_desc 'function' field. Signed-off-by: Hans Verkuil --- .../uapi/mediactl/media-ioc-enum-entities.rst | 31 +- 1 file changed, 25 insertions(+), 6 deletions(-) diff

[PATCH 2/8] media: add function field to struct media_entity_desc

From: Hans Verkuil This adds support for 'proper' functions to the existing API. This information was before only available through the new v2 API, with this change it's available to both. Yes, the plan is to allow entities to expose multiple functions for multi-function

[PATCH 6/8] media: add flags field to struct media_v2_entity

From: Hans Verkuil The v2 entity structure never exposed the entity flags, which made it impossible to detect connector or default entities. It is really trivial to just expose this information, so implement this. Signed-off-by: Hans Verkuil ---

[PATCH 1/8] media-ioc-g-topology.rst: fix 'reserved' sizes

From: Hans Verkuil The size of the reserved arrays in the documentation is wrong. Sync this with the actual header. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 6 +++--- 1 file changed, 3

[PATCH 0/8] media: fix more inconsistencies

From: Hans Verkuil This is a follow-up of my earlier "media: fix inconsistencies" patch series (https://www.mail-archive.com/linux-media@vger.kernel.org/msg127943.html). The purpose of this series is to expose the same information through the old and new MC APIs. There

Re: [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

Quoting Christian König (2018-03-16 14:22:32) [snip, probably lost too must context] > This allows for full grown pipelining, e.g. the exporter can say I need > to move the buffer for some operation. Then let the move operation wait > for all existing fences in the reservation object and install

[PATCH] s5p-mfc: Ensure HEVC QP controls range is properly updated

When value of V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP or V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP controls is changed we should update range of a set of HEVC quantization parameter v4l2 controls as specified in the HEVC controls documentation. Signed-off-by: Sylwester Nawrocki ---

[PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls

Valid range for those controls is specified in documentation as [0, 51], so initialize the controls to such range rather than [INT_MIN, INT_MAX]. Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 28 ++-- 1 file

Re: RFC: unpinned DMA-buf exporting v2

On Fri, Mar 16, 2018 at 02:20:44PM +0100, Christian König wrote: > Hi everybody, > > since I've got positive feedback from Daniel I continued working on this > approach. > > A few issues are still open: > 1. Daniel suggested that I make the invalidate_mappings callback a parameter > of

Re: [PATCH] s5p-mfc: Ensure HEVC QP controls range is properly updated

On 03/19/2018 03:29 PM, Sylwester Nawrocki wrote: > When value of V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP or > V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP > controls is changed we should update range of a set of HEVC quantization > parameter v4l2 controls as specified in the HEVC controls documentation. > >

Re: [PATCH 2/3] drm: bridge: dw-hdmi: check the cec-disable property

On 19/03/2018 12:43, Hans Verkuil wrote: > From: Hans Verkuil > > If the cec-disable property was set, then disable the DW CEC > controller. This is needed for boards that have their own > CEC controller. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCH 0/3] dw-hdmi: add property to disable CEC

Hi Hans, On 19/03/2018 12:43, Hans Verkuil wrote: > From: Hans Verkuil > > Some boards (amlogic) have two CEC controllers: the DesignWare controller > and their own CEC controller (meson ao-cec). > > Since the CEC line is not hooked up to the DW controller we need a way

Re: [PATCH 3/3] arm64: dts: meson-gxl-s905x-libretech-cc: add cec-disable

On 19/03/2018 12:43, Hans Verkuil wrote: > From: Hans Verkuil > > This board has two CEC controllers: the DesignWare controller and > a meson-specific controller. Disable the DW controller since the > CEC line is hooked up to the meson controller. > > Signed-off-by: Hans

Re: [PATCH 1/3] dt-bindings: display: dw_hdmi.txt

On 19/03/2018 12:43, Hans Verkuil wrote: > From: Hans Verkuil > > Some boards have both a DesignWare and their own CEC controller. > The CEC pin is only hooked up to their own CEC controller and not > to the DW controller. > > Add the cec-disable property to disable the

[PATCH] media: ov5645: add missing of_node_put() in error path

The device node obtained with of_graph_get_next_endpoint() should be released by calling of_node_put(). But it was not released when v4l2_fwnode_endpoint_parse() failed. This change moves the of_node_put() call before the error check and fixes the issue. Cc: Todor Tomov

Re: [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

Am 19.03.2018 um 16:53 schrieb Chris Wilson: Quoting Christian König (2018-03-16 14:22:32) [snip, probably lost too must context] This allows for full grown pipelining, e.g. the exporter can say I need to move the buffer for some operation. Then let the move operation wait for all existing

[PATCH v5] media/dvb: earth-pt3: use the new i2c binding helper

From: Akihiro Tsukada This patch slightly simplifies the binding code by introducing commit 8f569c0b4e6b ("media: dvb-core: add helper functions for I2C binding"). Signed-off-by: Akihiro Tsukada --- Changes since v4 - pci/pt3/pt3.c: removed redundant

Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition

Hi Wolfgang, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1b5f3ba415fe4cf8b8b39c8d104ed44cde330658 commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e media: dvb_usb_pctv452e: module refcount changes were

[GIT PULL] af9013/af9015 improvements

The following changes since commit 3f127ce11353fd1071cae9b65bc13add6aec6b90: media: em28xx-cards: fix em28xx_duplicate_dev() (2018-03-08 06:06:51 -0500) are available in the Git repository at: git://linuxtv.org/anttip/media_tree.git af9015_pull for you to fetch changes up to

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Hi! > >>> V4L2MEDIADESC > >>> 3 # number of files to open > >>> /dev/video2 > >>> /dev/video6 > >>> /dev/video3 > >> > >> This won't work. The video nodes numbers (or even names) can change. > >> Instead these should be entity names from the media controller. > > > > Yes, it will work. 1) will

RE: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

Hi Hans, Thanks for taking the time to take a look at this. > This should definitely use the V4L2 API. I guess it could be added > to staging/media with a big fat TODO that this should be converted to > the V4L2 mem2mem framework. > > But it makes no sense to re-invent the V4L2 streaming API

RE: [PATCH] media: cxd2880-spi: avoid out-of-bounds access warning

Hi. We check the patch. > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, March 13, 2018 9:09 PM > To: Takiguchi, Yasunari (SSS); Mauro Carvalho Chehab > Cc: Arnd Bergmann; Martin Sebor; Matsumoto, Toshihiko (SSS); Yonezawa, > Kota (SSS); Watanabe,

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 20 05:00:13 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit : > Hi Hans, > > Thanks for taking the time to take a look at this. > > > This should definitely use the V4L2 API. I guess it could be added > > to staging/media with a big fat TODO that this should be converted > > to > > the V4L2

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote: > On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > > According to the Devicetree Specification, "ok" is not a valid status. > > Correct. > > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") >

Re: Re: [PATCH] staging: media: davinci_vpfe: add error handling on kmalloc failure

On Mon, Mar 19, 2018 at 01:24:57PM +0900, Ji-Hun Kim wrote: > > 1294 } else if (to && !from && size) { > > 1295 rval = module_if->set(ipipe, NULL); > > 1296 if (rval) > > 1297

Re: [RFCv4,19/21] media: vim2m: add request support

On Wed, Mar 14, 2018 at 10:25 PM, Paul Kocialkowski wrote: > Hi, > > On Tue, 2018-03-13 at 19:24 +0900, Alexandre Courbot wrote: >> On Fri, Mar 9, 2018 at 11:35 PM, Paul Kocialkowski >> wrote: >> > Hi, >> > >> > On Thu, 2018-03-08 at