Re: [PATCH v2 2/3] s5p-g2d: Remove unrequired wait in .job_abort

2018-07-06 Thread Sylwester Nawrocki
Hi, On 07/04/2018 10:04 AM, Hans Verkuil wrote: > On 18/06/18 06:38, Ezequiel Garcia wrote: >> As per the documentation, job_abort is not required >> to wait until the current job finishes. It is redundant >> to do so, as the core will perform the wait operation. Could you elaborate how the core

[PATCH] media: i2c: ov5640: Re-work MIPI startup sequence

2018-07-06 Thread Jacopo Mondi
From: Jacopo Mondi Rework the MIPI interface startup sequence with the following changes: - Remove MIPI bus initialization from the initial settings blob - At set_power(1) time power up MIPI Tx/Rx and set data and clock lanes in LP11 during 'sleep' and 'idle' with MIPI clock in non-continuous

[PATCHv16.1 25/34] videobuf2-v4l2: add vb2_request_queue/validate helpers

2018-07-06 Thread Hans Verkuil
>From 6193f32ad1e746bfe70725e97b9bbb8b1269fec0 Mon Sep 17 00:00:00 2001 From: Hans Verkuil Date: Mon, 21 May 2018 11:54:52 +0300 Subject: [PATCH 25/34] videobuf2-v4l2: add vb2_request_queue/validate helpers The generic vb2_request_validate helper function checks if there are buffers in the

[PATCHv16.1 29/34] v4l2-mem2mem: add vb2_m2m_request_queue

2018-07-06 Thread Hans Verkuil
For mem2mem devices we have to make sure that v4l2_m2m_try_schedule() is called whenever a request is queued. We do that by creating a vb2_m2m_request_queue() helper that should be used instead of the 'normal' vb2_request_queue() helper. The m2m helper function will call v4l2_m2m_try_schedule()

Re: [PATCH v2 2/3] s5p-g2d: Remove unrequired wait in .job_abort

2018-07-06 Thread Ezequiel Garcia
On Fri, 2018-07-06 at 13:09 +0200, Sylwester Nawrocki wrote: > Hi, > > On 07/04/2018 10:04 AM, Hans Verkuil wrote: > > On 18/06/18 06:38, Ezequiel Garcia wrote: > > > As per the documentation, job_abort is not required > > > to wait until the current job finishes. It is redundant > > > to do so,

Re: [PATCH v2 1/3] rcar_jpu: Remove unrequired wait in .job_abort

2018-07-06 Thread Mikhail Ulyanov
Acked-by: Mikhail Ulyanov On Mon, Jun 18, 2018 at 7:38 AM, Ezequiel Garcia wrote: > As per the documentation, job_abort is not required > to wait until the current job finishes. It is redundant > to do so, as the core will perform the wait operation. > > Remove the wait infrastructure

[GIT PULL FOR v4.19] Venus updates

2018-07-06 Thread Hans Verkuil
Venus driver updates: * add initial support for Venus version 4xx (found on sdm845). * introduce a common capability parser to enumerate better supported uncompressed formats, capabilities by codec, supported codecs and so on. * also contains various cleanups, readability improvements and

Re: [PATCH v4 03/17] omap4iss: Add vb2_queue lock

2018-07-06 Thread Ezequiel Garcia
On Mon, 2018-07-02 at 10:28 +0200, Hans Verkuil wrote: > On 15/06/18 21:07, Ezequiel Garcia wrote: > > vb2_queue lock is now mandatory. Add it, remove driver ad-hoc > > locks, and implement wait_{prepare, finish}. > > I don't see any wait_prepare/finish implementation?! > > Oops, seems it felt

[GIT PULL FOR v4.19] Various fixes

2018-07-06 Thread Hans Verkuil
The following changes since commit 666e994aa2278e948e2492ee9d81b4df241e7222: media: platform: s5p-mfc: simplify getting .drvdata (2018-07-04 11:45:40 -0400) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.19i for you to fetch changes up to

Re: [PATCH v6 04/17] omap3isp: Add vb2_queue lock

2018-07-06 Thread Ezequiel Garcia
On Mon, 2018-07-02 at 19:49 +0300, Laurent Pinchart wrote: > Hi Ezequiel, > > (CC'ing Sakari) > > Thank you for the patch. > > On Friday, 22 June 2018 06:53:58 EEST Ezequiel Garcia wrote: > > vb2_queue locks is now mandatory. Add it, remove driver ad-hoc > > locks, > > and implement

Re: [PATCH v2 2/3] s5p-g2d: Remove unrequired wait in .job_abort

2018-07-06 Thread Sylwester Nawrocki
On 07/06/2018 03:43 PM, Ezequiel Garcia wrote: Could you elaborate how the core ensures DMA operation is not in progress after VIDIOC_STREAMOFF, VIDIOC_DQBUF with this patch applied? Well, .streamoff is handled by v4l2_m2m_streamoff, which guarantees that no job is running by calling

Re: [PATCH v2 2/3] media: dvb: represent min/max/step/tolerance freqs in Hz

2018-07-06 Thread Matthias Schwarzott
Am 06.07.2018 um 00:59 schrieb Mauro Carvalho Chehab: Hi Mauro, I have one comment below. > Right now, satellite frontend drivers specify frequencies in kHz, > while terrestrial/cable ones specify in Hz. That's confusing > for developers. > > However, the main problem is that universal