On Tue, 24 Sep 2013 10:35:50 +0800
Wei Yongjun weiyj...@gmail.com wrote:
irq allocated with devm_request_irq should not be freed using
free_irq, because doing so causes a dangling pointer, and a
subsequent double free.
Makes sense.
Acked-by: Jonathan Corbet cor...@lwn.net
jon
--
To
On Tue, 24 Sep 2013 20:59:47 +0200
Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote:
The marvell-ccic does several things wrong or ineffectively in the clock
handling and it's usage of the devm_* stuff
- it assumes clk_get doesn't return NULL
- it explicitly calls devm_clk_put
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Sep 25 10:47:57 CEST 2013
git branch: test
git hash: ffee921033e64edf8579a3b21c7f15d1a6c3ef71
gcc
On 09/24/2013 06:17 PM, Hans Verkuil wrote:
Hi Valentine,
Hi Hans,
On Tue 24 September 2013 15:38:34 Valentine Barshak wrote:
This adds ADV7611/ADV7612 Dual Port Xpressview
225 MHz HDMI Receiver support.
The code is based on the ADV7604 driver, and ADV7612 patch
by Shinobu Uehara
On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote:
Hi Valentine,
Hi Guennadi,
On Tue, 24 Sep 2013, Valentine Barshak wrote:
This adds ADV7611/ADV7612 Dual Port Xpressview
225 MHz HDMI Receiver support.
The code is based on the ADV7604 driver, and ADV7612 patch
by Shinobu Uehara
Hi Valentine,
On Wed, 25 Sep 2013, Valentine wrote:
On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote:
Hi Valentine,
Hi Guennadi,
On Tue, 24 Sep 2013, Valentine Barshak wrote:
This adds ADV7611/ADV7612 Dual Port Xpressview
225 MHz HDMI Receiver support.
The code is
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:
Hi Valentine,
Hi Guennadi,
On Wed, 25 Sep 2013, Valentine wrote:
On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote:
Hi Valentine,
Hi Guennadi,
On Tue, 24 Sep 2013, Valentine Barshak wrote:
This adds ADV7611/ADV7612 Dual Port
Hi,
As you can see sdo, hdmi and mixer are saparate drivers that are
parts of s5p-tv drivers set. Could you rename commit name to
'media: s5p-tv: sdo: Restore vpll clock rate after streamoff'
On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote:
Restore vpll clock rate if start stream fail or stream
Rename to 'media: s5p-tv: sdo: integrate with CCF'
On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote:
Replace clk_enable by clock_enable_prepare and clk_disable with
clk_disable_unprepare.
Clock prepare is required by Clock Common Framework, and old clock driver
didn`t support it.
Without it
rename to 'media: s5p-tv: mixer: integrate with CCF'
On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote:
Replace clk_enable by clock_enable_prepare and clk_disable with
clk_disable_unprepare.
Clock prepare is required by Clock Common Framework, and old clock driver
didn`t support it.
Without
On 09/23/2013 02:44 PM, Sylwester Nawrocki wrote:
On 21/09/13 17:00, Mateusz Krawczuk wrote:
Replace clk_enable by clock_enable_prepare and clk_disable with
clk_disable_unprepare.
Clock prepare is required by Clock Common Framework, and old clock driver
didn`t support it.
Without it Common
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:
[snip]
Using module parameters has a disadvantage, that all instances of this
driver will get the same values, and it is quite possible to have
several
HDMI receivers in a system, I
On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote:
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:
[snip]
Using module parameters has a disadvantage, that all instances of this
driver will get the same values, and it is quite possible to have
Hi Valentine,
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote:
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:
[snip]
Using module parameters has a disadvantage, that all instances of
Hi Guennadi,
On Tuesday 24 September 2013 17:54:11 Guennadi Liakhovetski wrote:
Hi Valentine,
On Tue, 24 Sep 2013, Valentine Barshak wrote:
This adds ADV7611/ADV7612 Dual Port Xpressview
225 MHz HDMI Receiver support.
The code is based on the ADV7604 driver, and ADV7612 patch
by
On 09/25/2013 10:33 PM, Guennadi Liakhovetski wrote:
Hi Valentine,
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote:
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:
[snip]
Using module parameters has a
Hi Valentine,
Thank you for the patch.
Please see below for a couple of comments (in addition to Hans' and Guennadi's
comments).
On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote:
This adds ADV7611/ADV7612 Dual Port Xpressview
225 MHz HDMI Receiver support.
The code is based
Hi Hans,
On Tuesday 24 September 2013 13:24:25 Hans Verkuil wrote:
On Tue 24 September 2013 12:59:44 Laurent Pinchart wrote:
On Tuesday 10 September 2013 11:34:32 Hans Verkuil wrote:
I have collected all the ideas up to now in a V2 of the agenda.
The items are grouped by the
On Wednesday 25 September 2013 12:21:04 Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
Please see below for a couple of comments (in addition to Hans' and
Guennadi's comments).
On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote:
This adds ADV7611/ADV7612
On 09/24/2013 03:01 PM, Hans Verkuil wrote:
On Thu 12 September 2013 12:19:29 Sylwester Nawrocki wrote:
On 09/11/2013 04:01 PM, Hans Verkuil wrote:
On 09/11/2013 03:07 PM, Sylwester Nawrocki wrote:
On 09/09/2013 11:07 AM, Hans Verkuil wrote:
On 09/06/2013 12:33 AM, Sylwester Nawrocki wrote:
On 09/26/2013 12:16 AM, Sylwester Nawrocki wrote:
On 09/24/2013 03:01 PM, Hans Verkuil wrote:
On Thu 12 September 2013 12:19:29 Sylwester Nawrocki wrote:
On 09/11/2013 04:01 PM, Hans Verkuil wrote:
On 09/11/2013 03:07 PM, Sylwester Nawrocki wrote:
On 09/09/2013 11:07 AM, Hans Verkuil wrote:
On Wednesday 25 September 2013 18:31:51 Guennadi Liakhovetski wrote:
On Wed, 25 Sep 2013, Valentine wrote:
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:
[snip]
+/* I2C I/O operations */
+static s32 adv_smbus_read_byte_data(struct i2c_client *client, u8
command)
Hi Jonathan Uwe,
In the clk enable and prepare function, we will check the NULL pointer. So it
should be no problem.
For the mipi_clk, it is shared between other components, so we put the clk it
we don't use it.
For the free_irq, it's my fault. Out before patch really removed this code
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Sep 26 04:00:16 CEST 2013
git branch: test
git hash: ffee921033e64edf8579a3b21c7f15d1a6c3ef71
gcc
Hello Wei Yongjun,
Thanks for finding the issue. It seems the last part code is missed when I
submitted the patch. Please see the patch we submitted before in [REVIEW PATCH
V4 07/12] [media] marvell-ccic: switch to resource managed allocation and
request.
The last part patch is missed:
@@
25 matches
Mail list logo
