Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
On 11/19/2013 01:50 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, thanks for your review. I don't entirely understand how you use this driver with soc-camera. Since soc-camera doesn't support FMT_CHANGE notifies it can't really act on it. Did you hack soc-camera to do this? I did not.

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Hans Verkuil
Hi Valentine, On 11/20/13 11:14, Valentine wrote: On 11/19/2013 01:50 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, thanks for your review. I don't entirely understand how you use this driver with soc-camera. Since soc-camera doesn't support FMT_CHANGE notifies it can't really act on

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
On 11/20/2013 03:19 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, On 11/20/13 11:14, Valentine wrote: On 11/19/2013 01:50 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, thanks for your review. I don't entirely understand how you use this driver with soc-camera. Since soc-camera

Private Request

2013-11-20 Thread Mr. smith Tiangaye
Hi, My name is Mr. smith Tiangaye from Central Africa but currently residing in South Africa. I want to invest in South Africa with your assistance. Contact me for more information. Best regard, Mr. smith Tiangaye 084 023 9962 -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-20 Thread Jacek Anaszewski
On 11/19/2013 03:46 PM, Hans Verkuil wrote: On 11/19/2013 03:27 PM, Jacek Anaszewski wrote: When output queue fourcc is set to any flavour of YUV, the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value as well as its in-driver cached counterpart have to be updated with the subsampling property of

Re: [PATCH 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-20 Thread Hans Verkuil
On 11/20/13 14:47, Jacek Anaszewski wrote: On 11/19/2013 03:46 PM, Hans Verkuil wrote: On 11/19/2013 03:27 PM, Jacek Anaszewski wrote: When output queue fourcc is set to any flavour of YUV, the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value as well as its in-driver cached counterpart have to

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Hans Verkuil
Hi Valentine, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 It adds adv761x support to the adv7604 in a pretty clean way. Thinking it over I prefer to use that code (although you will have to add the soc-camera

Dual licensing for v4l2-common.h userland headers

2013-11-20 Thread Devin Heitmueller
As a result of a code audit the VLC group is doing, they stumbled on the fact that v4l2-common.h is not dual licensed (it's marked as GPL only). This obviously poses a problem especially since v4l2-common.h is included by videodev2.h (which is the key header people include when they want to use

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I missed that one somehow, although I did search for the adv7611/7612 before implementing this one.

[PATCH] usb: cx231xx: Fix explicit freed pointer dereference

2013-11-20 Thread Geyslan G. Bem
Put kfree after the 'clear_bit()' call. Signed-off-by: Geyslan G. Bem geys...@gmail.com --- drivers/media/usb/cx231xx/cx231xx-cards.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c index

[PATCH] videobuf2-dma-sg: fix possible memory leak

2013-11-20 Thread Geyslan G. Bem
Fix the return when 'buf-pages' allocation error. Signed-off-by: Geyslan G. Bem geys...@gmail.com --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c

[PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-20 Thread Andy Walls
(This patch is RFC, because it was compiled and tested against kernel v3.5) videobuf2 file I/O emulation assumed that buffers dequeued from the driver would return in the order they were enqueued in the driver. Improve the file I/O emulator's book-keeping to remove this assumption. Also remove

cron job: media_tree daily build: WARNINGS

2013-11-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 21 04:00:25 CET 2013 git branch: test git hash: 80f93c7b0f4599ffbdac8d964ecd1162b8b618b9 gcc

[PATCH] [media] cx88: use correct pci drvdata type in cx88_audio_finidev()

2013-11-20 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn We had set the pci drvdata in cx88_audio_initdev() as a type of struct snd_card, so cx88_audio_finidev() should used it as the same type too. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/pci/cx88/cx88-alsa.c | 4 ++--

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-20 Thread Hans Verkuil
Hi Andy, As I mentioned in irc I have been working in this same area as well, so I'll take this patch and merge it in my tree and test it as well. I suspect that it might be easiest if I add the patch to my upcoming patch series in order to prevent merge conflicts. I'll know more later today.