Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I

Re: [RFC PATCH 1/8] vb2: push the mmap semaphore down to __buf_prepare()

2013-11-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 November 2013 08:12:24 Hans Verkuil wrote: On 11/26/2013 04:42 PM, Laurent Pinchart wrote: On Friday 22 November 2013 10:02:49 Hans Verkuil wrote: On 11/21/2013 08:04 PM, Laurent Pinchart wrote: On Thursday 21 November 2013 16:21:59 Hans Verkuil wrote: From: Hans

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
[...] I had to implement the IRQ handler since the soc_camera model does not use interrupt_service_routine subdevice callback and R-Car VIN knows nothing about adv7612 interrupt routed to a GPIO pin. So I had to schedule a workqueue and call adv7604_isr from there in case an interrupt

[PATCH v2] v4l: sh_vou: Fix warnings due to improper casts and printk formats

2013-11-27 Thread Laurent Pinchart
Use the %zu printk specifier to print size_t variables, and cast pointers to uintptr_t instead of unsigned int where applicable. This fixes warnings on platforms where pointers and/or dma_addr_t have a different size than int. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Mauro Carvalho

RFC: add FMT_CHANGE event and VIDIOC_G/S_EDID ioctls

2013-11-27 Thread Hans Verkuil
This RFC addresses some HDTV-related features that are missing in the API. The reason they were missing is that there were no bridge drivers in the kernel that needed them, but with the work done on soc_camera + adv7611/2 by Valentine this is now really needed. The two missing pieces are how to

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 12:21 PM, Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Hi Hans, Did you ever look at this adv7611 driver:

Re: [RFC PATCH 4/8] vb2: retry start_streaming in case of insufficient buffers.

2013-11-27 Thread Laurent Pinchart
Hi Hans, Re-reading the code I can't see my original point anymore :-/ Let's assume I was just wrong. I have two additional small comments though, please see below. On Wednesday 27 November 2013 08:17:15 Hans Verkuil wrote: On 11/26/2013 04:46 PM, Laurent Pinchart wrote: On Friday 22

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-27 Thread Dan Carpenter
On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote: On 11/27/2013 12:03 PM, Greg KH wrote: On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/27/13 11:29, Valentine wrote: On 11/27/2013 12:21 PM, Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/27/13 10:59, Lars-Peter Clausen wrote: [...] I had to implement the IRQ handler since the soc_camera model does not use interrupt_service_routine subdevice callback and R-Car VIN knows nothing about adv7612 interrupt routed to a GPIO pin. So I had to schedule a workqueue and call

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 04:14 PM, Hans Verkuil wrote: Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
On 11/27/2013 01:32 PM, Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 05:07 PM, Lars-Peter Clausen wrote: On 11/27/2013 01:32 PM, Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM,

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
On 11/27/2013 01:14 PM, Hans Verkuil wrote: [...] For our systems the adv7604 interrupts is not always hooked up to a gpio irq, instead a register has to be read to figure out which device actually produced the irq. Where is that register located ? Shouldn't it be modeled as an interrupt

[PATCH] cx231xx: fix i2c debug prints

2013-11-27 Thread Matthias Schwarzott
Do not shift the already 7bit i2c address. Print a message also for write+read transactions. For write+read, print the read buffer correctly instead of using the write buffer. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 16 1

[PATCH] cx231xx: Add missing selects for MEDIA_SUBDRV_AUTOSELECT

2013-11-27 Thread Matthias Schwarzott
The two drivers LGDT3305 and TDA18271C2DD were not autoselected, so the cx231xx_dvb module could not be loaded if MEDIA_SUBDRV_AUTOSELECT is enabled. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 November 2013 13:14:41 Hans Verkuil wrote: On 11/27/13 12:39, Laurent Pinchart wrote: On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Valentine, (CC'ing Linus Walleij, Wolfram Sang and LAKML) On Wednesday 27 November 2013 16:32:01 Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: On 11/27/13 12:39, Laurent Pinchart wrote: On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM,

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
[...] The driver enables multiple interrupts on the chip, however, the adv7604_isr callback doesn't seem to handle them correctly. According to the docs: If an interrupt event occurs, and then a second interrupt event occurs before the system controller has cleared or masked the first

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
On Wednesday 27 November 2013 15:50:18 Lars-Peter Clausen wrote: On 11/27/2013 01:14 PM, Hans Verkuil wrote: [...] For our systems the adv7604 interrupts is not always hooked up to a gpio irq, instead a register has to be read to figure out which device actually produced the irq.

Support for Terratec CINERGY S2 Stick HD new revision

2013-11-27 Thread Peter Lieven
Hi, i recently bought the above USB stick, but it seems to have a new/unknown revision. Does someone have any details which hardware is inside? [8.580089] usb 1-1.3: New USB device found, idVendor=0ccd, idProduct=0102 [8.593691] usb 1-1.3: New USB device strings: Mfr=1, Product=2,

[PATCH 2/2] af9035: fix broken I2C and USB I/O

2013-11-27 Thread Antti Palosaari
There was three small buffer len calculation bugs which caused driver non-working. These are coming from recent commit: commit 7760e148350bf6df95662bc0db3734e9d991cb03 [media] af9035: Don't use dynamic static allocation Signed-off-by: Antti Palosaari cr...@iki.fi ---

[PATCH 1/2] af9033: fix broken I2C

2013-11-27 Thread Antti Palosaari
Driver did not work anymore since I2C has gone broken due to recent commit: commit 37ebaf6891ee81687bb558e8375c0712d8264ed8 [media] dvb-frontends: Don't use dynamic static allocation Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/af9033.c | 2 +- 1 file changed, 1

Re: libdvbv5: dvb_table_pat_init is leaking memory

2013-11-27 Thread Mauro Carvalho Chehab
Hi Gregor, Em Wed, 27 Nov 2013 22:55:32 +0100 Gregor Jasny gja...@googlemail.com escreveu: Hello, Coverity noticed that dvb_table_pat_init leaks the reallocated memory stored in pat: http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/lib/libdvbv5/descriptors/pat.c#l26 Mauro, could you

Re: libdvbv5: dvb_table_pat_init is leaking memory

2013-11-27 Thread Mauro Carvalho Chehab
Em Wed, 27 Nov 2013 20:31:21 -0200 Mauro Carvalho Chehab mche...@infradead.org escreveu: Hi Gregor, Em Wed, 27 Nov 2013 22:55:32 +0100 Gregor Jasny gja...@googlemail.com escreveu: Hello, Coverity noticed that dvb_table_pat_init leaks the reallocated memory stored in pat:

Re: [PATCH] [media] az6007: support Technisat Cablestar Combo HDCI (minus remote)

2013-11-27 Thread Roland Scheidegger
Any chances this could get applied? Thanks, Roland Am 02.11.2013 20:49, schrieb linux-media-ow...@vger.kernel.org: This is similar to the Terratec H7. It works with the same az6007 firmware as the former, however the drx-k firmware of the H7 will NOT work. Hence use a different firmware

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-27 Thread Chen Gang
On 11/27/2013 06:43 PM, Dan Carpenter wrote: On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote: On 11/27/2013 12:03 PM, Greg KH wrote: On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go'

cron job: media_tree daily build: WARNINGS

2013-11-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 28 04:00:29 CET 2013 git branch: test git hash: 258d2fbf874c87830664cb7ef41f9741c1abffac gcc