On 08/03/14 14:23, Grant Likely wrote:
That's fine. In that case the driver would specifically require the
endpoint to be that one node although the above looks a little weird
The driver can't require that. It's up to the board designer to decide
how many endpoints are used. A driver may
On 08/03/14 14:25, Grant Likely wrote:
Sure. If endpoints are logical, then only create the ones actually
hooked up. No problem there. But nor do I see any issue with having
empty connections if the board author things it makes sense to have them
in the dtsi.
I don't think they are usually
Hi,
I am studying v4l2 m2m driver example. I want to know why the set
format function in the example fails when it is called again after
user application req_buf? In set format function checks for
vb2_is_busy(vq) and that function returns true after user space app
calls req_buf.
For example in
On 03/10/2014 08:02 AM, m silverstri wrote:
Hi,
I am studying v4l2 m2m driver example. I want to know why the set
format function in the example fails when it is called again after
user application req_buf? In set format function checks for
vb2_is_busy(vq) and that function returns true
Could anyone move forward with this patch?
Or is there anything I should do more?
Please advise.
Thanks,
Satoshi
(2014/02/10 18:45), Satoshi Nagahama wrote:
Add a device id to support for PX-S1UD (PLEX ISDB-T usb dongle) which
has sms2270.
Signed-off-by: Satoshi Nagahama satt...@aim.com
---
On Mon, Mar 10, 2014 at 4:45 AM, kbuild test robot
fengguang...@intel.com wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: ca62eec4e524591b82d9edf7a18e3ae6b691517d
commit: 866f321339988293a5bb3ec6634c2c9d8396bf54 Revert staging/solo6x10:
depend
Hi,
On 03/08/2014 04:54 PM, Laurent Pinchart wrote:
Hi Philipp,
On Saturday 08 March 2014 13:07:23 Philipp Zabel wrote:
On Fri, Mar 7, 2014 at 6:18 PM, Grant Likely wrote:
On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel wrote:
The 'ports' node is optional. It is only needed if the parent
Hi Grant,
Am Freitag, den 07.03.2014, 18:27 + schrieb Grant Likely:
On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel p.za...@pengutronix.de
wrote:
The device tree graph bindings as used by V4L2 and documented in
Documentation/device-tree/bindings/media/video-interfaces.txt contain
On 10/03/14 10:58, Andrzej Hajda wrote:
I want to propose another solution to simplify bindings, in fact I have
few ideas to consider:
1. Use named ports instead of address-cells/regs. Ie instead of
port@number schema, use port-function. This will allow to avoid ports
node and
Hi Mauro,
Here are some cleanups for lm3560 and a driver for lm3646 flash controller
which also adds a few new flash fault control bits.
The following changes since commit f2d7313534072a5fe192e7cf46204b413acef479:
[media] drx-d: add missing braces in drxd_hard.c:DRXD_init (2014-03-09
Hi,
i have some problems using the Terratec Cinergy HTC Stick HD Rev. 2 .
The driver or the specification is currenty not implemented into
driverset of media-build.
All i know is, that there is a buildin Conexant Chip (I think the
CX23102) and a SiliconLabs Tuner (SI2173). I already tried
On 05.03.2014 20:49, Mauro Carvalho Chehab wrote:
Em Thu, 27 Feb 2014 02:22:06 +0200
Antti Palosaari cr...@iki.fi escreveu:
Add documentation for RF tuner bandwidth controls. These controls are
used to set filters on tuner signal path.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti
On 08/03/14 13:41, Grant Likely wrote:
Ok. If we go for single directional link, the question is then: which
way? And is the direction different for display and camera, which are
kind of reflections of each other?
In general I would recommend choosing whichever device you would
sensibly
Moikka Hans!
I will look these issues today. Actually I forget to ran whole
v4l2-compliance after I added these controls... I ran it for basic API
and it failed there too in many places, IIRC mostly those were related
to new tuner types.
regards
Antti
On 06.03.2014 01:21, Hans Verkuil
Hi Philipp,
On Monday 10 March 2014 10:28:10 Philipp Zabel wrote:
Hi Grant,
Am Freitag, den 07.03.2014, 18:27 + schrieb Grant Likely:
On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel wrote:
The device tree graph bindings as used by V4L2 and documented in
Hi Andrzej,
On Monday 10 March 2014 09:58:07 Andrzej Hajda wrote:
On 03/08/2014 04:54 PM, Laurent Pinchart wrote:
On Saturday 08 March 2014 13:07:23 Philipp Zabel wrote:
On Fri, Mar 7, 2014 at 6:18 PM, Grant Likely wrote:
On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel wrote:
The
As reported when compiled with W=1:
drivers/media/dvb-frontends/drx39xyj/drxj.c: In function ‘ctrl_set_channel’:
drivers/media/dvb-frontends/drx39xyj/drxj.c:10340:26: warning: variable
‘common_attr’ set but not used [-Wunused-but-set-variable]
struct drx_common_attr *common_attr = NULL;
When the signal is 7, it means that no signal was received.
Value experimentally measured.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c
This patch series is meant to:
1) fix some reported issues (sparse, smatch);
2) Fix one compilation issue with em28xx when drx-j is not selected;
3) Get rid of unused code. It is always possible to restore the code
from git history. Removing the unused code helps to better understand
We'll need to use this function. Restore it from the
git history.
This function will be used on the next patch.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 77 +
1 file changed, 77 insertions(+)
diff
smatch warning:
drivers/media/dvb-frontends/drx39xyj/drxj.c:20803 drx_ctrl_u_code()
warn: variable dereferenced before check 'mc_info' (see line 20800)
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
Fixes the following warnings:
drivers/media/dvb-frontends/drx39xyj/drxj.c:16764:68: warning: dubious:
x !y
drivers/media/dvb-frontends/drx39xyj/drxj.c:16778:68: warning: dubious:
x !y
drivers/media/dvb-frontends/drx39xyj/drxj.c:16797:68: warning: dubious:
x !y
Convert the stats internally to use DVBv5. For now, it will keep
showing everything via DVBv3 API only, as the .len value were
not initialized.
That allows testing if the new stats code didn't break anything.
A latter patch will add the final bits for the DVBv5 stats to
fully work.
This driver doesn't export any external symbol, except for
the attach() method.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 12 ++--
drivers/media/dvb-frontends/drx39xyj/drxj.h | 30 -
2 files
As reported by the kbuild test robot fengguang...@intel.com:
drivers/built-in.o: In function `em28xx_dvb_init':
em28xx-dvb.c:(.text+0x876f2c): undefined reference to `drx39xxj_attach'
That happens when CONFIG_VIDEO_EM28XX_DVB is selected, and neither
CONFIG_MEDIA_SUBDRV_AUTOSELECT or
Instead of just assuming that the min resolution is 1E-6,
pass both bit error and bit counts for userspace to calculate
BER. The same applies for PER, for 8VSB. It is not clear how
to get the packet count for QAM. So, for now, don't expose PER
for QAM.
Signed-off-by: Mauro Carvalho Chehab
State is already used on other places for the state struct.
Don't use it here, to avoid troubles with latter patches.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 22 +++---
1 file changed, 11 insertions(+), 11
This function is currently not used. However, it was meant to
be called at device release. So, add it there.
While here, remove the bad check, as reported by Dan, as
smatch warning:
drivers/media/dvb-frontends/drx39xyj/drxj.c:20041 drxj_close() warn:
variable dereferenced before check
Fixes the following warnings:
drivers/media/dvb-frontends/drx39xyj/drxj.c:1679:65: warning: Using
plain integer as NULL pointer
drivers/media/dvb-frontends/drx39xyj/drxj.c:1679:71: warning: Using
plain integer as NULL pointer
Fix a smatch warning:
drivers/media/dvb-frontends/drx39xyj/drxj.c:11711 drx_ctrl_u_code()
info: why not propagate 'rc' from request_firmware() instead of (-2)?
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 2 +-
1 file
Now that everything is set, let's enable DVBv5 stats, for
applications that support it.
DVBv3 apps will still work.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 29 +
1 file changed, 25 insertions(+), 4
From: Hans Verkuil hans.verk...@cisco.com
With the new vb2_thread_start/stop core code it is very easy to implement
videobuf2-dvb. This should simplify converting existing videobuf drivers to
vb2.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/Kconfig |
From: Hans Verkuil hans.verk...@cisco.com
In order to implement vb2 DVB support you need to be able to start
a kernel thread that queues and dequeues buffers, calling a callback
function for every buffer. This patch adds support for that.
It's based on drivers/media/v4l2-core/videobuf-dvb.c, but
On 03/10/2014 01:12 PM, Archit Taneja wrote:
Hi Hans,
On Friday 07 March 2014 07:17 PM, Archit Taneja wrote:
On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote:
On 03/07/2014 02:22 PM, Archit Taneja wrote:
Disregard what I said, it's OK to upstream it. But if you could just
spend
Currently the VIDIOC_SUBDEV_G/S_EDID and struct v4l2_subdev_edid are subdev
APIs. However, that's in reality quite annoying since for simple video
pipelines there is no need to create v4l-subdev device nodes for anything
else except for setting or getting EDIDs.
What happens in practice is that
Three small fixes for 3.14:
- while working on the EDID changes Laurent discovered that the ioctl numbers
specified in v4l2-compat-ioctl32 were wrong and have been from the beginning.
Fix that. NOTE: this patch was also included with the 3.15 EDID pull request
I posted today.
- The
On 03/10/2014 01:40 PM, Hans Verkuil wrote:
Currently the VIDIOC_SUBDEV_G/S_EDID and struct v4l2_subdev_edid are subdev
APIs. However, that's in reality quite annoying since for simple video
pipelines there is no need to create v4l-subdev device nodes for anything
else except for setting or
When suspending a device while a video stream is active all buffers
marked as done but not dequeued yet will be kept across suspend and
given back to userspace after resume. This will result in outdated
buffers being dequeued.
Introduce a new vb2 function to mark all done buffers as erroneous
Em Mon, 10 Mar 2014 08:58:52 -0300
Mauro Carvalho Chehab m.che...@samsung.com escreveu:
This patch series is meant to:
1) fix some reported issues (sparse, smatch);
2) Fix one compilation issue with em28xx when drx-j is not selected;
3) Get rid of unused code. It is always possible to
On 03/10/2014 02:04 PM, Laurent Pinchart wrote:
When suspending a device while a video stream is active all buffers
marked as done but not dequeued yet will be kept across suspend and
given back to userspace after resume. This will result in outdated
buffers being dequeued.
Introduce a new
Hello,
On some platforms (namely ARM) IOMMUs are handled transparently by the DMA
mapping implementation. This requires mapping and unmapping all USERPTR
buffers for DMA, regardless of whether they're backed by struct page or not.
videobuf2-dma-contig is broken in that regard, as it call
Em Fri, 07 Mar 2014 18:23:30 +
Grant Likely grant.lik...@linaro.org escreveu:
On Thu, 06 Mar 2014 18:13:20 +0100, Philipp Zabel p.za...@pengutronix.de
wrote:
Hi Mauro, Russell,
I have temporarily removed the simplified bindings at Sylwester's
request and updated the branch with
On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote:
On 08/03/14 13:41, Grant Likely wrote:
Ok. If we go for single directional link, the question is then: which
way? And is the direction different for display and camera, which are
kind of reflections of each other?
In general I
Hi Tomi,
On Monday 10 March 2014 08:00:02 Tomi Valkeinen wrote:
On 08/03/14 17:54, Laurent Pinchart wrote:
Sylwester suggested as an alternative, if I understood correctly, to
drop the endpoint node and instead keep the port:
device-a {
implicit_output_ep: port {
Am Montag, den 10.03.2014, 12:37 +0100 schrieb Laurent Pinchart:
Hi Philipp,
On Monday 10 March 2014 10:28:10 Philipp Zabel wrote:
Hi Grant,
Am Freitag, den 07.03.2014, 18:27 + schrieb Grant Likely:
On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel wrote:
The device tree
From: Hans Verkuil hans.verk...@cisco.com
There is no reason why we shouldn't enable this here.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/mem2mem_testdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch series fixes a number of v4l2-compliance problems and some small
enhancements (a better default transfer time and adding USERPTR support).
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to
From: Hans Verkuil hans.verk...@cisco.com
- Set the sequence counters correctly.
- Copy timestamps, timecode, relevant buffer flags and field from
the received buffer to the outgoing buffer.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/mem2mem_testdev.c | 27
From: Hans Verkuil hans.verk...@cisco.com
To keep the vb2 buffer administration in balance stop_streaming() must
return any pending buffers to the vb2 framework.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/mem2mem_testdev.c | 21 +
1 file
From: Hans Verkuil hans.verk...@cisco.com
The default of 1 second is a bit painful, switch to a 25 Hz framerate.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/mem2mem_testdev.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
This resolves an issue raised by v4l2-compliance: if the given format does
not exist, then pick a default format.
While there is an exception regarding this for TV capture drivers, this
m2m driver should do the right thing.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
v4l2_compliance fix.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/mem2mem_testdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/mem2mem_testdev.c
b/drivers/media/platform/mem2mem_testdev.c
From: Hans Verkuil hans.verk...@cisco.com
try_fmt should just set field to NONE and not return an error if
a different field was passed.
buf_prepare should check if the field passed in from userspace has a
supported field value. At the moment only NONE is supported and ANY
is mapped to NONE.
On 10/03/14 15:52, Laurent Pinchart wrote:
In theory unidirectional links in DT are indeed enough. However, let's not
forget the following.
- There's no such thing as single start points for graphs. Sure, in some
simple cases the graph will have a single start point, but that's not a
On Mon, 10 Mar 2014 10:26:30 -0300, Mauro Carvalho Chehab
m.che...@samsung.com wrote:
Em Fri, 07 Mar 2014 18:23:30 +
Grant Likely grant.lik...@linaro.org escreveu:
On Thu, 06 Mar 2014 18:13:20 +0100, Philipp Zabel p.za...@pengutronix.de
wrote:
Hi Mauro, Russell,
I have
On Mon, 10 Mar 2014 12:18:20 +0200, Tomi Valkeinen tomi.valkei...@ti.com
wrote:
On 08/03/14 13:41, Grant Likely wrote:
Ok. If we go for single directional link, the question is then: which
way? And is the direction different for display and camera, which are
kind of reflections of each
On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote:
On 08/03/14 13:41, Grant Likely wrote:
Ok. If we go for single directional link, the question is then: which
way? And is the direction
Hi Grant,
On Monday 10 March 2014 14:58:15 Grant Likely wrote:
On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote:
On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote:
On 08/03/14 13:41, Grant Likely wrote:
Ok. If we go for single directional link, the question is then: which
On 03/10/2014 03:37 PM, Hans Verkuil wrote:
[...]
+
+static int adv7180_s_power(struct v4l2_subdev *sd, int on)
+{
+ struct adv7180_state *state = to_state(sd);
+ struct i2c_client *client = v4l2_get_subdevdata(sd);
+ int ret;
+
+ ret =
On 03/10/2014 04:24 PM, Lars-Peter Clausen wrote:
On 03/10/2014 03:37 PM, Hans Verkuil wrote:
[...]
+
+static int adv7180_s_power(struct v4l2_subdev *sd, int on)
+{
+ struct adv7180_state *state = to_state(sd);
+ struct i2c_client *client = v4l2_get_subdevdata(sd);
+ int ret;
+
+
Moikka Hans!
On 06.03.2014 01:21, Hans Verkuil wrote:
Antti,
Attached is a patch that fixed all but one v4l2-compliance error:
fail: v4l2-test-controls.cpp(295): returned control value out
of range
fail: v4l2-test-controls.cpp(357): invalid control 00a2090c
On 03/10/2014 04:28 PM, Hans Verkuil wrote:
On 03/10/2014 04:24 PM, Lars-Peter Clausen wrote:
On 03/10/2014 03:37 PM, Hans Verkuil wrote:
[...]
+
+static int adv7180_s_power(struct v4l2_subdev *sd, int on)
+{
+ struct adv7180_state *state = to_state(sd);
+ struct i2c_client *client
On 03/10/2014 04:29 PM, Antti Palosaari wrote:
Moikka Hans!
On 06.03.2014 01:21, Hans Verkuil wrote:
Antti,
Attached is a patch that fixed all but one v4l2-compliance error:
fail: v4l2-test-controls.cpp(295): returned control value
out of range
fail:
On 10.03.2014 17:36, Hans Verkuil wrote:
On 03/10/2014 04:29 PM, Antti Palosaari wrote:
Moikka Hans!
On 06.03.2014 01:21, Hans Verkuil wrote:
Antti,
Attached is a patch that fixed all but one v4l2-compliance error:
fail: v4l2-test-controls.cpp(295): returned control value
Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart:
Hi Grant,
On Monday 10 March 2014 14:58:15 Grant Likely wrote:
On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote:
On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote:
On 08/03/14 13:41, Grant Likely wrote:
Hi Hans,
Thank you for the patches.
On Monday 17 February 2014 12:44:11 Hans Verkuil wrote:
This patch series addresses a problem that was exposed by commit a5338190e.
The issue is that soc_camera implements s/g_std ioctls and just forwards
those to the subdev, whether or not the subdev
On Mon, Mar 10, 2014 at 12:21 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 03/10/2014 08:02 AM, m silverstri wrote:
Hi,
I am studying v4l2 m2m driver example. I want to know why the set
format function in the example fails when it is called again after
user application req_buf? In set
The adv7180 has a low power mode in which the analog and the digital processing
section are shut down. Implement the s_power callback to let bridge drivers put
the part into low power mode when not needed.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
Changes since v1:
* Set powered
The following changes since commit f2d7313534072a5fe192e7cf46204b413acef479:
[media] drx-d: add missing braces in drxd_hard.c:DRXD_init (2014-03-09
09:20:50 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v3.15e
for you to fetch changes up to
Hi Philipp,
On Friday 07 March 2014 18:40:54 Philipp Zabel wrote:
Am Freitag, den 07.03.2014, 01:12 +0100 schrieb Laurent Pinchart:
Hi Philipp,
Thank you for the patch.
I've submitted a fix for the of_graph_get_next_endpoint() function, but it
hasn't been applied yet due to the
Fix msi3101 driver v4l2-compliance issues.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/staging/media/msi3101/sdr-msi3101.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/msi3101/sdr-msi3101.c
Clamp bandwidth to nearest legal value in automode in order to pass
v4l2-compliance test.
Reported-by: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 12 ++--
1 file changed, 10 insertions(+), 2
Fix msi001 driver v4l2-compliance issues.
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/staging/media/msi3101/msi001.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/msi3101/msi001.c
From: Hans Verkuil hverk...@xs4all.nl
Fix rtl2832u_sdr driver v4l2-compliance issues.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 29 +++-
1 file changed, 23
We need depend on I2C_MUX as rtl2832 demod used requires it.
All error/warnings:
warning: (DVB_USB_RTL28XXU) selects DVB_RTL2832 which has unmet direct
dependencies (MEDIA_SUPPORT DVB_CORE I2C I2C_MUX)
ERROR: i2c_add_mux_adapter [drivers/media/dvb-frontends/rtl2832.ko] undefined!
ERROR:
Rename v4l2_format_sdr to v4l2_sdr_format in order to keep it in
line with other formats.
Reported-by: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Documentation/DocBook/media/v4l/dev-sdr.xml | 2 +-
drivers/media/v4l2-core/v4l2-ioctl.c| 2 +-
That is just same set I sent earlier too, but rebased to latest
media/master and 6 small compliance fix.
The following changes since commit f2d7313534072a5fe192e7cf46204b413acef479:
[media] drx-d: add missing braces in drxd_hard.c:DRXD_init
(2014-03-09 09:20:50 -0300)
are available in
This patch series contains a list of various vb2 fixes and improvements.
These patches were originally part of this RFC patch series:
http://www.spinics.net/lists/linux-media/msg73391.html
They are now rebased and reordered a bit. It's little stuff for the
most part, although the first patch
From: Hans Verkuil hans.verk...@cisco.com
The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.
The int return gave drivers the idea that
From: Hans Verkuil hans.verk...@cisco.com
It was impossible to read() or write() a frame if the queue type was
multiplanar.
Even if the current format is single planar. Change this to just check whether
the number of planes is 1 or more.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
From: Hans Verkuil hans.verk...@cisco.com
Many dprintk's in vb2 use a hardcoded prefix with the function name. In
many cases that is now outdated. Replace prefixes by the function name using
__func__. At least now I know if I see a 'qbuf:' prefix whether that refers
to the mmap, userptr or dmabuf
From: Hans Verkuil hans.verk...@cisco.com
When using write() to write data to an output video node the vb2 core
should set timestamps if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody
else is able to provide this information with the write() operation.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
__qbuf_mmap was sort of hidden in between the much larger __qbuf_userptr
and __qbuf_dmabuf functions. Move it before __qbuf_userptr which is
also conform the usual order these memory models are implemented: first
mmap, then userptr, then dmabuf.
From: Hans Verkuil hans.verk...@cisco.com
q-start_streaming_called is always true, so the WARN_ON check against
it being false can be dropped.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/videobuf2-core.c | 5 ++---
1 file changed, 2 insertions(+), 3
From: Hans Verkuil hans.verk...@cisco.com
The bytesused field of struct v4l2_buffer is not used for multiplanar
formats, so just zero it to prevent it from having some random value.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/videobuf2-core.c | 1 +
1 file
From: Hans Verkuil hans.verk...@cisco.com
The application should really always fill in bytesused for output
buffers, unfortunately the vb2 framework never checked for that.
So for single planar formats replace a bytesused of 0 by the length
of the buffer, and for multiplanar format do the same
From: Hans Verkuil hans.verk...@cisco.com
This is not allowed by the spec and does in fact not make any sense.
Return -EINVAL if this is the case.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/videobuf2-core.c | 9 +
1 file changed, 9 insertions(+)
diff
From: Hans Verkuil hans.verk...@cisco.com
The videobuf2-core did not zero the reserved array of v4l2_plane as it
should.
More serious is the fact that data_offset was not handled correctly:
- for capture devices it was never zeroed, which meant that it was
uninitialized. Unless the driver
From: Hans Verkuil hans.verk...@cisco.com
Added a vb2_fileio_is_active inline function that returns true if fileio
is in progress. Check for this too in mmap() (you don't want apps mmap()ing
buffers used by fileio) and expbuf() (same reason).
In addition drivers should be able to check for this
Hi Hans,
On Wednesday 12 February 2014 16:01:17 Hans Verkuil wrote:
On 02/05/14 17:42, Laurent Pinchart wrote:
Replace the dummy video format operations by pad format operations that
configure the output format.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
Hello,
This patch set implements support for the ADV7611 in the adv7604 driver. It
also comes up with new features such as output format configuration through
pad format operations, hot-plug detect control through GPIO and DT support.
Patches 06/48 to 24/48 and 39/48 replace the subdev video DV
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Laurent Pinchart
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/ths8200.c | 2 --
1 file changed, 2 deletions(-)
diff --git
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 104 +
include/uapi/linux/v4l2-mediabus.h | 4 +-
2 files changed, 107 insertions(+), 1
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 240 +
include/uapi/linux/v4l2-mediabus.h | 6 +-
2 files changed, 245 insertions(+), 1
The video enum_dv_timings operation is deprecated. Implement the
pad-level version of the operation to prepare for the removal of the
video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/tvp7002.c
The subdev EDID ioctls receive a pad field that must reference an
existing pad and an EDID field that must point to a buffer. Validate
both fields in the core code instead of duplicating validation in all
drivers.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
From: Lars-Peter Clausen l...@metafoo.de
We do not want to modify the info string arrays ever, so no need to
waste stack space for them. While we are at it also make them const.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
The ADV7604 has sink pads for its HDMI and analog inputs. Report them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/i2c/adv7604.c | 61 ++---
include/media/adv7604.h | 23 -
2 files changed, 46
From: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/i2c/adv7604.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/i2c/adv7604.c
1 - 100 of 143 matches
Mail list logo
