Re: [PATCH v2 12/48] ths8200: Add pad-level DV timings operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video enum_dv_timings and dv_timings_cap operations are deprecated. Implement the pad-level version of those operations to prepare for the removal of the video version. Signed-off-by: Laurent

Re: [PATCH v2 24/48] tvp7002: Remove deprecated video-level DV timings operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Hans Verkuil

Re: [PATCH v2 13/48] tvp7002: Add pad-level DV timings operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video enum_dv_timings operation is deprecated. Implement the pad-level version of the operation to prepare for the removal of the video version. Signed-off-by: Laurent Pinchart

Re: [PATCH v2 23/48] ths8200: Remove deprecated video-level DV timings operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Hans Verkuil

Re: [PATCH v2 15/48] media: davinci: vpif: Switch to pad-level DV operations

2014-03-11 Thread Prabhakar Lad
Hi Laurent, Thanks for the patch. On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video-level enum_dv_timings and dv_timings_cap operations are deprecated in favor of the pad-level versions. All subdev drivers implement the pad-level versions,

Re: [PATCH v2 16/48] media: staging: davinci: vpfe: Switch to pad-level DV operations

2014-03-11 Thread Prabhakar Lad
Hi Laurent, Thanks for the patch. On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video-level enum_dv_timings and dv_timings_cap operations are deprecated in favor of the pad-level versions. All subdev drivers implement the pad-level versions,

Re: [PATCH v2 39/48] v4l: subdev: Remove deprecated video-level DV timings operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The video enum_dv_timings and dv_timings_cap operations are deprecated and unused. Remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Hans Verkuil

Re: [PATCH v2 06/48] v4l: Add pad-level DV timings subdev operations

2014-03-11 Thread Prabhakar Lad
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar lad --- include/media/v4l2-subdev.h| 4

[PATCH v3 00/14] v4l: ti-vpe: Some VPE fixes and enhancements

2014-03-11 Thread Archit Taneja
This patch set mainly consists of minor fixes for the VPE driver. These fixes ensure the following: - The VPE module can be inserted and removed successively. - Make sure that smaller resolutions like qcif work correctly. - Prevent race condition between firmware loading and an open call to the

[PATCH v3 03/14] v4l: ti-vpe: Use video_device_release_empty

2014-03-11 Thread Archit Taneja
The video_device struct is currently embedded in the driver data struct vpe_dev. A vpe_dev instance is allocated by the driver, and the memory for the vfd is a part of this struct. The v4l2 core, however, manages the removal of the vfd region, through the video_device's .release() op, which

[PATCH v3 01/14] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

2014-03-11 Thread Archit Taneja
VPE has a ctrl parameter which decides how many mem to mem transactions the active job from the job queue can perform. The driver's job_ready() made sure that the number of ready source buffers are sufficient for the job to execute successfully. But it didn't make sure if there are sufficient

[PATCH v3 11/14] v4l: ti-vpe: Fix initial configuration queue data

2014-03-11 Thread Archit Taneja
The vpe output and capture queues are initially configured to default values in vpe_open(). A G_FMT before any S_FMTs will result in these values being populated. The colorspace and bytesperline parameter of this initial configuration are incorrect. This breaks compliance when as we get

[PATCH v3 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

2014-03-11 Thread Archit Taneja
The vpe driver wasn't setting the correct field parameter for dequed CAPTURE type buffers for the case where the captured output is progressive. Set the field to V4L2_FIELD_NONE for the completed destination buffers when the captured output is progressive. For OUTPUT type buffers, a queued

[PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Archit Taneja
Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers). For the CAPTURE type, V4L2_SEL_TGT_COMPOSE results in VPE writing the

[PATCH v3 05/14] v4l: ti-vpe: Allow usage of smaller images

2014-03-11 Thread Archit Taneja
The minimum width and height for VPE input/output was kept as 128 pixels. VPE doesn't have a constraint on the image height, it requires the image width to be at least 16 bytes. Change the minimum supported dimensions to 32x32. This allows us to de-interlace qcif content. A smaller image size

[PATCH v3 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

2014-03-11 Thread Archit Taneja
For OMAP and DRA7x, we generally allocate video and graphics buffers through omapdrm since the corresponding omap-gem driver provides DMM-Tiler backed contiguous buffers. omapdrm is a dma-buf exporter. These buffers are used by other drivers in the video pipeline. Add VB2_DMABUF flag to the

[PATCH v3 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

2014-03-11 Thread Archit Taneja
The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 ++- 1 file changed, 2

[PATCH v3 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

2014-03-11 Thread Archit Taneja
Zero out the reserved formats in v4l2_pix_format_mplane and v4l2_plane_pix_format members of the returned v4l2_format pointer when passed through TRY_FMT ioctl. This ensures that the user doesn't interpret the non-zero fields as some data passed by the driver, and ensures compliance.

[PATCH v3 09/14] v4l: ti-vpe: report correct capabilities in querycap

2014-03-11 Thread Archit Taneja
querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

2014-03-11 Thread Archit Taneja
The dequed CAPTURE_MPLANE type buffers don't contain the flags that the originally queued OUTPUT_MPLANE type buffers have. This breaks compliance. Copy the source v4l2_buffer flags to the destination v4l2_buffer flags before they are dequed. Signed-off-by: Archit Taneja arc...@ti.com ---

[PATCH v3 08/14] v4l: ti-vpe: Rename csc memory resource name

2014-03-11 Thread Archit Taneja
Rename the memory block resource vpe_csc to csc since it also exists within the VIP IP block. This would make the name more generic, and both VPE and VIP DT nodes in the future can use it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/csc.c | 2 +- 1 file changed,

[PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-11 Thread Archit Taneja
vpe fops(vpe_open in particular) should be called only when VPDMA firmware is loaded. File operations on the video device are possible the moment it is registered. Currently, we register the video device for VPE at driver probe, after calling a vpdma helper to initialize VPDMA and load firmware.

[PATCH v3 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

2014-03-11 Thread Archit Taneja
Some parameters of the VPE descriptors were understood incorrectly. They are now fixed. The fixes are explained as follows: - When adding an inbound data descriptor to the VPDMA descriptor list, we intend to use c_rect as the cropped region fetched by VPDMA. Therefore, c_rect-width shouldn't

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Sakari Ailus
On Tue, Mar 11, 2014 at 12:15:38AM +0100, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of duplicating validation in all drivers.

Re: [PATCH 36/47] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Hans Verkuil
On 03/10/14 23:43, Laurent Pinchart wrote: Hi Hans, On Wednesday 12 February 2014 16:01:17 Hans Verkuil wrote: On 02/05/14 17:42, Laurent Pinchart wrote: Replace the dummy video format operations by pad format operations that configure the output format. Signed-off-by: Laurent Pinchart

[PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-11 Thread Arun Kumar K
From: avnd kiran avnd.ki...@samsung.com Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. Since there are two versions of v6 firmware with different interfaces, it is differenciated using the version number read back from

Re: [REVIEW PATCH 1/3] v4l2-subdev.h: add g_tvnorms video op

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 00:32:48 Hans Verkuil wrote: On 03/11/2014 12:23 AM, Guennadi Liakhovetski wrote: Hi Hans, Thanks for taking care about this problem. I'm not sure it would be ok for me to pull this specific patch via my tree, because it's for the V4L2 core, and the

Re: [REVIEW PATCH 1/3] v4l2-subdev.h: add g_tvnorms video op

2014-03-11 Thread Hans Verkuil
On 03/11/14 10:33, Laurent Pinchart wrote: Hi Hans, On Tuesday 11 March 2014 00:32:48 Hans Verkuil wrote: On 03/11/2014 12:23 AM, Guennadi Liakhovetski wrote: Hi Hans, Thanks for taking care about this problem. I'm not sure it would be ok for me to pull this specific patch via my tree,

[PATCH] em28xx: fix PCTV 290e LNA oops

2014-03-11 Thread Antti Palosaari
Pointer to device state has been moved to different location during some change. PCTV 290e LNA function still uses old pointer, carried over FE priv, and it crash. Reported-by: Janne Kujanpää jik...@iki.fi Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/em28xx/em28xx-dvb.c | 3

[PATCH] v4l: subdev: Move [gs]_std operation to video ops

2014-03-11 Thread Laurent Pinchart
The g_std and s_std operations are video-related, move them to the video ops where they belong. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/adv7180.c | 6 +- drivers/media/i2c/adv7183.c | 4 ++--

Re: [PATCH v2 06/48] v4l: Add pad-level DV timings subdev operations

2014-03-11 Thread Hans Verkuil
Reviewed-by: Hans Verkuil hans.verk...@cisco.com On 03/11/14 00:15, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-subdev.h| 4 include/uapi/linux/videodev2.h | 10 -- 2 files changed, 12 insertions(+), 2

[GIT PULL for 3.15] mem2mem patches

2014-03-11 Thread Kamil Debski
The following changes since commit f2d7313534072a5fe192e7cf46204b413acef479: [media] drx-d: add missing braces in drxd_hard.c:DRXD_init (2014-03-09 09:20:50 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git master for you to fetch changes up to

[PATCH] drx-j: use ber_count var

2014-03-11 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/drx39xyj/drxj.c: In function 'ctrl_get_qam_sig_quality': drivers/media/dvb-frontends/drx39xyj/drxj.c:9468:6: warning: variable 'ber_cnt' set but not used [-Wunused-but-set-variable] u32 ber_cnt = 0; /* BER count */ ^ By reading the comment, it is said that

Re: [PATCH v2 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Hans Verkuil
On 03/11/14 00:15, Laurent Pinchart wrote: Validate the pad field in the core code whenever specified. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++

[PATCH] drx-j: Fix post-BER calculus on QAM modulation

2014-03-11 Thread Mauro Carvalho Chehab
There are two troubles there: 1) the bit error measure were not accumulating; 2) it was missing the bit count. Fix them. Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/14 00:15, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of duplicating validation in all drivers. Signed-off-by: Laurent Pinchart

[linuxtv-media:master 499/499] drivers/media/dvb-frontends/drx39xyj/drx39xxj.h:22:0: error: unterminated #ifndef

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 164e5cfb7d37e4826a8337029716f4885657d859 commit: 164e5cfb7d37e4826a8337029716f4885657d859 [499/499] [media] drx39xxj.h: Fix undefined reference to attach function config: make ARCH=m68k allmodconfig All error/warnings: In file included

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 11:45:09 Hans Verkuil wrote: On 03/11/14 00:15, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of

Re: [PATCH v2 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/14 11:57, Laurent Pinchart wrote: Hi Hans, On Tuesday 11 March 2014 11:45:09 Hans Verkuil wrote: On 03/11/14 00:15, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both

Re: [PATCH v2 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 11:38:39 Hans Verkuil wrote: On 03/11/14 00:15, Laurent Pinchart wrote: Validate the pad field in the core code whenever specified. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

cron job: media_tree daily build: ERRORS

2014-03-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 11 11:47:29 CET 2014 git branch: test git hash: 0d49e7761173520ff02cec6f11d581f8ebca764d gcc

Re: [linuxtv-media:master 499/499] drivers/media/dvb-frontends/drx39xyj/drx39xxj.h:22:0: error: unterminated #ifndef

2014-03-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Mar 2014 18:48:53 +0800 kbuild test robot fengguang...@intel.com escreveu: tree: git://linuxtv.org/media_tree.git master head: 164e5cfb7d37e4826a8337029716f4885657d859 commit: 164e5cfb7d37e4826a8337029716f4885657d859 [499/499] [media] drx39xxj.h: Fix undefined reference to

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-11 Thread Philipp Zabel
Hi Laurent, Am Montag, den 10.03.2014, 20:19 +0100 schrieb Laurent Pinchart: On Friday 07 March 2014 18:40:54 Philipp Zabel wrote: While we look at of_graph_get_next_endpoint(), could you explain the reason behind the extra reference count increase on the prev node: /* * Avoid

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 10 Mar 2014 14:37:58 + Grant Likely grant.lik...@linaro.org escreveu: On Mon, 10 Mar 2014 10:26:30 -0300, Mauro Carvalho Chehab m.che...@samsung.com wrote: Em Fri, 07 Mar 2014 18:23:30 + Grant Likely grant.lik...@linaro.org escreveu: On Thu, 06 Mar 2014 18:13:20

Re: [PATCH 36/47] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 10:05:00 Hans Verkuil wrote: On 03/10/14 23:43, Laurent Pinchart wrote: On Wednesday 12 February 2014 16:01:17 Hans Verkuil wrote: On 02/05/14 17:42, Laurent Pinchart wrote: Replace the dummy video format operations by pad format operations that

RE: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Kamil Debski
Hi Arun, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Friday, March 07, 2014 9:26 AM From: Pawel Osciak posc...@chromium.org Currently, for formats that are not H264, MFC driver will check the consumed stream size returned by the firmware and,

Re: [PATCH 36/47] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Hans Verkuil
Hi Laurent, On 03/11/14 12:16, Laurent Pinchart wrote: Hi Hans, On Tuesday 11 March 2014 10:05:00 Hans Verkuil wrote: On 03/10/14 23:43, Laurent Pinchart wrote: On Wednesday 12 February 2014 16:01:17 Hans Verkuil wrote: On 02/05/14 17:42, Laurent Pinchart wrote: Replace the dummy video

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Philipp, On Monday 10 March 2014 16:40:30 Philipp Zabel wrote: Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: On Monday 10 March 2014 14:58:15 Grant Likely wrote: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: On Monday 10 March 2014 12:18:20 Tomi

cron job: media_tree daily build: WARNINGS

2014-03-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 11 12:12:39 CET 2014 git branch: test git hash: 0d49e7761173520ff02cec6f11d581f8ebca764d gcc

Re: [PATCH v2 00/48] ADV7611 support

2014-03-11 Thread Hans Verkuil
Hi Laurent, You can add my: Reviewed-by: Hans Verkuil hans.verk...@cisco.com for patches 28-35, 37-45 and 47. For patches 46 and 48 (DT related) add my: Acked-by: Hans Verkuil hans.verk...@cisco.com For patches 26 and 27 I posted review comments, and patch 36 is removing support for the

Re: [PATCH v3 05/14] v4l: ti-vpe: Allow usage of smaller images

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The minimum width and height for VPE input/output was kept as 128 pixels. VPE doesn't have a constraint on the image height, it requires the image width to be at least 16 bytes. Change the minimum supported dimensions to 32x32. This allows us to

Re: [PATCH v3 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: For OMAP and DRA7x, we generally allocate video and graphics buffers through omapdrm since the corresponding omap-gem driver provides DMM-Tiler backed contiguous buffers. omapdrm is a dma-buf exporter. These buffers are used by other drivers in the video

Re: [PATCH v3 03/14] v4l: ti-vpe: Use video_device_release_empty

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The video_device struct is currently embedded in the driver data struct vpe_dev. A vpe_dev instance is allocated by the driver, and the memory for the vfd is a part of this struct. The v4l2 core, however, manages the removal of the vfd region,

Re: [PATCH v2 01/48] v4l: of: Support empty port nodes

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, On 11/03/14 00:15, Laurent Pinchart wrote: Empty port nodes are allowed but currently unsupported as the v4l2_of_get_next_endpoint() function assumes that all port nodes have at least an endpoint. Fix this. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Hans Verkuil
Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or

Re: [PATCH v3 09/14] v4l: ti-vpe: report correct capabilities in querycap

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com

Re: [PATCH v3 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Signed-off-by: Archit Taneja arc...@ti.com Reviewed-by: Hans

Re: [PATCH v3 11/14] v4l: ti-vpe: Fix initial configuration queue data

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The vpe output and capture queues are initially configured to default values in vpe_open(). A G_FMT before any S_FMTs will result in these values being populated. The colorspace and bytesperline parameter of this initial configuration are incorrect.

Re: [PATCH v3 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: Zero out the reserved formats in v4l2_pix_format_mplane and v4l2_plane_pix_format members of the returned v4l2_format pointer when passed through TRY_FMT ioctl. This ensures that the user doesn't interpret the non-zero fields as some data passed by

Re: [GIT PULL] SDR API

2014-03-11 Thread Antti Palosaari
On 10.03.2014 21:38, Antti Palosaari wrote: That is just same set I sent earlier too, but rebased to latest media/master and 6 small compliance fix. PULL request update. I rebased that again to todays media/master as master was rebased. The following changes since commit

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, Thank you for the patch. On Thursday 06 March 2014 17:20:12 Sylwester Nawrocki wrote: This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells property is needed

Re: [PATCH v3 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The vpe driver wasn't setting the correct field parameter for dequed CAPTURE type buffers for the case where the captured output is progressive. Set the field to V4L2_FIELD_NONE for the completed destination buffers when the captured output is

Re: [PATCH v3 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

2014-03-11 Thread Hans Verkuil
On 03/11/14 09:33, Archit Taneja wrote: The dequed CAPTURE_MPLANE type buffers don't contain the flags that the originally queued OUTPUT_MPLANE type buffers have. This breaks compliance. Copy the source v4l2_buffer flags to the destination v4l2_buffer flags before they are dequed.

Re: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Arun Kumar K
Hi Kamil, On Tue, Mar 11, 2014 at 4:59 PM, Kamil Debski k.deb...@samsung.com wrote: Hi Arun, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Friday, March 07, 2014 9:26 AM From: Pawel Osciak posc...@chromium.org Currently, for formats that are not

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Archit Taneja
On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only

[GIT PULL FOR v3.15] DocBook fixes and a new pci skeleton driver template

2014-03-11 Thread Hans Verkuil
Hi Mauro, This patch series adds a bunch of docbook fixes, posted here earlier: http://www.spinics.net/lists/linux-media/msg74059.html and it adds a pci skeleton driver originally written for FOSDEM 2014 and posted earlier here:

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Hans Verkuil
On 03/11/14 13:46, Archit Taneja wrote: On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Tomi Valkeinen
On 11/03/14 13:43, Laurent Pinchart wrote: We could scan the whole tree for entities, ports and endpoints once, in the base oftree code, and put that into a graph structure, adding the backlinks. The of_graph_* helpers could then use that graph instead of the device tree. That could work.

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 04:15 PM, Laurent Pinchart wrote: Hi Grant, On Monday 10 March 2014 14:58:15 Grant Likely wrote: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: On 08/03/14 13:41, Grant Likely wrote: Ok. If we go for single

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-11 Thread Archit Taneja
On Tuesday 11 March 2014 06:19 PM, Hans Verkuil wrote: On 03/11/14 13:46, Archit Taneja wrote: On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: snip Yes. If for no other reason that I plan on adding

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Tomi, On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: On 11/03/14 13:43, Laurent Pinchart wrote: We could scan the whole tree for entities, ports and endpoints once, in the base oftree code, and put that into a graph structure, adding the backlinks. The of_graph_* helpers could

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Tomi Valkeinen
On 11/03/14 15:16, Laurent Pinchart wrote: And if I gathered Grant's opinion correctly (correct me if I'm wrong), he thinks things should be explicit, i.e. the bindings for, say, an encoder should state that the encoder's output endpoint _must_ contain a remote-endpoint property, whereas the

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, Thanks for your review. On 11/03/14 13:30, Laurent Pinchart wrote: [...] --- .../devicetree/bindings/media/samsung-fimc.txt | 34 - 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt

[PATCH] drx39xyj: fix 64 bit division on 32 bit arch

2014-03-11 Thread Gianluca Gennari
Fix this linker warning: WARNING: __divdi3 [media_build/v4l/drx39xyj.ko] undefined! Signed-off-by: Gianluca Gennari gennar...@gmail.com --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi, Am Dienstag, den 11.03.2014, 15:27 +0200 schrieb Tomi Valkeinen: On 11/03/14 15:16, Laurent Pinchart wrote: And if I gathered Grant's opinion correctly (correct me if I'm wrong), he thinks things should be explicit, i.e. the bindings for, say, an encoder should state that the

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-11 Thread Sylwester Nawrocki
On 10/03/14 07:53, Tomi Valkeinen wrote: On 08/03/14 14:25, Grant Likely wrote: Sure. If endpoints are logical, then only create the ones actually hooked up. No problem there. But nor do I see any issue with having empty connections if the board author things it makes sense to have them in

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Andrzej Hajda
On 03/10/2014 12:42 PM, Laurent Pinchart wrote: Hi Andrzej, I like that idea. I would prefer making the 'port' nodes mandatory and the 'ports' and 'endpoint' nodes optional. Leaving the 'port' node out slightly decreases readability in my opinion, but making the 'endpoint' node optional

Re: [PATCH] saa7134: Add support for SnaZio TvPVR PRO

2014-03-11 Thread Mauro Carvalho Chehab
Em Mon, 10 Feb 2014 07:28:31 +0200 Antti Palosaari cr...@iki.fi escreveu: Moikka! On 10.02.2014 01:44, GEORGE wrote: b/drivers/media/rc/keymaps/rc-snazio-tvpvr-pro.c new file mode 100644 index 000..44f0c81 --- /dev/null +++ b/drivers/media/rc/keymaps/rc-snazio-tvpvr-pro.c @@

Re: [PATCH v6 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, On Tuesday 11 March 2014 14:38:37 Sylwester Nawrocki wrote: Hi Laurent, Thanks for your review. You're welcome. On 11/03/14 13:30, Laurent Pinchart wrote: [...] --- .../devicetree/bindings/media/samsung-fimc.txt | 34 +- 1 file changed, 26

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Philipp Zabel
Hi Grant, Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: On 08/03/14 13:41, Grant Likely wrote: Ok. If we go for single

[PATCH v3 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Laurent Pinchart
Validate the pad field in the core code whenever specified. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- .../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++ .../DocBook/media/v4l/vidioc-enum-dv-timings.xml | 30 +-

[PATCH v3 36/48] adv7604: Make output format configurable through pad format operations

2014-03-11 Thread Laurent Pinchart
Replace the dummy video format operations by pad format operations that configure the output format. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/adv7604.c | 280 include/media/adv7604.h | 56 -

[PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of duplicating validation in all drivers. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sakari

[PATCH v3 42/48] adv7604: Replace *_and_or() functions with *_clr_set()

2014-03-11 Thread Laurent Pinchart
The *_and_or() functions take an 'and' bitmask to be ANDed with the register value before ORing it with th 'or' bitmask. As the functions are used to mask and set bits selectively, this requires the caller to invert the 'and' bitmask and is thus error prone. Replace those functions with a

[PATCH v3 46/48] adv7604: Add DT support

2014-03-11 Thread Laurent Pinchart
Parse the device tree node to populate platform data. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- .../devicetree/bindings/media/i2c/adv7604.txt | 56 + drivers/media/i2c/adv7604.c| 92

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-11 Thread Laurent Pinchart
Hi Philipp, On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: [snip] In theory unidirectional links in DT are indeed enough. However, let's not forget the

[linuxtv-media:master 448/499] ERROR: __divdi3 [drivers/media/dvb-frontends/drx39xyj/drx39xyj.ko] undefined!

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 7b802ce7e8c67510389fdbbe29edd87a75df3a93 commit: 03fdfbfd3b5944bfd210541a83c9b222e2c20920 [448/499] [media] drx-j: Prepare to use DVBv5 stats config: make ARCH=m68k allmodconfig Note: the linuxtv-media/master HEAD

Re: [PATCH v3 26/48] v4l: Add support for DV timings ioctls on subdev nodes

2014-03-11 Thread Hans Verkuil
On 03/11/2014 04:09 PM, Laurent Pinchart wrote: Validate the pad field in the core code whenever specified. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans ---

[GIT PULL] m88ds3103 fixes

2014-03-11 Thread Antti Palosaari
I just noticed from patchwork these old patches are pending. It appears I have not pull requested or mail is just missed from the reason or the other. They are just fine for 3.15, but m88ds3103: fix bug on .set_tone() is stuff for 3.14 too. I know it is very late, but given the fact it fixes

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/2014 04:09 PM, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of duplicating validation in all drivers. Signed-off-by: Laurent

[linuxtv-media:master 446/499] drxj.c:undefined reference to `__divdi3'

2014-03-11 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: c3c2077d9579472b07581ecdaf6cc5a60b1700bc commit: 03fdfbfd3b5944bfd210541a83c9b222e2c20920 [446/499] [media] drx-j: Prepare to use DVBv5 stats config: make ARCH=i386 allyesconfig Note: the linuxtv-media/master HEAD

[PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells and clock-output-names properties to 'camera' node - these are now needed so the image sensor sub-devices can reference clocks provided by the camera host interface, -

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: On 03/11/2014 04:09 PM, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer. Validate both fields in the core code instead of

Re: [GIT PULL] m88ds3103 fixes

2014-03-11 Thread Antti Palosaari
DROP that request! I will split it to 2 requests, one for 3.14 and one for 3.15. Antti On 11.03.2014 17:42, Antti Palosaari wrote: I just noticed from patchwork these old patches are pending. It appears I have not pull requested or mail is just missed from the reason or the other. They are

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Hans Verkuil
On 03/11/2014 05:08 PM, Laurent Pinchart wrote: Hi Hans, On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: On 03/11/2014 04:09 PM, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference an existing pad and an EDID field that must point to a buffer.

[GIT PULL 3.14] m88ds3103 bugfix

2014-03-11 Thread Antti Palosaari
I have forgotten to pull request that earlier. It is simple one bit wrong in one register. regards Antti The following changes since commit 81d428cbdb9e630f4424bf81522cd35394beba76: [media] saa7134: fix WARN_ON during resume (2014-03-11 10:17:06 -0300) are available in the git repository

Re: [PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Laurent Pinchart
Hi Sylwester, Thank you for the patch. On Tuesday 11 March 2014 17:00:35 Sylwester Nawrocki wrote: This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells and clock-output-names properties to 'camera' node - these are

Re: [PATCH v3 27/48] v4l: Validate fields in the core code for subdev EDID ioctls

2014-03-11 Thread Laurent Pinchart
Hi Hans, On Tuesday 11 March 2014 17:11:07 Hans Verkuil wrote: On 03/11/2014 05:08 PM, Laurent Pinchart wrote: Hi Hans, On Tuesday 11 March 2014 16:44:27 Hans Verkuil wrote: On 03/11/2014 04:09 PM, Laurent Pinchart wrote: The subdev EDID ioctls receive a pad field that must reference

[GIT PULL 3.15] m88ds3103 fix non-important issues

2014-03-11 Thread Antti Palosaari
These are reported by Coverity and has no functionality changes. regards Antti The following changes since commit c3c2077d9579472b07581ecdaf6cc5a60b1700bc: [media] nuvoton-cir: Activate PNP device when probing (2014-03-11 12:22:50 -0300) are available in the git repository at:

Re: [PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-11 Thread Sylwester Nawrocki
Hi Laurent, On 11/03/14 17:20, Laurent Pinchart wrote: Image sensor nodes -- @@ -97,8 +108,8 @@ Image sensor nodes The sensor device nodes should be added to their control bus controller (e.g. I2C0) nodes and linked to a port node in the csis or the parallel-ports

  1   2   >