The else statement here is not aligned with the correct if statement.
I think the code works as intended and it's just the indenting which is
wrong. Also kernel style says we should use curly braces here so I have
added those.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This patch
Hi Mikhail,
Thank you for the patch. However, it does need some work before I can accept it.
First of all, run your patch through scripts/checkpatch.pl to ensure it complies
to the kernel coding style.
Secondly, split up this single patch in smaller ones: in particular the addition
of the new
Hi Laurent,
I have a few comments:
On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
The vb2 queue timestamp_flags field must be set by drivers, as enforced
by a WARN_ON in vb2_queue_init. The UVC gadget driver failed to do so.
This resulted in the following warning.
[2.104371] g_webcam gadget: uvc_function_bind
[
On 03/27/2014 12:07 PM, Ma Haijun wrote:
Hi all,
This is a trivial fix, but I think the patch itself has problem too.
The function requires a phys_addr_t, but we feed it with a dma_handle_t.
AFAIK, this implicit conversion does not always work.
Can I use virt_to_phys(mem-vaddr) to get the
Hi Hans,
Thank you for comments, I will rework the patch and document the new
event type.
Let me explain why I created a new thread.
My company is engaged in the monitoring of TV air. All TV channels are
recorded 24/7 for further analysis. But some local TV channels change
the standard over time
On 03/28/2014 10:51 AM, Mikhail Domrachev wrote:
Hi Hans,
Thank you for comments, I will rework the patch and document the new
event type.
Let me explain why I created a new thread.
My company is engaged in the monitoring of TV air. All TV channels are
recorded 24/7 for further analysis.
v4l2-compliance reports unbalanced prepare/finish memops in the case
where buffers are queued, streamon is never called and then reqbufs()
is called that has to cancel any queued buffers.
When canceling a queue __buf_finish_memory() should be called for all
buffers in the state 'PREPARED' or
Is there any chance that the three issues I reported will be fixed? If not,
then I'll work around it in the kernel code.
Regards,
Hans
On 03/15/2014 01:12 PM, Hans Verkuil wrote:
For the record: all these tests were done with a 3.14-rc5 kernel and sparse
compiled from the git tree as
The following changes since commit 8432164ddf7bfe40748ac49995356ab4dfda43b7:
[media] Sensoray 2255 uses videobuf2 (2014-03-24 17:23:43 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v3.16a
for you to fetch changes up to
Hi Hans,
On Friday 28 March 2014 09:50:42 Hans Verkuil wrote:
On 03/23/2014 04:32 PM, Laurent Pinchart wrote:
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart
This supersedes my previous 3.16 pull request of a 15 minutes ago: I had missed
two more relevant davinci patches from Prabhakar. Those are added here.
Regards,
Hans
The following changes since commit 8432164ddf7bfe40748ac49995356ab4dfda43b7:
[media] Sensoray 2255 uses videobuf2
This supersedes [PATCH for v3.15] vb2: call __buf_finish_memory for
prepared/queued buffers. I realized that that patch was for an internal
git branch and didn't apply to the master branch. The fix is the same,
though.
v4l2-compliance reports unbalanced prepare/finish memops in the case
where
It doesn't make sense to just copy the information to the PLL flags. Add a
new fields for the quirks to contain the PLL flags.
Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com
---
drivers/media/i2c/smiapp/smiapp-core.c | 4 +---
drivers/media/i2c/smiapp/smiapp-quirk.c | 2 +-
led_update_brightness helper function used to be exploited
only locally in the led-class.c module, where its result was
being passed to the brightness_show sysfs callback. With the
introduction of v4l2-flash subdevice the same functionality
became required for reading current brightness from a LED
Hello,
These three patches fix miscellaneous issues in the UVC gadget driver. Patches
1 and 3 have already been posted as part of the Clock fixes for UVC gadget
driver series, and patch 2 is new.
The series is based on the latest media tree master branch as it depends on
commit
The UVC gadget driver doesn't support interlaced video but left the
buffer field uninitialized. Set it to V4L2_FIELD_NONE.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_queue.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Hi Sakari,
Thanks for the review.
On 03/24/2014 12:18 AM, Sakari Ailus wrote:
Hi Jacek,
Thanks for the patchset. It's very nice in general. I have a few comments
below.
[...]
diff --git a/include/linux/leds.h b/include/linux/leds.h
index 0287ab2..1bf0ab3 100644
--- a/include/linux/leds.h
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Rob Herring robh...@kernel.org
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark Rutland mark.rutl...@arm.com
Cc: Ian Campbell ijc+devicet...@hellion.org.uk
Cc: Kumar Gala ga...@codeaurora.org
This patch adds device tree binding documentation for
the flash cell of the Maxim max77693 multifunctional device.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Rob Herring robh...@kernel.org
Cc: Pawel Moll pawel.m...@arm.com
Cc: Mark
Hi Sakari,
On 03/24/2014 01:08 AM, Sakari Ailus wrote:
Hi Jacek,
[...]
+static int v4l2_flash_set_intensity(struct v4l2_flash *flash,
+ unsigned int intensity)
+{
+ struct led_classdev *led_cdev = flash-led_cdev;
+ unsigned int fault;
+
Hi,
-Original Message-
On 03/27/2014 12:07 PM, Ma Haijun wrote:
Hi all,
This is a trivial fix, but I think the patch itself has problem too.
The function requires a phys_addr_t, but we feed it with a dma_handle_t.
AFAIK, this implicit conversion does not always work.
Can I
On 03/28/2014 05:02 PM, Laurent Pinchart wrote:
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
On 03/28/2014 05:02 PM, Laurent Pinchart wrote:
The UVC gadget driver doesn't support interlaced video but left the
buffer field uninitialized. Set it to V4L2_FIELD_NONE.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Hi Anton,
On Friday 28 March 2014 07:58:00 Anton Leontiev wrote:
26.03.2014 21:41, Laurent Pinchart wrote:
On Tuesday 25 March 2014 08:40:57 Anton Leontiev wrote:
Set error bit for incomplete buffers when end of buffer is detected by
FID toggling (for example when last transaction with EOF
On Fri, Mar 28, 2014 at 05:02:46PM +0100, Laurent Pinchart wrote:
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Felipe Balbi
Hi Laurent,
On Fri, 28 Mar 2014, Laurent Pinchart wrote:
Hi Guennadi,
Thank you for the patch.
On Thursday 27 March 2014 22:34:07 Guennadi Liakhovetski wrote:
It turns out, that 64-bit compilations sometimes align structs within
other structs on 32-bit boundaries, but in other cases
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Bryan Wu coolo...@gmail.com
Cc: Richard Purdie rpur...@rpsys.net
---
Documentation/leds/leds-class.txt | 52 +
1 file changed, 52 insertions(+)
The table is always declared but is unused when both CONFIG_OF and
CONFIG_MODULES are not set. This results in a compile warning. Fix it by
marking the table as __maybe_unused. The compiler will discard it if
unused.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
This patch adds suppport for external v4l2-flash devices.
The support includes parsing camera-flash DT property
and asynchronous subdevice registration.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
---
Hi Sakari,
On 03/24/2014 02:05 AM, Sakari Ailus wrote:
Hi Jacek,
On Thu, Mar 20, 2014 at 03:51:10PM +0100, Jacek Anaszewski wrote:
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Rob Herring robh...@kernel.org
Cc: Pawel Moll
This patch adds led-flash support to Maxim max77693 chipset.
Device can be exposed to user space through LED subsystem
sysfs interface or through V4L2 subdevice when the support
for Multimedia Framework is enabled. Device supports up to
two leds which can work in flash and torch mode. Leds can
be
Hi Olivier,
Thank you for the patch.
On Friday 28 March 2014 01:42:38 Olivier Langlois wrote:
timestamps in v4l2 buffers returned to userspace are updated in
uvc_video_clock_update() which uses timestamps fetched from
uvc_video_clock_decode() by calling unconditionally ktime_get_ts().
Some LED devices support two operation modes - torch and
flash. This patch provides support for flash LED devices
in the LED subsystem by introducing new sysfs attributes
and kernel internal interface. The attributes being
introduced are: flash_brightness, flash_strobe, flash_timeout,
This is is a second version of the patch series being a follow up
of the discussion on Media summit 2013-10-23, related to the
LED / flash API integration (the notes from the discussion were
enclosed in the message [1], paragraph 5).
The series is based on linux-next next-20140328 and contains
This patch adds helper functions for registering/unregistering
LED class flash devices as V4L2 subdevs. The functions should
be called from the LED subsystem device driver. In case the
Multimedia Framework support is disabled in the kernel config
the functions' empty versions will be used.
On Fri, Mar 28, 2014 at 05:02:47PM +0100, Laurent Pinchart wrote:
The UVC gadget driver doesn't support interlaced video but left the
buffer field uninitialized. Set it to V4L2_FIELD_NONE.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Felipe Balbi ba...@ti.com
Hi Guennadi,
Thank you for the patch.
On Thursday 27 March 2014 22:34:07 Guennadi Liakhovetski wrote:
It turns out, that 64-bit compilations sometimes align structs within
other structs on 32-bit boundaries, but in other cases alignment is done
on 64-bit boundaries, adding padding if
The sub-device names should be unique. Should two identical sensors be
present in the same media device they would be indistinguishable. The names
will change e.g. from vs6555 pixel array to vs6555 1-0010 pixel array.
Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com
---
Hi Guennadi,
On Friday 28 March 2014 18:44:04 Guennadi Liakhovetski wrote:
On Fri, 28 Mar 2014, Laurent Pinchart wrote:
On Thursday 27 March 2014 22:34:07 Guennadi Liakhovetski wrote:
It turns out, that 64-bit compilations sometimes align structs within
other structs on 32-bit
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_queue.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
The vb2 queue timestamp_flags field must be set by drivers, as enforced
by a WARN_ON in vb2_queue_init. The UVC gadget driver failed to do so.
This resulted in the following warning.
[2.104371] g_webcam gadget: uvc_function_bind
[2.105567] [ cut here ]
[
Let me explain why I created a new thread.
My company is engaged in the monitoring of TV air. All TV channels are
recorded 24/7 for further analysis. But some local TV channels change
the standard over time (SECAM-PAL, PAL-SECAM). So the recording
software must be notified about these changes
The smiapp driver is the owner of the sub-devices exposed by the smiapp
driver. This prevents unloading the module whilst it's in use.
Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com
---
drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Hi,
Here are a few fairly trivial fixes and cleanups for the smiapp driver.
--
Regards,
Sakari
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
I have endless problems since upgarding to ubuntu12.04 with my usb
microscope and it's a big problem cos i need it for work.
As suggested in dmesg I have sent you the log.. Interestingly the
em2750 camera is Ok on my desk pc with Xubuntu 12.04... go figure.. But
the desk pC is kinda
On Fri, Mar 28, 2014 at 05:02:48PM +0100, Laurent Pinchart wrote:
The vb2 queue timestamp_flags field must be set by drivers, as enforced
by a WARN_ON in vb2_queue_init. The UVC gadget driver failed to do so.
This resulted in the following warning.
[2.104371] g_webcam gadget:
Hi Laurent,
On Fri, 2014-03-28 at 17:20 +0100, Laurent Pinchart wrote:
Hi Olivier,
Thank you for the patch.
On Friday 28 March 2014 01:42:38 Olivier Langlois wrote:
timestamps in v4l2 buffers returned to userspace are updated in
uvc_video_clock_update() which uses timestamps fetched
Hi Olivier,
On Friday 28 March 2014 17:27:08 Olivier Langlois wrote:
On Fri, 2014-03-28 at 17:20 +0100, Laurent Pinchart wrote:
On Friday 28 March 2014 01:42:38 Olivier Langlois wrote:
timestamps in v4l2 buffers returned to userspace are updated in
uvc_video_clock_update() which uses
tree: git://linuxtv.org/media_tree.git master
head: 3ec40dcfb413214b2874aec858870502b61c2202
commit: 37571b163c15831cd0a213151c21387363dbf15b [498/499] [media] em28xx-dvb:
fix PCTV 461e tuner I2C binding
config: make ARCH=powerpc allmodconfig
All error/warnings:
On Friday 28 March 2014 01:08:56 David Härdeman wrote:
On Thu, Mar 27, 2014 at 11:21:23PM +, James Hogan wrote:
Hi David,
On Thursday 27 March 2014 22:00:37 David Härdeman wrote:
This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2
The patch ignores the fact that NEC32 scancodes
Before applying this, I'm curious, do you have a use case for realtime
time stamps ?
Yes. ffmpeg uses wall clock time to create timestamps for audio packets from
ALSA device.
OK. I suppose I shouldn't drop support for the realtime clock like I wanted
to
then :-)
There
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Mar 29 04:01:37 CET 2014
git branch: test
git hash: 3ec40dcfb413214b2874aec858870502b61c2202
gcc
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch fixes following checkpatch warning,
media/davinci_vpfe/dm365_ipipe.c:1271: WARNING: Missing a blank line after
declarations
media/davinci_vpfe/dm365_ipipe.c:1313: WARNING: Missing a blank line after
declarations
Signed-off-by: Lad,
28.03.2014 20:12, Laurent Pinchart пишет:
+ * Set error flag for incomplete buffer.
+ */
+static void uvc_buffer_check_bytesused(const struct uvc_streaming *const
stream,
No need for the second const keyword here.
I would have used uvc_video_ as a prefix, to be in sync with the
55 matches
Mail list logo
