Hi Sakari,
Thanks for the review.
On 04/16/2014 08:21 PM, Sakari Ailus wrote:
Hi Jacek,
Thanks for the update!
[...]
+static inline enum led_brightness v4l2_flash_intensity_to_led_brightness(
+ struct led_ctrl *config,
+
On 16/04/14 19:15, Steve Cookson wrote:
For no good reason AFAICT the initial resolution is set to 320x240. But
you can just set it to 640x480 (or more likely, 720x480 for NTSC or
720x576 for PAL):
v4l2-ctl -v width=640,height=480
Hi Guys,
The attachments here are sent using tinypic.com.
Hi Nicolas,
On Wednesday 16 April 2014 15:34:06 Nicolas Dufresne wrote:
Previously we where updating the buffer state using __fill_v4l2_buffer
before the state transition was completed through __vb2_dqbuf. This
would cause the V4L2_BUF_FLAG_DONE to be set, which would mean it still
queued.
Split off the removal of the vb2_is_streaming check as requested.
Note that the davinci drivers still have this unnecessary check, but
Prabhakar will remove that himself.
Also fix a compiler warning that I got during the daily build.
Regards,
Hans
--
To unsubscribe from this list: send
From: Hans Verkuil hans.verk...@cisco.com
When compiling this for older kernels using the compatibility build
the compiler complains about uninitialized variables:
In file included from include/linux/kernel.h:20:0,
from include/linux/cache.h:4,
from
From: Hans Verkuil hans.verk...@cisco.com
The stop_streaming op is only called if streaming is in progress,
so drop the unnecessary 'if (!vb2_is_streaming(vq))' check.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Pawel Osciak pa...@osciak.com
Acked-by: Sakari Ailus
The following changes since commit 701b57ee3387b8e3749845b02310b5625fbd8da0:
[media] vb2: Add videobuf2-dvb support (2014-04-16 18:59:29 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v3.16b
for you to fetch changes up to
From: Hans Verkuil hans.verk...@cisco.com
The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.
The int return gave drivers the idea that
Hi Sakari,
Thanks for the review.
On 04/16/2014 07:26 PM, Sakari Ailus wrote:
Hi Jacek,
Thanks for the patch! Comments below.
On Fri, Apr 11, 2014 at 04:56:54PM +0200, Jacek Anaszewski wrote:
This patch adds led-flash support to Maxim max77693 chipset.
A device can be exposed to user space
(restoring the Cc list I cleared accidentally in previous reply)
On 16/04/14 21:29, Rob Herring wrote:
On Wed, Apr 16, 2014 at 12:19 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
On 16/04/14 17:34, Rob Herring wrote:
On Tue, Apr 15, 2014 at 12:34 PM, Sylwester Nawrocki
On 04/17/2014 04:17 AM, Mauro Carvalho Chehab wrote:
Em Thu, 17 Apr 2014 00:33:55 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Mar 2014 13:20:49 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
From: Hans Verkuil
On 04/17/2014 11:18 AM, Steve Cookson wrote:
On 16/04/14 19:15, Steve Cookson wrote:
For no good reason AFAICT the initial resolution is set to 320x240. But
you can just set it to 640x480 (or more likely, 720x480 for NTSC or
720x576 for PAL):
v4l2-ctl -v width=640,height=480
Hi Guys,
On 04/16/2014 09:34 PM, Nicolas Dufresne wrote:
Previously we where updating the buffer state using __fill_v4l2_buffer
before the state transition was completed through __vb2_dqbuf. This
would cause the V4L2_BUF_FLAG_DONE to be set, which would mean it still
queued. The spec says the dqbuf
From: Hans Verkuil hans.verk...@cisco.com
If the saa7134 module is loaded with the saa7134_userptr set to 1,
then USERPTR support is enabled. A check in buffer_prepare
verifies that the pointer is page-aligned.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
This patch series splits up the previous version into smaller
pieces. The previous version is found here:
http://www.spinics.net/lists/linux-media/msg74171.html
Changes since v1:
- Split up the code in smaller parts where possible. The actual conversion
is still a lot of code.
- Added the
From: Hans Verkuil hans.verk...@cisco.com
This is already available from saa7134_dev.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-core.c | 3 +--
drivers/media/pci/saa7134/saa7134-video.c | 24 +++-
From: Hans Verkuil hans.verk...@cisco.com
All dmaqueue's use saa7134_pgtable, so move it into struct saa7134_dmaqueue.
The videobuf_queue priv_data field now points to the dmaqueue struct.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-dvb.c | 2 +-
From: Hans Verkuil hans.verk...@cisco.com
saa7134-alsa used low-level videobuf functions to allocate and sync
DMA buffers. Replace this with saa7134-specific code. These functions
will not be available when we convert to vb2.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
From: Hans Verkuil hans.verk...@cisco.com
Don't calculate this for every buffer, store it globally instead.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-vbi.c | 38 +++--
drivers/media/pci/saa7134/saa7134.h | 1 +
2
From: Hans Verkuil hans.verk...@cisco.com
This will make the next patch a bit easier to read.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-empress.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Use consistent _vbq suffix for videobuf_queue fields.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-video.c | 52 +++
drivers/media/pci/saa7134/saa7134.h | 4 +--
2 files
From: Hans Verkuil hans.verk...@cisco.com
Create consistent _vbq suffix for videobuf_queue fields.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-empress.c | 12 ++--
drivers/media/pci/saa7134/saa7134-video.c | 2 +-
From: Hans Verkuil hans.verk...@cisco.com
Just white space changes to reduce the noise in the following patches.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/saa7134/saa7134-alsa.c| 13
drivers/media/pci/saa7134/saa7134-core.c| 47
Hi Laurent.
On 11/03/14 00:15, Laurent Pinchart wrote:
Parse the device tree node to populate platform data.
Cc: devicet...@vger.kernel.org
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
.../devicetree/bindings/media/i2c/adv7604.txt | 56 +
Hi Laurent,
On 11/03/14 00:15, Laurent Pinchart wrote:
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
On 11/03/14 00:15, Laurent Pinchart wrote:
Add an inv_llc_pol field to platform data to control the clock polarity.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/i2c/adv7604.c | 3 ++-
Currently stk1160_read_reg() uses a stack-allocated char to get the
read control value. This is wrong because usb_control_msg() requires
a kmalloc-ed buffer.
This commit fixes such issue by kmalloc'ating a 1-byte buffer to receive
the read value.
While here, let's remove the urb_buf array which
Hi Sylwester,
Thank you for the review.
On Thursday 17 April 2014 12:59:22 Sylwester Nawrocki wrote:
On 11/03/14 00:15, Laurent Pinchart wrote:
Parse the device tree node to populate platform data.
Cc: devicet...@vger.kernel.org
Signed-off-by: Laurent Pinchart
Hi Sylwester,
On Thursday 17 April 2014 13:17:41 Sylwester Nawrocki wrote:
On 11/03/14 00:15, Laurent Pinchart wrote:
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Signed-off-by: Laurent Pinchart
On 17/04/14 13:45, Laurent Pinchart wrote:
Hi Sylwester,
On Thursday 17 April 2014 13:17:41 Sylwester Nawrocki wrote:
On 11/03/14 00:15, Laurent Pinchart wrote:
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Hi Ben,
On Thursday 17 April 2014 14:00:15 Ben Dooks wrote:
On 17/04/14 13:45, Laurent Pinchart wrote:
Hi Sylwester,
On Thursday 17 April 2014 13:17:41 Sylwester Nawrocki wrote:
On 11/03/14 00:15, Laurent Pinchart wrote:
Add support for the hsync-active, vsync-active and pclk-sample
Hi Sylwester,
On Thursday 17 April 2014 14:36:32 Laurent Pinchart wrote:
On Thursday 17 April 2014 12:59:22 Sylwester Nawrocki wrote:
On 11/03/14 00:15, Laurent Pinchart wrote:
Parse the device tree node to populate platform data.
Cc: devicet...@vger.kernel.org
Signed-off-by:
Em Thu, 17 Apr 2014 11:49:51 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 04/17/2014 04:17 AM, Mauro Carvalho Chehab wrote:
Em Thu, 17 Apr 2014 00:33:55 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 04/17/2014 12:23 AM, Mauro Carvalho Chehab wrote:
Em Mon, 10 Mar 2014
On 17/04/14 15:08, Laurent Pinchart wrote:
static struct i2c_driver adv7604_driver = {
.driver = {
.owner = THIS_MODULE,
.name = adv7604,
+.of_match_table = of_match_ptr(adv7604_of_id),
of_match_ptr() isn't
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 48 ++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c
This one line function is called in a single location. Inline it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
When extracting multiple bits from a single register read the register
once and extract the bits on the read value.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 33
The table is always declared but is unused when both CONFIG_OF and
CONFIG_MODULES are not set. This results in a compile warning. Fix it by
marking the table as __maybe_unused. The compiler will discard it if
unused.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
Hello,
This patch set implements support for the ADV7611 in the adv7604 driver. It
also comes up with new features such as output format configuration through
pad format operations, hot-plug detect control through GPIO and DT support.
I believe I've addressed all comments received on v3 and
The HPD GPIO is used as an output but its direction is never set. Fix
it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add an inv_llc_pol field to platform data to control the clock polarity.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/i2c/adv7604.c | 3 ++-
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 47 +
1 file changed, 43 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Hans Verkuil
The *_and_or() functions take an 'and' bitmask to be ANDed with the
register value before ORing it with th 'or' bitmask. As the functions
are used to mask and set bits selectively, this requires the caller to
invert the 'and' bitmask and is thus error prone. Replace those
functions with a
And set input routing when initializing the device.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 7 +++
include/media/adv7604.h | 2 ++
2 files changed, 9 insertions(+)
diff --git
This allows replacing duplicate code blocks by loops over the arrays.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 248 +---
include/media/adv7604.h
This helps locating duplicates and inserting new headers.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Parse the device tree node to populate platform data. Only the ADV7611
is currently support with DT.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
---
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
Acked-by: Lad, Prabhakar
Replace the dummy video format operations by pad format operations that
configure the output format.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Tested-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c |
Add support for optional GPIO-controlled HPD pins in addition to the
ADV7604-specific hotplug notifier.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 37 +
1
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 35 +--
1 file
The ADV7604 has sink pads for its HDMI and analog inputs. Report them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 61 ++---
include/media/adv7604.h
From: Lars-Peter Clausen l...@metafoo.de
This patch adds support for the Analog Devices ADV7611 HDMI receiver.
The adv7611 is quite similar to the adv7604. It has only one instead of four
HDMI inputs and no analog frontend though. Also some register bits have been
shuffled around, but large parts
Control operations are handled by the control framework and the subdev
control handlers are never called directly. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 7 ---
1 file
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7511.c | 2 --
1 file changed, 2 deletions(-)
diff --git
The subdev EDID ioctls receive a pad field that must reference an
existing pad and an EDID field that must point to a buffer. Validate
both fields in the core code instead of duplicating validation in all
drivers.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Sakari
Wrapping the #define's at a 80 columns boundary just obfuscates the
code. Don't do that.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
---
include/uapi/linux/v4l2-subdev.h |
Validate the pad field in the core code whenever specified.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
.../DocBook/media/v4l/vidioc-dv-timings-cap.xml| 27 +++
From: Lars-Peter Clausen l...@metafoo.de
The file is using u8 which is defined in linux/types.h.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
include/media/adv7604.h | 2
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7842.c | 2 --
1 file changed, 2 deletions(-)
diff --git
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/ad9389b.c | 2 --
1 file changed, 2 deletions(-)
diff --git
From: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/adv7604.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
The video enum_dv_timings operation is deprecated and unused. Remove it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/s5p-tv/hdmiphy_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: Lars-Peter Clausen l...@metafoo.de
We do not want to modify the info string arrays ever, so no need to
waste stack space for them. While we are at it also make them const.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
---
drivers/media/i2c/ths8200.c |
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
---
drivers/media/i2c/tvp7002.c |
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
The video enum_dv_timings operation is deprecated. Implement the
pad-level version of the operation to prepare for the removal of the
video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
The video enum_dv_timings and dv_timings_cap operations are deprecated
and unused. Remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 4 +---
1 file changed, 1
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 288 +
include/uapi/linux/v4l2-mediabus.h | 6 +-
2 files changed, 293 insertions(+), 1
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Acked-by:
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
The video enum_dv_timings operation is deprecated. Implement the
pad-level version of the operation to prepare for the removal of the
video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Lad, Prabhakar
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
The video-level enum_dv_timings and dv_timings_cap operations are
deprecated in favor of the pad-level versions. All subdev drivers
implement the pad-level versions, switch to them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
The video enum_dv_timings and dv_timings_cap operations are deprecated.
Implement the pad-level version of those operations to prepare for the
removal of the video version.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 104 +
include/uapi/linux/v4l2-mediabus.h | 4 +-
2 files changed, 107 insertions(+), 1
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
include/media/v4l2-subdev.h| 4
include/uapi/linux/videodev2.h | 10 --
2 files changed, 12 insertions(+), 2
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 240 +
include/uapi/linux/v4l2-mediabus.h | 6 +-
2 files changed, 245 insertions(+), 1
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 128 +
include/uapi/linux/v4l2-mediabus.h | 4 +-
2 files changed, 131 insertions(+), 1
Hi Thomas,
On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
On Wed, 16 Apr 2014, Laurent Pinchart wrote:
Hi Thomas,
(CC'ing the linux-usb mailing list)
On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote:
On Tue, 15 Apr 2014, Laurent Pinchart wrote:
Hi Thomas,
Hi Laurent,
On 17/04/14 16:13, Laurent Pinchart wrote:
Parse the device tree node to populate platform data. Only the ADV7611
is currently support with DT.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Laurent Pinchart
Hi Sylwester,
On Thursday 17 April 2014 16:39:29 Sylwester Nawrocki wrote:
On 17/04/14 16:13, Laurent Pinchart wrote:
Parse the device tree node to populate platform data. Only the ADV7611
is currently support with DT.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki
On 17/04/14 16:13, Laurent Pinchart wrote:
Add support for the hsync-active, vsync-active and pclk-sample
properties to the DT bindings and control BT.656 mode implicitly.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Laurent Pinchart
On 17/04/14 16:39, Sylwester Nawrocki wrote:
On 17/04/14 16:13, Laurent Pinchart wrote:
Parse the device tree node to populate platform data. Only the ADV7611
is currently support with DT.
Cc: devicet...@vger.kernel.org
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by:
On Thu, 17 Apr 2014, Laurent Pinchart wrote:
Hi Thomas,
On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
On Wed, 16 Apr 2014, Laurent Pinchart wrote:
Hi Thomas,
(CC'ing the linux-usb mailing list)
On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote:
On
Hi Tejun,
On 04/16/2014 03:58 PM, Tejun Heo wrote:
Hello,
Thanks for the review. A brief description of the use-case first.
Token is intended to be used as a large grain lock and once locked,
it can be held in the locked state for long periods of time.
For instance, application will request
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
Operating on the lock should be atomic, which is what devres_update()
is doing. It can be simplified as follows by holding devres_lock
in devm_token_lock().
spin_lock_irqsave(dev-devres_lock, flags);
if (tkn_ptr-status ==
On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
Operating on the lock should be atomic, which is what devres_update()
is doing. It can be simplified as follows by holding devres_lock
in devm_token_lock().
On 04/17/2014 02:10 PM, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
Operating on the lock should be atomic, which is what devres_update()
is doing. It can be simplified as follows by holding devres_lock
in devm_token_lock().
spin_lock_irqsave(dev-devres_lock,
Function del_timer() does not guarantee that timer was really deleted.
If the timer handler is beeing executed at the moment, the function
does nothing. So, we have a race between del_timer() and kfree(), and
it's possible to use already freed memory in the handler.
This is compile-tested only.
Hi Guys,
I've been playing around with this on my Kubuntu 13.10. Apart from the
issue that you know I have of the altera-stapl.ko file arriving in the
wrong directory, I think it's a good basis for moving forwards. What is
the process for including this in the Linux TV baseline?
I feel
Hi Thomas,
On Thursday 17 April 2014 09:53:32 Thomas Pugliese wrote:
On Thu, 17 Apr 2014, Laurent Pinchart wrote:
On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote:
[snip]
As you had mentioned previously, it should be possible to support both
formats by ignoring the endpoint
On 04/17/2014 02:22 PM, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
Please do not implement locking
primitive directly if at all avoidable. Why can't it use a mutex
embedded in the data area of a devres entry? And if you for some
reason have to implement it
Hi Will,
On Monday 14 April 2014 11:27:00 Will Manley wrote:
On Mon, 14 Apr 2014, at 1:34, Laurent Pinchart wrote:
[snip]
Thank you for investigating this, and sorry for the late reply.
I still haven't heard back from Logitech on this issue. I've pinged them,
they might be busy at the
On Mon, Apr 14, 2014 at 10:38 AM, Ben Dooks ben.do...@codethink.co.uk wrote:
On 14/04/14 18:14, Bryan Wu wrote:
On Thu, Apr 10, 2014 at 2:18 PM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
Hi Bryan,
On Tue, 8 Apr 2014, Bryan Wu wrote:
Thanks Josh, I think I will take you point and
1 - 100 of 109 matches
Mail list logo
