Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
Hi Pawel, On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: Hi Laurent, Thanks for the patch. Did you test this to work in fileio mode? Looks like it should, but would like to make sure. No, I haven't tested it. The OMAP4 ISS driver, which is my test target for this patch, doesn't support

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 11:19 AM, Laurent Pinchart wrote: Hi Pawel, On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: Hi Laurent, Thanks for the patch. Did you test this to work in fileio mode? Looks like it should, but would like to make sure. No, I haven't tested it. The OMAP4 ISS driver,

Re: [PATCH/RFC 2/2] libv4l2: release the lock before doing a DQBUF

2014-06-06 Thread Hans de Goede
Hi, On 06/05/2014 05:31 PM, Thiago Santos wrote: In blocking mode, if there are no buffers available the DQBUF will block waiting for a QBUF to be called but it will block holding the streaming lock which will prevent any QBUF from happening, causing a deadlock. Can be tested with: v4l2grab

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
Hi Hans, On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: On 06/06/2014 11:19 AM, Laurent Pinchart wrote: Hi Pawel, On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: Hi Laurent, Thanks for the patch. Did you test this to work in fileio mode? Looks like it should, but would like

Re: [PATCH/RFC v2 1/2] v4l: vb2: Don't return POLLERR during transient buffer underruns

2014-06-06 Thread Hans de Goede
Hi, On 06/05/2014 02:23 PM, Laurent Pinchart wrote: The V4L2 specification states that When the application did not call VIDIOC_QBUF or VIDIOC_STREAMON yet the poll() function succeeds, but sets the POLLERR flag in the revents field. The vb2_poll() function sets POLLERR when the queued

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 11:46 AM, Laurent Pinchart wrote: Hi Hans, On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: On 06/06/2014 11:19 AM, Laurent Pinchart wrote: Hi Pawel, On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: Hi Laurent, Thanks for the patch. Did you test this to work in fileio

Re: [PATCH/RFC v2 1/2] v4l: vb2: Don't return POLLERR during transient buffer underruns

2014-06-06 Thread Hans Verkuil
On 06/06/2014 11:50 AM, Hans de Goede wrote: Hi, On 06/05/2014 02:23 PM, Laurent Pinchart wrote: The V4L2 specification states that When the application did not call VIDIOC_QBUF or VIDIOC_STREAMON yet the poll() function succeeds, but sets the POLLERR flag in the revents field. The

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
On Friday 06 June 2014 11:55:49 Hans Verkuil wrote: On 06/06/2014 11:46 AM, Laurent Pinchart wrote: On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: On 06/06/2014 11:19 AM, Laurent Pinchart wrote: On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: Hi Laurent, Thanks for the patch.

Re: [PATCH/RFC v2 1/2] v4l: vb2: Don't return POLLERR during transient buffer underruns

2014-06-06 Thread Laurent Pinchart
On Friday 06 June 2014 11:58:18 Hans Verkuil wrote: On 06/06/2014 11:50 AM, Hans de Goede wrote: Hi, On 06/05/2014 02:23 PM, Laurent Pinchart wrote: The V4L2 specification states that When the application did not call VIDIOC_QBUF or VIDIOC_STREAMON yet the poll() function

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 03:42 PM, Laurent Pinchart wrote: On Friday 06 June 2014 11:55:49 Hans Verkuil wrote: On 06/06/2014 11:46 AM, Laurent Pinchart wrote: On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: On 06/06/2014 11:19 AM, Laurent Pinchart wrote: On Friday 06 June 2014 14:31:15 Pawel Osciak

Re: [PATCH v3 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Hans Verkuil
On 06/06/2014 03:53 PM, Laurent Pinchart wrote: When a fatal error occurs that render the device unusable, the only options for a driver to signal the error condition to userspace is to set the V4L2_BUF_FLAG_ERROR flag when dequeuing buffers and to return an error from the buffer prepare

[PATCH v3 0/2] vb2: Report POLLERR for fatal errors only

2014-06-06 Thread Laurent Pinchart
Hello, This patch set modifies the vb2 implementation of the poll() operation to set the POLLERR flag for fatal errors only. The rationale and implementation details are explained in the individual commit messages. Changes since v2: - Return POLLERR when not streaming only when no buffers are

[PATCH v3 1/2] v4l: vb2: Don't return POLLERR during transient buffer underruns

2014-06-06 Thread Laurent Pinchart
The V4L2 specification states that When the application did not call VIDIOC_QBUF or VIDIOC_STREAMON yet the poll() function succeeds, but sets the POLLERR flag in the revents field. The vb2_poll() function sets POLLERR when the queued buffers list is empty, regardless of whether this is caused

[PATCH v3 2/2] v4l: vb2: Add fatal error condition flag

2014-06-06 Thread Laurent Pinchart
When a fatal error occurs that render the device unusable, the only options for a driver to signal the error condition to userspace is to set the V4L2_BUF_FLAG_ERROR flag when dequeuing buffers and to return an error from the buffer prepare handler when queuing buffers. The buffer error flag

Re: [PATCH] staging: omap4iss: copy paste error in iss_get_clocks

2014-06-06 Thread Laurent Pinchart
Hi Vitaly, Thank you for the patch. On Thursday 05 June 2014 17:07:48 Vitaly Osipov wrote: It makes more sense to return PTR_ERR(iss-iss_ctrlclk) here. The current code looks like an oversight in pasting the block just above this one. Signed-off-by: Vitaly Osipov vitaly.osi...@gmail.com

[PATCH 1/5] v4l: omap4iss: Don't reinitialize the video qlock at every streamon

2014-06-06 Thread Laurent Pinchart
Initialize the spin lock once only when initializing the video object. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/iss_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c

[PATCH 4/5] v4l: omap4iss: Signal fatal errors to the vb2 queue

2014-06-06 Thread Laurent Pinchart
When a fatal error occurs in the pipeline signal it to the vb2 queue with a call to vb2_queue_error(). The queue will then take care to return -EIO when preparing buffers, remove the driver-specific code that now duplicates that check. Signed-off-by: Laurent Pinchart

[PATCH 0/5] OMAP4 ISS: Miscellaneous fixes and improvements

2014-06-06 Thread Laurent Pinchart
Hello, This patch set brings miscellaneous fixes and improvements to the OMAP4 ISS driver. Please see individual patches for details. Patch 4/5 depends on the vb2: Report POLLERR for fatal errors only patch series posted to the linux-media mailing list. I plan to send a pull request that will

[PATCH 3/5] v4l: omap4iss: Use the devm_* managed allocators

2014-06-06 Thread Laurent Pinchart
This simplifies remove and error code paths. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/iss.c | 84 1 file changed, 8 insertions(+), 76 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss.c

[PATCH 5/5] MAINTAINERS: Add the OMAP4 ISS driver

2014-06-06 Thread Laurent Pinchart
Update the OMAP Image Signal Processor entry to cover both the OMAP3 ISP and OMAP4 ISS. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6b7c633..6f2f537 100644

[PATCH 2/5] v4l: omap4iss: Add module debug parameter

2014-06-06 Thread Laurent Pinchart
The parameter is used to initialize the video node debug field and activate the V4L debug infrastructure. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/iss_video.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Lars-Peter Clausen
On 06/06/2014 05:49 PM, Ben Dooks wrote: On 05/06/14 13:55, Mauro Carvalho Chehab wrote: Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media topic/adv76xx For adv7604 driver updates, including DT support. Can we use the adv7611 for the adv7612 with

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Ben Dooks
On 05/06/14 13:55, Mauro Carvalho Chehab wrote: Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media topic/adv76xx For adv7604 driver updates, including DT support. Can we use the adv7611 for the adv7612 with these? -- Ben Dooks

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Ben Dooks
On 06/06/14 16:51, Lars-Peter Clausen wrote: On 06/06/2014 05:49 PM, Ben Dooks wrote: On 05/06/14 13:55, Mauro Carvalho Chehab wrote: Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media topic/adv76xx For adv7604 driver updates, including DT

rcar_vin, soc_camera and videobuf2

2014-06-06 Thread Ian Molton
Hi folks, A colleague and I have been attempting to debug issues with rcar_vin, soc_camera, and videobuf2. Presently, We're using the adv7180 frontend to feed composite video to the rcar hardware. Using the streamer utility from xawtv3 (as packaged by wheezy), we have been able to capture

Re: rcar_vin, soc_camera and videobuf2

2014-06-06 Thread Ian Molton
[[sorry for the repost - fixing CC's]] Hi folks, A colleague and I have been attempting to debug issues with rcar_vin, soc_camera, and videobuf2. Presently, We're using the adv7180 frontend to feed composite video to the rcar hardware. Using the streamer utility from xawtv3 (as packaged by

Re: hdpvr troubles

2014-06-06 Thread Scott Doty
On 06/02/2014 06:23 PM, Scott Doty wrote: Hello Mr. Hans and mailing list, In a nutshell, I'm having some hdpvr trouble: I'm using vlc to view the stream. Kernel 3.9.11 works pretty well, including giving me AC3 5.1 audio from the optical input to the Hauppauge device. The only problem

[PATCH] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code that putting values to the same variable twice

2014-06-06 Thread Rickard Strandqvist
Instead of putting the same variable twice, was rather intended to set this value to two different variable. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

fusion hdtv dual express 2

2014-06-06 Thread James Harper
After confirming that it was supported I just bought a fusion hdtv dual express PCI adapter, only to find that I'd bought the 'dual express 2' version, which isn't supported (not the first time I've made such a mistake). This page

RE: fusion hdtv dual express 2

2014-06-06 Thread James Harper
Hi James, The first basic thing you should look at is if the dvb device has got all its pieces. A dvb adapter has, sort of, 4 sub-devices: [me@home ~]$ ll /dev/dvb/adapter2 total 0 crw-rw+ 1 root video 212, 12 Jun 5 12:31 demux0 crw-rw+ 1 root video 212, 13 Jun 5 12:31 dvr0

cron job: media_tree daily build: OK

2014-06-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jun 7 04:00:38 CEST 2014 git branch: test git hash: 5ea878796f0a1d9649fe43a6a09df53d3915c0ef gcc

em28xx: New device @ 480 Mbps (eb1a:2861, interface 0, class 0)

2014-06-06 Thread Alexi Nones
Hi, I've made tests with an August ​device.​ Model: August VGB200 USB 2.0 Video capture adapter idVendor=eb1a, idProduct=2861 I couldn't get analogue capture to work in Debian Linux using VLC​. The manufacturer's website for the device is: http://www.augustint.com/en/productmsg-90-125.html

Ping: [PATCH 0/10] drivers/media/rc/ati_remote.c tweaks

2014-06-06 Thread George Spelvin
Just a ping... has anyone looked at this? (David Härdeman added to recipients list.) The series can be found in the linux-media archives stating at mid:2014051113.14427.qm...@ns.horizon.com http://www.spinics.net/lists/linux-media/msg76435.html

RE: fusion hdtv dual express 2 (working, kind of)

2014-06-06 Thread James Harper
OK I have picture in mythtv now, but it's very glitchy (lines in video, bursts of high pitched tone in audio). In fact it is behaving much like the dib0700 based adapter that I replaced with the express2 adapter because I thought it had died. Could there been a regression somewhere? I'll check