[PATCH] s5p-jpeg: exynos3250: fix erroneous reset procedure

2015-02-25 Thread Jacek Anaszewski
The first while loop in the function exynos3250_jpeg_reset had no chance to be executed because the reg variable was initialized to 0. Initialize reg variable to 1 to fix the issue. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Reported-by: Andrzej Pietrasiewicz andrze...@samsung.com

Re: [REVIEW PATCH 3/3] smiapp: Use __v4l2_ctrl_grab() to grab controls

2015-02-25 Thread Hans Verkuil
On 02/25/15 14:57, Sakari Ailus wrote: Hi Hans, On Wed, Feb 25, 2015 at 02:45:58PM +0100, Hans Verkuil wrote: ... @@ -1535,15 +1529,15 @@ static int smiapp_set_stream(struct v4l2_subdev *subdev, int enable) if (sensor-streaming == enable) goto out; - if (enable) {

Re: [REVIEW PATCH 3/3] smiapp: Use __v4l2_ctrl_grab() to grab controls

2015-02-25 Thread Sakari Ailus
Hi Hans, On Wed, Feb 25, 2015 at 03:14:16PM +0100, Hans Verkuil wrote: On 02/25/15 14:57, Sakari Ailus wrote: Hi Hans, On Wed, Feb 25, 2015 at 02:45:58PM +0100, Hans Verkuil wrote: ... @@ -1535,15 +1529,15 @@ static int smiapp_set_stream(struct v4l2_subdev *subdev, int enable)

Re: [PATCH] media: em28xx replace printk in dprintk macros

2015-02-25 Thread Mauro Carvalho Chehab
Em Tue, 24 Feb 2015 19:45:50 -0800 Joe Perches j...@perches.com escreveu: On Tue, 2015-02-24 at 16:41 -0700, Shuah Khan wrote: On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote: Em Tue, 24 Feb 2015 11:53:47 -0700 Shuah Khan shua...@osg.samsung.com escreveu: Replace printk macro in

[REVIEW PATCH 2/3] smiapp: Correctly serialise stream start / stop

2015-02-25 Thread Sakari Ailus
From: Sakari Ailus sakari.ai...@linux.intel.com The stream state was stored in sensor-streaming, but access to it was not serialised properly. Fix this by moving the mutex to smiapp_set_stream(). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- drivers/media/i2c/smiapp/smiapp-core.c

[REVIEW PATCH 0/3] Add unlocked v4l2_grab_ctrl(), use it in smiapp driver

2015-02-25 Thread Sakari Ailus
Hi, This patchset adds an unlocked variant of v4l2_grab_ctrl() which then is used by the smiapp driver. -- Regards, Sakari -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

[REVIEW PATCH 3/3] smiapp: Use __v4l2_ctrl_grab() to grab controls

2015-02-25 Thread Sakari Ailus
From: Sakari Ailus sakari.ai...@linux.intel.com Instead of returning -EBUSY in s_ctrl(), use __v4l2_ctrl_grab() to mark the controls grabbed. Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- drivers/media/i2c/smiapp/smiapp-core.c | 20 +++- 1 file changed, 7

[REVIEW PATCH 1/3] v4l: Add an unlocked variant of v4l2_grab_ctrl()

2015-02-25 Thread Sakari Ailus
From: Sakari Ailus sakari.ai...@linux.intel.com Commonly the control mutex is shared with the rest of the driver, which already holds the mutex when accessing the control framework. Add unlocked v4l2_grab_ctrl(), __v4l2_grab_ctrl() for this purpose. Signed-off-by: Sakari Ailus

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Shuah Khan
On 02/24/2015 10:29 AM, Devin Heitmueller wrote: This patch addresses a regression introduced in the following patch: commit 5264a522a597032c009f9143686ebf0fa4e244fb Author: Shuah Khan shua...@osg.samsung.com Date: Mon Sep 22 21:30:46 2014 -0300 [media] media: tuner xc5000 - release

Re: [REVIEW PATCH 3/3] smiapp: Use __v4l2_ctrl_grab() to grab controls

2015-02-25 Thread Sakari Ailus
Hi Hans, On Wed, Feb 25, 2015 at 02:45:58PM +0100, Hans Verkuil wrote: ... @@ -1535,15 +1529,15 @@ static int smiapp_set_stream(struct v4l2_subdev *subdev, int enable) if (sensor-streaming == enable) goto out; - if (enable) { - sensor-streaming = true;

Re: [REVIEW PATCH 3/3] smiapp: Use __v4l2_ctrl_grab() to grab controls

2015-02-25 Thread Hans Verkuil
On 02/25/15 15:22, Sakari Ailus wrote: Hi Hans, On Wed, Feb 25, 2015 at 03:14:16PM +0100, Hans Verkuil wrote: On 02/25/15 14:57, Sakari Ailus wrote: Hi Hans, On Wed, Feb 25, 2015 at 02:45:58PM +0100, Hans Verkuil wrote: ... @@ -1535,15 +1529,15 @@ static int smiapp_set_stream(struct

Re: [REVIEW PATCH 3/3] smiapp: Use __v4l2_ctrl_grab() to grab controls

2015-02-25 Thread Hans Verkuil
Hi Sakari, Thanks for the patch series, but I have one question, see below. On 02/25/15 13:33, Sakari Ailus wrote: From: Sakari Ailus sakari.ai...@linux.intel.com Instead of returning -EBUSY in s_ctrl(), use __v4l2_ctrl_grab() to mark the controls grabbed. Signed-off-by: Sakari Ailus

[PATCHv3] media.h: mark alsa struct in media_entity_desc as TODO

2015-02-25 Thread Hans Verkuil
The alsa struct in struct media_entity_desc is now marked as deprecated. However, the alsa struct should remain as it is since it cannot be replaced by a simple major/minor device node description. The alsa struct was designed to be used as an alsa card description so V4L2 drivers could use this

[PATCH] media: omap3isp: use vb2_buffer_state enum for vb2 buffer state

2015-02-25 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com use the vb2_buffer_state enum for assigning the state of the vb2 buffer, along side making isp_pipeline_state state variable local to the block. This fixes the following sparse warning as well: drivers/media/platform/omap3isp/ispvideo.c:497:35:

[PATCH] cx18: Fix bytes_per_line

2015-02-25 Thread Simon Farnsworth
Current GStreamer userspace respects the bytes_per_line from the driver. Set it to something reasonable for the format chosen. Signed-off-by: Simon Farnsworth simon.farnswo...@onelan.co.uk --- I'm hoping this is trivially correct - I've only tested UYVY. drivers/media/pci/cx18/cx18-driver.h |

Re: i.MX6 Video combiner

2015-02-25 Thread Steve Longerbeam
On 02/25/2015 02:57 AM, Jean-Michel Hautbois wrote: Hi all, I read in the i.MX6 TRM that it can do combining or deinterlacing with VDIC. Has it been tested by anyone ? Could it be a driver, which would allow to do some simple compositing of souces ? Thanks, JM I've added VDIC support

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Devin Heitmueller
I would request you to add a comment here indicating the hybrid case scenario to avoid any future cleanup type work deciding there is no need to set priv-firmware to null since priv gets released in hybrid_tuner_release_state(priv); No, I'm not going to rebase my tree and regenerate the patch

Re: i.MX6 Video combiner

2015-02-25 Thread Steve Longerbeam
On 02/25/2015 09:37 AM, Steve Longerbeam wrote: On 02/25/2015 02:57 AM, Jean-Michel Hautbois wrote: Hi all, I read in the i.MX6 TRM that it can do combining or deinterlacing with VDIC. Has it been tested by anyone ? Could it be a driver, which would allow to do some simple compositing of

Re: 0001-media-vb2-Fill-vb2_buffer-with-bytesused-from-user.patch

2015-02-25 Thread Jean-Michel Hautbois
Hi Sudip, 2015-02-25 19:23 GMT+01:00 Jeremiah Mahler jmmah...@gmail.com: Sudip, On Wed, Feb 25, 2015 at 03:29:22PM +0800, Sudip JAIN wrote: Dear Maintainer, PFA attached patch that prevents user from being returned garbage bytesused value from vb2 framework. Regards, Sudip Jain

Re: i.MX6 Video combiner

2015-02-25 Thread Jean-Michel Hautbois
Hi Steve, 2015-02-25 18:54 GMT+01:00 Steve Longerbeam slongerb...@gmail.com: On 02/25/2015 09:37 AM, Steve Longerbeam wrote: On 02/25/2015 02:57 AM, Jean-Michel Hautbois wrote: Hi all, I read in the i.MX6 TRM that it can do combining or deinterlacing with VDIC. Has it been tested by anyone

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Antti Palosaari
On 02/25/2015 07:56 PM, Devin Heitmueller wrote: I would request you to add a comment here indicating the hybrid case scenario to avoid any future cleanup type work deciding there is no need to set priv-firmware to null since priv gets released in hybrid_tuner_release_state(priv); No, I'm not

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Devin Heitmueller
These are just the issues I would like to implement drivers as standard I2C driver model =) Attaching driver for one chip twice is ugly hack! While I'm not arguing the merits of using the standard I2C driver model, it won't actually help in this case since we would still need a structure

Re: 0001-media-vb2-Fill-vb2_buffer-with-bytesused-from-user.patch

2015-02-25 Thread Jeremiah Mahler
Sudip, On Wed, Feb 25, 2015 at 03:29:22PM +0800, Sudip JAIN wrote: Dear Maintainer, PFA attached patch that prevents user from being returned garbage bytesused value from vb2 framework. Regards, Sudip Jain Patches should never be submitted as attachments, they should be inline. See

Re: [PATCH] xc5000: fix memory corruption when unplugging device

2015-02-25 Thread Mauro Carvalho Chehab
Em Wed, 25 Feb 2015 13:37:07 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: These are just the issues I would like to implement drivers as standard I2C driver model =) Attaching driver for one chip twice is ugly hack! While I'm not arguing the merits of using the standard

Re: i.MX6 Video combiner

2015-02-25 Thread Jean-Michel Hautbois
2015-02-25 22:44 GMT+01:00 Steve Longerbeam slongerb...@gmail.com: On 02/25/2015 11:40 AM, Jean-Michel Hautbois wrote: Hi Steve, 2015-02-25 18:54 GMT+01:00 Steve Longerbeam slongerb...@gmail.com: On 02/25/2015 09:37 AM, Steve Longerbeam wrote: On 02/25/2015 02:57 AM, Jean-Michel Hautbois

Re: i.MX6 Video combiner

2015-02-25 Thread Steve Longerbeam
On 02/25/2015 11:40 AM, Jean-Michel Hautbois wrote: Hi Steve, 2015-02-25 18:54 GMT+01:00 Steve Longerbeam slongerb...@gmail.com: On 02/25/2015 09:37 AM, Steve Longerbeam wrote: On 02/25/2015 02:57 AM, Jean-Michel Hautbois wrote: Hi all, I read in the i.MX6 TRM that it can do combining or

[PATCH] rc-core: fix dib0700 scancode generation for RC5

2015-02-25 Thread David Härdeman
David, could you please test this patch? --- drivers/media/usb/dvb-usb/dib0700_core.c | 70 +- 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c index 50856db..605b090

[PATCH] [media] saa7164: use an MSI interrupt when available

2015-02-25 Thread Brendan McGrath
From: Brendan McGrath red...@redmandi.dyndns.org [media] saa7164: use an MSI interrupt when available Fixes a known crash which most commonly occurs when multiple saa7164 chips are in use. Signed-off-by: Brendan McGrath red...@redmandi.dyndns.org --- drivers/media/pci/saa7164/saa7164-core.c

cron job: media_tree daily build: WARNINGS

2015-02-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Feb 26 04:00:20 CET 2015 git branch: test git hash: 8a26a258bdb82db241cdc35f332f88dd67bdb9c9 gcc

Re: [PATCH v5 3/4] media: ov2640: add primary dt support

2015-02-25 Thread Lad, Prabhakar
Hi Josh, On Wed, Feb 25, 2015 at 3:54 AM, Josh Wu josh...@atmel.com wrote: Hi, Prabhakar Lad On 2/17/2015 12:48 AM, Lad, Prabhakar wrote: Hi Josh, Thanks for the patch. On Tue, Feb 10, 2015 at 9:31 AM, Josh Wu josh...@atmel.com wrote: [Snip] - priv-clk =

Re: [PATCH v2] media: i2c: add support for omnivision's ov2659 sensor

2015-02-25 Thread Sakari Ailus
Hi Prabhakar, Lad, Prabhakar wrote: ... + +For further reading on port node refer to +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example: + + i2c0@1c22000 { + ... + ... + ov2659@30 { + compatible =

Re: [PATCH v2] media: i2c: add support for omnivision's ov2659 sensor

2015-02-25 Thread Lad, Prabhakar
Hi Sakari, Thanks for the review. On Thu, Feb 26, 2015 at 12:18 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, Lad, Prabhakar wrote: ... + +For further reading on port node refer to +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example: + +

[linuxtv-media:master 332/350] drivers/media/usb/cx231xx/cx231xx-cards.c:1553:15: error: 'struct v4l2_device' has no member named 'mdev'

2015-02-25 Thread kbuild test robot
Hi Mauro, FYI, the error/warning still remains. You may either fix it or ask me to silently ignore in future. tree: git://linuxtv.org/media_tree.git master head: 8a26a258bdb82db241cdc35f332f88dd67bdb9c9 commit: 1d058bdcf5cc800fbfeece0204f7774556d341bb [332/350] [media] cx231xx: add media

[linuxtv-media:master 338/350] drivers/media/v4l2-core/tuner-core.c:440:7: error: 'struct v4l2_subdev' has no member named 'entity'

2015-02-25 Thread kbuild test robot
Hi Mauro, FYI, the error/warning still remains. You may either fix it or ask me to silently ignore in future. tree: git://linuxtv.org/media_tree.git master head: 8a26a258bdb82db241cdc35f332f88dd67bdb9c9 commit: 00a5a4bf7bb40fe8cd5de042948b925c54b016de [338/350] [media] tuner-core: properly

RE: 0001-media-vb2-Fill-vb2_buffer-with-bytesused-from-user.patch; kernel version 3.10.69

2015-02-25 Thread Sudip JAIN
Hello Jeremiah, Please find the patch inline commit 3390900680e5182998916c8fa231bc79cd84046b Author: Sudip Jain sudip.j...@st.com Date: Thu Feb 26 10:40:34 2015 +0530 media: vb2: Fill vb2_buffer with bytesused from user In vb2_qbuf for dmabuf memory type, userside bytesused is

i.MX6 Video combiner

2015-02-25 Thread Jean-Michel Hautbois
Hi all, I read in the i.MX6 TRM that it can do combining or deinterlacing with VDIC. Has it been tested by anyone ? Could it be a driver, which would allow to do some simple compositing of souces ? Thanks, JM -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of