cron job: media_tree daily build: WARNINGS

2016-06-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jun 17 04:00:23 CEST 2016 git branch: test git hash: 59f0bc11848f8f3242bc1fefae670e745929cd7b gcc

Re: Need help with ir-keytable imon bug report

2016-06-16 Thread Mauro Carvalho Chehab
HI Gregor, Em Wed, 15 Jun 2016 22:25:06 +0200 Gregor Jasny escreveu: > Hello, > > could someone please help me triaging the following ir-keytable bug? The > reporter complains that the 'other' IR protocol results in double clicks > and we should set the device to RC6

[PATCH 1/6] [media] s5p-mfc: set capablity bus_info as required by VIDIOC_QUERYCAP

2016-06-16 Thread Javier Martinez Canillas
The driver doesn't set the struct v4l2_capability bus_info field so the v4l2-compliance tool reports the following errors for VIDIOC_QUERYCAP: Required ioctls: VIDIOC_QUERYCAP returned 0 (Success) fail: v4l2-compliance.cpp(304): string empty fail:

[PATCH 0/6] [media] Fixes and improvements for VIDIOC_QUERYCAP in Samsung media drivers

2016-06-16 Thread Javier Martinez Canillas
Hello, This series contains some fixes and improvements for the VIDIOC_QUERYCAP ioctl handler in different media platform drivers for IP blocks found in Exynos SoCs. Some of the issues were reported by the v4l2-compliance tool while others are things I noticed while looking at the Driver name,

[PATCH 3/6] [media] s5p-jpeg: set capablity bus_info as required by VIDIOC_QUERYCAP

2016-06-16 Thread Javier Martinez Canillas
The driver doesn't set the struct v4l2_capability cap_info field so the v4l2-compliance tool reports the following errors for VIDIOC_QUERYCAP: Required ioctls: VIDIOC_QUERYCAP returned 0 (Success) fail: v4l2-compliance.cpp(304): string empty fail:

[PATCH 6/6] [media] gsc-m2m: improve v4l2_capability driver and card fields

2016-06-16 Thread Javier Martinez Canillas
According to the V4L2 documentation the driver and card fields should be used to identify the driver and the device but the gsc-m2m driver fills those field using the platform device name, which in turn is the name of the device DT node. So not only the filled information isn't correct but also

[PATCH 4/6] [media] s5p-jpeg: only fill driver's name in capabilities driver field

2016-06-16 Thread Javier Martinez Canillas
The driver fills in both the struct v4l2_capability driver and card fields the same values, that is the driver's name plus the information if the dev is a decoder or an encoder. But the driver field has a fixed length of 16 bytes so the filled data is truncated: Driver Info (not using libv4l2):

[PATCH 5/6] [media] gsc-m2m: add device name sufix to bus_info capatiliby field

2016-06-16 Thread Javier Martinez Canillas
The driver doesn't set the device in the struct v4l2_capability bus_info field so v4l2-compliance reports the following error for VIDIOC_QUERYCAP: Required ioctls: fail: v4l2-compliance.cpp(537): missing bus_info prefix ('platform') test VIDIOC_QUERYCAP: FAIL This patch

[PATCH 2/6] [media] s5p-mfc: improve v4l2_capability driver and card fields

2016-06-16 Thread Javier Martinez Canillas
According to the V4L2 documentation the driver and card fields should be used to identify the driver and the device but the s5p-mfc driver fills those field using the platform device name, which in turn is the name of the device DT node. So not only the filled information isn't correct but also

Re: [PATCHv16 10/13] cec: adv7842: add cec support

2016-06-16 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2016 15:52:25 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add CEC support to the adv7842 driver. > > Signed-off-by: Hans Verkuil Won't review patches 10-13, as the same reviews I made for patch 9

Re: [PATCHv16 09/13] cec: adv7604: add cec support.

2016-06-16 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2016 15:52:24 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add CEC support to the adv7604 driver. > > Signed-off-by: Hans Verkuil > [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans

Re: [PATCHv16 08/13] DocBook/media: add CEC documentation

2016-06-16 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2016 15:52:23 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add DocBook documentation for the CEC API. Please always send the documentation patch *before* the code, in order to make easier to do the code review. > >

Re: [PATCHv16 07/13] cec.txt: add CEC framework documentation

2016-06-16 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2016 15:52:22 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Document the new HDMI CEC framework. As we'll be moving documentation to Sphinx/Rst, it would be good if you could make it work fine with sphinx, as this will likely be

Re: [PATCHv16 05/13] cec/TODO: add TODO file so we know why this is still in staging

2016-06-16 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2016 15:52:20 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Explain why cec.c is still in staging. Hmm... as this is for staging, even having pointed several things to be improved, I may end merging this series. Will decide

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Shuah Khan
On 06/16/2016 12:43 PM, Max Kellermann wrote: > On 2016/06/16 18:24, Shuah Khan wrote: >> On 06/15/2016 02:15 PM, Max Kellermann wrote: >>> media_gobj_destroy() may be called twice on one instance - once by >>> media_device_unregister() and again by

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Max Kellermann
On 2016/06/16 18:24, Shuah Khan wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > media_gobj_destroy() may be called twice on one instance - once by > > media_device_unregister() and again by dvb_media_device_free(). The > > function media_remove_intf_links()

Re: [PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

2016-06-16 Thread Max Kellermann
On 2016/06/16 18:06, Shuah Khan wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > Don't free the object until the file handle has been closed. Fixes > > use-after-free bug which occurs when I disconnect my DVB-S received > > while VDR is running. > > Which file

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-16 Thread Nicolas Dufresne
Le jeudi 16 juin 2016 à 10:02 -0700, Steve Longerbeam a écrit : > I found the cause at least in my case. After enabling dynamic debug in > videobuf2-dma-contig.c, "v4l2-ctl -d/dev/video0 --stream-user=8" gives > me > > [  468.826046] user data must be aligned to 64 bytes > > > > But even

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-16 Thread Nicolas Dufresne
Le jeudi 16 juin 2016 à 10:02 -0700, Steve Longerbeam a écrit : > I found the cause at least in my case. After enabling dynamic debug in > videobuf2-dma-contig.c, "v4l2-ctl -d/dev/video0 --stream-user=8" gives > me > > [  468.826046] user data must be aligned to 64 bytes > > > > But even

[RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

2016-06-16 Thread Janusz Krzysztofik
As requested by media subsystem maintainers, here is an attempt to convert the omap1_camera driver to the vb2 framework. Also, conversion to the dmaengine framework, long awaited by ARM/OMAP maintainers, is done. Next, I'm going to approach removal of soc-camera dependency. Please let me know

[RFC] [PATCH 1/3] staging: media: omap1: drop videobuf-dma-sg mode

2016-06-16 Thread Janusz Krzysztofik
For over 20 last kernel versions the driver has been able to allocate DMA buffers in videobuf-dma-contig mode without any issues. Drop the no longer needed sg mode in preparation for conversion to videobuf2. Created and tested on Amstrad Delta against Linux-4.7-rc3 with omap1_camera and ov6650

[RFC] [PATCH 3/3] staging: media: omap1: use dmaengine

2016-06-16 Thread Janusz Krzysztofik
Created and tested on Amstrad Delta on top of Linux-4.7-rc3 with "staging: media: omap1: convert to videobuf2" applied. Signed-off-by: Janusz Krzysztofik --- drivers/staging/media/omap1/Kconfig| 2 +- drivers/staging/media/omap1/omap1_camera.c | 432

[RFC] [PATCH 2/3] staging: media: omap1: convert to videobuf2

2016-06-16 Thread Janusz Krzysztofik
Created and tested on Amstrad Delta on top of Linux-4.7-rc3 with "staging: media: omap1: drop videobuf-dma-sg mode" applied. Signed-off-by: Janusz Krzysztofik --- drivers/staging/media/omap1/Kconfig| 2 +- drivers/staging/media/omap1/omap1_camera.c | 363

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-16 Thread Steve Longerbeam
On 06/16/2016 02:49 AM, Jack Mitchell wrote: > > On 16/06/16 02:37, Steve Longerbeam wrote: >> Hi Jack, >> >> On 06/15/2016 03:43 AM, Jack Mitchell wrote: >>> >>> Trying to use a user pointer rather than mmap also fails and causes a >>> kernel splat. >>> >> >> Hmm, I've tested userptr with the

Re: [PATCH 8/8] [media] rcar-vin: add Gen2 and Gen3 fallback compatibility strings

2016-06-16 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday 25 May 2016 21:10:09 Niklas Söderlund wrote: > From: Niklas Söderlund > > These are present in the soc-camera version of this driver and it's time > to add them to this driver as well. > > Signed-off-by:

Re: [PATCH 7/8] [media] rcar-vin: enable Gen3

2016-06-16 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday 25 May 2016 21:10:08 Niklas Söderlund wrote: > From: Niklas Söderlund > > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/Kconfig | 2 +-

Re: [PATCH 5/8] [media] rcar-vin: add Gen3 HW registers

2016-06-16 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday 25 May 2016 21:10:06 Niklas Söderlund wrote: > From: Niklas Söderlund > > Add the register needed to work with Gen3 hardware. This patch just adds > the logic for how to work with the Gen3 hardware. More

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Shuah Khan
On 06/15/2016 02:15 PM, Max Kellermann wrote: > media_gobj_destroy() may be called twice on one instance - once by > media_device_unregister() and again by dvb_media_device_free(). The > function media_remove_intf_links() establishes and documents the > convention that mdev==NULL means that the

Re: [PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

2016-06-16 Thread Shuah Khan
On 06/15/2016 02:15 PM, Max Kellermann wrote: > Don't free the object until the file handle has been closed. Fixes > use-after-free bug which occurs when I disconnect my DVB-S received > while VDR is running. Which file handle? /dev/dvb--- There seems to be a problem in the driver release

Re: [PATCH 31/38] media: imx: Add video switch

2016-06-16 Thread Ian Arkver
For me this fails when I try to enable both video muxes (mx6dl, though mx6q should be the same). I get a sysfs duplicate name failure for 34.videomux. I realise passing the GPR13 register offset and a bitfield mask as a tuple in the reg value of the of_node is handy, but how should we account

Re: [PATCH 3/8] media: rcar-vin: add DV timings support

2016-06-16 Thread Laurent Pinchart
Hello Niklas, Thank you for the patch. On Wednesday 25 May 2016 21:10:04 Niklas Söderlund wrote: > From: Ulrich Hecht > > Adds ioctls DV_TIMINGS_CAP, ENUM_DV_TIMINGS, G_DV_TIMINGS, S_DV_TIMINGS, > and QUERY_DV_TIMINGS. > > Signed-off-by: Ulrich Hecht

Re: [PATCH 2/8] media: rcar_vin: Use correct pad number in try_fmt

2016-06-16 Thread Laurent Pinchart
Hello Niklas, Thank you for the patch. On Wednesday 25 May 2016 21:10:03 Niklas Söderlund wrote: > From: Ulrich Hecht > > Fix rcar_vin_try_fmt's use of an inappropriate pad number when calling > the subdev set_fmt function - for the ADV7612, IDs should be

Re: [PATCH 1/8] media: rcar-vin: pad-aware driver initialisation

2016-06-16 Thread Laurent Pinchart
Hello Niklas, Thank you for the patch. On Wednesday 25 May 2016 21:10:02 Niklas Söderlund wrote: > From: Ulrich Hecht > > Add detection of source pad number for drivers aware of the media controller > API, so that rcar-vin can create device nodes to support

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-16 Thread Rob Clark
So, if we wanted to extend this to support the fourcc-modifiers that we have on the kernel side for compressed/tiled/etc formats, what would be the right approach? A new version of the existing extension or a new EGL_EXT_image_dma_buf_import2 extension, or ?? BR, -R On Mon, Feb 25, 2013 at 6:54

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-16 Thread Shuah Khan
On 06/16/2016 03:29 AM, Max Kellermann wrote: > (Shuah, I did not receive your second reply; I only found it in an > email archive.) > >> Yes media_devnode_create() creates the interfaces links and these >> links are deleted by media_devnode_remove(). >> media_device_unregister() still needs to

Re: [PATCH 34/38] media: imx: Add support for ADV7180 Video Decoder

2016-06-16 Thread Lars-Peter Clausen
On 06/15/2016 12:49 AM, Steve Longerbeam wrote: > This driver is based on adv7180.c from Freescale imx_3.10.17_1.0.0_beta > branch, modified heavily for code cleanup and converted from int-device > to subdev. We already have a driver for the adv7180 upstream, also using the subdev API. Is there

[PATCH] [media] media-devnode.h: Fix documentation

2016-06-16 Thread Mauro Carvalho Chehab
Two parameters were documented with a wrong name, and a struct device pointer description was missing. That caused the following warnings, when building documentation: include/media/media-devnode.h:102: warning: No description found for parameter 'media_dev' include/media/media-devnode.h:126:

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

2016-06-16 Thread Mauro Carvalho Chehab
Em Tue, 14 Jun 2016 19:08:08 +0800 tiffany lin escreveu: > Hi Mauro, > > > On Wed, 2016-06-08 at 07:13 +0900, Hans Verkuil wrote: > > > > On 06/07/2016 11:22 PM, Mauro Carvalho Chehab wrote: > > > Em Mon, 30 May 2016 20:29:14 +0800 > > > Tiffany Lin

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-16 Thread Jack Mitchell
On 16/06/16 02:37, Steve Longerbeam wrote: Hi Jack, On 06/15/2016 03:43 AM, Jack Mitchell wrote: Trying to use a user pointer rather than mmap also fails and causes a kernel splat. Hmm, I've tested userptr with the mem2mem driver, but maybe never with video capture. I tried "v4l2-ctl

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-16 Thread Max Kellermann
(Shuah, I did not receive your second reply; I only found it in an email archive.) > Yes media_devnode_create() creates the interfaces links and these > links are deleted by media_devnode_remove(). > media_device_unregister() still needs to delete the interfaces > links. The reason for that is

Re: [19/38] ARM: dts: imx6-sabrelite: add video capture ports and connections

2016-06-16 Thread Gary Bisson
Steve, All, On Tue, Jun 14, 2016 at 03:49:15PM -0700, Steve Longerbeam wrote: > Defines the host video capture device node and an OV5642 camera sensor > node on i2c2. The host capture device connects to the OV5642 via the > parallel-bus mux input on the ipu1_csi0_mux. > > Note there is a pin

Re: [PATCHv2] v4l2-ctrl.h: fix comments

2016-06-16 Thread Sakari Ailus
On Wed, Jun 15, 2016 at 02:57:48PM +0200, Hans Verkuil wrote: > The comments for the unlocked v4l2_ctrl_s_ctrl* functions were wrong (copy > and pasted from the locked variants). Fix this, since it is confusing. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus