[PATCH 1/3] [media] v4l2-ctrls.h: fully document the header file

2016-07-22 Thread Mauro Carvalho Chehab
There are lots of undocumented stuff on this header. Document them. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-ctrls.h | 365 ++--- 1 file changed, 279 insertions(+), 86 deletions(-) diff --git

[PATCH 2/3] [media] dvb_ringbuffer.h: some documentation improvements

2016-07-22 Thread Mauro Carvalho Chehab
Better document a note on this header. While here, better format dvb_ringbuffer_pkt_read_user() to adjust it to CodingStyle. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_ringbuffer.h | 15 ++- 1 file changed, 10 insertions(+), 5

[PATCH 3/3] [media] v4l2-ioctl.h add debug info for struct v4l2_ioctl_ops

2016-07-22 Thread Mauro Carvalho Chehab
This struct is mentioned at the kAPI docbook. So, let's document it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-common.rst | 2 + include/media/v4l2-ioctl.h | 266 +++ 2 files changed, 268

cron job: media_tree daily build: WARNINGS

2016-07-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jul 23 04:00:17 CEST 2016 git branch: test git hash: 009a620848218d521f008141c62f56bf19294dd9 gcc

Re: [PATCH] doc-rst: kernel-doc: fix handling of address_space tags

2016-07-22 Thread Mauro Carvalho Chehab
Em Fri, 22 Jul 2016 15:37:16 -0600 Jonathan Corbet escreveu: > On Fri, 22 Jul 2016 11:46:36 -0300 > Mauro Carvalho Chehab wrote: > > > The RST cpp:function handler is very pedantic: it doesn't allow any > > macros like __user on it: > > [...] > > So,

Re: [PATCH v8 0/10] Output raw touch data via V4L2

2016-07-22 Thread Chris Healy
I'm not Nick, but I'm testing his patches. ;-) Here's what I'm getting from v4l2-compliance with his patches: root@RDU2:/mnt/disk ./v4l2-compliance -a -f -d /dev/v4l-touch0 Driver Info: Driver name : rmi4_f54 Card type : Synaptics RMI4 Touch Sensor Bus info : rmi4:rmi4-00.fn54 Driver

Re: [PATCH] doc-rst: kernel-doc: fix handling of address_space tags

2016-07-22 Thread Jonathan Corbet
On Fri, 22 Jul 2016 11:46:36 -0300 Mauro Carvalho Chehab wrote: > The RST cpp:function handler is very pedantic: it doesn't allow any > macros like __user on it: > [...] > So, we have to remove it from the function prototype. Sigh, this is the kind of thing where

Re: Sony imx219 driver?

2016-07-22 Thread Dave Stevenson
Hi Hans. On 22/07/16 10:46, Hans Verkuil wrote: On 07/21/2016 08:19 PM, Dave Stevenson wrote: Hi All. Just a quick query to avoid duplicating effort. Has anyone worked on a Sony IMX219 (or other Sony sensor) subdevice driver as yet? Not that I am aware of. OK, glad to hear I won't be

Re: [PATCH] [media] vb2: move dma-buf unmap from __vb2_dqbuf() to vb2_buffer_done()

2016-07-22 Thread Luis de Bethencourt
On 20/07/16 19:22, Javier Martinez Canillas wrote: > Currently the dma-buf is unmapped when the buffer is dequeued by userspace > but it's not used anymore after the driver finished processing the buffer. > > So instead of doing the dma-buf unmapping in __vb2_dqbuf(), it can be made > in

Re: [PATCH v6 1/4] media: adv7604: automatic "default-input" selection

2016-07-22 Thread Sergei Shtylyov
On 07/22/2016 12:09 PM, Ulrich Hecht wrote: Fall back to input 0 if "default-input" property is not present. Additionally, documentation in commit bf9c82278c34 ("[media] media: adv7604: ability to read default input port from DT") states that the "default-input" property should reside directly

Re: [PATCH] [dvbv5-scan] wait no more than timeout when scanning

2016-07-22 Thread Mauro Carvalho Chehab
Hi Abylay, Em Fri, 22 Jul 2016 13:54:37 -0400 Abylay Ospan escreveu: > some frontends (mentioned on lgdt3306a) wait timeout inside code like: > for (i = 20; i > 0; i--) { > msleep(50); > > If there is no-LOCK then dvbv5-scan spent a lot of time (doing 40x calls). > This

[PATCH v2] [media] Documentation: Fix V4L2_CTRL_FLAG_VOLATILE

2016-07-22 Thread Ricardo Ribalda Delgado
V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE is set was not properly explained. Also set some hyperlink to ease the Documentation browsing. Reported-by: Dimitrios Katsaros Credit-to: Hans Verkuil Signed-off-by: Ricardo

[PATCH] [dvbv5-scan] wait no more than timeout when scanning

2016-07-22 Thread Abylay Ospan
some frontends (mentioned on lgdt3306a) wait timeout inside code like: for (i = 20; i > 0; i--) { msleep(50); If there is no-LOCK then dvbv5-scan spent a lot of time (doing 40x calls). This patch introduce timeout which 4 sec * multiply. So we do not wait more than 4 sec (or so) if no-LOCK.

[GIT PULL FOR v4.8] (v4) Various fixes

2016-07-22 Thread Hans Verkuil
Hi Mauro, Another bunch of bug fixes for 4.8. The vb2 fix is particularly nasty, the others are all pretty trivial. Regards, Hans New for v4: dropped cleanup patches. Will be a separate pull request for 4.9. New for v3: added patch "cec: fix off-by-one memset" New for v2: added patch

[PATCH 01/11] [media] v4l2-framework.rst: remove videobuf quick chapter

2016-07-22 Thread Mauro Carvalho Chehab
As we merged the videobuf chapter at the kABI section, and it is a way more complete, just remove the small videobuf chapter that came from framework.txt. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-framework.rst | 16 1 file

[PATCH 10/11] [media] doc-rst: reorganize the kAPI v4l2 chapters

2016-07-22 Thread Mauro Carvalho Chehab
Reorganize the order of the document, putting the chapters on a more logical order and renaming some sections. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-common.rst | 4 Documentation/media/kapi/v4l2-controls.rst| 4

[PATCH 08/11] [media] move V4L2 clocks to a separate .rst file

2016-07-22 Thread Mauro Carvalho Chehab
Move the v4l2 clocks stuff from v4l2-framework to a separate file and adds an attention that came from the v4l2-clk.h. Note: as this is meant to be a temporary kAPI, and it is used only by two drivers (soc_camera and em28xx), where the first one is in deprecation process, it probably not a worth

[PATCH 11/11] [media] doc-rst: Fix some typedef ugly warnings

2016-07-22 Thread Mauro Carvalho Chehab
Sphinx can't handle well typedefs. Change two typedef occurrences, in order to cleanup some of such warnings. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-ctrls.h | 4 +++- include/media/v4l2-dv-timings.h | 2 +- 2 files changed, 4 insertions(+), 2

[PATCH 07/11] [media] v4l2-fh.rst: add cross references and markups

2016-07-22 Thread Mauro Carvalho Chehab
Add cross-references with the kernel-doc functions/structs and improve the markups. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-fh.rst | 111 ++- 1 file changed, 56 insertions(+), 55 deletions(-) diff --git

[PATCH 04/11] [media] v4l2-event.rst: add cross-references and markups

2016-07-22 Thread Mauro Carvalho Chehab
Improve events documentation by adding cross references, sub-titles and other markup elements. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-event.rst | 137 +++- 1 file changed, 81 insertions(+), 56 deletions(-)

[PATCH 09/11] [media] rename v4l2-framework.rst to v4l2-intro.rst

2016-07-22 Thread Mauro Carvalho Chehab
Now that the only remaining chapters at v4l2-framework are the introduction ones, let' s rename the file. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-core.rst | 2 +- Documentation/media/kapi/{v4l2-framework.rst =>

[PATCH 03/11] [media] v4l2-event.h: document all functions

2016-07-22 Thread Mauro Carvalho Chehab
Several functions weren't documented. Document them all. While here, makes checkpatch.pl happy. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-event.h | 125 - 1 file changed, 113 insertions(+), 12 deletions(-)

[PATCH 06/11] [media] v4l2-fh.rst: add fh contents from v4l2-framework.rst

2016-07-22 Thread Mauro Carvalho Chehab
Move the v4l2_fh specific content from v4l2-framework.rst to v4l2-fh.rst. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-fh.rst| 134 Documentation/media/kapi/v4l2-framework.rst | 133

[PATCH 05/11] [media] v4l2-fh.h: add documentation for it

2016-07-22 Thread Mauro Carvalho Chehab
This header file was undocumented. Add documentation for it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/v4l2-core.rst | 1 + Documentation/media/kapi/v4l2-fh.rst | 3 + include/media/v4l2-fh.h| 128

[PATCH 02/11] [media] v4l2-event.rst: add text from v4l2-framework.rst

2016-07-22 Thread Mauro Carvalho Chehab
Move the v4l2 event-specific text from v4l2-framework.rst to v4l2-event.rst. That helps to keep the text together with the functions it describes, and makes easier to identify documentation gaps. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH] doc-rst: kernel-doc: fix handling of address_space tags

2016-07-22 Thread Mauro Carvalho Chehab
The RST cpp:function handler is very pedantic: it doesn't allow any macros like __user on it: Documentation/media/kapi/dtv-core.rst:28: WARNING: Error when parsing function declaration. If the function has no return type: Error in declarator or parameters and qualifiers

Re: [PATCH] [media] Documentation: Fix V4L2_CTRL_FLAG_VOLATILE

2016-07-22 Thread Hans Verkuil
On 07/22/2016 04:07 PM, Ricardo Ribalda Delgado wrote: > V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE > is set was not properly explained. > > Reported-by: Dimitrios Katsaros > Credit-to: Hans Verkuil > Signed-off-by:

[PATCH] [media] Documentation: Fix V4L2_CTRL_FLAG_VOLATILE

2016-07-22 Thread Ricardo Ribalda Delgado
V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE is set was not properly explained. Reported-by: Dimitrios Katsaros Credit-to: Hans Verkuil Signed-off-by: Ricardo Ribalda Delgado ---

Re: [v4l-utils RFC 0/3] mediatext library and test program

2016-07-22 Thread Hans Verkuil
Hi Sakari, First a practical matter: you should consider using the v4l-helpers.h: it will shield you and probably the end-user as well from lots of complexities, esp. the single vs multiplanar differences. I really need to spend some time documenting it, but it isn't all that difficult. On

Re: [PATCH v3 1/5] media: Determine early whether an IOCTL is supported

2016-07-22 Thread Sakari Ailus
Hi Hans, Hans Verkuil wrote: Hi Sakari, On 07/21/2016 01:14 PM, Sakari Ailus wrote: Preparation for refactoring media IOCTL handling to unify common parts. Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus ---

Re: [PATCH 00/18] Complete moving media documentation to ReST format

2016-07-22 Thread Markus Heiser
Am 22.07.2016 um 11:46 schrieb Mauro Carvalho Chehab : > Em Thu, 21 Jul 2016 17:17:26 +0200 > Markus Heiser escreveu: > >> Am 19.07.2016 um 19:18 schrieb Mauro Carvalho Chehab >> : >> A bit OT, but I see that

[GIT PULL FOR v4.8] (v3) Various fixes/cleanups

2016-07-22 Thread Hans Verkuil
Hi Mauro, Another bunch of bug fixes and small cleanups for 4.8. The vb2 fix is particularly nasty, the others are all pretty trivial. Regards, Hans New for v3: added patch "cec: fix off-by-one memset" New for v2: added patch "staging: add MEDIA_SUPPORT dependency" The following

Re: [PATCH v3 5/5] media: Support variable size IOCTL arguments

2016-07-22 Thread Hans Verkuil
On 07/21/2016 01:17 PM, Sakari Ailus wrote: > Instead of checking for a strict size for the IOCTL arguments, place > minimum and maximum limits. This sentence is out of date: it checks for alternative smaller sizes, not min/max. > > As an additional bonus, IOCTL handlers will be able to check

Re: [PATCH v3 4/5] media: Add flags to tell whether to take graph mutex for an IOCTL

2016-07-22 Thread Hans Verkuil
On 07/21/2016 01:17 PM, Sakari Ailus wrote: > New IOCTLs (especially for the request API) do not necessarily need the > graph mutex acquired. Leave this up to the drivers. > > Signed-off-by: Sakari Ailus > Reviewed-by: Laurent Pinchart

Re: [PATCH v3 2/5] media: Unify IOCTL handler calling

2016-07-22 Thread Hans Verkuil
On 07/21/2016 01:14 PM, Sakari Ailus wrote: > Each IOCTL handler can be listed in an array instead of using a large and > cumbersome switch. Do that. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Sakari Ailus Acked-by:

Re: [PATCH v3 3/5] media: Refactor copying IOCTL arguments from and to user space

2016-07-22 Thread Hans Verkuil
On 07/21/2016 01:14 PM, Sakari Ailus wrote: > Refactor copying the IOCTL argument structs from the user space and back, > in order to reduce code copied around and make the implementation more > robust. > > As a result, the copying is done while not holding the graph mutex. > > Signed-off-by:

Re: [PATCH v3 1/5] media: Determine early whether an IOCTL is supported

2016-07-22 Thread Hans Verkuil
Hi Sakari, On 07/21/2016 01:14 PM, Sakari Ailus wrote: > Preparation for refactoring media IOCTL handling to unify common parts. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH] [media] tw686x-kh: Delete an unnecessary check before the function call "video_unregister_device"

2016-07-22 Thread Krzysztof HaƂasa
SF Markus Elfring writes: > The video_unregister_device() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by:

Re: Sony imx219 driver?

2016-07-22 Thread Hans Verkuil
On 07/21/2016 08:19 PM, Dave Stevenson wrote: > Hi All. > > Just a quick query to avoid duplicating effort. Has anyone worked on a > Sony IMX219 (or other Sony sensor) subdevice driver as yet? Not that I am aware of. > With the new Raspberry Pi camera being IMX219, and as Broadcom have >

Re: [PATCH 00/18] Complete moving media documentation to ReST format

2016-07-22 Thread Mauro Carvalho Chehab
Em Thu, 21 Jul 2016 17:17:26 +0200 Markus Heiser escreveu: > Am 19.07.2016 um 19:18 schrieb Mauro Carvalho Chehab > : > > >> A bit OT, but I see that you often use tabs / I recommend to use > >> spaces for indentation: > >> > >>

Re: [PATCH v6 0/4] Lager/Koelsch board HDMI input support

2016-07-22 Thread Hans Verkuil
Looks good to me. I plan to queue this for 4.9. Regards, Hans On 07/22/2016 11:09 AM, Ulrich Hecht wrote: > Hi! > > This revision implements the pad translation between rcar-vin and subdevices > as suggested by Niklas. It also moves around the i2c devices, following the > introduction

Re: [PATCH] Staging: media: timblogiw: File cleanup.

2016-07-22 Thread Hans Verkuil
This driver will be removed in 4.8, so I won't take this patch. Regards, Hans On 07/20/2016 08:47 PM, Jeremiah Goerdt wrote: > Cleaned up checkpatch.pl warnings and checks. > > Signed-off-by: Jeremiah Goerdt > --- > drivers/staging/media/timb/timblogiw.c |

[PATCH v6 3/4] ARM: dts: koelsch: add HDMI input

2016-07-22 Thread Ulrich Hecht
From: Hans Verkuil Add support in the dts for the HDMI input. Based on the Lager dts patch from Ulrich Hecht. Signed-off-by: Hans Verkuil [uli: removed "renesas," prefixes from pfc nodes] Signed-off-by: Ulrich Hecht

[PATCH v6 2/4] ARM: dts: lager: Add entries for VIN HDMI input support

2016-07-22 Thread Ulrich Hecht
From: William Towle Add DT entries for vin0, vin0_pins, and adv7612. Sets the 'default-input' property for ADV7612, enabling image and video capture without the need to have userspace specifying routing. Signed-off-by: William Towle

[PATCH v6 4/4] rcar-vin: implement EDID control ioctls

2016-07-22 Thread Ulrich Hecht
Adds G_EDID and S_EDID. Signed-off-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c

[PATCH v6 0/4] Lager/Koelsch board HDMI input support

2016-07-22 Thread Ulrich Hecht
Hi! This revision implements the pad translation between rcar-vin and subdevices as suggested by Niklas. It also moves around the i2c devices, following the introduction of i2c multiplexing in the Gen2 device trees. Based on renesas-drivers-2016-07-19-v4.7-rc7. CU Uli Changes since v5: -

[PATCH v6 1/4] media: adv7604: automatic "default-input" selection

2016-07-22 Thread Ulrich Hecht
Fall back to input 0 if "default-input" property is not present. Additionally, documentation in commit bf9c82278c34 ("[media] media: adv7604: ability to read default input port from DT") states that the "default-input" property should reside directly in the node for adv7612. Hence, also adjust

[PATCH for v4.8] cec: fix off-by-one memset

2016-07-22 Thread Hans Verkuil
The unused bytes of the features array should be zeroed, but the start index was one byte too early. This caused the device features byte to be overwritten by 0. The compliance test for the CEC_S_LOG_ADDRS ioctl didn't catch this because it tested byte continuation with the second device

[PATCH v2 4/4] arm64: dts: mediatek: Add MDP for MT8173

2016-07-22 Thread Minghsiu Tsai
Add MDP node for MT8173 Signed-off-by: Minghsiu Tsai --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 80 ++ 1 file changed, 80 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi

[PATCH v2 3/4] media: Add Mediatek MDP Driver

2016-07-22 Thread Minghsiu Tsai
Add MDP driver for MT8173 Signed-off-by: Minghsiu Tsai --- drivers/media/platform/Kconfig| 16 + drivers/media/platform/Makefile |2 + drivers/media/platform/mtk-mdp/Makefile |9 +

[PATCH v2 1/4] VPU: mediatek: Add mdp support

2016-07-22 Thread Minghsiu Tsai
VPU driver add mdp support Signed-off-by: Minghsiu Tsai --- drivers/media/platform/mtk-vpu/mtk_vpu.h |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.h b/drivers/media/platform/mtk-vpu/mtk_vpu.h index

[PATCH v2 0/4] Add MT8173 MDP Driver

2016-07-22 Thread Minghsiu Tsai
Changes in v2: - Add section to describe blocks function in dts-bindings - Remove the assignment of device_caps in querycap() - Remove format's name assignment - Copy colorspace-related parameters from OUTPUT to CAPTURE - Use m2m helper functions - Fix DMA allocation failure - Initialize lazily

[PATCH v2 2/4] dt-bindings: Add a binding for Mediatek MDP

2016-07-22 Thread Minghsiu Tsai
Add a DT binding documentation of MDP for the MT8173 SoC from Mediatek Signed-off-by: Minghsiu Tsai --- .../devicetree/bindings/media/mediatek-mdp.txt | 96 1 file changed, 96 insertions(+) create mode 100644

Re: [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-07-22 Thread Hans Verkuil
On 07/22/2016 07:18 AM, Wu, Songjun wrote: >>> +/* >>> + * index(0~11): raw formats. >>> + * index(12~12): the formats which can be converted from raw format by ISC. >>> + * index(): the formats which can only be provided by subdev. >>> + */ >>> +static struct isc_format isc_formats[] =