Re: [PATCH] [media] vivid: support for contiguous DMA buffers

2016-09-11 Thread kbuild test robot
Hi Vincent, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.8-rc6 next-20160909] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience)

Re: musb: isoc pkt loss with pwc

2016-09-11 Thread Bin Liu
Hi, On Tue, Aug 30, 2016 at 11:44:33PM +0300, Matwey V. Kornilov wrote: > 2016-08-30 21:30 GMT+03:00 Bin Liu : > > Hi, > > > > On Sun, Aug 28, 2016 at 01:13:55PM +0300, Matwey V. Kornilov wrote: > >> Hello Bin, > >> > >> I would like to start new thread on my issue. Let me recall

cron job: media_tree daily build: ERRORS

2016-09-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Sep 12 04:00:16 CEST 2016 git branch: test git hash: 8a5a2ba86ab8fc12267fea974b9cd730ad2dee24 gcc

Re: [PATCH v3 08/10] v4l: fdp1: Rewrite format setting code

2016-09-11 Thread Kieran Bingham
I've gone through this one as well, and certainly seems like some much better approaches in there. I can't find anything to fault it. Acked-by: Kieran Bingham Reviewed-by: Kieran Bingham Thanks again, Kieran On 07/09/16 23:25, Laurent Pinchart wrote:

Re: [PATCH v3 10/10] v4l: fdp1: Store buffer information in vb2 buffer

2016-09-11 Thread Kieran Bingham
Hi Laurent, Ok - I've gone through this properly now, and I really like what I see :) Definitely some good changes here - and my comments are only minor fixups which are just things I've noticed which we can 'squash' in. You'll find 'fixup commits' for the following three hunks: -

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Julia Lawall
On Sun, 11 Sep 2016, Joe Perches wrote: > On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > > Constify local structures. > > Thanks Julia. > > A few suggestions & questions: > > Perhaps the script should go into scripts/coccinelle/ > so that future cases could be caught by the robot > and

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Joe Perches
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > Constify local structures. Thanks Julia. A few suggestions & questions: Perhaps the script should go into scripts/coccinelle/ so that future cases could be caught by the robot and commit message referenced by the patch instances. Can you

Re: [PATCH] [media] staging/media/cec: fix coding style error

2016-09-11 Thread Antti Palosaari
On 09/11/2016 07:07 PM, Richard wrote: Greetings Linux Kernel Developers, This is Task 10 of the Eudyptula Challenge, i fix few line over 80 characters, hope you will accept this pacth. /Richard For the eudyptula challenge (http://eudyptula-challenge.org/). Simple style fix for few line over

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Jarkko Sakkinen
On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > Constify local structures. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) Just my two cents but: 1. You *can* use a static analysis too to find bugs or other issues. 2. However, you

Re: [PATCH v3 09/10] v4l: fdp1: Fix field validation when preparing buffer

2016-09-11 Thread Kieran Bingham
On 07/09/16 23:25, Laurent Pinchart wrote: > Ensure that the buffer field matches the field configured for the > format. Looks OK and tests fine. I think with the field 'serialiser' the driver didn't actually care what the buffers put in were (as long as they were sequential) but it certainly

[PATCH] [media] staging/media/cec: fix coding style error

2016-09-11 Thread Richard
Greetings Linux Kernel Developers, This is Task 10 of the Eudyptula Challenge, i fix few line over 80 characters, hope you will accept this pacth. /Richard For the eudyptula challenge (http://eudyptula-challenge.org/). Simple style fix for few line over 80 characters Signed-off-by: Richard

[PATCH 2/3] [media] tuners: constify dvb_tuner_ops structures

2016-09-11 Thread Julia Lawall
These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r disable optional_qualifier@ identifier i; position p; @@ static struct dvb_tuner_ops i@p = { ... }; @ok1@

[PATCH 3/3] [media] mxl111sf-tuner: constify dvb_tuner_ops structures

2016-09-11 Thread Julia Lawall
These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r disable optional_qualifier@ identifier i; position p; @@ static struct dvb_tuner_ops i@p = { ... }; @ok1@

[PATCH 0/3] constify dvb_tuner_ops structures

2016-09-11 Thread Julia Lawall
Constify dvb_tuner_ops structures --- drivers/media/dvb-frontends/ascot2e.c |2 +- drivers/media/dvb-frontends/dvb-pll.c |2 +- drivers/media/dvb-frontends/helene.c |4 ++-- drivers/media/dvb-frontends/horus3a.c |2 +-

[PATCH 1/3] [media] dvb-frontends: constify dvb_tuner_ops structures

2016-09-11 Thread Julia Lawall
These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r disable optional_qualifier@ identifier i; position p; @@ static struct dvb_tuner_ops i@p = { ... }; @ok1@

[BUG] process stuck when closing saa7146 [dvb_ttpci]

2016-09-11 Thread Philipp Matthias Hahn
Hello, I own a | 04:07.0 Multimedia controller: Philips Semiconductors SAA7146 (rev 01) | Subsystem: Siemens AG Fujitsu/Siemens DVB-C card rev1.5 | Flags: bus master, medium devsel, latency 64, IRQ 16 | Memory at febff800 (32-bit, non-prefetchable) [size=512] |

[PATCH 2/6] ipr: use pci_irq_allocate_vectors

2016-09-11 Thread Christoph Hellwig
Switch the ipr driver to use pci_alloc_irq_vectors. We need to two calls to pci_alloc_irq_vectors as ipr only supports multiple MSI-X vectors, but not multiple MSI vectors. Otherwise this cleans up a lot of cruft and allows to use a common request_irq loop for irq types, which happens to only

[PATCH 5/6] genwqe: use pci_irq_allocate_vectors

2016-09-11 Thread Christoph Hellwig
Simply the interrupt setup by using the new PCI layer helpers. One odd thing about this driver is that it looks like it could request multiple MSI vectors, but it will then only ever use a single one. Signed-off-by: Christoph Hellwig --- drivers/misc/genwqe/card_base.h | 1 -

[PATCH 6/6] media/cobalt: use pci_irq_allocate_vectors

2016-09-11 Thread Christoph Hellwig
Simply the interrupt setup by using the new PCI layer helpers. Despite using pci_enable_msi_range, this driver was only requesting a single MSI vector anyway. Signed-off-by: Christoph Hellwig --- drivers/media/pci/cobalt/cobalt-driver.c | 8 ++--

[PATCH 1/6] arcmsr: use pci_alloc_irq_vectors

2016-09-11 Thread Christoph Hellwig
Switch the arcmsr driver to use pci_alloc_irq_vectors. We need to two calls to pci_alloc_irq_vectors as arcmsr only supports multiple MSI-X vectors, but not multiple MSI vectors. Otherwise this cleans up a lot of cruft and allows to use a common request_irq loop for irq types, which happens to

[PATCH 4/6] vfio_pci: use pci_irq_allocate_vectors

2016-09-11 Thread Christoph Hellwig
Simply the interrupt setup by using the new PCI layer helpers. Signed-off-by: Christoph Hellwig --- drivers/vfio/pci/vfio_pci_intrs.c | 45 + drivers/vfio/pci/vfio_pci_private.h | 1 - 2 files changed, 10 insertions(+), 36 deletions(-) diff

replace pci_enable_msi_{exact_range} with pci_alloc_irq_vectors

2016-09-11 Thread Christoph Hellwig
Hi all, this series switch the remaining users of pci_enable_msi_{exact_range} (accounting for ahci and nvme being done through other channels) to use the pci_alloc_irq_vectors helper instead and thus simplify the interrupt code in those drivers a lot. I decided to post it as a series to

[PATCH 3/6] skd: use pci_alloc_irq_vectors

2016-09-11 Thread Christoph Hellwig
Switch the skd driver to use pci_alloc_irq_vectors. We need to two calls to pci_alloc_irq_vectors as skd only supports multiple MSI-X vectors, but not multiple MSI vectors. Otherwise this cleans up a lot of cruft and allows to a lot more common code. Signed-off-by: Christoph Hellwig

[PATCH 00/26] constify local structures

2016-09-11 Thread Julia Lawall
Constify local structures. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // // The first rule ignores some cases that posed problems @r disable optional_qualifier@ identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer}; identifier i !=

[PATCH 13/26] [media]: constify local structures

2016-09-11 Thread Julia Lawall
For structure types defined in the same file or local header files, find top-level static structure declarations that have the following properties: 1. Never reassigned. 2. Address never taken 3. Not passed to a top-level macro call 4. No pointer or array-typed field passed to a function or stored

Re: DVB: Unable to find symbol dib7000p_attach()

2016-09-11 Thread Toralf Förster
On 08/25/2016 08:31 PM, Toralf Förster wrote: > Aug 25 20:28:27 t44 kernel: DVB: registering new adapter (Terratec Cinergy T > USB XXS (HD)/ T3) > Aug 25 20:28:27 t44 kernel: DVB: Unable to find symbol dib7000p_attach() > Aug 25 20:28:27 t44 kernel: dvb-usb: no frontend was attached by 'Terratec

[PATCH] pulse8-cec: fix compiler warning

2016-09-11 Thread Hans Verkuil
pulse8-cec.c: In function 'pulse8_connect': pulse8-cec.c:447:2: warning: 'pa' may be used uninitialized in this function [-Wmaybe-uninitialized] cec_s_phys_addr(pulse8->adap, pa, false); ^ pulse8-cec.c:609:6: note: 'pa' was declared here u16 pa; ^ As far as I can tell, this can't

[PATCH] pxa_camera: merge soc_mediabus.c into pxa_camera.c

2016-09-11 Thread Hans Verkuil
Linking soc_mediabus into this driver causes multiple definition linker warnings if soc_camera is also enabled: drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_image_size+0x0): multiple definition of `__ksymtab_soc_mbus_image_size'

drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit declaration of function 'dma_get_cache_alignment'

2016-09-11 Thread kbuild test robot
Hi Hans, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 98ac9a608dc79ba8a20cee77fe959a6dfccdaa63 commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media] drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

2016-09-11 Thread Takashi Iwai
On Sun, 11 Sep 2016 05:06:41 +0200, Takashi Sakamoto wrote: > > On Sep 10 2016 22:41, Takashi Iwai wrote: > > On Sat, 10 Sep 2016 09:25:31 +0200, > > Takashi Sakamoto wrote: > >> > >> On Sep 10 2016 15:44, Takashi Iwai wrote: > >>> On Sat, 10 Sep 2016 06:50:14 +0200, > >>> Takashi Sakamoto wrote: