Re: [PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

2017-03-27 Thread Matthias Schwarzott
Am 26.03.2017 um 12:34 schrieb Daniel Scheller: > Am Sun, 26 Mar 2017 10:03:33 +0200 > schrieb Matthias Schwarzott : > >> Am 24.03.2017 um 19:23 schrieb Daniel Scheller: >>> From: Daniel Scheller >>> >>> Some hardware and bridges (namely ddbridge) require

[PATCH] staging: media: atomisp: i2c: removed unnecessary white space before comma in memset()

2017-03-27 Thread vaibhavddit
From: Vaibhav Kothari Removed extra space before comma in memset() as a part of checkpatch.pl fix-up. Signed-off-by: Vaibhav Kothari --- drivers/staging/media/atomisp/i2c/gc2235.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: media: atomisp: i2c: removed unnecessary white space before comma in memset()

2017-03-27 Thread Greg KH
On Tue, Mar 28, 2017 at 10:44:44AM +0530, vaibhavd...@gmail.com wrote: > gc2235.c Why is this file name here? > > Removed extra space before comma in memset() as a part of > checkpatch.pl fix-up. Why the extra space at the beginning of the line? > Signed-off-by: Vaibhav Kothari

[PATCH] staging: media: atomisp: i2c: removed unnecessary white space before comma in memset()

2017-03-27 Thread vaibhavddit
gc2235.c Removed extra space before comma in memset() as a part of checkpatch.pl fix-up. Signed-off-by: Vaibhav Kothari --- drivers/staging/media/atomisp/i2c/gc2235.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

2017-03-27 Thread Smitha T Murthy
On Mon, 2017-03-27 at 14:09 +0200, Andrzej Hajda wrote: > Hi Smitha, > > Sorry for late reply, it seems I have missed this email. > > > On 14.03.2017 12:41, Smitha T Murthy wrote: > > On Tue, 2017-03-07 at 12:33 +0100, Andrzej Hajda wrote: > >> On 03.03.2017 10:07, Smitha T Murthy wrote: > >>>

cron job: media_tree daily build: ERRORS

2017-03-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 28 05:00:13 CEST 2017 media-tree git hash:c3d4fb0fb41f4b5eafeee51173c14e50be12f839 media_build

Re: [PATCH v6 1/3] drm_fourcc: Add new P010, P016 video format

2017-03-27 Thread Ayaka
從我的 iPad 傳送 > Clint Taylor 於 2017年3月28日 上午6:49 寫道: > >> On 03/26/2017 09:05 PM, Ayaka wrote: >> >> >> 從我的 iPad 傳送 >> Ander Conselvan De Oliveira 於 2017年3月14日 下午9:53 寫道: On Tue, 2017-03-07 at 04:27 +0800, Ayaka wrote:

[PATCH v6 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-03-27 Thread Steve Longerbeam
Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi

[PATCH v6 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam ---

[PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-27 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644

[PATCH v6 00/39] i.MX Media Driver

2017-03-27 Thread Steve Longerbeam
In version 6: - moved FIM error event back to a i.MX private event. I would like to leave this as a (private) event rather than reporting a vb2 queue error, for now. If and when the i.MX6 timer input capture patch is accepted later, then this event can become a queue error. - removed

[PATCH v6 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-27 Thread Steve Longerbeam
There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, but ENET uses it as the h/w workaround for erratum ERR006687, to wake-up the ARM cores on normal RX and TX packet done events. So we need to remove the h/w workaround to support the OV5642.

[PATCH v6 10/39] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

2017-03-27 Thread Steve Longerbeam
The sabreauto uses a steering pin to select between the SDA signal on i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control this steering pin. Idle state of the i2cmux selects SPI NOR. This is not a classic way to use i2cmux, since one side of the mux selects something other than

[PATCH v6 13/39] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-03-27 Thread Steve Longerbeam
Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58

[PATCH v6 03/39] [media] dt/bindings: Add bindings for OV5640

2017-03-27 Thread Steve Longerbeam
Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644

[PATCH v6 15/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-27 Thread Steve Longerbeam
v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-mc.c | 50 +++ include/media/v4l2-mc.h

[PATCH v6 08/39] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-03-27 Thread Steve Longerbeam
Adds the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave addresses. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI

[PATCH v6 06/39] ARM: dts: imx6qdl: add capture-subsystem device

2017-03-27 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76 100644 ---

[PATCH v6 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel This patch adds the device tree graph connecting the input multiplexers to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU multiplexers are added as children of the iomuxc-gpr syscon device node. On i.MX6Q/D two two-input multiplexers in

[PATCH v6 14/39] add mux and video interface bridge entity functions

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++

[PATCH v6 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-03-27 Thread Steve Longerbeam
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. Until the OV5652 sensor module compatible with the SabreSD becomes

[PATCH v6 28/39] media: imx: csi: fix crop rectangle changes in set_fmt

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel The cropping rectangle was being modified by the output pad's set_fmt, which is the wrong pad to do this. The crop rectangle should not be modified by the output pad set_fmt. It instead should be reset to the full input frame when the input pad format

[PATCH v6 18/39] media: Add userspace header file for i.MX

2017-03-27 Thread Steve Longerbeam
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom events and v4l2 controls for the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/linux/imx-media.h | 27

[PATCH v6 23/39] media: imx: Add IC subdev drivers

2017-03-27 Thread Steve Longerbeam
This is a set of three media entity subdevice drivers for the i.MX Image Converter: - Pre-process Router: Takes input frames from CSI0, CSI1, or VDIC. Two output pads enable either or both of the preprocess tasks below. If the input is from one of the CSIs, both proprocess task links can be

[PATCH v6 30/39] media: imx: csi/fim: add support for frame intervals

2017-03-27 Thread Steve Longerbeam
From: Russell King Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam ---

[PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The subdevice passes through frame interval and mbus configuration of the active input to the output side. Signed-off-by:

[PATCH v6 24/39] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-03-27 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 673

[PATCH v6 19/39] media: Add i.MX media core driver

2017-03-27 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 590 ++ drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1

[PATCH v6 11/39] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-03-27 Thread Steve Longerbeam
The reset pin to the port expander chip (MAX7310) is controlled by a gpio, so define a reset-gpios property to control it. There are three MAX7310's on the SabreAuto CPU card (max7310_[abc]), but all use the same pin for their reset. Since all can't acquire the same pin, assign it to max7310_b,

[PATCH v6 16/39] [media] add Omnivision OV5640 sensor driver

2017-03-27 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 +

[PATCH v6 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-03-27 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi

[PATCH v6 20/39] media: imx: Add Capture Device Interface

2017-03-27 Thread Steve Longerbeam
This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from various sources: - directly from CSI for capturing unconverted images directly from camera sensors. - from the IC pre-process encode task. - from the IC pre-process viewfinder task.

[PATCH v6 32/39] media: imx: csi: add frame skipping support

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam

[PATCH v6 34/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam

[PATCH v6 22/39] media: imx: Add VDIC subdev driver

2017-03-27 Thread Steve Longerbeam
This is a media entity subdevice driver for the i.MX Video De-Interlacing or Combining Block. So far this entity does not implement the Combining function but only motion compensated deinterlacing. Video frames are received from the CSI and are routed to the IC PRPVF entity. Signed-off-by: Steve

[PATCH v6 26/39] media: imx: add support for bayer formats

2017-03-27 Thread Steve Longerbeam
From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam

[PATCH v6 21/39] media: imx: Add CSI subdev driver

2017-03-27 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1318

[PATCH v6 31/39] media: imx: redo pixel format enumeration and negotiation

2017-03-27 Thread Steve Longerbeam
The previous API and negotiation of mbus codes and pixel formats was broken, and has been completely redone. The negotiation of media bus codes should be as follows: CSI: sink pad direct src pad IDMAC src pad - RGB (any)IPU RGB

[PATCH v6 29/39] media: imx: csi: add __csi_get_fmt

2017-03-27 Thread Steve Longerbeam
Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 61

[PATCH v6 37/39] media: imx-csi: add frame size/interval enumeration

2017-03-27 Thread Steve Longerbeam
From: Russell King Add frame size and frame interval enumeration to CSI. CSI can downscale the image independently horizontally and vertically by a factor of two, which enumerates to four different frame sizes at the output pads. The input pad supports a range of

[PATCH v6 36/39] media: imx: csi: add sink selection rectangles

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Move the crop rectangle to the sink pad and add a sink compose rectangle to configure scaling. Also propagate rectangles from sink pad to crop rectangle, to compose rectangle, and to the source pads both in ACTIVE and TRY variants of set_fmt/selection,

[PATCH v6 38/39] media: imx-ic-prpencvf: add frame size enumeration

2017-03-27 Thread Steve Longerbeam
Add frame size enumeration operation. The PRP ENC/VF subdevices are scalers, so they can output a continuous range of widths/ heights on their source pads. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prpencvf.c | 40

[PATCH v6 27/39] media: imx: csi: add support for bayer formats

2017-03-27 Thread Steve Longerbeam
From: Russell King Bayer formats must be treated as generic data and passthrough mode must be used. Add the correct setup for these formats. Signed-off-by: Russell King - added check to csi_link_validate() to verify that destination is

[PATCH v6 39/39] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-27 Thread Steve Longerbeam
From: Russell King Add support for enumerating frame sizes and frame intervals from the first subdev via the V4L2 interfaces. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam ---

[PATCH v6 33/39] media: imx: csi: Avoid faulty sensor frames at stream start

2017-03-27 Thread Steve Longerbeam
If the attached sensor reports faulty frames at stream start via g_skip_frames callback, add a delay to avoid them before enabling the CSI hardware. Especially for sensors with a bt.656 interface, any shifts in the SAV/EAV sync codes will cause the CSI to lose vert/horiz sync. Signed-off-by:

[PATCH v6 25/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-03-27 Thread Steve Longerbeam
Enable i.MX v4l2 media staging driver. For video capture on i.MX, the video multiplexer subdev is required. On the SabreAuto, the ADV7180 video decoder is required along with i2c-mux-gpio. The Sabrelite and SabreSD require the OV5640 and the SabreLite requires PWM clocks for the OV5640. Increase

[PATCH v6 35/39] media: imx: propagate sink pad formats to source pads

2017-03-27 Thread Steve Longerbeam
As part of this, separate format try code from *_set_fmt() into *_try_fmt(), so that the latter function can be used to propagate a legal format from sink to source. This also reduces subsequent bloat in *_set_fmt(). imx-ic-prp never needed separate formats for sink and source pads, so

Re: [PATCH v6 1/3] drm_fourcc: Add new P010, P016 video format

2017-03-27 Thread Clint Taylor
On 03/26/2017 09:05 PM, Ayaka wrote: 從我的 iPad 傳送 Ander Conselvan De Oliveira 於 2017年3月14日 下午9:53 寫道: On Tue, 2017-03-07 at 04:27 +0800, Ayaka wrote: 從我的 iPad 傳送 Ville Syrjälä 於 2017年3月7日 上午2:34 寫道: On Tue, Mar 07, 2017 at

Re: [RFC v2 07/11] vb2: dma-contig: Remove redundant sgt_base field

2017-03-27 Thread Shuah Khan
On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Sakari Ailus > > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter

Re: [RFC v2 05/11] v4l2-core: Don't sync cache for a buffer if so requested

2017-03-27 Thread Shuah Khan
On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache synchronisation, e.g. in >

Re: [RFC v2 03/11] vb2: Move cache synchronisation from buffer done to dqbuf handler

2017-03-27 Thread Shuah Khan
On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Sakari Ailus > > The cache synchronisation may be a time consuming operation and thus not > best performed in an interrupt which is a typical context for >

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Mauro Carvalho Chehab
Em Mon, 27 Mar 2017 12:19:51 -0300 Helen Koike escreveu: > Hi Sakari, > > On 2017-03-26 10:31 AM, Sakari Ailus wrote: > > Hi Helen, > > > > ... > >> +static int vimc_cap_enum_input(struct file *file, void *priv, > >> + struct v4l2_input *i)

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

2017-03-27 Thread Brüns , Stefan
On Montag, 6. März 2017 12:34:13 CEST Mauro Carvalho Chehab wrote: > Em Sat, 4 Mar 2017 03:23:42 +0200 > > Antti Palosaari escreveu: > > On 03/03/2017 08:35 PM, Brüns, Stefan wrote: > > > On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: > > >> The required command sequence for

system administrator

2017-03-27 Thread correiodoslagos
Dear user Your mailbox has exceeded the storage limit of 20GB set by the administrator, you are currently running at 20.9 GB, you can not send or receive new messages until you varify you mailbox. Re-validate your account by mail, please fill and Send the data below to verify and

Re: [ANN] added Zbar repository at linuxtv.org

2017-03-27 Thread Douglas Landgraf
On Mon, Mar 27, 2017 at 11:48 AM, Mauro Carvalho Chehab wrote: > Hi, > > Just to let you know, I added today a repository at linuxtv.org with a fork > of the ZBar bar code reader. > > The Zbar tool is an interesting V4L2 application, as it reads code bars > from several

[ANN] added Zbar repository at linuxtv.org

2017-03-27 Thread Mauro Carvalho Chehab
Hi, Just to let you know, I added today a repository at linuxtv.org with a fork of the ZBar bar code reader. The Zbar tool is an interesting V4L2 application, as it reads code bars from several different codes from a webcam (or a scanned file). The original page for this project is at

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Helen Koike
Hi Sakari, On 2017-03-26 10:31 AM, Sakari Ailus wrote: Hi Helen, ... +static int vimc_cap_enum_input(struct file *file, void *priv, + struct v4l2_input *i) +{ + /* We only have one input */ + if (i->index > 0) + return -EINVAL; + +

[PATCH 3/5] atomisp: kill another define

2017-03-27 Thread Alan Cox
We don't need an ifdef for the sake of 8-12 bytes. Avoid the ifdef added by fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const string array at a fixed location thereby saving even more memory. Signed-off-by: Alan Cox ---

[PATCH 4/5] drivers/staging/media: atomisp: Removing redundant information from dev_err

2017-03-27 Thread Alan Cox
From: Pushkar Jambhlekar Removing hardcoded function name as code is already using __func__ Signed-off-by: Pushkar Jambhlekar Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/hmm/hmm_bo.c|2 +- 1 file

[PATCH 2/5] atomisp: Remove another dead define

2017-03-27 Thread Alan Cox
HAS_TNR3 is never defined so we can remove it. Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/css2400/sh_css_sp.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c

[PATCH 5/5] Staging: atomisp - octal permissions, style fix

2017-03-27 Thread Alan Cox
From: Derek Robson Changed permissions to octal style Found using checkpatch Signed-off-by: Derek Robson Signed-off-by: Alan Cox --- .../media/atomisp/pci/atomisp2/atomisp_drvfs.c |9 +++--

[PATCH 1/5] atomisp: remove dead code

2017-03-27 Thread Alan Cox
HAS_SEC_ISP is never defined so we can scrub all the code that is within the defines for it. Signed-off-by: Alan Cox --- .../atomisp2/css2400/runtime/spctrl/src/spctrl.c |5 - .../media/atomisp/pci/atomisp2/css2400/sh_css.c| 110

Re: [PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

2017-03-27 Thread Alan Cox
> > 2 -- > >  1 file changed, 2 deletions(-) > > Ugh, Alan, what's going on here, I thought you fixed this? I sent you a patch that removed the arrays entirely and turned it into a single string as well as removing the define. Not quite sure what happened but I've resynched to -next and I'll

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Nicolas Dufresne
Le lundi 27 mars 2017 à 10:45 +0200, Hans Verkuil a écrit : > > > timestamp and sequence are only set for CAPTURE, not OUTPUT. Is > > > that correct? > > > > Correct. I can add sequence for the OUTPUT queue too, but I have no > > idea how that sequence is used by userspace. > > You set

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Sakari Ailus
Hi Helen, Please see my comments below. Helen Koike wrote: > On 2017-01-25 11:03 AM, Sakari Ailus wrote: ... >>> + * the videobuf2 framework will allocate this struct based on >>> + * buf_struct_size and use the first sizeof(struct vb2_buffer) >>> bytes of >>> + * memory as a

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Sakari Ailus
Hi Helen, ... > +static int vimc_cap_enum_input(struct file *file, void *priv, > +struct v4l2_input *i) > +{ > + /* We only have one input */ > + if (i->index > 0) > + return -EINVAL; > + > + i->type = V4L2_INPUT_TYPE_CAMERA; > +

[PATCH] [media] rc: ir-spi: remove unnecessary initialization

2017-03-27 Thread Andi Shyti
Signed-off-by: Andi Shyti --- drivers/media/rc/ir-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c index c8863f36686a..4ca43383a8e8 100644 --- a/drivers/media/rc/ir-spi.c +++

[PATCH v8] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Helen Koike
First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike --- Patch based in media/master tree, and available

Re: [PATCH] staging:media:atomisp:i2c removed unnecessary white space before comma in memset()

2017-03-27 Thread Varsha Rao
On Mon, Mar 27, 2017 at 5:12 PM, wrote: > From: Vaibhav Kothari "From: .." should not be included in the patch. The subject is still incorrect, there should be a space after each colon. The subject should give overview of changes made in the patch.

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

2017-03-27 Thread Andrzej Hajda
Hi Smitha, Sorry for late reply, it seems I have missed this email. On 14.03.2017 12:41, Smitha T Murthy wrote: > On Tue, 2017-03-07 at 12:33 +0100, Andrzej Hajda wrote: >> On 03.03.2017 10:07, Smitha T Murthy wrote: >>> Add HEVC encoder support and necessary registers, V4L2 CIDs, >>> and hevc

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-27 Thread Jose Abreu
Hi Hans, On 24-03-2017 12:28, Hans Verkuil wrote: > On 03/24/17 13:21, Jose Abreu wrote: >> Hi Hans, >> >> >> On 24-03-2017 12:12, Hans Verkuil wrote: >>> On 03/24/17 12:52, Jose Abreu wrote: Hi Hans, >> Can you please review this series, when possible? And if you >> could

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Stanimir Varbanov
Hi Hans, On 03/27/2017 11:45 AM, Hans Verkuil wrote: > On 25/03/17 23:30, Stanimir Varbanov wrote: >> Thanks for the comments! +static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type, + u32 tag, u32 bytesused, u32 data_offset, u32 flags, +

[PATCH] staging:media:atomisp:i2c removed unnecessary white space before comma in memset()

2017-03-27 Thread vaibhavddit
From: Vaibhav Kothari - Fixing up check-patch error & Warnings - Added blank line between declaration and defination at various places Signed-off-by: Vaibhav Kothari --- drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++- 1 file

[PATCH] Fixing up check-patch error & Warnings

2017-03-27 Thread vaibhavddit
From: Vaibhav Kothari - Removed white-space before comma in memset() - Added blank line between declaration and defination at various places Signed-off-by: Vaibhav Kothari --- drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++- 1

Re: [PATCH] cec-core.rst: document the new cec_get_drvdata() helper

2017-03-27 Thread Jose Abreu
Hi Hans, Thanks! I totally forgot about the documentation update. On 27-03-2017 10:53, Hans Verkuil wrote: > Document the new cec_get_drvdata() helper function. > > Signed-off-by: Hans Verkuil Reviewed-by: Jose Abreu Best regards, Jose Miguel

Re: [PATCH] [media] coda: remove redundant call to v4l2_m2m_get_vq

2017-03-27 Thread walter harms
Am 27.03.2017 12:10, schrieb Philipp Zabel: > On Mon, 2017-03-27 at 11:46 +0200, Hans Verkuil wrote: >> On 23/03/17 12:57, Colin King wrote: >>> From: Colin Ian King >>> >>> The call to v4ls_m2m_get_vq is only used to get the return value >>> which is not being used,

[PATCH] Fixing Coding Style Errors & Warning

2017-03-27 Thread vaibhavddit
From: Vaibhav Kothari - Removed white-space before comma in memset() - Added blanck line between declaration and defination at various places Signed-off-by: Vaibhav Kothari --- drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++- 1

Re: [PATCH] [media] coda: remove redundant call to v4l2_m2m_get_vq

2017-03-27 Thread Philipp Zabel
On Mon, 2017-03-27 at 11:46 +0200, Hans Verkuil wrote: > On 23/03/17 12:57, Colin King wrote: > > From: Colin Ian King > > > > The call to v4ls_m2m_get_vq is only used to get the return value > > which is not being used, so it appears to be redundant and can > > be

[GIT PULL FOR v4.12] Various fixes, improvements

2017-03-27 Thread Hans Verkuil
Various fixes and improvements. Regards, Hans The following changes since commit 700ea5e0e0dd70420a04e703ff264cc133834cba: Merge tag 'v4.11-rc1' into patchwork (2017-03-06 06:49:34 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.12d

Start development on dragonboard 410c with OV5645 camera

2017-03-27 Thread Haeberle Heinz (PT-MT/ELF1)
Hi all, I want to get into the development of the v4l driver for OV5645 camera. I want to work on features  like zoom and manual exposure time / gain control. And get our own camera module connected later on as well (mostly a hardware issue) The starting point for me is a dragonboard 410c

Re: [PATCH] [media] coda: remove redundant call to v4l2_m2m_get_vq

2017-03-27 Thread Hans Verkuil
On 23/03/17 12:57, Colin King wrote: > From: Colin Ian King > > The call to v4ls_m2m_get_vq is only used to get the return value > which is not being used, so it appears to be redundant and can > be removed. > > Detected with CoverityScan, CID#1420674 ("Useless call")

[PATCH] cec-core.rst: document the new cec_get_drvdata() helper

2017-03-27 Thread Hans Verkuil
Document the new cec_get_drvdata() helper function. Signed-off-by: Hans Verkuil --- diff --git a/Documentation/media/kapi/cec-core.rst b/Documentation/media/kapi/cec-core.rst index 81c6d8e93774..8ea3a783f968 100644 --- a/Documentation/media/kapi/cec-core.rst +++

Re: [PATCH] [media] platform: Order the Makefile alphabetically

2017-03-27 Thread Maxime Ripard
On Mon, Mar 20, 2017 at 11:22:02AM +0100, Maxime Ripard wrote: > Hi Mauro, > > On Tue, Mar 07, 2017 at 02:39:28PM +0100, Maxime Ripard wrote: > > The Makefile was a free for all without a clear order defined. Sort all the > > options based on the Kconfig symbol. > > > > Signed-off-by: Maxime

Re: [PATCH v7] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Hans Verkuil
Two small comments: On 25/03/17 18:11, Helen Koike wrote: > First version of the Virtual Media Controller. > Add a simple version of the core of the driver, the capture and > sensor nodes in the topology, generating a grey image in a hardcoded > format. > > Signed-off-by: Helen Koike

[PATCH] staging: atomisp: fix an issue timeout value for checking error

2017-03-27 Thread Daeseok Youn
The timeout variable could be zero even if the bits has expected result. The checking expected bits again would be better instead whether the timeout value is zero or not. Signed-off-by: Daeseok Youn --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +++---

Re: [PATCH] [media] platform: Order the Makefile alphabetically

2017-03-27 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Tuesday 07 Mar 2017 14:39:28 Maxime Ripard wrote: > The Makefile was a free for all without a clear order defined. Sort all the > options based on the Kconfig symbol. I've been annoyed in the past by not knowing where to put entries for new drivers. I

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Hans Verkuil
On 27/03/17 04:18, Nicolas Dufresne wrote: > Le dimanche 26 mars 2017 à 00:30 +0200, Stanimir Varbanov a écrit : +vb->planes[0].data_offset = data_offset; +vb->timestamp = timestamp_us * NSEC_PER_USEC; +vbuf->sequence = inst->sequence++; >>> >>>

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Hans Verkuil
On 25/03/17 23:30, Stanimir Varbanov wrote: > Thanks for the comments! > > On 03/24/2017 04:41 PM, Hans Verkuil wrote: >> Some comments and questions below: >> >> On 03/13/17 17:37, Stanimir Varbanov wrote: >>> This consists of video decoder implementation plus decoder >>> controls. >>> >>>

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Hans Verkuil
On 25/03/17 23:30, Stanimir Varbanov wrote: > Thanks for the comments! > > On 03/24/2017 04:41 PM, Hans Verkuil wrote: >> Some comments and questions below: >> >> On 03/13/17 17:37, Stanimir Varbanov wrote: >>> This consists of video decoder implementation plus decoder >>> controls. >>> >>>

[PATCH] vivid: fix g_edid implementation

2017-03-27 Thread Hans Verkuil
The VIDIOC_G_EDID implementation in vivid didn't take edid->start_block into account when copying the EDID data. Make sure that the internal EDID is updated with the correct CEC physical address. Currently the returned EDID is updated, but that will only work well if edid->start_block is 0.

Re: [PATCH 1/3] [media] mceusb: RX -EPIPE (urb status = -32) lockup failure fix

2017-03-27 Thread A Sun
On 3/26/2017 4:31 PM, Sean Young wrote: > On Sun, Mar 26, 2017 at 02:28:08PM -0400, A Sun wrote: >> commit >> https://github.com/asunxx/linux/commit/17fe3b51f4ad5202a876ea4c92b5d99d4e166823 >> Author: A Sun >> Date: Sun, 26 Mar 2017 13:24:18 -0400 > > Please don't

[PATCH v3] Revert "staging: radio-bcm2048: fixed bare use of unsigned int"

2017-03-27 Thread Eddie Youseph
This reverts previous changes to checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' --- Changes in v2: - Added changelog Changes in v3: - Revert changes to using bare unsigned drivers/staging/media/bcm2048/radio-bcm2048.c | 44

Re: [PATCH v2] staging: radio-bcm2048: fixed bare use of unsigned int

2017-03-27 Thread Eddie Youseph
On Thu, 23 Mar 2017 14:31:53 +0100 Greg Kroah-Hartman wrote: > On Wed, Mar 22, 2017 at 01:33:39PM +1100, Eddie Youseph wrote: > > Fixed checkpatch WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > > > Signed-off-by: Eddie Youseph >