Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-15 Thread Tomasz Figa
On Tue, Jun 6, 2017 at 7:09 PM, Tomasz Figa wrote: > On Tue, Jun 6, 2017 at 5:04 PM, Hans Verkuil wrote: >> On 06/06/17 09:25, Sakari Ailus wrote: >>> Hi Tomasz, >>> >>> On Tue, Jun 06, 2017 at 01:30:41PM +0900, Tomasz Figa wrote: Uhm, +Laurent. Sorry

Re: [git:media_tree/master] [media] s3c-camif: fix arguments position in a function call

2017-06-15 Thread Gustavo A. R. Silva
Hi Sylwester, Quoting Mauro Carvalho Chehab : This is an automatic generated email to let you know that the following patch were queued: Subject: [media] s3c-camif: fix arguments position in a function call Author: Gustavo A. R. Silva

RE: [PATCH v8] dw9714: Initial driver for dw9714 VCM

2017-06-15 Thread Mani, Rajmohan
Hi Sakari, > > > > On Sat, Jun 03, 2017 at 01:11:40AM -0700, Rajmohan Mani wrote: > > > DW9714 is a 10 bit DAC, designed for linear control of voice coil > > > motor. > > > > > > This driver creates a V4L2 subdevice and provides control to set the > > > desired focus. > > > > > > Signed-off-by:

[PATCH] [media] ov6650: convert to standalone v4l2 subdevice

2017-06-15 Thread Janusz Krzysztofik
Remove the soc_camera dependencies. Lost features, fortunately not used or not critical on test platform: - soc_camera power on/off callback - replaced with clock enable/disable only, no support for platform provided regulators nor power callback, - soc_camera sense request - replaced with

[PATCH] omap3isp: fix compilation

2017-06-15 Thread Pavel Machek
Fix compilation of isp.c Signed-off-by: Pavel Machek diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 4ca3fc9..b80debf 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2026,7

n900 camera on v4.12-rc (was Re: v4l2-fwnode: status, plans for merge, any branch to merge against?)

2017-06-15 Thread Pavel Machek
Hi! Ok, so I played a bit, and now I have working camera in v4.12-rc3. https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-n900.git/ camera-fw5-3 is recommended branch to play with. Sakari, should I attempt to clean/send you patches, or would it be better to wait till ccp2 branch is

Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

2017-06-15 Thread Sakari Ailus
On Wed, Jun 14, 2017 at 09:41:29PM +0200, Pavel Machek wrote: > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c > index 4ca3fc9..b80debf 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2026,7

[PATCH] af9013: add check on af9013_wr_regs() return value

2017-06-15 Thread Gustavo A. R. Silva
Check return value from call to af9013_wr_regs(), so in case of error print debug message and return. Addresses-Coverity-ID: 1227035 Signed-off-by: Gustavo A. R. Silva --- drivers/media/dvb-frontends/af9013.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[media-m5602-po1030] question about return value check

2017-06-15 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1227044 I ran into the following piece of code at drivers/media/usb/gspca/m5602/m5602_po1030.c:280: 280int po1030_start(struct sd *sd) 281{ 282struct cam *cam = >gspca_dev.cam; 283int i, err = 0; 284int width =

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-15 Thread Kevin Hilman
Hi Hans, Mauro, On Fri, Jun 9, 2017 at 9:10 AM, Kevin Hilman wrote: > The davinci VPIF is a single hardware block, but the existing driver > is broken up into a common library (vpif.c), output (vpif_display.c) and > intput (vpif_capture.c). > > When migrating to DT, to

[PATCH] i2c: tc358743: remove useless variable assignment in tc358743_isr

2017-06-15 Thread Gustavo A. R. Silva
Remove useless variable assignment in function tc358743_isr(). The value stored in variable _intstatus_ at line 1299 is overwritten at line 1302, just before it can be used. Addresses-Coverity-ID: 1397678 Signed-off-by: Gustavo A. R. Silva ---

[PATCH v11 04/19] media: venus: adding core part and helper functions

2017-06-15 Thread Stanimir Varbanov
* core.c has implemented the platform driver methods, file operations and v4l2 registration. * helpers.c has implemented common helper functions for: - buffer management - vb2_ops and functions for format propagation, - functions for allocating and freeing buffers for internal

[PATCH v11 06/19] media: venus: venc: add video encoder files

2017-06-15 Thread Stanimir Varbanov
This adds encoder part of the driver plus encoder controls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/venc.c | 1283 drivers/media/platform/qcom/venus/venc.h | 23 +

[PATCH v11 08/19] media: venus: hfi: add Venus HFI files

2017-06-15 Thread Stanimir Varbanov
Here is the implementation of Venus video accelerator low-level functionality. It contanins code which setup the registers and startup uthe processor, allocate and manipulates with the shared memory used for sending commands and receiving messages. Signed-off-by: Stanimir Varbanov

[PATCH v11 09/19] media: venus: enable building of Venus video driver

2017-06-15 Thread Stanimir Varbanov
This adds Venus driver Makefile and changes v4l2 platform Makefile/Kconfig in order to enable building of the driver. Note that in this initial version the COMPILE_TEST-ing is not supported because the drivers specific to ARM builds are still in process of enabling the aforementioned compile

[PATCH v11 05/19] media: venus: vdec: add video decoder files

2017-06-15 Thread Stanimir Varbanov
This consists of video decoder implementation plus decoder controls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 1154 drivers/media/platform/qcom/venus/vdec.h | 23 +

[PATCH v11 10/19] media: venus: hfi: fix mutex unlock

2017-06-15 Thread Stanimir Varbanov
This fixed a warning when build driver with gcc7: drivers/media/platform/qcom/venus/hfi.c:171 hfi_core_ping() warn: inconsistent returns 'mutex:>lock'. Locked on: line 159 Unlocked on: line 171 Signed-off-by: Stanimir Varbanov ---

[PATCH v11 13/19] media: venus: hfi_venus: fix variable dereferenced before check

2017-06-15 Thread Stanimir Varbanov
This fixes a warning found when building with gcc7: drivers/media/platform/qcom/venus/hfi_venus.c:998 venus_isr_thread() warn: variable dereferenced before check 'hdev' (see line 994) Signed-off-by: Stanimir Varbanov ---

[PATCH v11 11/19] media: venus: hfi_cmds: fix variable dereferenced before check

2017-06-15 Thread Stanimir Varbanov
This fixes a warning found when building the driver with gcc7: drivers/media/platform/qcom/venus/hfi_cmds.c:415 pkt_session_set_property_1x() warn: variable dereferenced before check 'pkt' (see line 412) drivers/media/platform/qcom/venus/hfi_cmds.c:1177 pkt_session_set_property_3xx() warn:

[PATCH v11 17/19] media: venus: vdec: add support for min buffers for capture

2017-06-15 Thread Stanimir Varbanov
This adds support for V4L2_CID_MIN_BUFFERS_FOR_CAPTURE get control in venus decoder, it is usable in case when the userspace wants to know minimum capture buffers before calling request_buf for capture queue in mem2mem drivers. Also this will fix an issue found gstreamer v4l2videodec element, i.e.

[PATCH v11 18/19] media: venus: update firmware path with linux-firmware place

2017-06-15 Thread Stanimir Varbanov
This makes firmware name and path part of venus_resources structure and initialize it properly depending on the SoC and firmware version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 6 --

[PATCH v11 15/19] media: venus: vdec: fix compile error in vdec_close

2017-06-15 Thread Stanimir Varbanov
This fixes the following compile error ocured when building with gcc7: drivers/media/platform/qcom/venus/vdec.c:1022 vdec_close() error: dereferencing freed memory 'inst' by moving kfree as a last call. Signed-off-by: Stanimir Varbanov ---

[PATCH v11 19/19] media: venus: enable building with COMPILE_TEST

2017-06-15 Thread Stanimir Varbanov
We want all media drivers to build with COMPILE_TEST, as the Coverity instance we use on Kernel works only for x86. Also, our test workflow relies on it, in order to identify git bisect breakages. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Stanimir Varbanov

[PATCH v11 16/19] media: venus: venc: fix compile error in venc_close

2017-06-15 Thread Stanimir Varbanov
This fixes the following compile error ocured when building with gcc7: drivers/media/platform/qcom/venus/venc.c:1150 venc_close() error: dereferencing freed memory 'inst' by moving kfree as a last call. Signed-off-by: Stanimir Varbanov ---

[PATCH v11 12/19] media: venus: helpers: fix variable dereferenced before check

2017-06-15 Thread Stanimir Varbanov
This fixes a warning found when building the driver with gcc7: drivers/media/platform/qcom/venus/helpers.c:157 load_per_instance() warn: variable dereferenced before check 'inst' (see line 153) Signed-off-by: Stanimir Varbanov ---

[PATCH v11 14/19] media: venus: hfi_msgs: fix set but not used variables

2017-06-15 Thread Stanimir Varbanov
This fixes a warning found when building with gcc7: drivers/media/platform/qcom/venus/hfi_msgs.c:465:40: warning: variable 'domain' set but not used [-Wunused-but-set-variable] u32 rem_bytes, num_props, codecs = 0, domain = 0; ^~

[PATCH v11 03/19] MAINTAINERS: Add Qualcomm Venus video accelerator driver

2017-06-15 Thread Stanimir Varbanov
Add an entry for Venus video encoder/decoder accelerator driver. Signed-off-by: Stanimir Varbanov --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..2cf03bb969b5 100644 --- a/MAINTAINERS +++

[PATCH v11 07/19] media: venus: hfi: add Host Firmware Interface (HFI)

2017-06-15 Thread Stanimir Varbanov
This is the implementation of HFI. It is charged with the responsibility to comunicate with the firmware through an interface commands and messages. - hfi.c has interface functions used by the core, decoder and encoder parts to comunicate with the firmware. For example there are functions for

[PATCH v11 01/19] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-06-15 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov ---

[PATCH v11 02/19] doc: DT: venus: binding document for Qualcomm video driver

2017-06-15 Thread Stanimir Varbanov
Add binding document for Venus video encoder/decoder driver Cc: Rob Herring Cc: devicet...@vger.kernel.org Acked-by: Rob Herring Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/media/qcom,venus.txt | 107

[PATCH v11 00/19] Qualcomm video decoder/encoder driver

2017-06-15 Thread Stanimir Varbanov
Hello, Changes since v10: * added patch 18/19 which updates firmware path. regards, Stan Stanimir Varbanov (19): media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management doc: DT: venus: binding document for Qualcomm video driver MAINTAINERS: Add Qualcomm Venus video

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-15 Thread Dave Stevenson
Hi Sakari. Thanks for the review. On 15 June 2017 at 13:59, Sakari Ailus wrote: > Hi Dave, > > Thanks for the set! > > On Wed, Jun 14, 2017 at 04:15:46PM +0100, Dave Stevenson wrote: >> Document the DT bindings for the CSI2/CCP2 receiver peripheral >> (known as Unicam) on

Re: [GIT PULL] linux-firmware: Add Qualcomm Venus firmware

2017-06-15 Thread Kyle McMartin
On Mon, Jun 12, 2017 at 07:30:30PM +0300, Stanimir Varbanov wrote: > Hi, > > This pull request adds firmware for venus video codec driver. > > The following changes since commit 37857004a430e96dc837db7f967b6d0279053de8: > > linux-firmware: add firmware image for Redpine 9113 chipset >

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Dave Stevenson
Hi Stefan. On 15 June 2017 at 15:49, Stefan Wahren wrote: > Hi Dave, > > Am 15.06.2017 um 15:38 schrieb Dave Stevenson: >> Hi Hans. >> >> "On 15 June 2017 at 08:12, Hans Verkuil wrote: >>> Hi Dave, >>> >>> Here is a quick review of this driver. Once a

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Dave Stevenson
On 15 June 2017 at 15:14, Hans Verkuil wrote: > On 06/15/17 15:38, Dave Stevenson wrote: >> Hi Hans. >> >> "On 15 June 2017 at 08:12, Hans Verkuil wrote: >>> Hi Dave, >>> >>> Here is a quick review of this driver. Once a v2 is posted I'll do a more >>>

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Stefan Wahren
Hi Dave, Am 15.06.2017 um 15:38 schrieb Dave Stevenson: > Hi Hans. > > "On 15 June 2017 at 08:12, Hans Verkuil wrote: >> Hi Dave, >> >> Here is a quick review of this driver. Once a v2 is posted I'll do a more >> thorough >> check. > Thank you. I wasn't expecting such a quick

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Hans Verkuil
On 06/15/17 15:38, Dave Stevenson wrote: > Hi Hans. > > "On 15 June 2017 at 08:12, Hans Verkuil wrote: >> Hi Dave, >> >> Here is a quick review of this driver. Once a v2 is posted I'll do a more >> thorough >> check. > > Thank you. I wasn't expecting such a quick response. >

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

2017-06-15 Thread Jacek Anaszewski
On 06/15/2017 03:34 PM, Sakari Ailus wrote: > Hi Jacek, > > On Thu, Jun 15, 2017 at 03:01:47PM +0200, Jacek Anaszewski wrote: >> Hi Sakari, >> >> On 06/15/2017 12:10 AM, Sakari Ailus wrote: >>> Hi Jacek, >>> >>> Thanks for the review! >> >> You're welcome! >> >>> I have to say I found the

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Dave Stevenson
Hi Hans. "On 15 June 2017 at 08:12, Hans Verkuil wrote: > Hi Dave, > > Here is a quick review of this driver. Once a v2 is posted I'll do a more > thorough > check. Thank you. I wasn't expecting such a quick response. > On 06/14/2017 05:15 PM, Dave Stevenson wrote: >> >>

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

2017-06-15 Thread Sakari Ailus
Hi Jacek, On Thu, Jun 15, 2017 at 03:01:47PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 06/15/2017 12:10 AM, Sakari Ailus wrote: > > Hi Jacek, > > > > Thanks for the review! > > You're welcome! > > > I have to say I found the v4l2-flash-led-class framework quite useful, now > > that I

Re: [PATCHv2] ARM: dts: exynos: add needs-hpd to for Odroid-U3

2017-06-15 Thread Krzysztof Kozlowski
On Tue, Jun 13, 2017 at 03:47:06PM +0200, Hans Verkuil wrote: > The Odroid-U3 board has an IP4791CZ12 level shifter that is > disabled if the HPD is low, which means that the CEC pin is > disabled as well. > > Signed-off-by: Hans Verkuil > --- > Changes since v1: moved

Re: [PATCH v5 2/2] v4l: vsp1: Repair suspend resume operations for video pipelines

2017-06-15 Thread Kieran Bingham
On 09/05/17 13:37, Kieran Bingham wrote: > When a suspend/resume action is taken, the pipeline is reset and never > reconfigured. > > To correct this, we establish a new flag pipe->configured and utilise > this to establish when we write a full configuration set to the current > display list. >

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

2017-06-15 Thread Jacek Anaszewski
Hi Sakari, On 06/15/2017 12:10 AM, Sakari Ailus wrote: > Hi Jacek, > > Thanks for the review! You're welcome! > I have to say I found the v4l2-flash-led-class framework quite useful, now > that I refactored a driver for using it. Now we have a user for the > indicator, too. :-) Nice :-). I'm

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-15 Thread Sakari Ailus
Hi Dave, Thanks for the set! On Wed, Jun 14, 2017 at 04:15:46PM +0100, Dave Stevenson wrote: > Document the DT bindings for the CSI2/CCP2 receiver peripheral > (known as Unicam) on BCM283x SoCs. > > Signed-off-by: Dave Stevenson > --- >

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sebastian Reichel
Hi, On Thu, Jun 15, 2017 at 03:32:10PM +0300, Sakari Ailus wrote: > On Thu, Jun 15, 2017 at 11:24:26AM +0200, Sebastian Reichel wrote: > > On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > > > None of the flash operations are not mandatory and therefore there should > > > be no need

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-15 Thread Dave Stevenson
Hi Stefan. Thanks for taking the time to review this. On 15 June 2017 at 07:34, Stefan Wahren wrote: > Hi Dave, > > Am 14.06.2017 um 17:15 schrieb Dave Stevenson: >> Document the DT bindings for the CSI2/CCP2 receiver peripheral >> (known as Unicam) on BCM283x SoCs. >> >>

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sakari Ailus
On Thu, Jun 15, 2017 at 11:24:26AM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > > None of the flash operations are not mandatory and therefore there should > > be no need for the flash ops structure either. Accept NULL. > > I think you

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-06-15 Thread Hans Verkuil
On 06/15/17 14:29, Dave Stevenson wrote: > On 15 June 2017 at 08:17, Hans Verkuil wrote: >> On 06/14/2017 11:03 PM, Dave Stevenson wrote: >>> >>> On 14 June 2017 at 18:38, Hans Verkuil wrote: On 06/14/2017 06:29 PM, Dave Stevenson wrote: >

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-06-15 Thread Dave Stevenson
On 15 June 2017 at 08:17, Hans Verkuil wrote: > On 06/14/2017 11:03 PM, Dave Stevenson wrote: >> >> On 14 June 2017 at 18:38, Hans Verkuil wrote: >>> >>> On 06/14/2017 06:29 PM, Dave Stevenson wrote: Hi Hans. On 14 June 2017 at

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Jacek Anaszewski
Hi Sakari, On 06/14/2017 11:19 PM, Sakari Ailus wrote: > Hi Jacek, > > On Wed, Jun 14, 2017 at 11:14:13PM +0200, Jacek Anaszewski wrote: >> Hi Sakari, >> >> On 06/14/2017 11:47 AM, Sakari Ailus wrote: >>> None of the flash operations are not mandatory and therefore there should >>> be no need

Re: [PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:15PM +0300, Sakari Ailus wrote: > The V4L2 flash class initialisation expects struct led_classdev_flash that > describes an indicator but only uses struct led_classdev which is a field > iled_cdev in the struct. Use struct iled_cdev only. > > Signed-off-by:

Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

2017-06-15 Thread Pavel Machek
Krasny den! > > > Thanks for the review! > > > > You are welcome :-). > > > > > On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote: > > > > Hi! > > > > > > > > > From: Sakari Ailus > > > > > > > > That address no longer works, right? > > > > > > Why wouldn't

Re: [PATCH 8/8] arm: dts: omap3: N9/N950: Add AS3645A camera flash

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:19PM +0300, Sakari Ailus wrote: > From: Sakari Ailus > > Add the as3645a flash controller to the DT source as well as the flash > property with the as3645a device phandle to the sensor DT node. > > Signed-off-by: Sakari Ailus

Re: [PATCH v7 2/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2017-06-15 Thread Sakari Ailus
Hejssan Niklas, On Thu, Jun 15, 2017 at 10:48:20AM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your comments. > > On 2017-05-29 14:35:16 +0300, Sakari Ailus wrote: > > Hi Niklas, > > > > A few comments below. > > > > On Wed, May 24, 2017 at 02:13:53AM +0200, Niklas Söderlund

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > None of the flash operations are not mandatory and therefore there should > be no need for the flash ops structure either. Accept NULL. I think you negated one time too much :). Otherwise: Reviewed-by: Sebastian Reichel

Re: [PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:12PM +0300, Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > > Signed-off-by: Sakari Ailus

[PATCH v4 0/2] media: entity: add operation to help map DT node to media pad

2017-06-15 Thread Niklas Söderlund
Hi, This series add a new entity operation which will aid capture drivers to map a port/endpoint in DT to a media graph pad. This series is implemented support for the ongoing ADV748x work by Kieran Bingham. In his work he have a driver which registers more then one subdevice. So when a driver

[PATCH v4 2/2] media: entity: Add media_entity_get_fwnode_pad() function

2017-06-15 Thread Niklas Söderlund
This is a wrapper around the media entity get_fwnode_pad operation. Signed-off-by: Niklas Söderlund Acked-by: Sakari Ailus --- drivers/media/media-entity.c | 36

[PATCH v4 1/2] media: entity: Add get_fwnode_pad entity operation

2017-06-15 Thread Niklas Söderlund
The optional operation can be used by entities to report how it maps its fwnode endpoints to media pad numbers. This is useful for devices which require advanced mappings of pads. Signed-off-by: Niklas Söderlund Acked-by: Sakari Ailus

Re: [PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor

2017-06-15 Thread Pavel Machek
On Wed 2017-06-14 12:47:12, Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > > Signed-off-by: Sakari Ailus

Re: [PATCH 1/6] v4l: vsp1: Remove WPF vertical flip support on VSP2-B[CD] and VSP2-D

2017-06-15 Thread Hans Verkuil
On 06/15/17 10:24, Laurent Pinchart wrote: > The WPF vertical flip is only supported on Gen3 SoCs on the VSP2-I. > Don't enable it on other VSP2 instances. > > Signed-off-by: Laurent Pinchart Should this go to older kernels as well? Or is that not

Re: [PATCH v7 1/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

2017-06-15 Thread Niklas Söderlund
Hi Sakari, On 2017-06-14 13:45:58 +0300, Sakari Ailus wrote: > Hi Niklas, > > On Tue, Jun 13, 2017 at 06:50:14PM +0200, Niklas Söderlund wrote: > > Hi Sakari, > > > > Thanks for your feedback. > > > > On 2017-05-29 14:16:25 +0300, Sakari Ailus wrote: > > > Hi Niklas, > > > > > > On Wed, May

Re: [PATCH v7 2/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2017-06-15 Thread Niklas Söderlund
Hi Sakari, Thanks for your comments. On 2017-05-29 14:35:16 +0300, Sakari Ailus wrote: > Hi Niklas, > > A few comments below. > > On Wed, May 24, 2017 at 02:13:53AM +0200, Niklas Söderlund wrote: > > From: Niklas Söderlund > > > > A V4L2 driver for

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-15 Thread Hans Verkuil
On 06/15/17 08:29, Minghsiu Tsai wrote: > Hi, Hans, > > Would you have time to review this patch v2? > The patch v1 violates v4l2 spec. I have fixed it in v2. I plan to review it Friday or Monday. Regards, Hans > > > Sincerely, > Ming Hsiu > > On Fri, 2017-05-12 at 10:42 +0800,

Re: [PATCH 00/12] Intel IPU3 ImgU patchset

2017-06-15 Thread Sakari Ailus
On Thu, Jun 15, 2017 at 11:26:05AM +0300, Andy Shevchenko wrote: > On Thu, Jun 15, 2017 at 1:26 AM, Sakari Ailus wrote: > > On Mon, Jun 05, 2017 at 09:46:59PM +0100, Alan Cox wrote: > > >> and a pointer to the firmware (which ideally should go into the standard > >> Linux

[GIT PULL FOR v4.13] Add ov13858 and dw9714 drivers, digital gain control

2017-06-15 Thread Sakari Ailus
Hi Mauro, Here are new drivers for the ov13858 sensor and the dw9714 lens voice coil driver, as well as the new V4L2_CID_DIGITAL_GAIN control. A small cleanup for the as3645a driver is included as well. Compared to the patches reviewed on the list, I've added MAINTAINERS entries to the drivers:

Re: [PATCH 00/12] Intel IPU3 ImgU patchset

2017-06-15 Thread Andy Shevchenko
On Thu, Jun 15, 2017 at 1:26 AM, Sakari Ailus wrote: > On Mon, Jun 05, 2017 at 09:46:59PM +0100, Alan Cox wrote: >> and a pointer to the firmware (which ideally should go into the standard >> Linux firmware git) > > Good question. Let me see what I can find. Just a side

[PATCH 6/6] v4l: vsp1: Add support for header display lists in continuous mode

2017-06-15 Thread Laurent Pinchart
The VSP supports both header and headerless display lists. The latter is easier to use when the VSP feeds data directly to the DU in continuous mode, and the driver thus uses headerless display lists for DU operation and header display lists otherwise. Headerless display lists are only available

[PATCH 4/6] v4l: vsp1: Add pipe index argument to the VSP-DU API

2017-06-15 Thread Laurent Pinchart
In the H3 ES2.0 SoC the VSP2-DL instance has two connections to DU channels that need to be configured independently. Extend the VSP-DU API with a pipeline index to identify which pipeline the caller wants to operate on. Signed-off-by: Laurent Pinchart

[PATCH 5/6] v4l: vsp1: Fill display list headers without holding dlm spinlock

2017-06-15 Thread Laurent Pinchart
The display list headers are filled using information from the display list only. Lower the display list manager spinlock contention by filling the headers without holding the lock. Signed-off-by: Laurent Pinchart ---

[PATCH 3/6] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances

2017-06-15 Thread Laurent Pinchart
New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL, as well as a new VSP2-D variant on V3M and V3H SoCs. Add new entries for them in the VSP device info table. Signed-off-by: Laurent Pinchart ---

[PATCH 0/6] Renesas R-Car VSP: Add H3 ES2.0 support

2017-06-15 Thread Laurent Pinchart
Hello, This patch series implements support for the R-Car H3 ES2.0 SoC in the VSP driver. Compared to the H3 ES1.1, the H3 ES2.0 has a new VSP2-DL instance that includes two blending units, a BRU and a BRS. The BRS is similar to the BRU but has two inputs only, and is used to service a second DU

[PATCH 2/6] v4l: vsp1: Add support for the BRS entity

2017-06-15 Thread Laurent Pinchart
The Blend/ROP Sub Unit (BRS) is a stripped-down version of the BRU found in several VSP2 instances. Compared to a regular BRU, it supports two inputs only, and thus has no ROP unit. Add support for the BRS by modeling it as a new entity type, but reuse the vsp1_bru object underneath. Chaining the

[PATCH 1/6] v4l: vsp1: Remove WPF vertical flip support on VSP2-B[CD] and VSP2-D

2017-06-15 Thread Laurent Pinchart
The WPF vertical flip is only supported on Gen3 SoCs on the VSP2-I. Don't enable it on other VSP2 instances. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

cron job: media_tree daily build: ERRORS

2017-06-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jun 15 05:00:15 CEST 2017 media-tree git hash:acec3630155763c170c7ae6508cf973355464508 media_build

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Stefan Wahren
Am 15.06.2017 um 09:12 schrieb Hans Verkuil: > Hi Dave, > > Here is a quick review of this driver. Once a v2 is posted I'll do a > more thorough > check. > > On 06/14/2017 05:15 PM, Dave Stevenson wrote: >> Add driver for the Unicam camera receiver block on >> BCM283x processors. >> >>

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-06-15 Thread Hans Verkuil
On 06/14/2017 11:03 PM, Dave Stevenson wrote: On 14 June 2017 at 18:38, Hans Verkuil wrote: On 06/14/2017 06:29 PM, Dave Stevenson wrote: Hi Hans. On 14 June 2017 at 16:42, Hans Verkuil wrote: Hi Dave, How does this driver relate to this staging

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Hans Verkuil
Hi Dave, Here is a quick review of this driver. Once a v2 is posted I'll do a more thorough check. On 06/14/2017 05:15 PM, Dave Stevenson wrote: Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson ---

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-15 Thread Stefan Wahren
Hi Dave, Am 14.06.2017 um 17:15 schrieb Dave Stevenson: > Document the DT bindings for the CSI2/CCP2 receiver peripheral > (known as Unicam) on BCM283x SoCs. > > Signed-off-by: Dave Stevenson please add the devicetree guys in CC for the binding. > --- >

Re: [PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator

2017-06-15 Thread kbuild test robot
/Sakari-Ailus/Support-registering-lens-flash-and-EEPROM-devices/20170615-084016 base: git://linuxtv.org/media_tree.git master config: tile-allmodconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin

Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-06-15 Thread Minghsiu Tsai
Hi, Hans, Would you have time to review this patch v2? The patch v1 violates v4l2 spec. I have fixed it in v2. Sincerely, Ming Hsiu On Fri, 2017-05-12 at 10:42 +0800, Minghsiu Tsai wrote: > From: Daniel Kurtz > > Experiments show that the: > (1) mtk-mdp uses the