Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote: > Hi, Sakari, > > Thanks for the time spent on code review, acks to all the comments, except > two places: > >> +/* .complete() is called after all subdevices have been located */ >> +static int

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jul 13 05:00:18 CEST 2017 media-tree git hash:2748e76ddb2967c4030171342ebdd3faa6a5e8e8 media_build

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 03:04 AM, Antti Palosaari wrote: On 07/13/2017 02:45 AM, Jasmin J. wrote: Hello Antti! Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 02:45 AM, Jasmin J. wrote: Hello Antti! Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix in a follow up, you mentioned other issues. Please

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

Hello Antti! > Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix in a follow up, you mentioned other issues. Please can you tell me which one you mean, so that

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 02:23 AM, Jasmin J. wrote: Hello Antti! Quickly looking this patch serie I noticed few other coding style mistakes. You should read kernel coding style documentation first, and then make changes according to doc. In fact I used checkpatch.pl to find the issues and fixed them.

Re: [PATCH] Added support for the TerraTec T1 DVB-T USB tuner [IT9135 chipset]

On 06/29/2017 08:55 PM, Nuno Henriques wrote: Signed-off-by: Nuno Henriques --- drivers/media/dvb-core/dvb-usb-ids.h | 1 + drivers/media/usb/dvb-usb-v2/af9035.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/media/dvb-core/dvb-usb-ids.h

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

Hello Antti! > Quickly looking this patch serie I noticed few other coding style mistakes. > You should read kernel coding style documentation first, and then make > changes according to doc. In fact I used checkpatch.pl to find the issues and fixed them. All the patches are 100% checkpatch.pl

RE: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi, Sakari, Thanks for the time spent on code review, acks to all the comments, except two places: > +/* .complete() is called after all subdevices have been located */ > +static int cio2_notifier_complete(struct v4l2_async_notifier *notifier) > +{ > + struct cio2_device *cio2 =

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 02:00 AM, Jasmin J. wrote: From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Also multiline comments should be written like this: /* * Comment. */ Quickly looking this patch serie I noticed few other coding style mistakes.

[PATCH V2 7/9] [media] dvb-core/dvb_ca_en50221.c: Added line breaks

From: Jasmin Jessich Fixed all: WARNING: Missing a blank line after declarations Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH V2 0/9] Fix coding style in en50221 CAM functions

From: Jasmin Jessich These patch series is the V2 version adapted to the already merged patches from V1 and other merged patches. It does no longer rename constants, as stated by Mauro as a no-go. It still fixed nearly all the style issues reported by checkpatch.pl in

[PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH V2 3/9] [media] dvb-core/dvb_ca_en50221.c: use usleep_range

From: Jasmin Jessich Fixed all: WARNING: msleep < 20ms can sleep for up to 20ms by using usleep_range. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V2 6/9] [media] dvb-core/dvb_ca_en50221.c: Used a helper variable

From: Jasmin Jessich Used a helper variable "struct dvb_ca_slot *sl" instead of "ca->slot_info[slot]". This reduces the line length and simplifies code reading. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 187

[PATCH V2 1/9] [media] dvb-core/dvb_ca_en50221.c: Refactored dvb_ca_en50221_thread

From: Jasmin Jessich Refactored "dvb_ca_en50221_thread" by moving the state machine into the new function "dvb_ca_en50221_thread_state_machine". This reduces the thread function size and reduces the structural complexity and of course gives us more space to meet the line length

[PATCH V2 5/9] [media] dvb-core/dvb_ca_en50221.c: Avoid assignments in ifs

From: Jasmin Jessich Fixed all: ERROR: do not use assignment in if condition Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 97 ++--- 1 file changed, 64 insertions(+), 33 deletions(-) diff --git

[PATCH V2 9/9] [media] dvb-core/dvb_ca_en50221.c: Fixed 80 char limit

From: Jasmin Jessich Fixed most of: WARNING: line over 80 characters The remaining lines are printk strings, which should not be split and lines where I thing they should stay as they are. Signed-off-by: Jasmin Jessich ---

[PATCH V2 8/9] [media] dvb-core/dvb_ca_en50221.c: Removed useless braces

From: Jasmin Jessich Fixed all: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-)

[PATCH V2 2/9] [media] dvb-core/dvb_ca_en50221.c: New function dvb_ca_en50221_poll_cam_gone

From: Jasmin Jessich The CAM poll code for the budget-av is exactly the same on several places. Extracting the code to a new function improves maintainability. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 63

omap3isp: is capture mode working? what hardware? was Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

Hi! > What I've done is just rebased the ccp2 branch. In other words, the patches > in that branch are no more ready than they were. > > To get these merged we should ideally > > 1) Make sure there will be no regressions, I grepped dts trees a bit... where is omap3isp currently used? Anything

Re: [PATCH v6] media: platform: Renesas IMR driver

Hello! On 07/06/2017 09:16 PM, Sergei Shtylyov wrote: [...] += + +This file documents some driver-specific aspects of the IMR driver, such as +driver-specific ioctls. + +The ioctl reference +~~~ + +VIDIOC_IMR_MESH - Set mapping data

[PATCH for 4.13] cec: cec_transmit_attempt_done: ignore CEC_TX_STATUS_MAX_RETRIES

The switch in cec_transmit_attempt_done() should ignore the CEC_TX_STATUS_MAX_RETRIES status bit. Calling this function with e.g. CEC_TX_STATUS_NACK | CEC_TX_STATUS_MAX_RETRIES is perfectly legal and should not trigger the WARN(1). Signed-off-by: Hans Verkuil --- After

Re: [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera

Hi Hugues, On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > This patchset enables OV9655 camera support. > > OV9655 support has been tested using STM32F4DIS-CAM extension board > plugged on connector P1 of STM32F746G-DISCO board. > Due to lack of OV9650/52 hardware support, the modified related

Re: [PATCH 4/4] drm/vc4: add HDMI CEC support

On 12/07/17 21:02, Eric Anholt wrote: > Hans Verkuil writes: > >> From: Hans Verkuil >> >> This patch adds support to VC4 for CEC. >> >> To prevent the firmware from eating the CEC interrupts you need to add this >> to >> your config.txt: >> >>

Re: [PATCH v2 3/7] [media] ov9650: add device tree support

On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > Allows use of device tree configuration data. > If no device tree data is there, configuration is taken from platform data. > In order to keep GPIOs configuration compatible between both way of doing, > GPIOs are switched to descriptor-based

Re: [PATCH 2/4] drm/vc4: prepare for CEC support

On 12/07/17 20:42, Eric Anholt wrote: > Hans Verkuil writes: > >> From: Hans Verkuil >> >> In order to support CEC the hsm clock needs to be enabled in >> vc4_hdmi_bind(), not in vc4_hdmi_encoder_enable(). Otherwise you wouldn't >> be able to support

Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case

On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > Switch i2c device id to lower case as it is s/i2c/I2C ? > done for other omnivision cameras. s/omnivision/Omnivision This is required for properly matching driver with device on DT platforms, right? It might be worth to mention that so it is

[PATCH v2] [media] lirc_zilog: Clean up lirc zilog error codes

According the coding style guidelines, the ENOSYS error code must be returned in case of a non existent system call. This code has been replaced with the ENOTTY error code indicating a missing functionality. v2: Improved punctuation Fixed patch subject Signed-off-by: Yves Lemée

Re: [PATCH 4/4] drm/vc4: add HDMI CEC support

Hans Verkuil writes: > From: Hans Verkuil > > This patch adds support to VC4 for CEC. > > To prevent the firmware from eating the CEC interrupts you need to add this to > your config.txt: > > mask_gpu_interrupt1=0x100 > > Signed-off-by: Hans Verkuil

RE: [v2,07/12] intel-ipu3: css: firmware management

Thanks Kaehlcke for reviewing the code. > -Original Message- > From: Matthias Kaehlcke [mailto:m...@chromium.org] > Sent: Wednesday, July 12, 2017 11:33 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian > Xu

Re: [PATCH 2/4] drm/vc4: prepare for CEC support

Hans Verkuil writes: > From: Hans Verkuil > > In order to support CEC the hsm clock needs to be enabled in > vc4_hdmi_bind(), not in vc4_hdmi_encoder_enable(). Otherwise you wouldn't > be able to support CEC when there is no hotplug detect signal,

Re: [v2,07/12] intel-ipu3: css: firmware management

El Wed, Jun 14, 2017 at 05:19:22PM -0500 Yong Zhi ha dit: > Functions to load and install imgu FW blobs > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-abi.h| 1573 > > drivers/media/pci/intel/ipu3/ipu3-css-fw.c | 272

Re: [PATCH 3/4] drm/vc4: Add register defines for CEC.

Hans Verkuil writes: > From: Eric Anholt > > Basic usage: > > poweron: HSM clock should be running. Set the bit clock divider, > set all the other _US timeouts based on bit clock rate. Bring RX/TX > reset up and then down. > > powerdown: Set RX/TX reset. >

Re: [PATCH v2] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

On 07/12/2017 08:50 AM, Philipp Zabel wrote: On Tue, 2017-07-11 at 15:18 +0200, Arnd Bergmann wrote: While looking at a compiler warning, I noticed the use of IS_ERR_OR_NULL, which is generally a sign of a bad API design and should be avoided. In this driver, this is fairly easy, we can

Re: v4l2-fwnode: status, plans for merge, any branch to merge against?

Hi! > > > 1) Make sure there will be no regressions, > > > > Well, all I have running recent kernels is N900. If ccp branch works > > for you on N9, that's probably as much testing as we can get. > > > > > 2) clean things up in the omap3isp; which resources are needed and when > > > (e.g.

Re: [PATCH v2] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

On Tue, 2017-07-11 at 15:18 +0200, Arnd Bergmann wrote: > While looking at a compiler warning, I noticed the use of > IS_ERR_OR_NULL, which is generally a sign of a bad API design > and should be avoided. > > In this driver, this is fairly easy, we can simply stop storing > error pointers in

Re: Lots of new warnings with gcc-7.1.1

On Wed, Jul 12, 2017 at 3:10 PM, Greg Kroah-Hartman wrote: > On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote: >> [ Very random list of maintainers and mailing lists, at least >> partially by number of warnings generated by gcc-7.1.1 that is then >>

Re: Lots of new warnings with gcc-7.1.1

On Wed, Jul 12, 2017 at 5:41 AM, Linus Torvalds wrote: > > We also have about a bazillion > > warning: ‘*’ in boolean context, suggest ‘&&’ instead > > warnings in drivers/ata/libata-core.c, all due to a single macro that > uses a pattern that gcc-7.1.1 doesn't

Re: Lots of new warnings with gcc-7.1.1

On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote: > [ Very random list of maintainers and mailing lists, at least > partially by number of warnings generated by gcc-7.1.1 that is then > correlated with the get_maintainers script ] > > So I upgraded one of my boxes to F26, which

Re: Lots of new warnings with gcc-7.1.1

Em Tue, 11 Jul 2017 15:35:15 -0700 Linus Torvalds escreveu: > [ Very random list of maintainers and mailing lists, at least > partially by number of warnings generated by gcc-7.1.1 that is then > correlated with the get_maintainers script ] Under drivers/media, I

[PATCH] media: staging: atomisp: disable warnings with cc-disable-warning

Instead of directly using -Wno-foo, use cc-disable-warning, as it checks if the compiler has the warnings we want to disable. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp2/Makefile | 10 ++ 1 file changed, 6 insertions(+),

Re: [PATCH v2 2/3] drm: rcar-du: Fix planes to CRTC assignment when using the VSP

Hi Kieran, On Wednesday 12 Jul 2017 11:30:19 Kieran Bingham wrote: > On 11/07/17 23:29, Laurent Pinchart wrote: > > The DU can compose the output of a VSP with other planes on Gen2 > > hardware, and of two VSPs on Gen3 hardware. Neither of these features > > are supported by the driver, and the

[PATCH] media: vimc: cleanup a few warnings

The const structs uded by MODULE_DEVICE_TABLE() may never be used with COMPILE_TEST: drivers/media/platform/vimc/vimc-capture.c:528:40: warning: 'vimc_cap_driver_ids' defined but not used [-Wunused-const-variable=] static const struct platform_device_id vimc_cap_driver_ids[] = {

Re: [PATCH v2 1/3] drm: rcar-du: Use the VBK interrupt for vblank events

Hi Laurent, On 11/07/17 23:29, Laurent Pinchart wrote: > When implementing support for interlaced modes, the driver switched from > reporting vblank events on the vertical blanking (VBK) interrupt to the > frame end interrupt (FRM). This incorrectly divided the reported refresh > rate by two. Fix

Re: [PATCH v2 2/3] drm: rcar-du: Fix planes to CRTC assignment when using the VSP

Hi Laurent, Thanks for the patch Only a minor nit on one comment, but aside from that, On 11/07/17 23:29, Laurent Pinchart wrote: > The DU can compose the output of a VSP with other planes on Gen2 > hardware, and of two VSPs on Gen3 hardware. Neither of these features > are supported by the

Re: Query: IR remote over android

On Wed, Jul 12, 2017 at 02:40:20PM +0530, Sharma, Jitendra wrote: > Hi, > > I am working on a android project. Here, I want to enable Remote control > support on one of our custom msm chipset based board. > > The idea is, once board boot up, then via HDMI over HDMI monitor we will see > android

Query: IR remote over android

Hi, I am working on a android project. Here, I want to enable Remote control support on one of our custom msm chipset based board. The idea is, once board boot up, then via HDMI over HDMI monitor we will see android UI, and we want to browse through that UI using any standard protocol(like

Re: Trying to use IR driver for my SoC

On Tue, Jul 11, 2017 at 11:51:02PM +0200, Mason wrote: > On 11/07/2017 20:35, Sean Young wrote: > > > Mason wrote: > > > >> Repeating the test (pressing '1' for one second) with ir-keytable: > >> > >> # ir-keytable -p all -t -v > >> Found device /sys/class/rc/rc0/ > >> Input sysfs node is