Re: [PATCH] media: intel-ipu3: cio2: Synchronize irqs at stop_streaming

2018-02-07 Thread Sakari Ailus
Hi Yong, On Wed, Feb 07, 2018 at 02:47:50PM -0800, Yong Zhi wrote: > This is to avoid pending interrupts to be handled during > stream off, in which case, the ready buffer will be removed > from buffer list, thus not all buffers can be returned to VB2 > as expected. Disable CIO2 irq at

cron job: media_tree daily build: ERRORS

2018-02-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Feb 8 05:00:18 CET 2018 media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 media_build

RE: [PATCH 0/8] Add support for multi-planar formats and 10 bit formats

2018-02-07 Thread Satish Kumar Nagireddy
Hi Sakari, Thanks for the review. I will provide the rst documentation. Regards, Satish > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sakari Ailus > Sent: Wednesday, February 07, 2018 2:34 PM > To: Satish Kumar

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-07 Thread Kieran Bingham
Hi Archit, On 07/02/18 12:33, Kieran Bingham wrote: > Hi Archit, > > Thank you for your review, > >>>   unsigned int val; >>>   int ret; >>>   @@ -1153,24 +1151,35 @@ static int adv7511_probe(struct i2c_client *i2c, >>> const struct i2c_device_id *id) >>>   if (ret) >>>  

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-07 Thread Kieran Bingham
Hi Laurent, On 07/02/18 21:59, Laurent Pinchart wrote: > Hi Kieran, > > On Wednesday, 7 February 2018 17:14:09 EET Kieran Bingham wrote: >> On 29/01/18 10:26, Laurent Pinchart wrote: >>> On Monday, 22 January 2018 14:50:00 EET Kieran Bingham wrote: The ADV7511 has four 256-byte maps that

RE: [PATCH v4 00/12] Intel IPU3 ImgU patchset

2018-02-07 Thread Mani, Rajmohan
Hi Mauro, > -Original Message- > From: Mani, Rajmohan > Sent: Tuesday, December 26, 2017 2:31 PM > To: 'Mauro Carvalho Chehab' > Cc: Zhi, Yong ; linux-media@vger.kernel.org; > sakari.ai...@linux.intel.com; Zheng, Jian Xu

[PATCH] media: intel-ipu3: cio2: Synchronize irqs at stop_streaming

2018-02-07 Thread Yong Zhi
This is to avoid pending interrupts to be handled during stream off, in which case, the ready buffer will be removed from buffer list, thus not all buffers can be returned to VB2 as expected. Disable CIO2 irq at cio2_hw_exit() so no new interrupts are generated. Signed-off-by: Yong Zhi

[PATCH v9 0/8] TDA1997x HDMI video reciver

2018-02-07 Thread Tim Harvey
This is a v4l2 subdev driver supporting the TDA1997x HDMI video receiver. I've tested this on a Gateworks GW54xx/GW551x with an IMX6Q/IMX6DL which uses the TDA19971 with 16bits connected to the IMX6 CSI and single-lane I2S audio providing 2-channel audio. For this configuration I've tested both

[PATCH v9 2/8] media: v4l-ioctl: fix clearing pad for VIDIOC_DV_TIMIGNS_CAP

2018-02-07 Thread Tim Harvey
Signed-off-by: Tim Harvey --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 7961499..5f3670d 100644 ---

[PATCH v9 1/8] v4l2-dv-timings: add v4l2_hdmi_colorimetry()

2018-02-07 Thread Tim Harvey
From: Hans Verkuil Add the v4l2_hdmi_colorimetry() function so we have a single function that determines the colorspace, YCbCr encoding, quantization range and transfer function from the InfoFrame data. Cc: Randy Dunlap Signed-off-by: Hans Verkuil

[PATCH v9 6/8] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-07 Thread Tim Harvey
Add support for the TDA1997x HDMI receivers. Cc: Hans Verkuil Signed-off-by: Tim Harvey --- v9: - remove redundant pad bounds check already in v4l2-subdev.c - assign entity function (Hans) - properly assign/check/free ctrl_handler (Hans) - fixed

[PATCH v9 3/8] media: add digital video decoder entity function

2018-02-07 Thread Tim Harvey
Add a new media entity function definition for digital TV decoders: MEDIA_ENT_F_DTV_DECODER Signed-off-by: Tim Harvey --- Documentation/media/uapi/mediactl/media-types.rst | 11 +++ include/uapi/linux/media.h| 5 + 2 files changed, 16

[PATCH v9 5/8] media: dt-bindings: Add bindings for TDA1997X

2018-02-07 Thread Tim Harvey
Acked-by: Rob Herring Acked-by: Sakari Ailus Signed-off-by: Tim Harvey --- v6: - replace copyright with SPDX tag - added Rob's ack v5: - added Sakari's ack v4: - move include/dt-bindings/media/tda1997x.h to bindings patch -

[PATCH v9 8/8] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x

2018-02-07 Thread Tim Harvey
Signed-off-by: Tim Harvey --- v5: - add missing audmux config arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 138 ++ 1 file changed, 138 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi

[PATCH v9 7/8] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx

2018-02-07 Thread Tim Harvey
The GW54xx has a front-panel microHDMI connector routed to a TDA19971 which is connected the the IPU CSI when using IMX6Q. Signed-off-by: Tim Harvey --- v5: - remove leading 0 from unit address - add newline between property list and child node v4: no changes v3: no

[PATCH v9 4/8] MAINTAINERS: add entry for NXP TDA1997x driver

2018-02-07 Thread Tim Harvey
Signed-off-by: Tim Harvey --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 845fc25..439b500 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13262,6 +13262,14 @@ T: git git://linuxtv.org/mkrufky/tuners.git S:

Re: [PATCH] media: intel-ipu3: cio2: Use SPDX license headers

2018-02-07 Thread Sakari Ailus
Hi Yong, Thanks for the patch. On Mon, Feb 05, 2018 at 08:19:53PM -0800, Yong Zhi wrote: > Adopt SPDX license headers and update year to 2018. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 12 ++-- >

Re: [PATCH 0/8] Add support for multi-planar formats and 10 bit formats

2018-02-07 Thread Sakari Ailus
Hi Satish, On Wed, Feb 07, 2018 at 02:29:30PM -0800, Satish Kumar Nagireddy wrote: > Jeffrey Mouroux (1): > uapi: media: New fourcc codes needed by Xilinx Video IP > > Rohit Athavale (1): > media-bus: uapi: Add YCrCb 420 media bus format Could you add ReST documentation for these formats?

[PATCH 5/8] v4l: xilinx: dma: Update video format descriptor

2018-02-07 Thread Satish Kumar Nagireddy
This patch updates video format descriptor to help information viz., number of planes per color format and chroma sub sampling factors. This commit adds the various 8-bit and 10-bit that are supported to the table queried by drivers. Signed-off-by: Satish Kumar Nagireddy

[PATCH 6/8] v4l: xilinx: dma: Add multi-planar support

2018-02-07 Thread Satish Kumar Nagireddy
The current v4l driver supports single plane formats. This patch will add support to handle multi-planar formats. Updated driver capabilities to multi-planar, where it can handle both single and multi-planar formats Signed-off-by: Satish Kumar Nagireddy ---

[PATCH 1/8] v4l: xilinx: dma: Remove colorspace check in xvip_dma_verify_format

2018-02-07 Thread Satish Kumar Nagireddy
From: Radhey Shyam Pandey In current implementation driver only checks the colorspace between the last subdev in the pipeline and the connected video node, the pipeline could be configured with wrong colorspace information until the very end. It thus makes little

[PATCH 4/8] media-bus: uapi: Add YCrCb 420 media bus format

2018-02-07 Thread Satish Kumar Nagireddy
From: Rohit Athavale This commit adds a YUV 420 media bus format. Currently, one doesn't exist. VYYUYY8_1X24 does not describe the way the pixels are sent over the bus, but is an approximation. Signed-off-by: Satish Kumar Nagireddy ---

[PATCH 3/8] uapi: media: New fourcc codes needed by Xilinx Video IP

2018-02-07 Thread Satish Kumar Nagireddy
From: Jeffrey Mouroux The Xilinx Video Framebuffer DMA IP supports video memory formats that are not represented in the current V4L2 fourcc library. This patch adds those missing fourcc codes. This includes both new 8-bit and 10-bit pixel formats. Signed-off-by: Satish

[PATCH 7/8] v4l: xilinx: dma: Add scaling and padding factor functions

2018-02-07 Thread Satish Kumar Nagireddy
scaling_factor function returns multiplying factor to calculate bytes per component based on color format. For eg. scaling factor of YUV420 8 bit format is 1 so multiplying factor is 1 (8/8) scaling factor of YUV420 10 bit format is 1.25 (10/8) padding_factor function returns multiplying factor

[PATCH 2/8] media: xilinx: vip: Add the pixel format for RGB24

2018-02-07 Thread Satish Kumar Nagireddy
From: Hyun Kwon The pixel format for RGB24 is missing, and the driver always falls back to YUYV as no format descriptor matches with RGB24 fourcc. The pixel format is added to RGB24 format descriptor so that user can use the format. Signed-off-by: Satish Kumar Nagireddy

[PATCH 8/8] v4l: xilinx: dma: Get scaling and padding factor to calculate DMA params

2018-02-07 Thread Satish Kumar Nagireddy
Get multiplying factor to calculate bpp especially in case of 10 bit formats. Get multiplying factor to calculate padding width Signed-off-by: Satish Kumar Nagireddy --- drivers/media/platform/xilinx/xilinx-dma.c | 29 ++--- 1 file changed, 26

[PATCH 0/8] Add support for multi-planar formats and 10 bit formats

2018-02-07 Thread Satish Kumar Nagireddy
The patches are for xilinx v4l. The patcheset enable support to handle multiplanar formats and 10 bit formats. The implemenation has handling of single plane formats too for backward compatibility of some existing applications. Some patches are included as dependencies and are intended to

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-07 Thread Hans Verkuil
On 02/07/2018 11:05 PM, Tim Harvey wrote: > On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote: >> On 02/07/18 09:22, Hans Verkuil wrote: >>> On 02/07/2018 12:29 AM, Tim Harvey wrote: Media Controller ioctls: fail: v4l2-test-media.cpp(141):

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-07 Thread Tim Harvey
On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote: > On 02/07/18 09:22, Hans Verkuil wrote: >> On 02/07/2018 12:29 AM, Tim Harvey wrote: >>> Media Controller ioctls: >>> fail: v4l2-test-media.cpp(141): ent.function == >>> MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN >> >>

Re: [PATCH v3 4/8] i2c: ov9650: use 64-bit arithmetic instead of 32-bit

2018-02-07 Thread Sakari Ailus
Hi Gustavo, On Tue, Feb 06, 2018 at 10:47:50AM -0600, Gustavo A. R. Silva wrote: > Add suffix ULL to constants 1 and 100 in order to give the > compiler complete information about the proper arithmetic to use. > Notice that these constants are used in contexts that expect > expressions of

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-07 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 7 February 2018 17:14:09 EET Kieran Bingham wrote: > On 29/01/18 10:26, Laurent Pinchart wrote: > > On Monday, 22 January 2018 14:50:00 EET Kieran Bingham wrote: > >> The ADV7511 has four 256-byte maps that can be accessed via the main I²C > >> ports. Each map has it own

[PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification

2018-02-07 Thread Kieran Bingham
From: Kieran Bingham The error handling for the adv748x_identify_chip() call erroneously jumps to the err_cleanup_clients label before the clients have been established. Correct this by jumping to the next (and correct) label in the cleanup code:

Re: [PATCH] media: stm32-dcmi: add g/s_parm framerate support

2018-02-07 Thread Hans Verkuil
On 02/07/2018 06:43 PM, Hugues Fruchet wrote: > Add g/s_parm framerate support by calling subdev > g/s_frame_interval ops. > This allows user to control sensor framerate by > calling ioctl G/S_PARM. > > Signed-off-by: Hugues Fruchet > --- >

[PATCH] media: stm32-dcmi: add g/s_parm framerate support

2018-02-07 Thread Hugues Fruchet
Add g/s_parm framerate support by calling subdev g/s_frame_interval ops. This allows user to control sensor framerate by calling ioctl G/S_PARM. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 49 +++ 1 file

[PATCH] media: stm32-dcmi: rework overrun/error case

2018-02-07 Thread Hugues Fruchet
Do not stop/restart dma on overrun or errors. Dma will be restarted on current frame transfer completion. Frame transfer completion is ensured even if overrun or error occurs by DCMI continuous capture mode which restarts data transfer at next frame sync. Do no warn on overrun while in irq thread,

[PATCH] media: stm32-dcmi: fix lock scheme

2018-02-07 Thread Hugues Fruchet
Fix lock scheme leading to spurious freeze. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 57 ++- 1 file changed, 25 insertions(+), 32 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH v1 0/3] STM32 DCMI redundant code & trace cleanup

2018-02-07 Thread Hugues Fruchet
Remove some redundant code and fix/enhance some error trace points. Hugues Fruchet (3): media: stm32-dcmi: remove redundant capture enable media: stm32-dcmi: remove redundant clear of interrupt flags media: stm32-dcmi: improve error trace points drivers/media/platform/stm32/stm32-dcmi.c |

[PATCH v1 2/3] media: stm32-dcmi: remove redundant clear of interrupt flags

2018-02-07 Thread Hugues Fruchet
It is already cleared in dcmi_irq_callback(). Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c index

[PATCH v1 3/3] media: stm32-dcmi: improve error trace points

2018-02-07 Thread Hugues Fruchet
Fix some missing "\n". Trace error returned by subdev streamon/streamoff. Remove extra "0x" unneeded with %pad formatter. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

[PATCH v1 1/3] media: stm32-dcmi: remove redundant capture enable

2018-02-07 Thread Hugues Fruchet
Remove redundant capture enable already done in dcmi_start_capture(). Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH 1/2] media: i2c: adv748x: Simplify regmap configuration

2018-02-07 Thread Kieran Bingham
From: Kieran Bingham The ADV748x has identical map configurations for each register map. The duplication of each map can be simplified using a helper macro such that each map is represented on a single line. Define ADV748X_REGMAP_CONF for this purpose

[PATCH 2/2] media: i2c: adv748x: Add missing CBUS page.

2018-02-07 Thread Kieran Bingham
From: Kieran Bingham The ADV748x has 12 pages mapped onto I2C addresses. In the existing implementation only 11 are mapped correctly in the page enumerations, which causes an off-by-one fault on pages above the infoframe definition due to a missing

[PATCH 0/2] media: i2c: adv748x: Fix CBUS page issue

2018-02-07 Thread Kieran Bingham
From: Kieran Bingham The ADV748x has 12 pages mapped on to I2C addresses. The existing implementation only has 11 of these in the map enumeration, and this can cause an off-by-one error when programming the map addresses. This short series simplifies

[PATCH] vimc: use correct subdev functions

2018-02-07 Thread Hans Verkuil
Instead of calling everything a MEDIA_ENT_F_ATV_DECODER, pick the correct functions for these blocks. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vimc/vimc-debayer.c b/drivers/media/platform/vimc/vimc-debayer.c index 4d663e89d33f..6e10b63ba9ec

Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

2018-02-07 Thread Hans Verkuil
On 12/29/2017 08:52 AM, Shunqian Zheng wrote: > From: Jeffy Chen > > Add the header for userspace > > Signed-off-by: Jeffy Chen > Signed-off-by: Jacob Chen > --- > include/uapi/linux/rkisp1-config.h | 757 >

Re: [PATCH 1/2] media: adv7604: Add support for i2c_new_secondary_device

2018-02-07 Thread Kieran Bingham
Hi Rob, On 29/01/18 20:08, Rob Herring wrote: > On Mon, Jan 22, 2018 at 12:49:56PM +, Kieran Bingham wrote: >> From: Jean-Michel Hautbois >> >> The ADV7604 has thirteen 256-byte maps that can be accessed via the main >> I²C ports. Each map has it own I²C

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-07 Thread Kieran Bingham
Hi Laurent, On 29/01/18 10:26, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. Thanks for your review, > On Monday, 22 January 2018 14:50:00 EET Kieran Bingham wrote: >> The ADV7511 has four 256-byte maps that can be accessed via the main I²C >> ports. Each map has it own I²C

[PATCH 6/7] i2c: add SPDX license info

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil Replace the old license information with the corresponding SPDX license for those drivers Cisco authored. Signed-off-by: Hans Verkuil --- drivers/media/i2c/ad9389b.c | 14 +- drivers/media/i2c/adv7511.c |

[PATCH 3/7] vivid: add SPDX license info

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil Replace the old license information with the corresponding SPDX license. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-cec.c | 14 +- drivers/media/platform/vivid/vivid-cec.h | 14

[PATCH 0/7] Add SPDX headers for Cisco-authored sources

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil This replaces all the old boilerplate license code with the new SPDX tags for Cisco-authored files in the media subsystem. Regards, Hans Hans Verkuil (7): media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs

[PATCH 5/7] cec: add SPDX license info

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil Replace the old license information with the corresponding SPDX license. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 14 +- drivers/media/cec/cec-api.c | 14 +-

[PATCH 4/7] cobalt: add SPDX license info

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil Replace the old license information with the corresponding SPDX license. Signed-off-by: Hans Verkuil --- drivers/media/pci/cobalt/Makefile | 1 + drivers/media/pci/cobalt/cobalt-alsa-main.c

[PATCH 2/7] include/(uapi/)media: add SPDX license info

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil Replace the old license information with the corresponding SPDX license for those headers that I authored. Signed-off-by: Hans Verkuil --- include/media/cec-notifier.h| 14 +- include/media/cec-pin.h | 14

[PATCH 1/7] media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil If the device is of type VFL_TYPE_SUBDEV then vdev->ioctl_ops is NULL so the 'if (!ops->vidioc_query_ext_ctrl)' check would crash. Add a test for !ops to the condition. All sub-devices that have controls will use the control framework, so they do not have

[PATCH 7/7] media: add SPDX license info

2018-02-07 Thread Hans Verkuil
From: Hans Verkuil Replace the old license information with the corresponding SPDX license for the remaining media drivers that Cisco authored. Signed-off-by: Hans Verkuil --- drivers/media/common/v4l2-tpg/v4l2-tpg-colors.c | 14 +-

[PATCH v3 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

2018-02-07 Thread Maxime Ripard
Hi, Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence. This IP block is able to receive 4 video streams and stream them over a MIPI-CSI2 link using up to 4 lanes. Those streams are basically the interfaces to controllers generating some video signals, like a camera or a

[PATCH v3 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-02-07 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used as a bridge between pixel interfaces and a CSI-2 bus. It supports operating with an internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the former case. While the virtual

[PATCH v3 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-02-07 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 video streams and can output on up to 4 CSI-2 lanes, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

[PATCH v6 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-02-07 Thread Maxime Ripard
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a bridge between a CSI-2 bus and pixel grabbers. It supports operating with internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the former case. It also support dynamic

[PATCH v6 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2018-02-07 Thread Maxime Ripard
The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

[PATCH v6 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 RX

2018-02-07 Thread Maxime Ripard
Hi, Here is the sixth attempt at supporting the MIPI-CSI2 RX block from Cadence. This IP block is able to receive CSI data over up to 4 lanes, and split it to over 4 streams. Those streams are basically the interfaces to the video grabbers that will perform the capture. It is able to map

Re: [PATCH v5] media: imx258: Add imx258 camera sensor driver

2018-02-07 Thread Sakari Ailus
Hi Andy, Thanks for the update. On Fri, Jan 26, 2018 at 01:58:55AM +0800, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh >

Re: [PATCH 4/4] add video control handlers using V4L2 control framework

2018-02-07 Thread Hans Verkuil
On 02/07/18 14:00, Florian Echtler wrote: > This patch registers four standard control handlers using the corresponding > V4L2 framework. > > Signed-off-by: Florian Echtler > --- > drivers/input/touchscreen/sur40.c | 64 > +++ > 1 file

Re: [PATCH 2/4] add default settings and module parameters for video controls

2018-02-07 Thread Hans Verkuil
On 02/07/18 14:00, Florian Echtler wrote: > This patch adds parameter definitions and module parameters for the four > userspace controls that the SUR40 can currently provide. > > Signed-off-by: Florian Echtler > --- > drivers/input/touchscreen/sur40.c | 28

[PATCH v3] add video controls for SUR40 driver

2018-02-07 Thread Florian Echtler
As discussed previously, here's the third iteration of my patch to add control functions for the SUR40 driver, with (hopefully) correct handling of default values/module parameters, using the V4L2 control framework. Best regards, Florian

[PATCH 3/4] add panel register access functions

2018-02-07 Thread Florian Echtler
These functions provide write access to the internal LCD panel registers which also control the sensor. They can be used to disable the preprocessor, set the illumination brightness, and adjust gain/contrast (which are stored together in one register internally called "vsvideo"). Signed-off-by:

[PATCH 1/4] add missing blob structure field for tag id

2018-02-07 Thread Florian Echtler
The SUR40 can recognize specific printed patterns directly in hardware; this information (i.e. the pattern id) is present but currently unused in the blob structure. Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 5 - 1 file changed, 4

[PATCH 2/4] add default settings and module parameters for video controls

2018-02-07 Thread Florian Echtler
This patch adds parameter definitions and module parameters for the four userspace controls that the SUR40 can currently provide. Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 28 1 file changed, 28 insertions(+) diff

[PATCH 4/4] add video control handlers using V4L2 control framework

2018-02-07 Thread Florian Echtler
This patch registers four standard control handlers using the corresponding V4L2 framework. Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 64 +++ 1 file changed, 64 insertions(+) diff --git

Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

2018-02-07 Thread Robin Murphy
On 06/02/18 13:14, Hans Verkuil wrote: [...] The one thing that I worry about is if these structs are the same for 32 and 64 bit arm. I see some enums and bools in there - in general the storage size of those isn't even guaranteed to be consistent between different compiler implementations

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-07 Thread Kieran Bingham
Hi Archit, Thank you for your review, On 29/01/18 04:11, Archit Taneja wrote: > Hi, > > On 01/22/2018 06:20 PM, Kieran Bingham wrote: >> The ADV7511 has four 256-byte maps that can be accessed via the main I²C >> ports. Each map has it own I²C address and acts as a standard slave >> device on

Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

2018-02-07 Thread Hans Verkuil
On 12/29/17 08:52, Shunqian Zheng wrote: > From: Jeffy Chen > > Add the header for userspace General note: I saw four cases where this documentation referred to the datasheet. Three comments on that: 1) You don't say which datasheet. 2) I assume the datasheet is

Re: [RFCv3 01/17] media: add request API core and UAPI

2018-02-07 Thread Sakari Ailus
Hi Alexandre, On Wed, Feb 07, 2018 at 10:48:05AM +0900, Alexandre Courbot wrote: > The request API provides a way to group buffers and device parameters > into units of work to be queued and executed. This patch introduces the > UAPI and core framework. > > This patch is based on the previous

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-07 Thread Hans Verkuil
On 02/07/18 09:22, Hans Verkuil wrote: > On 02/07/2018 12:29 AM, Tim Harvey wrote: >> Media Controller ioctls: >> fail: v4l2-test-media.cpp(141): ent.function == >> MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN > > Weird, this shouldn't happen. I'll look into this a bit more. Can you run

Re: [PATCH 5/5] add module parameters for default values

2018-02-07 Thread Hans Verkuil
On 02/07/18 09:33, Florian Echtler wrote: > On 06.02.2018 22:31, Hans Verkuil wrote: >> On 02/06/2018 10:01 PM, Florian Echtler wrote: >>> To allow setting custom parameters for the sensor directly at startup, the >>> three primary controls are exposed as module parameters in this patch. >>> >>>

BUG: unable to handle kernel NULL pointer dereference

2018-02-07 Thread rwar...@gmx.de
hallo is someone so neat to look into this or to provide suggestions to debug this ? https://bugzilla.redhat.com/show_bug.cgi?id=1542562 maybe related: https://bugzilla.kernel.org/show_bug.cgi?id=118101 https://bugzilla.kernel.org/show_bug.cgi?id=195029 -- Greeting Ronald

Re: [PATCH] v4l2-ioctl.c: fix VIDIOC_DV_TIMINGS_CAP: don't clear pad

2018-02-07 Thread Sakari Ailus
On Tue, Feb 06, 2018 at 08:04:42PM +0100, Hans Verkuil wrote: > The pad field should be passed on to the subdev driver, but it is cleared in > v4l2-ioctl.c so the subdev driver always sees a 0 pad. > > Found with v4l2-compliance. > > Signed-off-by: Hans Verkuil >

Re: [PATCH 5/5] add module parameters for default values

2018-02-07 Thread Florian Echtler
On 06.02.2018 22:31, Hans Verkuil wrote: > On 02/06/2018 10:01 PM, Florian Echtler wrote: >> To allow setting custom parameters for the sensor directly at startup, the >> three primary controls are exposed as module parameters in this patch. >> >> +/* module parameters */ >> +static uint

Re: [PATCH 1/5] add missing blob structure field for tag id

2018-02-07 Thread Florian Echtler
On 06.02.2018 22:22, Hans Verkuil wrote: > On 02/06/2018 10:01 PM, Florian Echtler wrote: >> The SUR40 can recognize specific printed patterns directly in hardware; >> this information (i.e. the pattern id) is present but currently unused >> in the blob structure. >> >> >> __le32 area;

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-07 Thread Hans Verkuil
On 02/07/2018 12:29 AM, Tim Harvey wrote: > On Tue, Feb 6, 2018 at 1:21 PM, Hans Verkuil wrote: >> On 02/06/2018 09:27 PM, Tim Harvey wrote: >> >> >> >>> v4l2-compliance test results: >>> - with the following kernel patches: >>>v4l2-subdev: clear reserved fields >>> .