[PATCHv3] media: add tuner standby op, use where needed

The v4l2_subdev core s_power op was used for two different things: power on/off sensors or video decoders/encoders and to put a tuner in standby (and only the tuner!). There is no 'tuner wakeup' op, that's done automatically when the tuner is accessed. The danger with calling (s_power, 0) to put

Re: [PATCHv2] media: add tuner standby op, use where needed

On 02/21/2018 01:02 AM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Tuesday, 20 February 2018 11:44:20 EET Hans Verkuil wrote: >> The v4l2_subdev core s_power op was used for two different things: power >> on/off sensors or video decoders/encoders and to put a tuner in

Re: [RFCv4 16/21] v4l2: video_device: support for creating requests

On 02/21/2018 07:01 AM, Alexandre Courbot wrote: > On Wed, Feb 21, 2018 at 1:35 AM, Hans Verkuil wrote: >> On 02/20/2018 05:44 AM, Alexandre Courbot wrote: >>> Add a new VIDIOC_NEW_REQUEST ioctl, which allows to instanciate requests >>> on devices that support the request API.

Re: [RFCv4 01/21] media: add request API core and UAPI

On 02/21/2018 07:01 AM, Alexandre Courbot wrote: > Hi Hans, > > On Tue, Feb 20, 2018 at 7:36 PM, Hans Verkuil wrote: >> On 02/20/18 05:44, Alexandre Courbot wrote: >>> +#define MEDIA_REQUEST_IOC(__cmd, func) >>> \ >>> +

Re: [RFCv4 01/21] media: add request API core and UAPI

Hi Hans, On Tue, Feb 20, 2018 at 7:36 PM, Hans Verkuil wrote: > On 02/20/18 05:44, Alexandre Courbot wrote: >> The request API provides a way to group buffers and device parameters >> into units of work to be queued and executed. This patch introduces the >> UAPI and core

Re: [RFCv4 10/21] videodev2.h: Add request_fd field to v4l2_buffer

On Wed, Feb 21, 2018 at 12:20 AM, Hans Verkuil wrote: > On 02/20/18 05:44, Alexandre Courbot wrote: >> From: Hans Verkuil >> >> When queuing buffers allow for passing the request that should >> be associated with this buffer. >> >> Signed-off-by: Hans

Re: [RFCv4 13/21] media: videobuf2-v4l2: support for requests

On Wed, Feb 21, 2018 at 1:18 AM, Hans Verkuil wrote: > On 02/20/2018 05:44 AM, Alexandre Courbot wrote: >> Add a new vb2_qbuf_request() (a request-aware version of vb2_qbuf()) >> that request-aware drivers can call to queue a buffer into a request >> instead of directly into

Re: [RFCv4 11/21] media: v4l2_fh: add request entity field

On Wed, Feb 21, 2018 at 12:24 AM, Hans Verkuil wrote: > On 02/20/18 05:44, Alexandre Courbot wrote: >> Allow drivers to assign a request entity to v4l2_fh. This will be useful >> for request-aware ioctls to find out which request entity to use. >> >> Signed-off-by: Alexandre

Re: [RFCv4 16/21] v4l2: video_device: support for creating requests

On Wed, Feb 21, 2018 at 1:35 AM, Hans Verkuil wrote: > On 02/20/2018 05:44 AM, Alexandre Courbot wrote: >> Add a new VIDIOC_NEW_REQUEST ioctl, which allows to instanciate requests >> on devices that support the request API. Requests created that way can >> only control the

Re: [RFCv4 09/21] v4l2: add request API support

On Tue, Feb 20, 2018 at 10:25 PM, Hans Verkuil wrote: > On 02/20/18 05:44, Alexandre Courbot wrote: >> Add a v4l2 request entity data structure that takes care of storing the >> request-related state of a V4L2 device ; in this case, its controls. >> >> Signed-off-by: Alexandre

cron job: media_tree daily build: ABI WARNING

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Feb 21 05:00:11 CET 2018 media-tree git hash:29422737017b866d4a51014cc7522fa3a99e8852 media_build

RE: [PATCH v4 00/12] Intel IPU3 ImgU patchset

Hi Mauro, > > > Subject: Re: [PATCH v4 00/12] Intel IPU3 ImgU patchset > > > > > > Hi, > > > > > > Em Fri, 17 Nov 2017 02:58:56 + > > > "Mani, Rajmohan" escreveu: > > > > > > > Here is an update on the IPU3 documentation that we are currently > > > > working > > >

[PATCH] media: dw9714: Update to SPDX license identifier

Remove the GPL v2 license boilerplate and update with the SPDX license identifier. Signed-off-by: Rajmohan Mani --- drivers/media/i2c/dw9714.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c/dw9714.c

Re: [PATCHv2] media: add tuner standby op, use where needed

Hi Hans, Thank you for the patch. On Tuesday, 20 February 2018 11:44:20 EET Hans Verkuil wrote: > The v4l2_subdev core s_power op was used for two different things: power > on/off sensors or video decoders/encoders and to put a tuner in standby > (and only the tuner!). There is no 'tuner wakeup'

Re: Bug: Two device nodes created in /dev for a single UVC webcam

Hi Devin, On Tuesday, 20 February 2018 20:18:16 EET Devin Heitmueller wrote: > On Mon, Feb 19, 2018 at 11:19 AM, Laurent Pinchart wrote: > > I've tested VLC (2.2.8) and haven't noticed any issue. If a program is > > directed to the metadata video node and tries to capture video from it it > >

drivers/media/common/videobuf2/videobuf2-v4l2.c:678: undefined reference to `video_devdata'

Hi Hans, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: af3e79d29555b97dd096e2f8e36a0f50213808a8 commit: 7952be9b6ece3d3c4d61f9811d7e5a984580064a media: drivers/media/common/videobuf2: rename from videobuf date:

Re: Bug: Two device nodes created in /dev for a single UVC webcam

Hi Laurent, On Mon, Feb 19, 2018 at 11:19 AM, Laurent Pinchart wrote: > I've tested VLC (2.2.8) and haven't noticed any issue. If a program is > directed to the metadata video node and tries to capture video from it it will > obviously fail. That being said,

Re: [RFCv4 16/21] v4l2: video_device: support for creating requests

On 02/20/2018 05:44 AM, Alexandre Courbot wrote: > Add a new VIDIOC_NEW_REQUEST ioctl, which allows to instanciate requests > on devices that support the request API. Requests created that way can > only control the device they originate from, making them suitable for > simple devices, but not

Re: [RFCv4 13/21] media: videobuf2-v4l2: support for requests

On 02/20/2018 05:44 AM, Alexandre Courbot wrote: > Add a new vb2_qbuf_request() (a request-aware version of vb2_qbuf()) > that request-aware drivers can call to queue a buffer into a request > instead of directly into the vb2 queue if relevent. > > This function expects that drivers invoking it

Re: [RFCv4 11/21] media: v4l2_fh: add request entity field

On 02/20/18 05:44, Alexandre Courbot wrote: > Allow drivers to assign a request entity to v4l2_fh. This will be useful > for request-aware ioctls to find out which request entity to use. > > Signed-off-by: Alexandre Courbot > --- > include/media/v4l2-fh.h | 3 +++ > 1

Re: stable-rc build: 3 warnings 0 failures (stable-rc/v4.14.20-119-g1b1ab1d)

On Tue, Feb 20, 2018 at 1:47 PM, Olof's autobuilder wrote: > Warnings: > > arm64.allmodconfig: > drivers/media/tuners/r820t.c:1334:1: warning: the frame size of 2896 bytes is > larger than 2048 bytes [-Wframe-larger-than=] Hi Greg, please add 16c3ada89cff ("media:

Re: [RFCv4 10/21] videodev2.h: Add request_fd field to v4l2_buffer

On 02/20/18 05:44, Alexandre Courbot wrote: > From: Hans Verkuil > > When queuing buffers allow for passing the request that should > be associated with this buffer. > > Signed-off-by: Hans Verkuil > [acour...@chromium.org: make request ID

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

Hi Marek, On 20/02/18 09:36, Marek Szyprowski wrote: Hi Robin, On 2018-02-19 17:29, Robin Murphy wrote: Hi Maciej, On 19/02/18 15:43, Maciej Purski wrote: When a driver is going to use clk_bulk_get() function, it has to initialize an array of clk_bulk_data, by filling its id fields. Add a

Re: [RFCv4 09/21] v4l2: add request API support

On 02/20/18 05:44, Alexandre Courbot wrote: > Add a v4l2 request entity data structure that takes care of storing the > request-related state of a V4L2 device ; in this case, its controls. > > Signed-off-by: Alexandre Courbot > --- > drivers/media/v4l2-core/Makefile

Re: [RFCv4 08/21] [WAR] v4l2-ctrls: do not clone non-standard controls

On 02/20/18 05:44, Alexandre Courbot wrote: > Only standard controls can be successfully cloned: handler_new_ref, used > by v4l2_ctrl_request_clone(), forcibly calls v4l2_ctrl_new_std() which > fails to find custom controls names, and we eventually hit the condition > that name == NULL in

Re: cron job: media_tree daily build: ABI WARNING

On 02/20/18 05:44, Hans Verkuil wrote: > This message is generated daily by a cron job that builds media_tree for > the kernels and architectures in the list below. > > Results of the daily build of media_tree: > > date: Tue Feb 20 05:00:11 CET 2018 > media-tree git hash:

Re: [RFCv4 01/21] media: add request API core and UAPI

On 02/20/18 05:44, Alexandre Courbot wrote: > The request API provides a way to group buffers and device parameters > into units of work to be queued and executed. This patch introduces the > UAPI and core framework. > > This patch is based on the previous work by Laurent Pinchart. The core > has

[PATCHv2] media: add tuner standby op, use where needed

The v4l2_subdev core s_power op was used for two different things: power on/off sensors or video decoders/encoders and to put a tuner in standby (and only the tuner!). There is no 'tuner wakeup' op, that's done automatically when the tuner is accessed. The danger with calling (s_power, 0) to put

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

Hi Robin, On 2018-02-19 17:29, Robin Murphy wrote: Hi Maciej, On 19/02/18 15:43, Maciej Purski wrote: When a driver is going to use clk_bulk_get() function, it has to initialize an array of clk_bulk_data, by filling its id fields. Add a new function to the core, which dynamically allocates

[GIT PULL v2 FOR v4.17] media: replace g/s_parm by g/s_frame_interval

There are currently two subdev ops variants to get/set the frame interval: g/s_parm and g/s_frame_interval. This patch series replaces all g/s_parm calls by g/s_frame_interval. The first patch clears the reserved fields in v4l2-subdev.c. It's taken from the "Media Controller compliance fixes"

Re: [RFC PATCH] Add core tuner_standby op, use where needed

On 02/19/18 20:27, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Monday, 19 February 2018 15:12:05 EET Hans Verkuil wrote: >> The v4l2_subdev core s_power op was used to two different things: power >> on/off sensors or video decoders/encoders and to put a tuner in

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

Hi Laurent, On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Monday, 19 February 2018 18:59:44 EET Jacopo Mondi wrote: > > The sensor driver sets mbus format colorspace information and sizes, > > but not ycbcr encoding,

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Niklas, On 02/19/2018 11:28 PM, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback. > > [snip] > >> Can you then fix v4l2-compliance to stop testing colorspace >> against 0xff >> ? > > For now I can simply relax this test for subdevs with sources and sinks.

Re: [PATCH v2] [media] Use common error handling code in 20 functions

Hi Markus, Thank you for the patch. On 19.02.2018 20:11, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 19 Feb 2018 18:50:40 +0100 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of these functions. > >

Re: [RFCv4 09/21] v4l2: add request API support

Hi Philippe, On Tue, Feb 20, 2018 at 4:36 PM, Philippe Ombredanne wrote: > On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot > wrote: >> Add a v4l2 request entity data structure that takes care of storing the >> request-related state of a V4L2