cron job: media_tree daily build: WARNINGS

2018-09-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Sep 15 04:00:49 CEST 2018 media-tree git hash:78cf8c842c111df656c63b5d04997ea4e40ef26a media_build

Re: cx23885 - regression between 4.17.x and 4.18.x

2018-09-14 Thread Vincent McIntyre
On Thu, Sep 13, 2018 at 06:39:57PM +0100, David R wrote: > Hi > > Just a heads up. I'm having to revert cx23885-core.c to the 4.17 version > to obtain stability with my old AMD Phenom/ASUS M4A785TD and Hauppauge > WinTV-HVR-5525. The latest code drops out and refuses to return video > streams in

Re: [PATCH] media: imx-pxp: fix compilation on i386 or x86_64

2018-09-14 Thread Randy Dunlap
On 9/14/18 12:10 AM, Philipp Zabel wrote: > Include the missing interrupt.h header to fix compilation on i386 or > x86_64: > > ../drivers/media/platform/imx-pxp.c:988:1: error: unknown type name > 'irqreturn_t' > static irqreturn_t pxp_irq_handler(int irq, void *dev_id) > ^ >

Re: [PATCH v2 0/4] media: soc_camera: ov9640: switch driver to v4l2_async

2018-09-14 Thread Petr Cvek
Dne 14.9.2018 v 14:59 Sakari Ailus napsal(a): > Hi Petr, > > On Wed, Aug 15, 2018 at 03:30:23PM +0200, petrcve...@gmail.com wrote: >> From: Petr Cvek >> >> This patch series transfer the ov9640 driver from the soc_camera subsystem >> into a standalone v4l2 driver. There is no changes except the

Re: [PATCH v2 1/4] media: soc_camera: ov9640: move ov9640 out of soc_camera

2018-09-14 Thread Petr Cvek
Dne 14.9.2018 v 14:59 Sakari Ailus napsal(a): > Hi Petr, > > Thanks for the patchset, and my apologies for reviewing it so late! > > I'm commenting this one but feel free to add patches to address the > comments. > Hi and thanks for the review. I would like to have this patch set to be as much

Re: [PATCH 0/4] em28xx: solve several issues pointed by v4l2-compliance

2018-09-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Sep 2018 15:22:30 -0300 Mauro Carvalho Chehab escreveu: > There are several non-compliance issues on em28xx. Fix those that > I can hit with a simple grabber board like Terratec AV 350. > > I also tested it with a WinTV USB2. There, I got several other compliants > all related to

Re: [PATCH v2 7/7] [media] tvp5150: add s_power callback

2018-09-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Sep 2018 20:20:46 +0200 Marco Felsch escreveu: > Hi Sakari, > > On 18-09-14 16:23, Sakari Ailus wrote: > > Hi Marco, > > > > On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote: > > > Don't en-/disable the interrupts during s_stream because someone can > > > disable the

Re: [PATCH v3 0/5] Fix OV5640 exposure & gain

2018-09-14 Thread Nicolas Dufresne
Interesting, I just hit this problem yesterday. Same module as Steve, with MIPI CSI-2 OV5640 (on Sabre Lite). Tested-By: Nicolas Dufresne Le mardi 11 septembre 2018 à 15:48 +0200, Hugues Fruchet a écrit : > This patch serie fixes some problems around exposure & gain in OV5640 > driver. > >

[PATCH 2/4] media: em28xx: use a default format if TRY_FMT fails

2018-09-14 Thread Mauro Carvalho Chehab
Follow the V4L2 spec, as warned by v4l2-compliance: warn: v4l2-test-formats.cpp(732): TRY_FMT cannot handle an invalid pixelformat. warn: v4l2-test-formats.cpp(733): This may or may not be a problem. For more information see: warn: v4l2-test-formats.cpp(734):

[PATCH 0/4] em28xx: solve several issues pointed by v4l2-compliance

2018-09-14 Thread Mauro Carvalho Chehab
There are several non-compliance issues on em28xx. Fix those that I can hit with a simple grabber board like Terratec AV 350. I also tested it with a WinTV USB2. There, I got several other compliants all related to msp3400 driver and step size. Fixing those is more complex, as it would require

[PATCH 4/4] media: em28xx: make v4l2-compliance happier by starting sequence on zero

2018-09-14 Thread Mauro Carvalho Chehab
The v4l2-compliance tool complains if a video doesn't start with a zero sequence number. While this shouldn't cause any real problem for apps, let's make it happier, in order to better check the v4l2-compliance differences before and after patchsets. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 3/4] media: em28xx: fix input name for Terratec AV 350

2018-09-14 Thread Mauro Carvalho Chehab
Instead of using a register value, use an AMUX name, as otherwise VIDIOC_G_AUDIO would fail. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c

[PATCH 1/4] media: em28xx: fix handler for vidioc_s_input()

2018-09-14 Thread Mauro Carvalho Chehab
The a->index is not the name of the internal amux entry, but, instead a value from zero to the maximum number of audio inputs. As the actual available inputs depend on each board, build it dynamically. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 29

Re: [PATCH v2 7/7] [media] tvp5150: add s_power callback

2018-09-14 Thread Marco Felsch
Hi Sakari, On 18-09-14 16:23, Sakari Ailus wrote: > Hi Marco, > > On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote: > > Don't en-/disable the interrupts during s_stream because someone can > > disable the stream but wants to get informed if the stream is locked > > again. So keep the

Re: [PATCH v2 4/7] [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency

2018-09-14 Thread Marco Felsch
Hi Sakari, On 18-09-14 16:25, Sakari Ailus wrote: > Hi Marco, > > On Mon, Aug 13, 2018 at 11:25:05AM +0200, Marco Felsch wrote: > > These helpers make us of the media-controller entity which is only > > available if the CONFIG_MEDIA_CONTROLLER is enabled. > > > > Signed-off-by: Marco Felsch >

Re: [PATCH v2 1/7] [media] tvp5150: add input source selection of_graph support

2018-09-14 Thread Marco Felsch
Hi Sakari, thanks for the review. On 18-09-14 16:31, Sakari Ailus wrote: > Hi Marco, > > On Mon, Aug 13, 2018 at 11:25:02AM +0200, Marco Felsch wrote: > ... > > +static void tvp5150_dt_cleanup(struct tvp5150 *decoder) > > +{ > > + unsigned int i; > > + > > + for (i = 0; i <

Re: [PATCH v3 0/5] Fix OV5640 exposure & gain

2018-09-14 Thread Steve Longerbeam
Hi Hughes, The whole series, Acked-by: Steve Longerbeam and Tested-by: Steve Longerbeam on i.MX6q SabreSD with MIPI CSI-2 OV5640 module On 09/11/2018 06:48 AM, Hugues Fruchet wrote: This patch serie fixes some problems around exposure & gain in OV5640 driver. The 4th patch about

Re: [PATCH v4 2/2] media: ov5640: Fix timings setup code

2018-09-14 Thread Steve Longerbeam
On 09/14/2018 08:58 AM, Jacopo Mondi wrote: From: Jacopo Mondi As of: commit 476dec012f4c ("media: ov5640: Add horizontal and vertical totals") the timings parameters gets programmed separately from the static register values array. When changing capture mode, the vertical and horizontal

Re: [PATCH v4 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-14 Thread Steve Longerbeam
On 09/14/2018 08:58 AM, Jacopo Mondi wrote: From: Jacopo Mondi Rework the MIPI interface startup sequence with the following changes: - Remove MIPI bus initialization from the initial settings blob - At set_power(1) time power up MIPI Tx/Rx and set data and clock lanes in LP11 during

Re: [PATCH v3 0/5] Fix OV5640 exposure & gain

2018-09-14 Thread jacopo mondi
Hi Sakari, On Tue, Sep 11, 2018 at 03:48:16PM +0200, Hugues Fruchet wrote: > This patch serie fixes some problems around exposure & gain in OV5640 driver. As you offered to collect this series and my CSI-2 fixes I have just re-sent, you might be interested in this branch: git://jmondi.org/linux

Re: [PATCH v3 0/5] Fix OV5640 exposure & gain

2018-09-14 Thread jacopo mondi
Hi Hugues, thanks for the patches On Tue, Sep 11, 2018 at 03:48:16PM +0200, Hugues Fruchet wrote: > This patch serie fixes some problems around exposure & gain in OV5640 driver. > > The 4th patch about autocontrols requires also a fix in v4l2-ctrls.c: >

[PATCH v4 0/2] media: i2c: ov5640: Re-work MIPI startup sequence

2018-09-14 Thread Jacopo Mondi
Hello ov5640 people, this driver has received a lot of attention recently, and this series aims to fix the CSI-2 interface startup on i.Mx6Q platforms. Please refer to the v2 cover letters for more background informations: https://www.mail-archive.com/linux-media@vger.kernel.org/msg133420.html

[PATCH v4 2/2] media: ov5640: Fix timings setup code

2018-09-14 Thread Jacopo Mondi
From: Jacopo Mondi As of: commit 476dec012f4c ("media: ov5640: Add horizontal and vertical totals") the timings parameters gets programmed separately from the static register values array. When changing capture mode, the vertical and horizontal totals gets inspected by the

[PATCH v4 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-14 Thread Jacopo Mondi
From: Jacopo Mondi Rework the MIPI interface startup sequence with the following changes: - Remove MIPI bus initialization from the initial settings blob - At set_power(1) time power up MIPI Tx/Rx and set data and clock lanes in LP11 during 'sleep' and 'idle' with MIPI clock in non-continuous

Re: [PATCH v2 1/7] [media] tvp5150: add input source selection of_graph support

2018-09-14 Thread Sakari Ailus
Hi Marco, On Mon, Aug 13, 2018 at 11:25:02AM +0200, Marco Felsch wrote: ... > +static void tvp5150_dt_cleanup(struct tvp5150 *decoder) > +{ > + unsigned int i; > + > + for (i = 0; i < TVP5150_NUM_PADS; i++) > + of_node_put(decoder->endpoints[i]); > +} > + > static const char

Re: [PATCH v2 4/7] [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency

2018-09-14 Thread Sakari Ailus
Hi Marco, On Mon, Aug 13, 2018 at 11:25:05AM +0200, Marco Felsch wrote: > These helpers make us of the media-controller entity which is only > available if the CONFIG_MEDIA_CONTROLLER is enabled. > > Signed-off-by: Marco Felsch > --- > include/media/v4l2-subdev.h | 100

Re: [PATCH v2 7/7] [media] tvp5150: add s_power callback

2018-09-14 Thread Sakari Ailus
Hi Marco, On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote: > Don't en-/disable the interrupts during s_stream because someone can > disable the stream but wants to get informed if the stream is locked > again. So keep the interrupts enabled the whole time the pipeline is > opened. >

Re: [PATCH v2 0/4] media: soc_camera: ov9640: switch driver to v4l2_async

2018-09-14 Thread Sakari Ailus
Hi Petr, On Wed, Aug 15, 2018 at 03:30:23PM +0200, petrcve...@gmail.com wrote: > From: Petr Cvek > > This patch series transfer the ov9640 driver from the soc_camera subsystem > into a standalone v4l2 driver. There is no changes except the required > v4l2_async calls, GPIO allocation, deletion

Re: [PATCH v2 1/4] media: soc_camera: ov9640: move ov9640 out of soc_camera

2018-09-14 Thread Sakari Ailus
Hi Petr, Thanks for the patchset, and my apologies for reviewing it so late! I'm commenting this one but feel free to add patches to address the comments. On Wed, Aug 15, 2018 at 03:30:24PM +0200, petrcve...@gmail.com wrote: > From: Petr Cvek > > Initial part of ov9640 transition from

[GIT PULL FOR v4.20 (request_api branch)] Add Allwinner cedrus decoder driver (v2)

2018-09-14 Thread Hans Verkuil
Hi Mauro, This is the cedrus Allwinner decoder driver. It is for the request_api topic branch. Note that there is a COMPILE_TEST issue with sram functions, for that another patch is needed: https://lore.kernel.org/patchwork/patch/983848/ But that's going through another subsystem and is

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-14 Thread Sakari Ailus
Hi Ping-chung, My apologies for the late review. On Wed, Aug 08, 2018 at 03:16:00PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data.

[PATCH v3 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-14 Thread Sakari Ailus
The event subscriptions are added to the subscribed event list while holding a spinlock, but that lock is subsequently released while still accessing the subscription object. This makes it possible to unsubscribe the event --- and freeing the subscription object's memory --- while the subscription

Re: [PATCH v2 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-14 Thread Hans Verkuil
On 09/13/18 00:24, Sakari Ailus wrote: > The event subscriptions are added to the subscribed event list while > holding a spinlock, but that lock is subsequently released while still > accessing the subscription object. This makes it possible to unsubscribe > the event --- and freeing the

[PATCH for request_api branch] v4l2-compat-ioctl32.c: fix sparse warning

2018-09-14 Thread Hans Verkuil
Fix this sparse warning: drivers/media/v4l2-core/v4l2-compat-ioctl32.c:256: warning: Function parameter or member 'capabilities' not described in 'v4l2_create_buffers32' Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c

[PATCH for request_api branch] v4l2-ctrls.c: fix smatch error

2018-09-14 Thread Hans Verkuil
Fix this smatch error: drivers/media/v4l2-core/v4l2-ctrls.c:2971 v4l2_ctrl_request_clone() error: uninitialized symbol 'err'. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 73665c7d7045..65e3cf838ac7 100644 ---

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-14 Thread jacopo mondi
Hello Loic, On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote: > On 6 September 2018 at 09:48, jacopo mondi wrote: > > Hello Loic, > >thanks for looking into this > > > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: > >> Hi Jacopo, > >> > >> > - ret =

Re: [PATCH v2 0/7] TVP5150 fixes and new features

2018-09-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Sep 2018 10:43:03 +0200 Marco Felsch escreveu: > Hi, > > since I sent this series I only got feedback from Rob. I'm doing some tests on it. If everything gets ok, I'll likely merge it today. > > Regards, > Marco > > On 18-08-13 11:25, Marco Felsch wrote: > > Hi, > > > > this is

Re: [PATCH] tvp5150: avoid going past array on v4l2_querymenu()

2018-09-14 Thread Marco Felsch
On 18-09-13 18:36, Mauro Carvalho Chehab wrote: > The parameters of v4l2_ctrl_new_std_menu_items() are tricky: instead of > the number of possible values, it requires the number of the maximum > value. In other words, the ARRAY_SIZE() value should be decremented, > otherwise it will go past the

Re: [PATCH v2 0/7] TVP5150 fixes and new features

2018-09-14 Thread Marco Felsch
Hi, since I sent this series I only got feedback from Rob. Regards, Marco On 18-08-13 11:25, Marco Felsch wrote: > Hi, > > this is my v2 with the integrated reviews from my v1 [1]. Since Mauro > applied the most patches from my v1 to his experimental/tvp5150-3 > branch [2], this series only

[RFP] Media Summit: Save/Restore controls from MTD

2018-09-14 Thread Ricardo Ribalda Delgado
Industrial/Scientific sensors usually come with very extensive calibration information such as: per column gain, list of dead/pixels, temperature sensor offset... etc We are saving that information on an flash device that is located by the sensor. I would like some minutes (15 max) to show you

[PATCH] media: imx-pxp: fix compilation on i386 or x86_64

2018-09-14 Thread Philipp Zabel
Include the missing interrupt.h header to fix compilation on i386 or x86_64: ../drivers/media/platform/imx-pxp.c:988:1: error: unknown type name 'irqreturn_t' static irqreturn_t pxp_irq_handler(int irq, void *dev_id) ^ ../drivers/media/platform/imx-pxp.c: In function 'pxp_irq_handler':

Re: RFC: stop support for 2.6 kernel in the daily build

2018-09-14 Thread Hans Verkuil
On 09/13/2018 11:32 PM, Jasmin J. wrote: > Hello Hans! > >> I'm inclined to drop support for 2.6 altogether. > RHEL 6 is on kernel 2.6.32, which we do not support since long time. > Most other distributions switched to 3.x also years in the past. > So lets drop 2.6.x then! OK, I'll do that in