ith the STV and
also the CXD28xx-based tuners. The work on this was done in around 2013
or so by Antti Palosaari (see [2]), and it worked out so nicely when I
first started tackling things I never cared to pick up the
tda18212DD :-)
Best regards,
Daniel Scheller
[1]
https://github.com/herrnst/dddvb
From: Daniel Scheller <d.schel...@gmx.net>
The values used for comparing symbol rates and the resulting conditional
reg writes seem wrong (rates multiplied by ten), so fix those values.
While this doesn't seem to influence operation, it should be fixed anyway.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
In some configurations (due to different PIN config, wiring or so), the
QAM FECLock might be signalled using a different register than
F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw),
so make that register selectable.
Sign
From: Daniel Scheller <d.schel...@gmx.net>
The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed
everytime tuning succeeds or fails, quite cluttering the normal kernel log.
Use dprintk() instead of printk(KERN_ERR...) so that if the information is
needed, it'll be printe
From: Daniel Scheller <d.schel...@gmx.net>
This adds detection and activation for STV0367-based tuner hardware (namely
CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the
extended stv0367 demod driver.
TDA18212 i2c_client/regmap-api code was originally implemented by
From: Daniel Scheller <d.schel...@gmx.net>
These patches enhance the functionality of dvb-frontends/stv0367 to work
with Digital Devices hardware driven by the ST STV0367 demodulator chip
and adds probe & attach bits to ddbridge to make use of them, effectively
enabling full support fo
From: Daniel Scheller <d.schel...@gmx.net>
Move the *ter and *cab st_register tables into a separate header file and
additionally organize them via a multidimensional array, allowing to add
more tables with differing init values, and also prepare for a base init
table which should contain g
From: Daniel Scheller <d.schel...@gmx.net>
Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit
of the demodulator will be performed. While this might cause a slight delay
when switching channels due to all involved tables being rewritten, it can
even be dan
From: Daniel Scheller <d.schel...@gmx.net>
Digital Devices uses defaults tables in their stv0367dd demod driver
variant which differ in a few registers, at least enough that no stable
operation can be provided with the tables already present in the driver
(init succeeds and DVB reception
From: Daniel Scheller <d.schel...@gmx.net>
This moves the PLL SETUP code from stv0367ter_init() into a dedicated
function, and also make it possible to configure 58Mhz IC speed at
27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode).
Signed-off-by: Daniel Scheller <d.schel..
From: Daniel Scheller <d.schel...@gmx.net>
This - in conjunction with the previous changes - makes it possible to use
the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having
this demodulator soldered on them (namely CineCTv6 bridges and some earlier
DuoFlex CT addon m
From: Daniel Scheller <d.schel...@gmx.net>
Change defaults table writing so tables can be of dynamic length without
having to keep track of their lengths by adding and evaluating an end
marker (reg 0x), also move table writing to a dedicated function to
remove code duplication. Additi
From: Daniel Scheller <d.schel...@gmx.net>
Some hardware and bridges (namely ddbridge) require that tuner access is
limited to one concurrent access and wrap i2c gate control with a
mutex_lock when attaching frontends. According to vendor information, this
is required as concurrent
From: Daniel Scheller <d.schel...@gmx.net>
Currently, if_khz is set and provided using the configuration var in
struct stv0367_config. However, in some constellations, the value might be
different for differing channel bandwidths or even -T and -C operation.
When e.g. used in conju
Am Sun, 26 Mar 2017 10:03:33 +0200
schrieb Matthias Schwarzott <z...@gentoo.org>:
> Am 24.03.2017 um 19:23 schrieb Daniel Scheller:
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Some hardware and bridges (namely ddbridge) require that tuner
> > acc
e system]
>
> url:
> https://github.com/0day-ci/linux/commits/Daniel-Scheller/stv0367-ddbridge-support-CTv6-FlexCT-hardware/20170326-235957
> base: git://linuxtv.org/media_tree.git master config:
> x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian
> 6.2.0-3) 6.2.0
From: Daniel Scheller <d.schel...@gmx.net>
Adds new i2c_read_regs() function and make i2c_read_reg() wrap into this
with len=1. Required for the tuner_tda18212_ping() and XO2 handling
functions (part of the Sony CXD28xx support patch series).
Signed-off-by: Daniel Scheller <d.schel..
From: Daniel Scheller <d.schel...@gmx.net>
Digital Devices uses defaults tables in their stv0367dd demod driver
variant which differ in a few registers, at least enough that no stable
operation can be provided with the tables already present in the driver
(init succeeds and DVB reception
From: Daniel Scheller <d.schel...@gmx.net>
This adds detection and activation for STV0367-based tuner hardware (namely
CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the
extended stv0367 demod driver.
TDA18212 i2c_client/regmap-api code was originally implemented by
From: Daniel Scheller <d.schel...@gmx.net>
Move the *ter and *cab st_register tables into a separate header file and
additionally organize them via a multidimensional array, allowing to add
more tables with differing init values, and also prepare for a base init
table which should contain g
From: Daniel Scheller <d.schel...@gmx.net>
Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit
of the demodulator will be performed. While this might cause a slight delay
when switching channels due to all involved tables being rewritten, it can
even be dan
From: Daniel Scheller <d.schel...@gmx.net>
This - in conjunction with the previous changes - makes it possible to use
the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having
this demodulator soldered on them (namely CineCTv6 bridges and some earlier
DuoFlex CT addon m
From: Daniel Scheller <d.schel...@gmx.net>
Some hardware and bridges (namely ddbridge) require that tuner access is
limited to one concurrent access and wrap i2c gate control with a
mutex_lock when attaching frontends. According to vendor information, this
is required as concurrent
From: Daniel Scheller <d.schel...@gmx.net>
Change defaults table writing so tables can be of dynamic length without
having to keep track of their lengths by adding and evaluating an end
marker (reg 0x), also move table writing to a dedicated function to
remove code duplication. Additi
From: Daniel Scheller <d.schel...@gmx.net>
Third iteration of the DD CineCTv6/FlexCT support patches with mostly
all things cleaned up that popped up so far. Obsoletes V1 and V2 series.
These patches enhance the functionality of dvb-frontends/stv0367 to work
with Digital Devices hardware
From: Daniel Scheller <d.schel...@gmx.net>
Currently, if_khz is set and provided using the configuration var in
struct stv0367_config. However, in some constellations, the value might be
different for differing channel bandwidths or even -T and -C operation.
When e.g. used in conju
From: Daniel Scheller <d.schel...@gmx.net>
This moves the PLL SETUP code from stv0367ter_init() into a dedicated
function, and also make it possible to configure 58Mhz IC speed at
27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode).
Signed-off-by: Daniel Scheller <d.schel..
From: Daniel Scheller <d.schel...@gmx.net>
The values used for comparing symbol rates and the resulting conditional
reg writes seem wrong (rates multiplied by ten), so fix those values.
While this doesn't seem to influence operation, it should be fixed anyway.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed
everytime tuning succeeds or fails, quite cluttering the normal kernel log.
Use dprintk() instead of printk(KERN_ERR...) so that if the information is
needed, it'll be printe
From: Daniel Scheller <d.schel...@gmx.net>
In some configurations (due to different PIN config, wiring or so), the
QAM FECLock might be signalled using a different register than
F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw),
so make that register selectable.
Sign
Am Fri, 24 Mar 2017 19:24:08 +0100
schrieb Daniel Scheller <d.scheller@gmail.com>:
> When boards with STV0367 are cold-started, there might be issues with
> the I2C gate, causing the TDA18212 detection/probe to fail. For these
> demods, a workaround is implemented to do the tu
From: Daniel Scheller <d.schel...@gmx.net>
Fixes "w_scan -f c" complaining with
This dvb driver is *buggy*: the symbol rate limits are undefined - please
report to linuxtv.org)
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/cxd284
From: Daniel Scheller <d.schel...@gmx.net>
When fe_ops.read_status is called and no channel is tuned (yet), the
subsequent calls to get_lock_status() causes the kernel log to be filled
with
drxk: Error -22 on get_lock_status
which either means a NULL pointer was passed for the p_lock_
Am Mon, 13 Mar 2017 16:16:29 +0200
schrieb Antti Palosaari <cr...@iki.fi>:
> On 03/07/2017 08:57 PM, Daniel Scheller wrote:
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Taken from tda18212dd, first read after cold reset sometimes fails
> > on some
Am Tue, 7 Mar 2017 19:57:25 +0100
schrieb Daniel Scheller <d.scheller@gmail.com>:
> - add a third *_attach function which will make use of a third
> frontend_ops struct which announces both -C and -T support (the same
> as with DD's own driver stv0367dd). This is necessary
Am Wed, 29 Mar 2017 18:43:00 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> From: Daniel Scheller <d.schel...@gmx.net>
>
> Third iteration of the DD CineCTv6/FlexCT support patches with mostly
> all things cleaned up that popped up so far. Obso
From: Daniel Scheller <d.schel...@gmx.net>
Doing the I2C read operation with two calls to i2c_transfer() causes the
exclusive I2C bus lock of the underlying adapter to be released. While this
isn't an issue if only one demodulator is attached to the bus, having two
or even more causes tr
From: Daniel Scheller <d.schel...@gmx.net>
Important note: This series depends on the stv0367/ddbridge series posted
earlier (patches 12 [1] and 13 [2], depending on the I2C functions and the
TDA18212 attach function).
This series improves the cxd2841er demodulator driver and adds som
From: Daniel Scheller <d.schel...@gmx.net>
This moves the I2C debug dump into the preceding dev_dbg() call by
utilising the %*ph format macro and removes the call to
print_hex_debug_bytes().
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/cxd
From: Daniel Scheller <d.schel...@gmx.net>
The Sony CXD28xx demods may have other tuner types attached to them (e.g.
NXP TDA18212), so don't mandatorily configure and enable the ASCOT
functionality, but make this conditional by a config flag.
Signed-off-by: Daniel Scheller <d.schel..
From: Daniel Scheller <d.schel...@gmx.net>
Those demods are programmed in the same way as the CXD2841ER/54ER and can
be handled by this driver. Support added in a way matching the existing
code, supported delivery systems are set according to what each demod
supports.
Updates the type
From: Daniel Scheller <d.schel...@gmx.net>
Some constellations work/need a serial TS transport mode. This adds a flag
that will toggle set up of such mode.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/cxd2841er.c | 18 --
drive
From: Daniel Scheller <d.schel...@gmx.net>
Do unfreeze_regs() directly when accessing the demod registers is done,
and don't have multiple unfreeze's on different conditions, which even
can get prone to errors.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/d
From: Daniel Scheller <d.schel...@gmx.net>
Don't wait for FE_HAS_LOCK in set_frontend_tc() and thus don't hammer the
lock status register with inquiries when CXD2841ER_NO_WAIT_LOCK is set
in the configuration, which also unneccessarily blocks applications until
a TS LOCK has been acquired.
From: Daniel Scheller <d.schel...@gmx.net>
This is a backport of the board control setup from the vendor provided
dddvb driver package, which does additional device initialisation based
on the board_control device info values. Also backports the TS quirk
flags which is used to control
From: Daniel Scheller <d.schel...@gmx.net>
Some Flex modules (mostly with anyof C/C2/T/T2 demods based on the Sony
CXD28xxER series) are equipped with an interface named XO2 (which
appears to be the Lattice MachXO2). Add functionality to detect such
links and initialise them, so any tuner
From: Daniel Scheller <d.schel...@gmx.net>
Adds hardware IDs for all Sony CXD-based Cine-cards and MaxA8 devices, also
adds some other yet missing IDs like the Octopus V3, Octopus OEM and
Octopus Mini, as well as cards with unknown/deleted sub-ids.
Signed-off-by: Daniel Scheller &l
From: Daniel Scheller <d.schel...@gmx.net>
When AUTO_IFHZ is set and the tuner is supposed to provide proper IF speed
values, it should be possible to have the tuner setup take place before
the demod is configured, else the demod might be configured with either
wrong (old), or even no
From: Daniel Scheller <d.schel...@gmx.net>
Throughout the patch series some configuration flags will be added to the
demod driver. This patch prepares this by adding the flags var to
struct cxd2841er_config, which will serve as a bitmask to toggle various
options and behaviour in the
From: Daniel Scheller <d.schel...@gmx.net>
Bits 3 and 4 of the TSCONFIG register are important for certain hardware
constellations, in that they need to be zeroed. Add a configuration flag
to toggle this.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/d
From: Daniel Scheller <d.schel...@gmx.net>
The way the MAKE_IFFREQ_CONFIG macros are written make it impossible to
pass regular integers for iffreq calculation, since this will cause "SSE
register return with SSE disabled" compile errors. This changes the
calculation into C func
From: Daniel Scheller <d.schel...@gmx.net>
Some cards/bridges wrap i2c_gate_ctrl handling with a mutex_lock(). This is
e.g. done in ddbridge to protect against concurrent tuner access with
regards to the dual tuner HW, where concurrent tuner reconfiguration can
result in tuning fails
From: Daniel Scheller <d.schel...@gmx.net>
Adds a flag to enable or disable the IFAGCNEG bit in cxd2841er_init_tc().
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/cxd2841er.c | 5 +++--
drivers/media/dvb-frontends/cxd2841er.h | 1 +
2 file
From: Daniel Scheller <d.schel...@gmx.net>
Properly detect and attach Ports and Flex modules with the Sony CXD28xxER
series demods. This makes newer Cine cards and most DuoFlex C/C2/T/T2 (or
any combination of these systems) work, PCI IDs need to be added though.
Note: This ut
From: Daniel Scheller <d.schel...@gmx.net>
Add a AUTO_IFHZ flag and a function that will read IF speed values from any
attached tuner if the tuner supports this and if AUTO_IFHZ is enabled, and
else the passed default value (which probably matches Sony ASCOT tuners)
will be passe
From: Daniel Scheller <d.schel...@gmx.net>
On DVB-T/T2 at least, SNR might be reported as >2500dB, which not only is
just wrong but also ridiculous, so fix this by improving the conversion
of the register value.
The INTLOG10X100 function/macro and the way the values are converted were
b
From: Daniel Scheller <d.schel...@gmx.net>
Digital Devices uses defaults tables in their stv0367dd demod driver
variant which differ in a few registers, at least enough that no stable
operation can be provided with the tables already present in the driver
(init succeeds and DVB reception
From: Daniel Scheller <d.schel...@gmx.net>
Taken from tda18212dd, first read after cold reset sometimes fails on some
cards, trying twice shall do the trick. This is the case with the STV0367
demods soldered on the CineCTv6 bridge boards and older DuoFlex CT modules.
All other users (c
From: Daniel Scheller <d.schel...@gmx.net>
This - in conjunction with the previous changes - makes it possible to use
the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having
this demodulator soldered on them (namely CineCTv6 bridges and some earlier
DuoFlex CT addon m
From: Daniel Scheller <d.schel...@gmx.net>
There can be use cases (bridges, namely ddbridge) which will care about
gate control in a way that involves mutex_locks and remapped i2c_gatectrl
FE ops. If the demod driver (additionally) performs it's own gate control
and there's somethin
From: Daniel Scheller <d.schel...@gmx.net>
The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed
everytime tuning succeeds or fails, quite cluttering the normal kernel log.
Use dprintk() instead of printk(KERN_ERR...) so that if the information is
needed, it'll be printe
From: Daniel Scheller <d.schel...@gmx.net>
Currently, if_khz is set and provided using the configuration var in
struct stv0367_config. However, in some constellations, the value might be
different for differing channel bandwidths or even -T and -C operation.
When e.g. used in conju
From: Daniel Scheller <d.schel...@gmx.net>
In some configurations (due to different PIN config, wiring or so), the
QAM FECLock might be signalled using a different register than
F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw),
so make that register selectable.
Sign
From: Daniel Scheller <d.schel...@gmx.net>
This adds detection and activation for STV0367-based tuner hardware (namely
CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the
extended stv0367 demod driver, and needs the init_retry when attaching the
TDA18212 tuner.
TD
From: Daniel Scheller <d.schel...@gmx.net>
Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit
of the demodulator will be performed. While this might cause a slight delay
when switching channels due to all involved tables being rewritten, it can
even be dan
From: Daniel Scheller <d.schel...@gmx.net>
This moves the PLL SETUP code from stv0367ter_init() into a dedicated
function, and also make it possible to configure 58Mhz IC speed at
27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode).
Signed-off-by: Daniel Scheller <d.schel..
From: Daniel Scheller <d.schel...@gmx.net>
Move the *ter and *cab st_register tables into a separate header file and
additionally organize them via a multidimensional array, allowing to add
more tables with differing init values, and also prepare for a base init
table which should contain g
From: Daniel Scheller <d.schel...@gmx.net>
These patches enhance the functionality of dvb-frontends/stv0367 to work
with Digital Devices hardware driven by the ST STV0367 demodulator chip
and adds probe & attach bits to ddbridge to make use of them, effectively
enabling full support fo
From: Daniel Scheller <d.schel...@gmx.net>
The values used for comparing symbol rates and the resulting conditional
reg writes seem wrong (rates multiplied by ten), so fix those values.
While this doesn't seem to influence operation, it should be fixed anyway.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
Change defaults table writing so tables can be of dynamic length without
having to keep track of their lengths by adding and evaluating an end
marker (reg 0x), also move table writing to a dedicated function to
remove code duplication. Additi
From: Daniel Scheller <d.schel...@gmx.net>
It is known that MSI interrupts - while working quite well so far - can
still cause issues on some hardware platforms (causing I2C timeouts due
to unhandled interrupts). The msi variable/option is set to 1 by default.
So, add a Kconfig option pr
From: Daniel Scheller <d.schel...@gmx.net>
Further cleanup of ddbridge-core and ddbridge-main, and moves all such
hw definitions into one single place, making things easier to maintain.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
Tested-by: Richard Scobie <r.sco...@clear
From: Daniel Scheller <d.schel...@gmx.net>
>From smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:3490 snr_store() info: ignoring
unreachable code.
In fact, the function immediately returns zero, so remove it and update
ddb_attrs_snr[] to not reference it anymore.
Cc: Ralph M
From: Daniel Scheller <d.schel...@gmx.net>
Smatch reported:
drivers/media/pci/ddbridge/ddbridge-core.c:1602 dvb_input_attach() error: we
previously assumed 'dvb->fe' could be null (see line 1595)
dvb->fe2 will ever only be populated when dvb->fe is set. So only handle
regi
From: Daniel Scheller <d.schel...@gmx.net>
Report from smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:2659 ddb_ports_init() error:
buffer overflow 'dev->port' 32 <= u32max
Fix by making sure "p" is greater than zero before checking for
"dev->port[].typ
From: Daniel Scheller <d.schel...@gmx.net>
Both ts_release() and ts_open() can use "output" before check (smatch):
drivers/media/pci/ddbridge/ddbridge-core.c:816 ts_release() warn: variable
dereferenced before check 'output' (see line 809)
drivers/media/pci/ddbridge/ddb
From: Daniel Scheller <d.schel...@gmx.net>
This not only helps keep the ddbridge-core tidy, but also gets rid of
defined-but-unused-function warnings which might be triggered depending of
CONFIG_PCI_MSI, without having to clutter the code with #ifdef'ery.
Signed-off-by: Daniel Scheller &l
From: Daniel Scheller <d.schel...@gmx.net>
As of 0.9.9b, the ddbridge code has been split from one single file
(ddbridge-core.c) into multiple files, with the purpose of taking care of
different topics, and to be able to reuse code in different kernel modules
(ddbridge.ko and octo
From: Daniel Scheller <d.schel...@gmx.net>
Still prefered for and made for Linux 4.14.
Changes from v1 to v2:
* I2C access functions (ie. i2c_read() et al) refactored from
ddbridge-i2c.c into ddbridge-i2c.h and declared static, and needed
include added to all .c files making use o
From: Daniel Scheller <d.schel...@gmx.net>
The functions in ddbridge-core.c have been moved to different positions in
newer versions of the dddvb vendor driver package (most notably in version
0.9.9b). Perform the same code move to keep the diff of the upcoming
code bump simpler.
Sign
From: Daniel Scheller <d.schel...@gmx.net>
While it seems valid that headers can carry simple oneline static inline
annotated functions, move them into their own header file to have the
overall code more readable. Also, keep them as header (and don't put in
a separate object) and static
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9826a918d37a..f25f26b5d9f6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -842
From: Daniel Scheller <d.schel...@gmx.net>
Fixes two warnings reported by smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:240 ddb_redirect() warn: variable
dereferenced before check 'idev' (see line 238)
drivers/media/pci/ddbridge/ddbridge-core.c:240 ddb_redirect() warn: va
From: Daniel Scheller <d.schel...@gmx.net>
Smatch and gcc complained:
drivers/media/pci/ddbridge/ddbridge-core.c:3491 bpsnr_show() warn: impossible
condition '(snr[0] == 255) => ((-128)-127 == 255)'
drivers/media/pci/ddbridge/ddbridge-core.c: In function ‘bpsnr_show’:
drivers/
From: Daniel Scheller <d.schel...@gmx.net>
Both ts_release() and ts_open() can use "output" before check (smatch):
drivers/media/pci/ddbridge/ddbridge-core.c:816 ts_release() warn: variable
dereferenced before check 'output' (see line 809)
drivers/media/pci/ddbridge/ddb
From: Daniel Scheller <d.schel...@gmx.net>
It is known that MSI interrupts - while working quite well so far - can
still cause issues on some hardware platforms (causing I2C timeouts due
to unhandled interrupts). The msi variable/option is set to 1 by default.
So, add a Kconfig option pr
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 931abca006b7..0453a1365c3a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -842
From: Daniel Scheller <d.schel...@gmx.net>
Fixes two warnings reported by smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:240 ddb_redirect() warn: variable
dereferenced before check 'idev' (see line 238)
drivers/media/pci/ddbridge/ddbridge-core.c:240 ddb_redirect() warn: va
From: Daniel Scheller <d.schel...@gmx.net>
Smatch reported:
drivers/media/pci/ddbridge/ddbridge-core.c:1602 dvb_input_attach() error: we
previously assumed 'dvb->fe' could be null (see line 1595)
dvb->fe2 will ever only be populated when dvb->fe is set. So only handle
regi
From: Daniel Scheller <d.schel...@gmx.net>
Further cleanup of ddbridge-core and ddbridge-main, and moves all such
hw definitions into one single place, making things easier to maintain.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
Tested-by: Richard Scobie <r.sco...@clear
From: Daniel Scheller <d.schel...@gmx.net>
While it seems valid that headers can carry simple oneline static inline
annotated functions, move them into their own header file to have the
overall code more readable. Also, keep them as header (and don't put in
a separate object) and static
From: Daniel Scheller <d.schel...@gmx.net>
Still, target: 4.14.
Changes from v3 to v4:
* IRQ handler splitoff removed
* Prefixed irq_handler{,0,1} with ddb_ to avoid potential conflicts in
the global namespace wrt things like allyesconfig due to very generic
function naming
* R
From: Daniel Scheller <d.schel...@gmx.net>
>From smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:3490 snr_store() info: ignoring
unreachable code.
In fact, the function immediately returns zero, so remove it and update
ddb_attrs_snr[] to not reference it anymore.
Cc: Ralph M
From: Daniel Scheller <d.schel...@gmx.net>
Report from smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:2659 ddb_ports_init() error:
buffer overflow 'dev->port' 32 <= u32max
Fix by making sure "p" is greater than zero before checking for
"dev->port[].typ
From: Daniel Scheller <d.schel...@gmx.net>
Smatch and gcc complained:
drivers/media/pci/ddbridge/ddbridge-core.c:3491 bpsnr_show() warn: impossible
condition '(snr[0] == 255) => ((-128)-127 == 255)'
drivers/media/pci/ddbridge/ddbridge-core.c: In function ‘bpsnr_show’:
drivers/
From: Daniel Scheller <d.schel...@gmx.net>
Since the cab_* codepath doesn't recognize QAM_AUTO, don't announce that
it is supported when it really isn't. Fixes ie. w_scan from
unconditionally using QAM_AUTO on DVB-C scans.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
d
From: Daniel Scheller <d.schel...@gmx.net>
Return 0 instead of -EINVAL in get_frontend if no demod mode is active.
This fixes ie. dvb-fe-tool getting confused and assuming a DVBv3 FE on idle
frontends when the FE has been put to sleep using sleep().
Also, in read_status(), don't immed
From: Daniel Scheller <d.schel...@gmx.net>
Picked up code parts introduced one smatch error:
drivers/media/pci/ddbridge/ddbridge-maxs8.c:163 max_set_input_unlocked()
error: buffer overflow 'dev->link[port->lnr].lnb.voltage' 4 <= 255
Fix this by clamping the .lnb.voltage arra
From: Daniel Scheller <d.schel...@gmx.net>
This adds the frontend driver for the MaxLinear MxL5xx family of tuner-
demodulators, as used on Digital Devices MaxS4/8 four/eight-tuner cards.
The driver was picked from the dddvb vendor driver package and - judging
solely from the diff
From: Daniel Scheller <d.schel...@gmx.net>
Both ts_release() and ts_open() can use "output" before check (smatch):
drivers/media/pci/ddbridge/ddbridge-core.c:816 ts_release() warn: variable
dereferenced before check 'output' (see line 809)
drivers/media/pci/ddbridge/ddb
1 - 100 of 516 matches
Mail list logo
