Some of these comments may still need to be reviewed.
This patch only cleans the comment style.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
V2: Fix comment style and resend patch to proper maintainers.
drivers/staging/media/easycap/easycap_main.c | 243
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
V2: resend to proper maintainers
drivers/staging/media/easycap/easycap_main.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/easycap/easycap_main.c
b/drivers/staging/media/easycap
When the device is probed a driver struct is either
allocated or retrieved.
This operation is logically splitted in several functions.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c | 384 +++---
1 files changed, 216
When the device is probed, this driver allocates
frame buffers, field buffers, isoc buffers and urbs.
This patch just split this into separate functions,
which helps clearing the currently gigantic probe function.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c | 72 +++---
1 files changed, 41 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/media/easycap/easycap_main.c
b/drivers/staging/media/easycap/easycap_main.c
This parameter is now initialized at init_easycap(),
this way we assure it won't be used uninitialized.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c | 58 +++---
1 files changed, 33 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/media/easycap/easycap_main.c
b/drivers/staging/media/easycap/easycap_main.c
When the device is probed, this driver allocates
audio buffers, and audio urbs.
This patch just split this into separate functions,
which helps clearing the currently gigantic probe function.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c | 64 ++
1 files changed, 24 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/media/easycap/easycap_main.c
b/drivers/staging/media/easycap/easycap_main.c
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c | 43 +
1 files changed, 16 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/media/easycap/easycap_main.c
b/drivers/staging/media/easycap/easycap_main.c
The patch splits easycap_delete(), which is in charge of
buffer deallocation, into smaller functions each
deallocating a specific kind of buffer.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/easycap/easycap_main.c | 445 ++---
1 files
These arrays were embedded in the struct itself, but they weren't
used by anyone, since urbs are now dinamically allocated
at em28xx_usb_isoc_ctl struct.
Tested by compilation only.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx.h |3 ---
1 files
This patch saves 255 bytes of stack on usb_probe() by removing
a char array. In some platforms this is represents a substantial save.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-cards.c | 19 ---
1 files changed, 4 insertions
This patch saves 255 bytes of stack on usb_probe() by removing
a char array. In some platforms this is represents a substantial save.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
Previous patch was sent as 2/2 by mistake
---
drivers/media/video/em28xx/em28xx-cards.c | 19
This changes rc_core to not load the IR decoders at load time,
postponing it to load only if a RC_DRIVER_IR_RAW device is registered
via rc_register_device.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/rc/rc-main.c |8 ++--
include/media/rc-core.h|2
-by: Ezequiel Garcia elezegar...@gmail.com
---
v2: Fix broken logic in v1.
Also, put raw_init as static instead of inside rc_dev
struct to ensure loading is only tried the first time.
---
drivers/media/rc/rc-main.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git
-by: Ezequiel Garcia elezegar...@gmail.com
---
v3: Fix scope of static bool: now it is local to relevant function.
v2: Fix broken logic in v1.
Also, put raw_init as static instead of inside rc_dev
struct to ensure loading is only tried the first time.
---
drivers/media/rc/rc-main.c |9
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-i2c.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-i2c.c
b/drivers/media/video/em28xx/em28xx-i2c.c
index 36f5a9b..a88e169 100644
dev-ctl_input() is always set before a call to video_mux(),
but then video_mux() sets it again with the same value.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-video.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-core.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-core.c
b/drivers/media/video/em28xx/em28xx-core.c
index 53a9fb9..237d44f 100644
Moving this helps isolating em28xx_input and will help
converting it into a separate module.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-cards.c | 10 --
drivers/media/video/em28xx/em28xx-i2c.c |3 ---
drivers/media/video/em28xx
This function is only used in em28xx-input.c so it
makes no sense to have it anywhere but in em28xx-input.c.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-cards.c | 48 -
drivers/media/video/em28xx/em28xx-input.c | 44
This functions are no longer used from another file,
so they should be declared as static.
Also is it necessary to move some of them before they
are used, since they are no longer header-declared.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/em28xx-input.c
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/em28xx/Kconfig|4 ++--
drivers/media/video/em28xx/Makefile |5 ++---
drivers/media/video/em28xx/em28xx-cards.c |8 ++--
drivers/media/video/em28xx/em28xx-input.c | 27
: chip 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 @
0x4a is unknown
(found on a device labeled as GM7113C 1145 by Ezequiel Garcia)
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/i2c/saa7115.c | 36
include/media/v4l2
On Fri, Apr 26, 2013 at 09:49:16AM -0300, Mauro Carvalho Chehab wrote:
As we're now seeing other variants from chinese clones, like
gm1113c, we'll need to add more bits at the detection code.
So, move it into a separate function.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
Hi Mauro,
Thanks for the patch!
On Fri, Apr 26, 2013 at 09:49:15AM -0300, Mauro Carvalho Chehab wrote:
I didn't add there the part of your code with the gm7113c specifics,
as I prefer if you can rebase your patch on the top of those two,
of course assuming that they'll work.
Patches
Hi Jon,
On Mon, Apr 29, 2013 at 10:41:06PM +0200, Jon Arne Jørgensen wrote:
This is the second version of a patch-set previously posted by Mauro,
the first verseon was posted on 26 April, and can be found here:
http://www.spinics.net/lists/linux-media/msg63079.html
The purpose of this patch
Hi Jon,
On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote:
As we're now seeing other variants from chinese clones, like
gm1113c, we'll need to add more bits at the detection code.
So, move it into a separate function.
Signed-off-by: Mauro Carvalho Chehab
: chip 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 @
0x4a is unknown
(found on a device labeled as GM7113C 1145 by Ezequiel Garcia)
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no
Your SOB doesn't appear to be correct. See my
this issue finally fixed!
Could you please re-send the whole series, taking account of this
comments. You can add my:
Tested-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
to every patch in the series.
Thanks!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http
Hi Jon,
On Fri, May 03, 2013 at 11:13:17AM +0200, Jon Arne Jørgensen wrote:
[...]
I've tested the changes, and it doesn't seem to break/change the smi2021
driver.
I'll append this to the pending saa7115 patch and ask Ezequiel Garcia to check
that the change doesn't break the stk1160 driver
Hi Jon,
On Fri, May 03, 2013 at 08:58:46AM +0200, Jon Arne Jørgensen wrote:
[...]
You can read more about this in Documentation/SubmittingPatches.
I just re-read SubmittingPatches.
I couldn't see that there is anything wrong with multiple sign-off's.
Indeed there isn't anything wrong
Hi Mauro,
On Thu, May 02, 2013 at 11:52:33AM -0300, Mauro Carvalho Chehab wrote:
is unreliable (doesn't do what some people expect) when SND=m and
SND_AC97_CODEC=m,
since VIDEO_STK1160_AC97 is a bool.
Using select is always tricky.
I can see a few possible fixes for it:
1) split
Tested-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
: chip 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 @
0x4a is unknown
(found on a device labeled as GM7113C 1145 by Ezequiel Garcia)
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
Tested-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com
--
Ezequiel García, Free Electrons
On Sat, May 04, 2013 at 09:59:50PM +0200, Yann E. MORIN wrote:
Ezequiel, All,
On Sat, May 04, 2013 at 02:21:44PM -0300, Ezequiel Garcia wrote:
I'm trying to split the ac97 support into a separate module.
So far I've managed to do this with two different approaches,
but both of them
On Thu, May 9, 2013 at 1:11 PM, a b genericgroupm...@gmail.com wrote:
Hi,
I am seeing occasional issues when using an easycap card on our fedora
17 machine.
[...]
On a very quick look you seem to be getting out of memory (out of
blocks of pages large enough for stk1160). Now, this may be some
On Sat, May 11, 2013 at 10:28 AM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Thu, May 9, 2013 at 1:11 PM, a b genericgroupm...@gmail.com wrote:
Hi,
I am seeing occasional issues when using an easycap card on our fedora
17 machine.
[...]
On a very quick look you seem to be getting out
Hi Alejandro,
On Wed, May 22, 2013 at 10:12 PM, Alejandro A. Valdés
av2...@gmail.com wrote:
Being able to capture the TV signal from a cable decoder; but can't make it
with getting audio working.I'm using an Easycap dc60 USB adapter, plugged in
to one of the USB 2.0 ports of an ASUS
On Thu, May 23, 2013 at 1:19 PM, Alejandro A. Valdés av2...@gmail.com wrote:
Good morning,
Please find the output the cat /proc/asound/ command below:
# cat /proc/asound/cards
0 [Intel ]: HDA-Intel - HDA Intel
HDA Intel at 0xf7cf8000 irq 45
1 [EasyALSA1
Alejandro,
You dropped the linux-media list from Cc. I'm adding it back.
On Thu, May 23, 2013 at 3:30 PM, Alejandro A. Valdés av2...@gmail.com wrote:
# lsmod
Module Size Used by
snd_usb_audio 106622 0
snd_usbmidi_lib24590 1 snd_usb_audio
easycap
Hi Alejandro,
See below.
On Sat, May 25, 2013 at 4:00 AM, Jon Arne Jørgensen jona...@jonarne.no wrote:
On Thu, May 23, 2013 at 09:48:38PM -0300, Alejandro A. Valdés wrote:
[...]
[ 187.472216] easycap::0adjust_contrast: adjusting contrast to 0x3F
[ 187.496207] easycap::0adjust_saturation:
Hi Greg,
On Thu, May 30, 2013 at 3:58 PM, Greg Horvath horvath@gmail.com wrote:
I have ported the 3.2 version of driver to kernel version 3.0.8 running on
an rk3066 (mk808) device.
That's cool.
[13336.159017] stk1160: driver ver 0.9.5 successfully loaded
[...]
First of all, look here:
On Thu, May 30, 2013 at 6:22 PM, Greg Horvath horvath@gmail.com wrote:
I am not running them at the same time. There are two sets of dmesg output.
One for the stk1160 driver and the other when I attempted to load easycap
driver without loading stk1160.
Right. In that case you can forget
and let you know how it goes.
Will probably give it a few days worth of runs to see if it re-occurs.
Thanks again!
On Sat, May 11, 2013 at 3:40 PM, Ezequiel Garcia elezegar...@gmail.com
wrote:
On Sat, May 11, 2013 at 10:28 AM, Ezequiel Garcia elezegar...@gmail.com
wrote:
On Thu, May 9, 2013
On Fri, May 31, 2013 at 12:23 PM, Greg Horvath horvath@gmail.com wrote:
I will try and get a 3.7 kernel running on an x86 machine and
see if I can get it to run though. Thanks for taking the time to
investigate.
That sounds like a good plan! Please try with a v3.7+ kernel on x86
and
Hi Hans,
On Mon, Jun 10, 2013 at 9:48 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-dev.c | 34
+++---
Ale,
On Mon, Jun 10, 2013 at 8:27 PM, Alejandro A. Valdés av2...@gmail.com wrote:
[...]
Besides, please find the kernel configuration file attached t this note.
Seems that the STK1160_AC97 is already there (Ln 4151 AND SS).
Yes, it seems your configuration is correct.
I have a device here
Hi everyone,
On Sat, Jun 16, 2012 at 10:35 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
Hm... There are several more places which have this same problem.
I'm not sure what's going on here.
drivers/media/video/saa7164/saa7164-i2c.c:112 saa7164_i2c_register() error:
memcpy()
.
The latter is, in my opinion, a much safer way for struct filling
and I'm not aware of any drawbacks.
The patches are based on today's linux-next; I hope this is okey.
As I don't own any of these devices, I can't test the changes beyond
compilation.
Ezequiel Garcia (12):
cx25821: Replace struct
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/saa7164/saa7164-i2c.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/saa7164/saa7164-i2c.c
b/drivers/media/video/saa7164/saa7164-i2c.c
index 26148f7..536f7dc 100644
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/saa7164/saa7164-i2c.c |4
drivers/media/video/saa7164/saa7164.h |1 -
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/saa7164/saa7164-i2c.c
b/drivers/media/video
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx231xx/cx231xx-i2c.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c
b/drivers/media/video/cx231xx/cx231xx-i2c.c
index f5f4844..2b2e91e 100644
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx231xx/cx231xx-i2c.c |2 --
drivers/media/video/cx231xx/cx231xx.h |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c
b/drivers/media/video
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx25821/cx25821-i2c.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx25821/cx25821-i2c.c
b/drivers/media/video/cx25821/cx25821-i2c.c
index 6311180..398e0e6 100644
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx23885/cx23885-i2c.c |3 ---
drivers/media/video/cx23885/cx23885.h |2 --
drivers/media/video/saa7164/saa7164.h |1 -
3 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/media
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx25821/cx25821-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/cx25821/cx25821-i2c.c
b/drivers/media/video/cx25821/cx25821-i2c.c
index 431fa7f..8a823b8 100644
On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote:
Hi Mauro,
This patchset cleans the i2c part of some drivers.
This issue was recently reported by Dan Carpenter [1],
and revealed wrong (and harmless
Hi Mauro,
On Mon, Jun 18, 2012 at 7:01 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 31-05-2012 13:29, Ezequiel Garcia escreveu:
Hi Gregor,
On Thu, May 31, 2012 at 4:07 AM, Gregor Jasny gja...@googlemail.com wrote:
Hello,
On 5/30/12 3:42 PM, Ezequiel Garcia wrote:
This patch
Hi Hans,
On Tue, Jun 19, 2012 at 3:34 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi all,
Yesterday I upgraded the gcc version I use to compile the daily build to
4.7.1.
This causes very strange errors when compiling 2.6.39 - 3.3:
FATAL: media_build/v4l/tuner: sizeof(struct
On Tue, Jun 19, 2012 at 4:39 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Hans,
I've:
[peter@ace tmp]$ diff linux-2.6.35.13/scripts/mod/file2alias.c
linux-3.4.3/scripts/mod/file2alias.c
And found:
727a840
ADD_TO_DEVTABLE(i2c, struct i2c_device_id, do_i2c_entry);
FWIW, that macro
Hi Peter and Hans,
On Wed, Jun 20, 2012 at 3:19 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 19/06/12 21:41, Peter Senna Tschudin wrote:
Full diff:
http://pastebin.com/BJS2EXcH
On Tue, Jun 19, 2012 at 4:39 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Hans,
I've:
[peter@ace
Hi all,
solo6x10 TODO file says this:
TODO (staging = main):
* Motion detection flags need to be moved to v4l2
* Some private CIDs need to be moved to v4l2
But I could not find any v4l2 motion detection flag. I guess it's a
new kind of flag that needs to be added.
Also, what
.
The patches are based on today's linux-next; I hope this is okey.
As I don't own this device, I can't provide any test beyond compilation.
Ezequiel Garcia (10):
staging: solo6x10: Avoid extern declaration by reworking module parameter
staging: solo6x10: Fix several over 80 character lines
Mauro Carvalho Chehab is the current maintainer of staging/media.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/TODO |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/media/solo6x10/TODO
b/drivers/staging/media
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/gpio.c |2 +-
drivers/staging/media/solo6x10/solo6x10.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/solo6x10/gpio.c
b/drivers/staging/media/solo6x10
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/v4l2-enc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/media/solo6x10/v4l2-enc.c
b/drivers/staging/media/solo6x10/v4l2-enc.c
index f8f0da9..9333a00 100644
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/media/solo6x10/core.c
b/drivers/staging/media/solo6x10/core.c
index d2fd842..8c4f5cf 100644
--- a/drivers
The patch removes this warning:
warning: format ‘%d’ expects type ‘int’,
but argument 2 has type ‘long unsigned int’
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/tw28.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/p2m.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/solo6x10/p2m.c
b/drivers/staging/media/solo6x10/p2m.c
index 56210f0..1eb9fb3 100644
--- a/drivers
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/core.c |4 ++--
drivers/staging/media/solo6x10/v4l2.c |6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/solo6x10/core.c
b/drivers/staging/media/solo6x10
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/v4l2.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/solo6x10/v4l2.c
b/drivers/staging/media/solo6x10/v4l2.c
index 90e1379..1f896b9 100644
--- a/drivers
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media/solo6x10/i2c.c |3 ++-
drivers/staging/media/solo6x10/v4l2-enc.c | 28 ++--
drivers/staging/media/solo6x10/v4l2.c |5 -
3 files changed, 20 insertions(+), 16 deletions
This patch moves video_nr module parameter to core.c
and then passes that parameter as an argument to functions
that need it.
This way we avoid the extern declaration and parameter
dependencies are better exposed.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/staging/media
Hi Hans,
Dropped Greg from Cc since it's not relevant (and that suse.de address
is broken).
On Thu, Jun 21, 2012 at 5:09 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On 21/06/12 17:08, Ezequiel Garcia wrote:
Hi all,
solo6x10 TODO file says this:
TODO (staging = main):
* Motion
Gianluca,
Forwarded to linux-media, since it could be interesting
and/or might get some extra help.
Please, keep linux-media in Cc when you reply.
Ezequiel.
-- Forwarded message --
From: Ezequiel Garcia elezegar...@gmail.com
Date: Fri, Jun 22, 2012 at 1:19 PM
Subject: Re
Hi Ariel,
On Fri, Jun 22, 2012 at 3:41 PM, Ariel Mammoli cmamm...@gmail.com wrote:
I have a tuner NOGANET NG-FM PTV which has the Philips chip 7134.
I have reviewed the list of values several times but can not find it.
What are the correct values to configure the module saa7134?
That's a
Hi Ariel,
Please don't drop linux-media from Cc.
On Fri, Jun 22, 2012 at 4:08 PM, Ariel Mammoli cmamm...@gmail.com wrote:
Hi Ezequiel,
El vie 22 jun 2012 15:51:02 ART, Ezequiel Garcia ha escrito:
Hi Ariel,
On Fri, Jun 22, 2012 at 3:41 PM, Ariel Mammoli cmamm...@gmail.com wrote:
I have
On Fri, Jun 22, 2012 at 4:40 PM, Ariel Mammoli cmamm...@gmail.com wrote:
Hello again Ezequiel,
[snip]
Ok, I will continue trying, I will contact the manufacturer.
Thank you!
No problem :-)
Please remember to keep Cc when replying;
that way you allow other people reading the list to follow
Hi Ariel,
On Fri, Jun 22, 2012 at 4:40 PM, Ariel Mammoli cmamm...@gmail.com wrote:
Hello again Ezequiel,
El vie 22 jun 2012 16:16:51 ART, Ezequiel Garcia ha escrito:
Hi Ariel,
Please don't drop linux-media from Cc.
On Fri, Jun 22, 2012 at 4:08 PM, Ariel Mammoli cmamm...@gmail.com wrote
On Fri, Jun 22, 2012 at 5:03 PM, Ariel Mammoli cmamm...@gmail.com wrote:
Ezequiel;
El vie 22 jun 2012 16:54:52 ART, Ezequiel Garcia ha escrito:
Hi Ariel,
On Fri, Jun 22, 2012 at 4:40 PM, Ariel Mammoli cmamm...@gmail.com wrote:
Hello again Ezequiel,
El vie 22 jun 2012 16:16:51 ART
On Fri, Jun 22, 2012 at 5:30 PM, Ariel Mammoli cmamm...@gmail.com wrote:
[ 31.130403] saa7130/34: v4l2 driver version 0.2.16 loaded
[ 31.130543] saa7134 :04:05.0: PCI INT A - GSI 16 (level, low) -
IRQ 16
[ 31.130548] saa7130[0]: found at :04:05.0, rev: 1, irq: 16,
latency: 64,
Hi Gianluca,
On Fri, Jun 22, 2012 at 9:00 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
I've patched my kernel 3.0.8 and it compiles without problems.
I've compiled it NOT as a module but directly built in in the kernel.
I just patched a vanilla 3.0.8 (taken from stable repository)
On Sat, Jun 23, 2012 at 10:51 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
I've found the problem. Your module is lacking the init and exit module
functions.
You are using :
module_usb_driver(stk1160_usb_driver);
Indeed.
That has been introduced in kernel 3.3 and so in my
On Sat, Jun 23, 2012 at 11:11 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
I think you can simply make a patch to make it work also with kernels 3.3.
Let's talk about this on monday...now I don't have my development pc with me
so I can't see the code and the dbg messages.
Okey,
Hi Gianluca,
On Sat, Jun 23, 2012 at 10:51 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
You are using :
module_usb_driver(stk1160_usb_driver);
That has been introduced in kernel 3.3 and so in my kernel 3.0.8 it does not
give compiler error (I don't know why) but the probe method
Hi Gianluca,
On Mon, Jun 25, 2012 at 4:09 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
Hi Ezequiel,
No problem in patching each new release you made.
Please note I've just send a v3 of stk1160 driver.
It adds support for controlling ac97 and for selecting video inputs.
In my
On Mon, Jun 25, 2012 at 11:09 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
Hi Ezequiel,
Have you tested with the latest version of your driver? Where can I download
it?
http://patchwork.linuxtv.org/patch/13043/
--
To unsubscribe from this list: send the line unsubscribe linux-media
On Mon, Jun 25, 2012 at 11:26 AM, Gianluca Bergamo
gianluca.berg...@gmail.com wrote:
Thank you.
I'm going to test it as soon as I can.
PS : Are you testing on ARM architecture? I'm starting to think my problems
could be related to it...as most of the video capture drivers are working
well on
Hi Mauro,
On Mon, Jun 25, 2012 at 4:29 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
diff --git a/drivers/media/video/saa7164/saa7164-i2c.c
b/drivers/media/video/saa7164/saa7164-i2c.c
index 26148f7..536f7dc 100644
--- a/drivers/media/video/saa7164/saa7164-i2c.c
+++
On Mon, Jun 25, 2012 at 4:49 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
If i2c_rc was never initialized, then just remove it. If it is required,
then there's a bug somewhere out there on those drivers.
IMHO, if the I2C bus doesn't register, any driver that requires I2C bus
should
Mauro,
On Mon, Jun 25, 2012 at 5:53 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Yeah, research is needed ;) As bttv is the mother of the I2C code found at
other PCI drivers, as it is one of the oldest implementations, I bet you'll
find this field propagated without usage on some
On Mon, Jun 25, 2012 at 6:09 PM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
Hi Ezequiel,
a few minor comments below...
Hi Sylwester,
I'm OK with every comment you made.
Except for the -ETIMEDOUT.
I'm still not 100% convinced, but I'll take your word for it.
Also, is there any
.
As I don't own any of these devices, I can't test the changes beyond
compilation.
Changes from v1:
- Drop i2c_rc clean patches
- Verbose commit messages
Ezequiel Garcia (9):
cx25821: Replace struct memcpy with struct assignment
cx231xx: Replace struct memcpy with struct assignment
cx23885
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel
This function has no users, so it's safe to remove it.
Tested by compilation only.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/saa7164/saa7164-i2c.c |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/media/video/saa7164
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx23885/cx23885-i2c.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/cx23885/cx23885
Copying structs by assignment is type safe.
Plus, is shorter and easier to read.
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
---
drivers/media/video/cx231xx/cx231xx-i2c.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/cx231xx/cx231xx
1 - 100 of 808 matches
Mail list logo
