Re: image capturing on i.mx27 with gstreamer

2011-08-19 Thread Fabio Estevam
decode/encode up to full D1 (720x576 or 720x480) resolution. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: image capturing on i.mx27 with gstreamer

2011-08-19 Thread Fabio Estevam
(available here ftp://ftp.phytec.de/pub/Products/phyCORE-iMX27/Linux/PD11.1.0/). Whick kernel version is this? I am also interested in getting VPU support in the mainline kernel? Are you working on that? Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux

Re: camera on Freescale i.MX51

2011-01-22 Thread Fabio Estevam
board with a OV3640 camera: modprobe mxc_v4l2_capture modprobe ov3640_camera gst-launch mfw_v4lsrc ! mfw_v4lsink Then I got the camera preview in the LCD/DVI output. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH] drivers: video: cx231xx: Fix dependency for VIDEO_CX231XX_DVB

2012-01-09 Thread Fabio Estevam
Fix the following build warning: warning: (VIDEO_CX231XX_DVB) selects DVB_MB86A20S which has unmet direct dependencies (MEDIA_SUPPORT DVB_CAPTURE_DRIVERS DVB_CORE I2C) Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/cx231xx/Kconfig |2 +- 1 files changed

[PATCH] drivers: media: au0828: Fix dependency for VIDEO_AU0828

2012-01-10 Thread Fabio Estevam
Fix the following build warning: warning: (VIDEO_AU0828) selects DVB_AU8522 which has unmet direct dependencies (MEDIA_SUPPORT DVB_CAPTURE_DRIVERS DVB_CORE I2C VIDEO_V4L2) Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/au0828/Kconfig |1 + 1 files

[PATCH] drivers: video: mx3_camera: Convert mx3_camera to use module_platform_driver()

2012-01-10 Thread Fabio Estevam
Using module_platform_driver makes the code smaller and simpler. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx3_camera.c | 14 +- 1 files changed, 1 insertions(+), 13 deletions(-) diff --git a/drivers/media/video/mx3_camera.c b/drivers/media

Re: [PATCH] drivers: video: mx3_camera: Convert mx3_camera to use module_platform_driver()

2012-01-11 Thread Fabio Estevam
On Wed, Jan 11, 2012 at 6:28 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Wed, 11 Jan 2012, Fabio Estevam wrote: Using module_platform_driver makes the code smaller and simpler. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Isn't this covered by this: http

Re: OV2640 and iMX25PDK - help needed

2012-02-02 Thread Fabio Estevam
On 2/1/12, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hello Gonzalo On Tue, 31 Jan 2012, Fernandez Gonzalo wrote: Hi all, I've been working for a while with an iMX25PDK using the BSP provided by Freescale (L2.6.31). The camera driver (V4L2-int) and examples do the job quite well

Re: OV2640 and iMX25PDK - help needed

2012-02-10 Thread Fabio Estevam
-v v4l2src device=/dev/video0 !\ video/x-raw-yuv,width=320,height=240 !\ ffmpegcolorspace ! fbdevsink Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

mx3_camera: dmaengine: failed to get dma1chan

2012-02-14 Thread Fabio Estevam
, ready 0, 0, cur 80 ,and the display gets frozen with the last captured frame from the camera. Are there known patches that fix this issue? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: linux-next: Tree for Jan 20 (drivers/media/radio/wl128x/)

2012-02-14 Thread Fabio Estevam
On 2/14/12, Geert Uytterhoeven ge...@linux-m68k.org wrote: Ping? Build breakage in mainline since at least 3 weeks. From what I recall Randy proposed a patch for fixing this issue: http://patchwork.linuxtv.org/patch/9750/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: mx3_camera: dmaengine: failed to get dma1chan

2012-02-14 Thread Fabio Estevam
On 2/14/12, Fabio Estevam feste...@gmail.com wrote: Then I start the following Gstreamer pipeline: $ gst-launch v4l2src ! fbdevsink Setting pipeline to PAUSED ... mx3-camera mx3-camera.0: MX3 Camera driver attached to camera 0 Pipeline is live and does not need PREROLL ... WARNING: from

[PATCH 1/3] media: video: mx2_camera.c: Fix build warning by initializing 'res_emma'

2012-02-15 Thread Fabio Estevam
Fix the following build warning: drivers/media/video/mx2_camera.c: In function 'mx2_camera_probe': drivers/media/video/mx2_camera.c:1527: warning: 'res_emma' may be used uninitialized in this function Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx2_camera.c

[PATCH 2/3] media: video: mx2_camera.c: Provide error message if clk_get fails

2012-02-15 Thread Fabio Estevam
Provide error message if clk_get fails. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx2_camera.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 5888e33

[PATCH 3/3] media: video: mx2_camera.c: Remove unneeded dev_dbg

2012-02-15 Thread Fabio Estevam
csi clock frequency is already shown by: dev_info(pdev-dev, MX2 Camera (CSI) driver probed, clock frequency: %ld\n, clk_get_rate(pcdev-clk_csi)); ,so no need to have the dev_dbg call to present the same information. Signed-off-by: Fabio Estevam fabio.este...@freescale.com

[PATCH] media: video: mx2_camera: Remove ifdef's

2012-02-16 Thread Fabio Estevam
As we are able to build a same kernel that supports both mx27 and mx25, we should remove the ifdef's for CONFIG_MACH_MX27 in the mx2_camera driver. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx2_camera.c | 22 +++--- 1 files changed, 3

[PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-02-20 Thread Fabio Estevam
Align mx3_camera driver with the other soc camera driver implementations by allocating the camera object via kzalloc. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx3_camera.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-02-20 Thread Fabio Estevam
On Mon, Feb 20, 2012 at 4:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 20 Feb 2012, Fabio Estevam wrote: Align mx3_camera driver with the other soc camera driver implementations by allocating the camera object via kzalloc. Sorry, any specific reason, why you think

Re: [PATCH 01/11] v4l: Add driver for Micron MT9M032 camera sensor

2012-02-26 Thread Fabio Estevam
. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: mx3-camera

2012-03-06 Thread Fabio Estevam
On Tue, Mar 6, 2012 at 10:22 AM, Alex Gershgorin al...@meprolight.com wrote: In i.MX35 (arch/arm/mach-imx/clock-imx35.c) it looks like this: _REGISTER_CLOCK(NULL, csi, csi_clk) Yes, I will submit a patch to fix this. Regards, Fabio Estevam -- To unsubscribe from this list: send the line

Re: I.MX35 PDK

2012-03-08 Thread Fabio Estevam
On 3/8/12, Alex Gershgorin al...@meprolight.com wrote: Setting pipeline to PAUSED ...mx3-camera mx3-camera.0: MX3 Camera driver attached to camera 0 /GstPipeline:pipeline0/GstV4l2Src:v4l2src0.GstPad:src: caps = video/x-raw-yuv, format=(fourcc)UYVY, framerate=(fraction)25/1, width=(int)320,

[PATCH] video: Kconfig: Select VIDEOBUF2_DMA_CONTIG for VIDEO_MX2

2012-03-09 Thread Fabio Estevam
: migrate driver to videobuf2) missed to select VIDEOBUF2_DMA_CONTIG in Kconfig. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig

Re: I.MX35 PDK

2012-03-12 Thread Fabio Estevam
it on a PC. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] video: Kconfig: Select VIDEOBUF2_DMA_CONTIG for VIDEO_MX2

2012-03-12 Thread Fabio Estevam
Hi Guennadi, On 3/9/12, Fabio Estevam feste...@gmail.com wrote: Fix the following build error: LD .tmp_vmlinux1 drivers/built-in.o: In function `mx2_camera_init_videobuf': clkdev.c:(.text+0xcfaf4): undefined reference to `vb2_dma_contig_memops' drivers/built-in.o: In function

Re: [PATCH] i.MX35-PDK: Add Camera support

2012-03-13 Thread Fabio Estevam
Hi Alex, On Mon, Mar 12, 2012 at 1:28 PM, Alex al...@meprolight.com wrote: In i.MX35-PDK, OV2640  camera is populated on the personality board. This camera is registered as a subdevice via soc-camera interface. Signed-off-by: Alex Gershgorin al...@meprolight.com Are you able to get the

Re: [PATCH v1] i.MX35-PDK: Add Camera support

2012-03-19 Thread Fabio Estevam
Hi Sascha, On Mon, Mar 19, 2012 at 7:37 PM, Sascha Hauer s.ha...@pengutronix.de wrote: It's scheduled there. I should have responded with an applied message. Please apply this one too: http://patchwork.ozlabs.org/patch/144942/ Otherwise camera device cannot register. -- To unsubscribe from

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Fabio Estevam
Hi Guennadi, On 3/20/12, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Don't think so. vzalloc() is used in mx3_camera to allocate driver private data objects and are never used for DMA, so, it doesn't have any restrictions on contiguity, coherency, alignment etc. Is this valid only for

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Fabio Estevam
On 3/20/12, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Is this valid only for mx3_camera driver? No All other soc camera drivers use kzalloc. What makes mx3_camera different in this respect? Nothing Ok, so isn't my patch correct then? -- To unsubscribe from this list: send the

Re: [PATCH v1] i.MX35-PDK: Add Camera support

2012-03-22 Thread Fabio Estevam
is required to getting the camera to work? Are you getting the camera image with the correct colors? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v1] i.MX35-PDK: Add Camera support

2012-03-23 Thread Fabio Estevam
could fix the I2C issues you reported earlier in software. Otherwise the camera will only work on your own modified mx35pdk ;-) Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] media: coda: Fix compile breakage

2013-04-27 Thread Fabio Estevam
Alexander/Arnd, On Sat, Apr 27, 2013 at 12:33 PM, Arnd Bergmann a...@arndb.de wrote: On Saturday 27 April 2013, Alexander Shiyan wrote: Patch adds GENERIC_ALLOCATOR, if coda is selected. drivers/built-in.o: In function `coda_remove': :(.text+0x110634): undefined reference to `gen_pool_free'

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Fabio Estevam
On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret = devm_regulator_bulk_get(client-dev, 3, mt9p031-regulators); + if (ret 0) {

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Fabio Estevam
On Sat, Jun 8, 2013 at 10:20 AM, Fabio Estevam feste...@gmail.com wrote: On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret

Re: [PATCH] Revert [media] media: mx2_camera: Fix mbus format handling

2012-06-18 Thread Fabio Estevam
is reported only once drivers/media/video/mx2_camera.c:937: error: for each function it appears in.) Can this be applied? It is breaking mxs_defconfig for one month now. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-19 Thread Fabio Estevam
, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] Support for 'Coda' video codec IP.

2012-07-03 Thread Fabio Estevam
, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] video: mx2_camera: Fix build error due to the lack of 'pixfmt' definition

2012-05-21 Thread Fabio Estevam
a 'pixfmt' definition. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx2_camera.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index ded26b7..ef72733 100644 --- a/drivers

[PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-05-25 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Prepare the clock before enabling it. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx1_camera.c |4 ++-- 1 files changed, 2

[PATCH 07/15] video: mx2_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-05-25 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Prepare the clock before enabling it. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx2_camera.c | 12 ++-- 1 files

[PATCH 08/15] video: mx2_emmaprp: Use clk_prepare_enable/clk_disable_unprepare

2012-05-25 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Prepare the clock before enabling it. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: linux-media@vger.kernel.org Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/video/mx2_emmaprp.c |4 ++-- 1 files changed, 2

Re: [PATCH] [media] em28xx: Show a warning if the board does not support remote controls

2012-05-29 Thread Fabio Estevam
On Tue, May 29, 2012 at 6:08 PM, Martin Blumenstingl martin.blumensti...@googlemail.com wrote: This simply shows a little warning if the board does not have remote control support. This should make it easier for users to see if they have misconfigured their system or if the driver simply does

Re: [PATCH] [media] em28xx: Show a warning if the board does not support remote controls

2012-05-29 Thread Fabio Estevam
On Tue, May 29, 2012 at 6:26 PM, Martin Blumenstingl martin.blumensti...@googlemail.com wrote: Hello Fabio, I can use dev_err if you want. Or maybe dev_warn is better since this is a warning. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH] media: mx2_camera: Add YUYV output format.

2012-06-05 Thread Fabio Estevam
. Saludos, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-06-05 Thread Fabio Estevam
Guennadi, On Tue, May 29, 2012 at 6:20 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, May 25, 2012 at 08:14:47PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Prepare the clock before enabling it. Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc

Re: [PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-06-06 Thread Fabio Estevam
that were not converted, so this patch series aim to address the clock conversion for the remaining imx drivers. I think this is 3.5 material. Sascha, would you agree? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH] media: mx2_camera: Add YUYV output format.

2012-06-07 Thread Fabio Estevam
am back to the office. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/4] [media] lirc_bt829: Fix physical address type

2013-09-04 Thread Fabio Estevam
) { pci_addr_phys = my_dev-resource[0].start; - pr_info(memory at 0x%08X\n, - (unsigned int)pci_addr_phys); + pr_info(memory at %pa\n, pci_addr_phys); Looks much better :-) Reviewed-by: Fabio Estevam

[PATCH] [media] platform: Kconfig: Select SRAM for VIDEO_CODA

2013-09-30 Thread Fabio Estevam
Running the coda driver without CONFIG_SRAM selected leads to the following probe error: coda 63ff4000.vpu: iram pool not available coda: probe of 63ff4000.vpu failed with error -12 In order to avoid it, select CONFIG_SRAM inside VIDEO_CODA. Signed-off-by: Fabio Estevam fabio.este

Re: imx27.dtsi usbotg/usbh2 oops in fsl_usb2_mph_dr_of_probe

2013-10-28 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 10:17 AM, Chris Ruehl chris.ru...@gtsys.com.hk wrote: Hi, when tried to activate the USB-OTG or USBH2 with the FDT the system oops You should have posted this to the linux-usb list instead :-) config: (imx27.dtsi) usbotg: usb@10024000 {

Re: imx27.dtsi usbotg/usbh2 oops in fsl_usb2_mph_dr_of_probe

2013-10-28 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 10:42 AM, Chris Ruehl chris.ru...@gtsys.com.hk wrote: I didn't get USB detected with compatible =fsl,imx27-usb nothing happen. You probably need a mx27 entry into drivers/usb/chipidea/usbmisc_imx.c. Again, this is offtopic to this list, so please start a new thread

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-25 Thread Fabio Estevam
, the better, IMHO, is to send both via the same tree. If you decide to do so, please get arm maintainer's ack, instead, and we can merge both via my tree. Can you please send your Ack to this series so that Mauro can merge it via his tree? Thanks, Fabio Estevam -- To unsubscribe from this list

[PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-10-30 Thread Fabio Estevam
again. Tested-by: Gaëtan Carlier gcem...@gmail.com Tested-by: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v3: - Drop unneeded clk_unprepare calls as pointed out by Guennadi Changes since v2: - Fix clock error handling

[PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-30 Thread Fabio Estevam
-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Sascha Hauer s.ha...@pengutronix.de --- Changes since v3: - Use imx27-camera.0 instead of mx2-camera.0, due to recent changes in the imx27 clock (commit 27b76486a3: media: mx2_camera: remove cpu_is_xxx by using platform_device_id) arch/arm/mach-imx

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread Fabio Estevam
Javier, On Tue, Oct 30, 2012 at 10:16 AM, Javier Martin javier.mar...@vista-silicon.com wrote: i.MX25 support has been broken for several releases now and nobody seems to care about it. I will work on fixing camera support for mx25. Please do not remove its support. Thanks, Fabio Estevam

Re: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-31 Thread Fabio Estevam
changes from mx2_camera.0 to imx27-camera.0. So it seems to be better to merge this via arm tree to avoid such conflict. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] [media] coda: Fix build due to iram.h rename

2012-11-14 Thread Fabio Estevam
: error: implicit declaration of function 'iram_free Since the content of iram.h is not imx specific, move it to include/linux/iram.h instead. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- arch/arm/mach-imx/iram_alloc.c |3 +-- drivers/media/platform/coda.c

Re: [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-11-14 Thread Fabio Estevam
this series via your tree? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [media] soc_camera: mx2_camera: Constify v4l2_crop

2012-11-17 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Since commit 4f996594ce ([media] v4l2: make vidioc_s_crop const), set_crop should receive a 'const struct v4l2_crop *' argument type. Adapt to this new format and get rid of the following build warning: drivers/media/platform/soc_camera

[PATCH] [media] soc_camera: mx3_camera: Constify v4l2_crop

2012-11-17 Thread Fabio Estevam
incompatible pointer type Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/platform/soc_camera/mx3_camera.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx3_camera.c b/drivers/media/platform/soc_camera

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-11-27 Thread Fabio Estevam
camera 0 mx2-camera imx25-camera.0: MX2 Camera (CSI) driver probed, clock frequency: 2216 Could we please keep the mx25 support? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] [media] mx2_camera: Convert it to platform driver

2012-11-30 Thread Fabio Estevam
Converting it to platform code can make the code smaller. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/platform/soc_camera/mx2_camera.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2012-12-03 Thread Fabio Estevam
Hi Mauro, On Wed, Nov 14, 2012 at 11:04 AM, Fabio Estevam fabio.este...@freescale.com wrote: commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed the location of iram.h, which causes the following build error when building the coda driver: drivers/media/platform

Re: [PATCH] [media] mx2_camera: Convert it to platform driver

2012-12-17 Thread Fabio Estevam
Hi Guennadi, On Fri, Nov 30, 2012 at 1:06 PM, Fabio Estevam fabio.este...@freescale.com wrote: Converting it to platform code can make the code smaller. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Does this patch look good? Regards, Fabio Estevam -- To unsubscribe from

Re: [PATCH RFC 07/11] it913x: make remote controller optional

2013-01-01 Thread Fabio Estevam
+308,7 @@ static struct i2c_algorithm it913x_i2c_algo = { }; /* Callbacks for DVB USB */ +#if defined(CONFIG_RC_CORE) || defined(CONFIG_RC_CORE_MODULE) Maybe you could use: #if IS_ENABLED(CONFIG_RC_CORE) Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread Fabio Estevam
-kernel/msg210216.html ,and have only verified that camera probe worked on mx25pdk. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread Fabio Estevam
this driver. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2013-01-07 Thread Fabio Estevam
until the i.MX iram allocator is converted to the generic SRAM allocator. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- Based on an earlier version from Fabio Estevam, but this one moves iram.h to include/linux/platform_data/imx-iram.h instead of include/linux/iram.h which is a less

Re: [PATCH v2 2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations.

2011-11-23 Thread Fabio Estevam
On Tue, Nov 22, 2011 at 10:01 AM, Javier Martin javier.mar...@vista-silicon.com wrote: +/* In bytes, per queue */ +#define MEM2MEM_VID_MEM_LIMIT  (16 * SZ_1M) You could use SZ_16M instead. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH v3 2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations.

2011-11-23 Thread Fabio Estevam
Javier, On Wed, Nov 23, 2011 at 1:13 PM, Javier Martin javier.mar...@vista-silicon.com wrote: Changes since v2: - Use devres to simplify error handling. - Remove unused structures. - Fix clock handling. - Other minor problems. It would be better if you put such comments below the --- line.

Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic

2013-03-18 Thread Fabio Estevam
. + */ +static int emulate_delivery_system(struct dvb_frontend *fe, u32 delsys) Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Camera not detected on linux-next

2012-09-05 Thread Fabio Estevam
if there is anything obvious I am missing. Also tested on a mx27pdk and ov2640 could not be probed there as well. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Camera not detected on linux-next

2012-09-05 Thread Fabio Estevam
Hi Sylwester, On Wed, Sep 5, 2012 at 1:17 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Maybe this is about the sensor/host driver linking order. If so, then this patch should help Excellent! This fixed the problem! Thanks, Fabio Estevam -- To unsubscribe from this list: send

[PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-05 Thread Fabio Estevam
-by: Fabio Estevam fabio.este...@freescale.com --- arch/arm/mach-imx/clk-imx27.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx27.c b/arch/arm/mach-imx/clk-imx27.c index 3b6b640..5ef0f08 100644 --- a/arch/arm/mach-imx/clk-imx27.c +++ b/arch/arm/mach-imx/clk-imx27.c

[PATCH 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-05 Thread Fabio Estevam
again. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/platform/soc_camera/mx2_camera.c | 42 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera

Re: [PATCH 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-08 Thread Fabio Estevam
: Failed to get attributes for norm 0 on devide '/dev/video0'. (61 - No data available) Setting pipeline to NULL ... Freeing pipeline ... Does anyone have any ideas? Thanks, Fabio Estevam --- drivers/media/platform/soc_camera/mx2_camera.c | 47 +--- 1 file changed, 34

[PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-08 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Since mx27 transitioned to the commmon clock framework in 3.5, the correct way to acquire the csi clock is to get csi_ahb and csi_per clocks separately. By not doing so the camera sensor does not probe correctly: soc-camera-pdrv soc-camera-pdrv.0

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
in the bootloader or you get the clock to your camera from somewhere else. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
again. Tested-by: Gaëtan Carlier gcem...@gmail.com Tested-by: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v2: - Fix clock error handling code as pointed out by Russell King Changes since v1: - Rebased against linux-next

[PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com commit 136b5721d (workqueue: deprecate __cancel_delayed_work()) made __cancel_delayed_work deprecated. Use cancel_delayed_work instead and get rid of the following warning: drivers/media/platform/coda.c:1543: warning: '__cancel_delayed_work

[PATCH] [media] coda: Fix 'driver_data' for mx53

2012-10-09 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com CODA_7541 is the coda_product type for mx53. The 'driver_data' for mx53 is CODA_IMX53 instead. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/platform/coda.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-22 Thread Fabio Estevam
saying it's for i.MX27. Confused... I provide this mx27 clock in the first patch of the series: http://patchwork.linuxtv.org/patch/14915/ Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

[PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'

2012-10-24 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), flush_work() should be used instead of flush_work_sync(). Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/pci/ivtv/ivtv-driver.c |2 +- 1

Re: imx27 coda interface no capture output

2013-06-21 Thread Fabio Estevam
Hi Chris, On Fri, Jun 21, 2013 at 4:38 AM, Chris Ruehl chris.ru...@gtsys.com.hk wrote: Hi All, After Freescale was so kind and forward the v4l-codadx6-imx27.bin the firmware loaded properly and I see a /dev/video1 the v4l_ctrl looks promising root@gtsir-nand:~# v4l2-ctl --list-formats -d

[PATCH 1/2] [media] coda: Check the return value from clk_prepare_enable()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/platform/coda.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH 2/2] [media] coda: No need to check the return value of platform_get_resource()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/media/platform/coda.c | 5 - 1 file changed, 5

[PATCH v2 1/2] [media] coda: Check the return value from clk_prepare_enable()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v1: - Add missing 'if' drivers/media/platform/coda.c | 11

[PATCH 2/2] [media] coda: No need to check the return value of platform_get_resource()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v1: - None drivers/media/platform/coda.c | 5

[PATCH v3 1/3] [media] coda: Fix error paths

2013-07-22 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v2: - Newly introduced in this series drivers/media/platform/coda.c

[PATCH v3 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-07-22 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v2

[PATCH v3 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-07-22 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- - Changes since v2: - Release the previously acquired resources Changes since v1

[PATCH v4 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-07-23 Thread Fabio Estevam
clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v3: - Adapt it to make error handling easier Changes since v2: - Release the previously acquired resources Changes since

[PATCH v4 1/3] [media] coda: Fix error paths

2013-07-23 Thread Fabio Estevam
Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v3: - Only disable the clocks after v4l2_m2m_ctx_release() Changes since v2: - Newly introduced in this series

[PATCH v4 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-07-23 Thread Fabio Estevam
When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v3: - None Changes since v2: - None Changes since

[PATCH v6 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-08-20 Thread Fabio Estevam
When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v5: - Rebased against latest Kamil's tree drivers

[PATCH v6 1/3] [media] coda: Fix error paths

2013-08-20 Thread Fabio Estevam
Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v5: - Rebased against latest Kamil's tree drivers/media/platform/coda.c | 43

[PATCH v6 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-08-20 Thread Fabio Estevam
clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v5: - Rebased against latest Kamil's tree drivers/media/platform/coda.c | 27 ++- 1 file

[PATCH v7 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-08-21 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- Changes since v6: - Rebased against correct branch drivers/media/platform/coda.c

[PATCH v7 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-08-21 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v6

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Fabio Estevam
On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings b...@decadent.org.uk wrote: pci_addr_phys = pdev-resource[0].start; - dev_info(pdev-dev, memory at 0x%08X\n, -(unsigned int)pci_addr_phys); + dev_info(pdev-dev, memory at 0x%08llX\n, +(unsigned

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Fabio Estevam
On Sun, Sep 1, 2013 at 10:41 PM, Ben Hutchings b...@decadent.org.uk wrote: On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote: On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings b...@decadent.org.uk wrote: pci_addr_phys = pdev-resource[0].start; - dev_info(pdev-dev, memory

  1   2   3   >