[PATCH] media/dvb-core: Race condition when writing to CAM.

It started with a sporadic message in syslog: "CAM tried to send a buffer larger than the ecount size" This message is not the fault itself, but a consecutive fault, after a read error from the CAM. This happens only on several CAMs, several hardware, and of course sporadic. It is a consecutive

linux media DKMS

Hello! I googled some time now, but I couldn't find a suitable DKMS to encapsulate the media-build. Before I write my own one I would like to ask if it is already existing(for the case I can't properly use Google). If not I will use "media-build-experimental-dkms" as a start. BR, Jasmin

Re: [PATCH v2 00/10] STV0910/STV6111 drivers, ddbridge CineS2 V7 support

Hello! > This series adds drivers for the ST STV0910 DVB-S/S2 demodulator ICs and > the ST STV6111 DVB-S/S2 tuners, and utilises them to enable ddbridge to > support the current line of Digital Devices DVB-S/S2 hardware (e.g. Cine > S2 V7/V7A adapters, DuoFlex S2 V4 addon modules and maybe more,

media-build breaks for Kernel 3.13

Hello! I tried to compile the last media master for Kernel 3.13 (Ubuntu 14.04) and get errors during the patch step: tar xfj linux-media.tar.bz2 rm -f .patches_applied .linked_dir .git_log.md5 make -C /mnt/home_hdd/jasmin/vdr/dd_driver/git/media_build/v4l stagingconfig make[1]: Entering

Re: media-build breaks for Kernel 3.13

Hello Hans! > It suggests you are using an old media_build. No I am not, but I found another problem. We have changed a driver and the patches needs to be adapted for that. Sorry to bother you. BR, Jasmin

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

Hello Antti! > Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix in a follow up, you mentioned other issues. Please can you tell me which one you mean, so that

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

Hello Antti! > actually it reports, when run --strict mode I checked this once, but I thought this would be too aggressive changes. >> * many cases where if (ret != 0), which generally should be written as if >> (ret). If you expect it is just error ret value, then prefer if (ret), but >> if>

[PATCH V3 10/16] [media] dvb-core/dvb_ca_en50221.c: Fixed C++ comments

From: Jasmin Jessich - Changed all C++ style comments ("// ..") to C style ones ("/* .. */"). Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH V3 09/16] [media] dvb-core/dvb_ca_en50221.c: Removed unused symbol

From: Jasmin Jessich - The STATUSREG_TXERR definition is not used and it has style problems, too. Removing it seems to solve both issues. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH V3 14/16] [media] dvb-core/dvb_ca_en50221.c: Fixed remaining block comments

From: Jasmin Jessich - Added the missing opening empty comment line. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c

[PATCH V3 08/16] [media] dvb-core/dvb_ca_en50221.c: Removed useless braces

From: Jasmin Jessich Fixed all: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-)

[PATCH V3 04/16] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Added also the missing opening empty comment line. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 29 +++-- 1 file changed, 19

[PATCH V3 06/16] [media] dvb-core/dvb_ca_en50221.c: Used a helper variable

From: Jasmin Jessich Used a helper variable "struct dvb_ca_slot *sl" instead of "ca->slot_info[slot]". This reduces the line length and simplifies code reading. Fixed also "-strict" checks in this patch: - Comparison to NULL written as "!". Signed-off-by: Jasmin Jessich

[PATCH V3 02/16] [media] dvb-core/dvb_ca_en50221.c: New function dvb_ca_en50221_poll_cam_gone

From: Jasmin Jessich The CAM poll code for the budget-av is exactly the same on several places. Extracting the code to a new function improves maintainability. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 66

[PATCH V3 03/16] [media] dvb-core/dvb_ca_en50221.c: use usleep_range

From: Jasmin Jessich Fixed all: WARNING: msleep < 20ms can sleep for up to 20ms by using usleep_range. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V3 05/16] [media] dvb-core/dvb_ca_en50221.c: Avoid assignments in ifs

From: Jasmin Jessich Fixed all: ERROR: do not use assignment in if condition Fixed also "-strict" checks in this patch: - Changed "if (ret != 0)" to "if (ret)". - Camel case variables have been converted to kernel_case. - Comparison to NULL written as "!". - No space is

[PATCH V3 00/16] Fix coding style in en50221 CAM functions

From: Jasmin Jessich Changes V2 to V3: Fixed the remarks from Antti Polosaari. Checked the code with checkpatch.pl -strict and fixed all the findings. These patch series is the V3 version adapted to the already merged patches from V1 and other merged patches. It does no longer

[PATCH V3 01/16] [media] dvb-core/dvb_ca_en50221.c: Refactored dvb_ca_en50221_thread

From: Jasmin Jessich Refactored "dvb_ca_en50221_thread" by moving the state machine into the new function "dvb_ca_en50221_thread_state_machine". This reduces the thread function size and reduces the structural complexity and of course gives us more space to meet the line length

[PATCH V3 11/16] [media] dvb-core/dvb_ca_en50221.c: Fixed 80 char limit

From: Jasmin Jessich Fixed most of: WARNING: line over 80 characters The remaining lines are printk strings, which should not be split and lines where I thing they should stay as they are. Signed-off-by: Jasmin Jessich ---

[PATCH V3 13/16] [media] dvb-core/dvb_ca_en50221.c: Fix again wrong EXPORT_SYMBOL order

From: Jasmin Jessich Some EXPORT_SYMBOL() on this file don't match the name of functions that precedes them. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH V3 12/16] [media] dvb-core/dvb_ca_en50221.c: Fixed typo

From: Jasmin Jessich - "dont" -> "don't" Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c

[PATCH V3 16/16] [media] dvb-core/dvb_ca_en50221.c: Fixed multiple blank lines

From: Jasmin Jessich - Running "checkpatch.pl -strict -f ..." complained * Please don't use multiple blank lines Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 40 - 1 file changed, 40 deletions(-)

[PATCH V3 07/16] [media] dvb-core/dvb_ca_en50221.c: Added line breaks

From: Jasmin Jessich Fixed all: WARNING: Missing a blank line after declarations Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH V3 15/16] [media] dvb-core/dvb_ca_en50221.c: Fixed style issues on the whole file

From: Jasmin Jessich - Running "checkpatch.pl -strict -f ..." gave more checks to fix. * Blank lines aren't necessary after an open brace '{' * Comparison to NULL written as "!" * CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Jasmin Jessich

[PATCH 1/3] build: Add compat code for pm_runtime_get_if_in_use

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- v4l/compat.h | 15 +++ v4l/scripts/make_config_compat.pl | 1 + 2 files changed, 16 insertions(+) diff --git a/v4l/compat.h b/v4l/compat.h index e565292..b5b0846 100644 ---

[PATCH 3/3] build: fix up build w/kernels <=4.12 by reverting 4.13 patches

From: Daniel Scheller Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich --- backports/backports.txt| 3 + .../v4.12_revert_solo6x10_copykerneluser.patch | 71 ++ 2 files

[PATCH 2/3] build: Disable VIDEO_OV5670 for Kernels older that 3.17

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- v4l/versions.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/v4l/versions.txt b/v4l/versions.txt index ae4a14f..1dd9a2b 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -68,6 +68,7 @@

[PATCH 0/3] fix compile for kernel 3.13

From: Jasmin Jessich This series fixed compilation errors for older kernels. I have tested it with Kernel 3.13 and Daniel with Kernel 4.12. I disabled VIDEO_OV5670 for all kernels older than 3.17, but I am not 100% sure if the required change to compile it was really implemented

Re: [PATCH 0/7] stv0910/stv6111 updates

Hello! I tested this patch series with: DD Cine S2 V6 DD Duoflex CI (single) DD Duoflex S2 V4 (stv0910/stv6111) VDR 2.3.8, ddci2 Plugin 1.5.0 The SAT cables were connected to the DD DuoFlex S2 V4 card and VDR was instructed to use this device only. I checked the signal values with VDR

[PATCH V2 0/3] fix compile for kernel 3.13

From: Jasmin Jessich Changes since V1: - CEC_PIN and VIDEO_OV5670 disabled for all kernels older 4.10. This series fixed compilation errors for older kernels. I have tested it with Kernel 3.13 and Daniel with Kernel 4.12 and someone else with Kernel 4.4. CEC_PIN and VIDEO_OV5670

[PATCH V2 2/3] build: CEC_PIN and the VIDEO_OV5670 driver both require kernel 4.10 to compile

From: Daniel Scheller Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich --- v4l/versions.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/v4l/versions.txt b/v4l/versions.txt index ae4a14f..7d786da 100644 ---

[PATCH V2 3/3] build: fix up build w/kernels <=4.12 by reverting 4.13 patches

From: Daniel Scheller Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich --- backports/backports.txt| 3 + .../v4.12_revert_solo6x10_copykerneluser.patch | 71 ++ 2 files

[PATCH V2 1/3] build: Add compat code for pm_runtime_get_if_in_use

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- v4l/compat.h | 15 +++ v4l/scripts/make_config_compat.pl | 1 + 2 files changed, 16 insertions(+) diff --git a/v4l/compat.h b/v4l/compat.h index e565292..b5b0846 100644 ---

Re: [PATCH 2/3] build: Disable VIDEO_OV5670 for Kernels older that 3.17

Superseded by: [PATCH V2 2/3] build: CEC_PIN and the VIDEO_OV5670 driver both require kernel 4.10 to compile So please drop this patch. BR, Jasmin

Re: [PATCH 00/14] ddbridge: bump to ddbridge-0.9.29

Hi! Daniel lined out already what the technical differences are. In fact nothing what the normal user of this very good DVB cards needs. The Octopus NET has its own distribution provided by DD. So there is no need to support this in the mainline Kernel at this time. Also the modulator is

[PATCH V2 7/9] [media] dvb-core/dvb_ca_en50221.c: Added line breaks

From: Jasmin Jessich Fixed all: WARNING: Missing a blank line after declarations Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH V2 0/9] Fix coding style in en50221 CAM functions

From: Jasmin Jessich These patch series is the V2 version adapted to the already merged patches from V1 and other merged patches. It does no longer rename constants, as stated by Mauro as a no-go. It still fixed nearly all the style issues reported by checkpatch.pl in

[PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH V2 3/9] [media] dvb-core/dvb_ca_en50221.c: use usleep_range

From: Jasmin Jessich Fixed all: WARNING: msleep < 20ms can sleep for up to 20ms by using usleep_range. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V2 6/9] [media] dvb-core/dvb_ca_en50221.c: Used a helper variable

From: Jasmin Jessich Used a helper variable "struct dvb_ca_slot *sl" instead of "ca->slot_info[slot]". This reduces the line length and simplifies code reading. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 187

[PATCH V2 5/9] [media] dvb-core/dvb_ca_en50221.c: Avoid assignments in ifs

From: Jasmin Jessich Fixed all: ERROR: do not use assignment in if condition Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 97 ++--- 1 file changed, 64 insertions(+), 33 deletions(-) diff --git

[PATCH V2 9/9] [media] dvb-core/dvb_ca_en50221.c: Fixed 80 char limit

From: Jasmin Jessich Fixed most of: WARNING: line over 80 characters The remaining lines are printk strings, which should not be split and lines where I thing they should stay as they are. Signed-off-by: Jasmin Jessich ---

[PATCH V2 8/9] [media] dvb-core/dvb_ca_en50221.c: Removed useless braces

From: Jasmin Jessich Fixed all: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-)

[PATCH V2 2/9] [media] dvb-core/dvb_ca_en50221.c: New function dvb_ca_en50221_poll_cam_gone

From: Jasmin Jessich The CAM poll code for the budget-av is exactly the same on several places. Extracting the code to a new function improves maintainability. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 63

[PATCH V2 1/9] [media] dvb-core/dvb_ca_en50221.c: Refactored dvb_ca_en50221_thread

From: Jasmin Jessich Refactored "dvb_ca_en50221_thread" by moving the state machine into the new function "dvb_ca_en50221_thread_state_machine". This reduces the thread function size and reduces the structural complexity and of course gives us more space to meet the line length

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

Hello Antti! > Quickly looking this patch serie I noticed few other coding style mistakes. > You should read kernel coding style documentation first, and then make > changes according to doc. In fact I used checkpatch.pl to find the issues and fixed them. All the patches are 100% checkpatch.pl

Re: [linux-media] How to handle independent CA devices

Hello! It is now 6,5 years since this eMail ir reply to and a lot of things changed since then. As there is currently a lot of effort done to get the newest version of the DD (Digital Devices) drivers into the Kernel, I want to bring up this topic again. Yes, this eMail is long but it is

[PATCH] build: Added missing "DESTDIR"

From: Jasmin Jessich Directory "$DESTDIR" was missing in the "Removing obsolete files" output. The executed code was correct. Signed-off-by: Jasmin Jessich --- v4l/scripts/make_makefile.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: media: cxd2099: Use __func__ macro in messages

Hi Alexandre! The current cxd2099 driver is an old version. DD provides a newer variant. Please see my patch series http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html Especially this patch http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html where I

Re: [PATCH 0/7] Add block read/write to en50221 CAM functions

Hello Mauro! > It should be, instead: >From: Ralph Metzler I thought it is enough to write him in the Signed-off-by as first. This From line is automatically generated by Git with Format Patch and then used by send. However I should change that and my mail program still

Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

Hello Mauro! > Yeah, it would be great if Ralph would have some time to review > them, or to submit a new series adding all pending features from > DD drivers upstream. I am pretty sure he will not do that. > Both Jasmin and Thomas could have reviewed it, and replied > if they tested it, and on

Re: [PATCH 3/7] [media] dvb-core/dvb_ca_en50221.c: Add block read/write functions

Hello Mauro! > We decided to split the monster thread function into a sub function to make > it more readable and also to overcome the 80 line length limit ... Sorry I mixed the patches. I will cleanup this patch to make checkpatch silent. BR, Jasmin

Re: [PATCH 3/7] [media] dvb-core/dvb_ca_en50221.c: Add block read/write functions

Hello Mauro! > Please check the patch with checkpatch.pl: I am nearly finished with a V2 series of this set, where I partly changed some of this issues. We decided to split the monster thread function into a sub function to make it more readable and also to overcome the 80 line length limit which

[PATCH v2 2/7] [media] dvb-core/dvb_ca_en50221.c: Increase timeout for link init

From: Ralph Metzler Some CAMs do a really slow initialization, which requires a longer timeout for the first response. Original code change by Ralph Metzler, modified by Jasmin Jessich to match Kernel code style. Signed-off-by: Ralph Metzler

[PATCH v2 6/7] [staging] cxd2099/cxd2099.c: Removed printing in write_block

From: Jasmin Jessich There were remaining debug prints which haven't been found earlier due to the disabled buffer mode (see commit "Removed useless printing in cxd2099 driver" for the already removed printings. Signed-off-by: Jasmin Jessich ---

[PATCH v2 7/7] [staging] cxd2099/cxd2099.c: Activate cxd2099 buffer mode

From: Jasmin Jessich Activate the cxd2099 buffer mode. Signed-off-by: Jasmin Jessich --- drivers/staging/media/cxd2099/cxd2099.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/cxd2099/cxd2099.c

[PATCH v2 4/7] [staging] cxd2099/cxd2099.c/.h: Fixed buffer mode

From: Ralph Metzler The buffer mode was already implemented in this driver, but it did not work as expected. This has been fixed now, but it is still deactivated and can be activated by removing a comment at the begin of the file. Original code change by Ralph Metzler,

[PATCH v2 0/7] Add block read/write to en50221 CAM functions

From: Jasmin Jessich This is now the V2 version of the patch series with preserved author and little checkpatch fixes. I also combined some patches which needs to be applied at once to. Changes from v1 to v2: - Preserved authorship of original author. - All patches tested with

[PATCH v2 5/7] [staging] cxd2099/cxd2099.c: Removed useless printing in cxd2099 driver

From: Ralph Metzler campoll and read_data are called very often and the printouts are very annoying and make the driver unusable. They seem to be left over from developing the buffer mode. Original code change by Ralph Metzler, modified by Jasmin Jessich to match current

[PATCH v2 3/7] [media] dvb-core/dvb_ca_en50221.c: Add block read/write functions

From: Ralph Metzler Some lower level drivers may work better when sending blocks of data instead byte per byte. For this we need new function pointers in the dvb_ca_en50221 protocol structure (read_data, write_data) and the protocol needs to execute them, if they are

[PATCH v2 1/7] [media] dvb-core/dvb_ca_en50221.c: State UNINITIALISED instead of INVALID

From: Ralph Metzler In case of a linkinit failure change to state UNINITIALISED to re-init the CAM. Original code change by Ralph Metzler, modified by Jasmin Jessich to match Kernel code style. Signed-off-by: Ralph Metzler Signed-off-by: Jasmin

[media-build] Can't compile for Kernel 3.13 after recent changes

Hi! After the recent changes, I can no longer compile for Kernel 3.13 BR, Jasmin Here the build Log: Kernel build directory is /lib/modules/3.13.0-117-generic/build make -C ../linux apply_patches make[2]: Entering directory '/mnt/home_hdd/jasmin/vdr/dd_driver/git/media_build/linux' Patches

Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

Hello ! On 06/19/2017 10:18 PM, Daniel Scheller wrote: > Am Sun, 28 May 2017 23:45:37 +0200 > schrieb Daniel Scheller : > >> Am Sun, 7 May 2017 17:42:12 +0200 >> schrieb Daniel Scheller : >> >>> Am Wed, 12 Apr 2017 21:23:27 +0200 >>> schrieb

Re: [media-build] Can't compile for Kernel 3.13 after recent changes

Hallo Hans! > OK, so I felt a bit guilty and decided to take a quick look. I think it > will now build again for 3.13. Yes, It builds now perfectly. Will test the driver tomorrow. THANK YOU VERRY MUCH! BR, Jasmin

Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues

Hello Christoph! The current cxd2099 driver is an old version. DD provides a newer variant. Please see my patch series http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html Especially this patch http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html where I

Re: [PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

Hello Mauro! > If you want it applied, this is needed anyway, as the patch doesn't apply > cleanly: Because you didn't apply the first series! In the first series [PATCH 0/7] Add block read/write to en50221 CAM functions I wrote: There is another patch series coming soon "Fix coding style in

Re: [PATCH 0/7] Add block read/write to en50221 CAM functions

Hello Mauro! THX for looking into this! > Hmm... from what I understood, the original author for those patches > is Ralph, right? Yes. I re-formatted them into smaller pieces to be easier reviewed. The goal of this series is to make the Kernel version equal to the official DD version. But I

Re: [PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

Hello Mauro! > The idea behind patch 04/11 makes sense to me. I'll review it carefully > after having everything applied. Please don't do that now! The first series will then not be easily changed, because it changes the state machine. I will provide the first series and when it is applied the

[PATCH 4/7] [staging] cxd2099/cxd2099.c/.h: Fixed buffer mode

From: Jasmin Jessich The buffer mode was already implemented in this driver, but it did not work as expected. This has been fixed now, but it is still deactivated and can be activated by removing a comment at the begin of the file. Signed-off-by: Ralph Metzler

[PATCH 2/7] [media] dvb-core/dvb_ca_en50221.c: Increase timeout for link init

From: Jasmin Jessich Some CAMs do a really slow initialization, which requires a longer timeout for the first response. Signed-off-by: Ralph Metzler Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich ---

[PATCH 3/7] [media] dvb-core/dvb_ca_en50221.c: Add block read/write functions

From: Jasmin Jessich Some lower level drivers may work better when sending blocks of data instead byte per byte. For this we need new function pointers in the dvb_ca_en50221 protocol structure (read_data, write_data) and the protocol needs to execute them, if they are defined.

[PATCH 6/7] [staging] cxd2099/cxd2099.c: Removed useless printing in cxd2099 driver

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- drivers/staging/media/cxd2099/cxd2099.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c

[PATCH 0/7] Add block read/write to en50221 CAM functions

From: Jasmin Jessich These patch series implement a block read/write interface to the en50221 CAM control functions. The origin of this patches can be found in the Digital Devices Git on https://github.com/DigitalDevices/dddvb maintained by Ralph Metzler The

[PATCH 02/11] [media] dvb-core/dvb_ca_en50221.c: Rename DVB_CA_SLOTSTATE_???

From: Jasmin Jessich Rename DVB_CA_SLOTSTATE_??? -> SLOT_STAT_??? to reduce the line length. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 124 1 file changed, 62 insertions(+), 62 deletions(-) diff

[PATCH 05/11] [media] dvb-core/dvb_ca_en50221.c: Make checkpatch happy 1

From: Jasmin Jessich Fixed all: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git

[PATCH 06/11] [media] dvb-core/dvb_ca_en50221.c: Make checkpatch happy 2

From: Jasmin Jessich Fixed all: ERROR: do not use assignment in if condition Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 130 +--- 1 file changed, 88 insertions(+), 42 deletions(-) diff --git

[PATCH 08/11] [media] dvb-core/dvb_ca_en50221.c: Make checkpatch happy 4

From: Jasmin Jessich Fixed all: WARNING: Missing a blank line after declarations WARNING: Block comments use * on subsequent lines Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 24 1 file changed, 16

[PATCH 5/7] [media] ddbridge/ddbridge-core.c: Set maximum cxd2099 block size to 512

From: Jasmin Jessich Signed-off-by: Ralph Metzler Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich --- drivers/media/pci/ddbridge/ddbridge-core.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 10/11] [media] dvb-core/dvb_ca_en50221.c: Make checkpatch happy 6

From: Jasmin Jessich Fixed most of WARNING: line over 80 characters The remaining lines are printk strings, which should not be split. The WARNING: memory barrier without comment WARNING: Prefer [subsystem eg: netdev]_dbg will not be fixed. checkpatch result: total: 0

[PATCH 11/11] [media] dvb-core/dvb_ca_en50221.c: Fixed wrong EXPORT_SYMBOL order

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/dvb_ca_en50221.c

[PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

From: Jasmin Jessich Rename STATUSREG_?? -> STATREG_?? to reduce the line length. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH 04/11] [media] dvb-core/dvb_ca_en50221.c: Refactored dvb_ca_en50221_thread

From: Jasmin Jessich Refactored "dvb_ca_en50221_thread" by moving the state machine into the new function "dvb_ca_en50221_thread_state_machine". This reduces the thread function size and reduces the structural complexity and of course gives us more space to meet the line length

[PATCH 7/7] [staging] cxd2099/cxd2099.c: Activate cxd2099 buffer mode

From: Jasmin Jessich Now the cxd2099 buffer mode is activated, but can be deactivated by setting BUFFER_MODE to 0 at the compiler command line or by editiing the file. Signed-off-by: Jasmin Jessich --- drivers/staging/media/cxd2099/cxd2099.c | 4 +++- 1 file

[PATCH 07/11] [media] dvb-core/dvb_ca_en50221.c: Make checkpatch happy 3

From: Jasmin Jessich Fixed all: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 48 + 1 file changed, 18 insertions(+), 30 deletions(-)

[PATCH 03/11] [media] dvb-core/dvb_ca_en50221.c: Used a helper variable

From: Jasmin Jessich Used a helper variable "struct dvb_ca_slot *sl" instead of "ca->slot_info[slot]". This reduces the line lenght and simplifies code reading. Renamed "i" to "slot" in some functions to make the code more readable. Signed-off-by: Jasmin Jessich

[PATCH 1/7] [media] dvb-core/dvb_ca_en50221.c: State UNINITIALISED instead of INVALID

From: Jasmin Jessich In case of a linkinit failure change to state UNINITIALISED to re-init the CAM. Signed-off-by: Ralph Metzler Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich ---

[PATCH 09/11] [media] dvb-core/dvb_ca_en50221.c: Make checkpatch happy 5

From: Jasmin Jessich Fixed all: WARNING: msleep < 20ms can sleep for up to 20ms by using usleep_range. Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 00/11] Fix coding style in en50221 CAM functions

From: Jasmin Jessich These patch series is a follow up to the series "Add block read/write to en50221 CAM functions". It fixed nearly all the style issues reported by checkpatch.pl in dvb-core/dvb_ca_en50221.c Please note, that there are 7 Warnings left, which I won't fix. Two of

Re: [PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

Hello Mauro! >> Rename STATUSREG_?? -> STATREG_?? to reduce the line length. > That sounds a bad idea. We use "stat" on the DVB subsystem as an > alias for statistics. At the beginning of the style fixes, I thought it is a good idea to reduce as much as possible to get more characters, but at

[PATCH V2] build: Added missing functions nsecs_to_jiffies(64)

From: Jasmin Jessich Several modules expect the functions nsecs_to_jiffies64 and nsecs_to_jiffies to be available when they get loaded. For Kernels prior to 3.16, this symbol is not exported in time.c . Copied the functions to compat.h, so that they get already resolved during

[PATCH 1/2] Store device structure in dvb_register_device

From: Jasmin Jessich The device created by device_create in dvb_register_device was not available for DVB device drivers. Added "struct device *dev" to "struct dvb_device" and store the created device. Signed-off-by: Jasmin Jessich ---

[PATCH 2/2] Added timers for dvb_ca_en50221_write_data

From: Jasmin Jessich Some (older) CAMs are really slow in accepting data. The CI interface specification doesn't define a handshake for accepted data. Thus, the en50221 protocol driver can't control if a data byte has been correctly written to the CAM. The current implementation

[PATCH 0/2] Add timers to en50221 protocol driver

From: Jasmin Jessich Some (older) CAMs are really slow in accepting data. I got sometimes the already known error "CAM tried to send a buffer larger than the ecount size". I could track it down to the dvb_ca_en50221_write_data function not waiting between sending the data

Re: [PATCH] build: Fixed patches partly for Kernel 2.6.32

Hello Hans! > Do you need build support for kernels < 2.6.36? I don't, but I have the headers laying around on my disk and I simply tried to fix the build ;) > I gave up supporting such old kernels 2 or 3 years ago. It seems so. I just learned, that RHEL 6.x does still use 2.6.32. But there is

Re: [PATCH] media: dvb_ca_en50221: sanity check slot number from userspace

Good catch! > Seems that this bug has been in the driver forever. Indeed ... and I overlooked it during my recent changes to that module. Reviewed-by: Jasmin Jessich BR, Jasmin

Re: [PATCH 0/2] Add timers to en50221 protocol driver

Ping!

Re: [ANN] Agenda (v1) for the media mini-summit on Friday Oct 27 in Prague

Hello Hans! Will there be some "powerpoint" (or what ever) file of the presentations available afterwards? Or any other media to listen/see it later? BR, Jasmin

Re: [PATCH] build: Fixed patches for Kernel 2.6.35

Hi! I haven't tried to compile for 2.6.35, but the patches will now apply back till version 2.6.33. BR, Jasmin

[PATCH] build: Remove IDA from lirc_dev

From: Jasmin Jessich Compiling for Kernel 2.6.x failed in "lirc_dev.c" with implicit declaration of function 'ida_simple_get' This will in principle revert commit 46c8f4771154eb0dc21f5f2bc2640a33e8fe1d02 . Signed-off-by: Jasmin Jessich ---

Re: [PATCH] build: Fixed patches partly for Kernel 2.6.32

Hi! I have fixed the patches for 2.6.32 partly. File rc-ir-raw.c is still missing, but I can't fix that. Moreover, when compiling for 2.6.32, I get errors from compat.h: implicit declaration of function 'ktime_to_ms' So it seems this needs a fix in compat.h also. I am sending this patch

  1   2   3   >