[PATCH 2/2] [media] coda: copy headers in front of every I-frame

That way we don't have to rely on userspace to inject the headers on IDR requests, and there is always enough information to start decoding at an I-frame. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-bit.c | 9 + 1 file changed, 5 inse

[PATCH 1/2] [media] coda: implement forced key frames

requests from userspace. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-bit.c| 12 drivers/media/platform/coda/coda-common.c | 3 +++ drivers/media/platform/coda/coda.h| 1 + 3 files changed, 12 insertions(+), 4 deletions(-)

Re: [PATCH 0/3] tc358743: minor driver fixes

> Is it worth going to the effort of dynamically computing the delay, or > >> > is increasing the default acceptable? > >> > >> I see that the fifo_level value of 16 was supplied by Philipp Zabel, so > >> I have CC-ed him as I am not sure where those values came

Re: [PATCH 0/3] tc358743: minor driver fixes

uting register > > settings). It increases the delay by 2.96usecs at 720P60 on 2 lanes, > > so not a huge change. > > Is it worth going to the effort of dynamically computing the delay, or > > is increasing the default acceptable? > > I see that the fifo_level value of 16 wa

Re: [PATCH v4 1/4] media-ctl: add pad support to set/get_frame_interval

Hi, On Thu, 2017-03-30 at 18:51 +0200, Philipp Zabel wrote: > This allows to set and get the frame interval on pads other than pad 0. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> any more comments on

Re: [PATCH v7 2/3] [media] add mux and video interface bridge entity functions

Hi Sakari, On Mon, 2017-05-29 at 23:38 +0300, Sakari Ailus wrote: [...] > > diff --git a/Documentation/media/uapi/mediactl/media-types.rst > > b/Documentation/media/uapi/mediactl/media-types.rst > > index 2a5164aea2b40..1d15542f447c1 100644 > > ---

[PATCH v7 1/3] dt-bindings: Add bindings for video-multiplexer device

Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Sakari Ailus <sakari.ai...@linu

[PATCH v7 3/3] [media] platform: add video-multiplexer subdevice driver

: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Pavel Machek <pa...@ucw.cz> --- Chang

[PATCH v7 2/3] [media] add mux and video interface bridge entity functions

Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Changes since [1]: - Reword the video interface bridge description, do not use "bus format" to avoid

Re: [PATCH v7 00/34] i.MX Media Driver

On Mon, 2017-05-29 at 15:46 +0200, Hans Verkuil wrote: > Hi Steve, > > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > In version 7: > > > > - video-mux: switched to Philipp's latest video-mux driver and updated > >bindings docs, that makes use of the mmio-mux framework. > > > > -

Re: [PATCH v7 15/34] add mux and video interface bridge entity functions

On Mon, 2017-05-29 at 15:37 +0200, Hans Verkuil wrote: > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > From: Philipp Zabel <p.za...@pengutronix.de> > > > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > > > > - renamed MEDIA_ENT_F_M

[PATCH] [media] coda: improve colorimetry handling

, as returned by calling VIDIOC_TRY/S_FMT with V4L2_COLORSPACE_DEFAULT, initially. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-common.c | 51 ++- drivers/media/platform/coda/coda.h| 3 ++ 2 files changed, 39 inse

[PATCH v5 3/3] [media] platform: video-mux: include temporary mmio-mux support

As long as the mux framework is not merged, add temporary mmio-mux support to the video-mux driver itself. This patch is to be reverted once the "mux: minimal mux subsystem" and "mux: mmio-based syscon mux controller" patches are merged. Signed-off-by: Philipp Zabel <

[PATCH v5 1/3] dt-bindings: Add bindings for video-multiplexer device

Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Sakari Ailus <sakari.ai...@linu

[PATCH v5 2/3] platform: add video-multiplexer subdevice driver

-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- No changes since v4 [1]: This patch depends on the mux subsystem [2] and on the mmio-mux driver [3] to work on i.MX6. T

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

if (tryfmt->quantization == V4L2_QUANTIZATION_DEFAULT) > + tryfmt->quantization = fmt->quantization; According to Hans' latest comments, this could be changed to: --8<-- >From cca3cda9effcaca0891eb8044a79137023fed1c2 Mon Sep 17 00:00:00 2

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

Hi Hans, On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: > Hi Philipp, > > Sorry for the very long delay, but I finally had some time to think about > this. Thank you for your thoughts. > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is

Re: [PATCH] [media] tc358743: fix register i2c_rd/wr function fix

Hi Arnd, On Thu, 2017-05-04 at 17:24 +0200, Arnd Bergmann wrote: > On Thu, May 4, 2017 at 5:20 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > The below mentioned fix contains a small but severe bug, > > fix it to make the driver work again. > > > > Fixes

[PATCH] [media] tc358743: fix register i2c_rd/wr function fix

;mche...@s-opensource.com> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/i2c/tc358743.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index acef4eca269f1..3251cba89e8f6 100644 --- a/

[PATCH v4 1/2] [media] dt-bindings: Add bindings for video-multiplexer device

Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Sakari Ailus <sakari.ai...@linu

[PATCH v4 2/2] [media] platform: add video-multiplexer subdevice driver

-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Changes since v3 [1]: - Dropped v4l2-fwnode dependency and endpoint parsing for now. - Use devm_kcalloc

Re: [PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver

Hi Sebastian, On Thu, 2017-05-04 at 16:21 +0200, Sebastian Reichel wrote: > Hi, > > On Thu, May 04, 2017 at 03:38:57PM +0200, Philipp Zabel wrote: > > This driver can handle SoC internal and external video bus multiplexers, > > controlled by mux controllers provided

Re: [PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver

Hi Kieran, On Thu, 2017-05-04 at 15:59 +0100, Kieran Bingham wrote: > Hi Philipp, > > Thankyou for the patch, thank you for reviewing. > On 04/05/17 14:38, Philipp Zabel wrote: > > This driver can handle SoC internal and external video bus multiplexers, > > contr

Re: [PATCH v3.1 4/7] v4l: Switch from V4L2 OF not V4L2 fwnode API

ogen6X i.MX6Q + Toshiba TC358743 HDMI to MIPI CSI-2 bridge. Tested-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

[PATCH v3 1/2] [media] dt-bindings: Add bindings for video-multiplexer device

Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Peter Rosin <p...@axentia.se>

[PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver

-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Changes since v2 [1]: - Extend vmux->lock to protect mbus format against simultaneous access from get/set_format calls.

[PATCH] [media] imx: switch from V4L2 OF to V4L2 fwnode API

Switch from the v4l2_of_ APIs to the v4l2_fwnode_ APIs so this driver can work if the patch "v4l: Switch from V4L2 OF not V4L2 fwnode API" is applied before it. Tested against https://git.linuxtv.org/sailus/media_tree.git/log/?h=v4l2-acpi-merge Signed-off-by: Philipp Zabel <p.za...@p

Re: [PATCH v2 2/2] [media] platform: add video-multiplexer subdevice driver

On Thu, 2017-05-04 at 12:48 +0300, Sakari Ailus wrote: > Hi Philipp, > > On Thu, May 04, 2017 at 11:26:18AM +0200, Philipp Zabel wrote: > > Hi Sakari, > > > > On Thu, 2017-05-04 at 10:17 +0300, Sakari Ailus wrote: > > > Hi Philipp, > > > > >

Re: [PATCH v2 2/2] [media] platform: add video-multiplexer subdevice driver

Hi Sakari, On Thu, 2017-05-04 at 10:17 +0300, Sakari Ailus wrote: > Hi Philipp, > > On Thu, May 04, 2017 at 09:07:32AM +0200, Philipp Zabel wrote: > > On Wed, 2017-05-03 at 22:28 +0300, Sakari Ailus wrote: > > > Hi Philipp, > > > > > > Thanks for conti

Re: [PATCH v2 2/2] [media] platform: add video-multiplexer subdevice driver

On Wed, 2017-05-03 at 22:28 +0300, Sakari Ailus wrote: > Hi Philipp, > > Thanks for continuing working on this! > > I have some minor comments below... Thank you for the comments. [...] > Could you rebase this on the V4L2 fwnode patchset here, please? > >

Re: [PATCH 2/2] [media] platform: add video-multiplexer subdevice driver

On Tue, 2017-05-02 at 19:42 +0200, Peter Rosin wrote: > On 2017-05-02 17:21, Philipp Zabel wrote: > > On Sat, 2017-04-29 at 23:42 +0200, Peter Rosin wrote: > >> On 2017-04-29 23:29, Peter Rosin wrote: > >>> On 2017-04-28 16:13, Philipp Zabel wrote: > >>

Re: [PATCH 2/2] [media] platform: add video-multiplexer subdevice driver

On Sat, 2017-04-29 at 23:42 +0200, Peter Rosin wrote: > On 2017-04-29 23:29, Peter Rosin wrote: > > On 2017-04-28 16:13, Philipp Zabel wrote: > >> This driver can handle SoC internal and external video bus multiplexers, > >> controlled by mux controllers provided by t

[PATCH v2 2/2] [media] platform: add video-multiplexer subdevice driver

-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Changes since v1 [1]: - Protect vmux->active with a mutex in link_setup and set_format. s_stream does not need to be

[PATCH v2 1/2] [media] dt-bindings: Add bindings for video-multiplexer device

Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Peter Rosin <p...@axentia.se> --

[PATCH 2/2] [media] platform: add video-multiplexer subdevice driver

-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- This has been last sent as part of the i.MX media series. Changes since https://patchwork.kernel.org/patch/9647869/: - Split

[PATCH 1/2] [media] dt-bindings: Add bindings for video-multiplexer device

Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- This has been last sent as part of Steve's

Re: [PATCH] V4L2 SDR: Add Real U8 format (V4L2_SDR_FMT_RU8)

Hi Bertold, On Mon, 2017-04-24 at 00:45 +0200, Bertold Van den Bergh wrote: > This patch adds support for the Real U8 format to the V4L2 SDR framework. > This will be used for a piece of hardware we are developing. > > Signed-off-by: Bertold Van den Bergh > --- >

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

On Thu, 2017-04-13 at 09:40 -0700, Steve Longerbeam wrote: [...] > >> @@ -804,12 +804,29 @@ static void prp_try_fmt(struct prp_priv *priv, > >> >format.height, > >> infmt->height / 4, MAX_H_SRC, > >>

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Pavel, On Fri, 2017-04-14 at 22:32 +0200, Pavel Machek wrote: > Hi! > > > > The MUX framework is already in linux-next. Could you use that instead of > > > adding new driver + bindings that are not compliant with the MUX > > > framework? > > > I don't think it'd be much of a change in terms

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Sakari, thank you for the review. On Tue, 2017-04-04 at 15:47 +0300, Sakari Ailus wrote: > Hi Steve, Philipp and Pavel, > > On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > > From: Philipp Zabel <p.za...@pengutronix.de> > > > > Th

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

Hi Steve, thanks for cleaning this up. Apart from the comments below, this looks good to me. On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and >

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 17:43 +0200, Hans Verkuil wrote: > On 04/06/2017 04:54 PM, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > >> On 04/06/2017 03:55 PM, Philipp Zabel wrote: > >>> If the the field order is set to ANY in set_fmt,

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 16:10 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > > > On Thu, Apr 06, 2017 at 03:55:29PM +0200, P

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace.

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdfor

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace.

[PATCH] [media] coda: do not enumerate YUYV if VDOA is not available

TRY_FMT already disables the YUYV format if the VDOA is not available. ENUM_FMT must do the same. Fixes: d40e98c13b3e ("[media] coda: support YUYV output if VDOA is used") Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-common.c |

[PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

field order and colorimetry information. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- This is based on imx-media-staging-md-v14, and it is supposed to allow configuring the pipeline with media-ctl like this: 1) media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY8_1X16/19

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On Wed, 2017-04-05 at 11:53 -0300, Mauro Carvalho Chehab wrote: [...] > There are a number of drivers that can work with different > types of TV demodulators. Typical examples of such hardware can be > found at em28xx, saa7134, cx88 drivers (among lots of other drivers). > Those drivers don't use

Re: [PATCH v6 19/39] media: Add i.MX media core driver

On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam [...] > diff --git a/drivers/staging/media/imx/imx-media-of.c > b/drivers/staging/media/imx/imx-media-of.c > new file mode 100644

Re: [PATCH 3/3] [media] coda/imx-vdoa: always wait for job completion

> > Make sure to wait on job completion before running a different context and > before destroying the currently active context. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> > --- > d

Re: [PATCH 2/3] [media] coda: first step at error recovery

ce, > i.e. userspace issued DEC_CMD_STOP and waits for EOS, but after the failed > decode run we would hold the context and wait for userspace to queue more > buffers. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Just a naming nitpick below. Reviewed-by: Philipp

Re: [PATCH] [media] coda: bump maximum number of internal framebuffers to 17

of those video streams. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp > --- > drivers/media/platform/coda/coda.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [PATCH 1/3] [media] coda: use correct offset for mvcol buffer

On Wed, 2017-04-05 at 15:09 +0200, Lucas Stach wrote: > The mvcol buffer needs to be placed behind the chroma plane(s), so > use the real offset including any required rounding. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Philipp Zabel <p.za...@pen

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On Tue, 2017-04-04 at 15:11 -0700, Steve Longerbeam wrote: > > On 03/30/2017 10:25 AM, Philipp Zabel wrote: > > The TVP5150 DT bindings specify a single output port (port 0) that > > corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). > > > > Sign

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [...] > > Actually what was I thinking, the TVP5150 is already an example of > > such a device. > > > > All of this could be solved if there was some direction information > > in port nodes. > > I disagree. > > Philipp identified

Re: [RFC 01/10] [media] vb2: add explicit fence user API

Hi Gustavo, On Mon, 2017-03-13 at 16:20 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > an in-fence to the kernel return an out-fence from the kernel to > userspace. > > Two new flags

[PATCH 2/2] [media] tvp5150: fix pad format frame height

Even if field order is set to V4L2_FIELD_ALTERNATE, the width and height values in struct v4l2_mbus_framefmt still refer to frame size, not field size. Fixes: 4f57d27be2a5 ("[media] tvp5150: fix tvp5150_fill_fmt()") Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- d

[PATCH 1/2] [media] tvp5150: allow get/set_fmt on the video source pad

). Fixes: 55606310e77f ("[media] tvp5150: create the expected number of pads") Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c

Re: [PATCH] [media] docs-rst: clarify field vs frame height in the subdev API

On Fri, 2017-03-31 at 13:08 +0200, Hans Verkuil wrote: [...] > >>> Applications are responsible for configuring coherent parameters on the > >>> whole pipeline and making sure that connected pads have compatible > >>> @@ -379,7 +382,10 @@ is supported by the hardware. > >>> pad for further

Re: [PATCH] [media] docs-rst: clarify field vs frame height in the subdev API

Hi Laurent, On Fri, 2017-03-31 at 11:09 +0300, Laurent Pinchart wrote: > Hi Philipp, > > Thank you for the patch. > > On Thursday 30 Mar 2017 17:38:20 Philipp Zabel wrote: > > VIDIOC_SUBDEV_G/S_FMT take the field size if V4L2_FIELD_ALTERNATE field > > order is s

[RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- I'm trying to get this to work with a TVP5150 analog TV decoder, and the first problem is that this

[PATCH v4 2/4] media-ctl: print the configured frame interval

After the pad format, also print the frame interval, if already configured. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> --- Changes since v3: - Ignore EINVAL error of VIDIOC_SUBDEV_G_FRAME_INTERVAL as that is a valid

[PATCH v4 3/4] media-ctl: propagate frame interval

Same as the media bus format, the frame interval should be propagated from output pads to connected entities' input pads. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> --- Changes since v3: - Ignore frame interval propag

[PATCH v4 4/4] media-ctl: add colorimetry support

media-ctl can be used to propagate v4l2 subdevice pad formats from source pads of one subdevice to another one's sink pads. These formats include colorimetry information, so media-ctl should be able to print or change it using the --set/get-v4l2 option. Signed-off-by: Philipp Zabel <p

[PATCH v4 1/4] media-ctl: add pad support to set/get_frame_interval

This allows to set and get the frame interval on pads other than pad 0. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> --- utils/media-ctl/libv4l2subdev.c | 24 ++-- utils/media-ctl/v4l2subdev.h

[PATCH] [media] docs-rst: clarify field vs frame height in the subdev API

. This was not immediately clear to me when reading the documentation, so this patch adds some clarifications in the relevant places. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- Documentation/media/uapi/v4l/de

Re: [PATCH] [media] coda: remove redundant call to v4l2_m2m_get_vq

or should this actually check whether the queue is > an > output queue? Yes, this was previously assigned to an unused local variable src_vq, since initial commit 918c66fd4126 ("[media] coda: add CODA7541 decoding support"). coda_buf_is_end_of_stream is called from coda_m2m_buf_done, which is exclusively used on destination buffers on the capture queue. Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH v4 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

On Tue, 2017-03-21 at 16:12 +0100, Neil Armstrong wrote: > Some display pipelines can only provide non-RBG input pixels to the HDMI TX > Controller, this patch takes the pixel format from the plat_data if provided. > > Signed-off-by: Neil Armstrong On i.MX6 we could

Re: [PATCH v3 2/4] media-ctl: print the configured frame interval

On Mon, 2017-02-13 at 12:40 +0100, Philipp Zabel wrote: > After the pad format, also print the frame interval, if already configured. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> > --- > u

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > >

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, 2017-03-20 at 15:43 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote: > > To set and read colorimetry information: > > https://patchwork.linuxtv.org/patch/39350/ > > Thanks, I've applied all four of your patche

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: > > The above paragraph suggests we skip any rectangles that are not > > supported. In our case that would be 3. and 4., since the CSI can't > >

Re: [PATCH v5 00/39] i.MX Media Driver

On Sun, 2017-03-19 at 12:14 +, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2 > >

Re: [PATCH v5 00/39] i.MX Media Driver

interval information, so there's > > no way to read it back with standard tools, and no indication that > > this is going on... > > I think Philipp Zabel submitted a patch which addresses these > in media-ctl. Check with him. To read back and propagate the frame inte

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Sun, 2017-03-19 at 12:08 -0700, Steve Longerbeam wrote: > > On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: > > On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: > >> From: Philipp Zabel <p.za...@pengutronix.de> > >> > >> Th

Re: [PATCH v2 03/14] [media] coda: simplify optional reset handling

ependent from each other, and unchanged from v1. I've resent the series (possibly adding a few mailing lists where I previously forgot) now that commit bb475230b8e5 is in mainline. regards Philipp > Regards, > > Hans > > On 03/15/2017 12:31 PM, Philipp Zabel wrote: > > As

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: [...] > The big question, waiting for an answer on the last 8 years is > who would do that? Such person would need to have several different > hardware from different vendors, in order to ensure that it has > a generic solution. > >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, 2017-03-17 at 11:42 +, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > > We're all very driver-development-driven, and userspace gets very little > > attention in general. So before just throwing in the towel we should take > > a good

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

On Thu, 2017-03-16 at 10:47 +0100, Philippe De Muyter wrote: > On Thu, Mar 16, 2017 at 10:26:00AM +0100, Philipp Zabel wrote: > > On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > > > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > >

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > > with those, it will likely run with any other application. > > > > > > > I would like

[PATCH v2 03/14] [media] coda: simplify optional reset handling

trol_reset unconditionally. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-common.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/cod

[PATCH v2 04/14] [media] st_rc: simplify optional reset handling

ditionally. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Patrice Chotard <patrice.chot...@st.com> --- drivers/media/rc/st_rc.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c index f0d719

[PATCH v2 05/14] [media] rc: sunxi-cir: simplify optional reset handling

ditionally. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/rc/sunxi-cir.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 25b0061678102..4b785dd775c11 100644 ---

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On Tue, 2017-03-14 at 08:34 +0100, Hans Verkuil wrote: > On 03/13/2017 10:03 PM, Sakari Ailus wrote: > > Hi Steve, > > > > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: > >> > >> > >> On 03/13/2017 06:55 AM, Philipp Zabel wrote:

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote: > > The vast majority of existing drivers do not implement them nor the user > > space expects having to set them. Making that mandatory would break existing > > user

Re: [PATCH] coda: enable with COMPILE_TEST

gt; tristate "Chips Coda multi-standard codec IP" > - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC > + depends on VIDEO_DEV && VIDEO_V4L2 > + depends on ARCH_MXC || COMPILE_TEST Yes, that could be helpful. Acked-by: Phil

[PATCH v2] [media] coda: restore original firmware locations

mware compatibility location") Cc: Baruch Siach <bar...@tkos.co.il> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Baruch Siach <bar...@tkos.co.il> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> --- Changes since v1: - moved fw assignment after ARRAY_SI

Re: [PATCH] [media] coda: restore original firmware locations

On Wed, 2017-03-08 at 11:38 +0100, Hans Verkuil wrote: > On 01/03/17 16:36, Philipp Zabel wrote: > > Recently, an unfinished patch was merged that added a third entry to the > > beginning of the array of firmware locations without changing the code > > to also look at th

Re: [PATCH] [media] coda: implement encoder stop command

On Thu, 2017-03-02 at 17:30 +0100, Jean-Michel Hautbois wrote: > > > > + /* If there is no buffer in flight, wake up */ > > + if (ctx->qsequence == ctx->osequence) { > > Not sure about this one, I would have done something like : > if (!(ctx->fh.m2m_ctx->job_flags)) { This field is

[PATCH 2/4] [media] coda: keep queued buffers on a temporary list during start_streaming

-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-bit.c| 28 ++-- drivers/media/platform/coda/coda-common.c | 29 ++--- drivers/media/platform/coda/coda.h| 2 +- 3 files changed, 45 insertions(

[PATCH 4/4] [media] coda: disable reordering for baseline profile h.264 streams

.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-bit.c| 44 - drivers/media/platform/coda/coda-common.c | 12 ++ drivers/media/platform/coda/coda-h264.c | 63 +++ drivers/media/platform

[PATCH 1/4] [media] coda: Use && instead of & for non-bitfield conditions

From: Michael Tretter <m.tret...@pengutronix.de> streamon and streamoff are used as boolean values, not as bitfields. Therefore, the logical && should be used to combine them. Signed-off-by: Michael Tretter <m.tret...@pengutronix.de> Signed-off-by: Philipp Zabel <

[PATCH 3/4] [media] coda: pad first h.264 buffer to 512 bytes

The bitstream reader needs 512 bytes ready to read to examine the headers in the first frame. If that frame is too small, prepend it with a filler NAL. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-bit.c | 28 ++-- d

[PATCH] [media] coda: disable BWB for all codecs on CODA 960

frames to memory, so there is an "enable_bwb" module parameter to turn it back on. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-common.c | 7 ++- drivers/media/platform/coda/coda_regs.h | 1 + 2 files changed, 7 insertions(+), 1 d

Re: [PATCH] [media] coda: implement encoder stop command

Hi Jean-Michel, On Thu, 2017-03-02 at 11:02 +0100, Jean-Michel Hautbois wrote: > Hi Philipp, > > 2017-03-02 10:51 GMT+01:00 Philipp Zabel <p.za...@pengutronix.de>: > > There is no need to call v4l2_m2m_try_schedule to kick off draining the > > bitstream buffer f

[PATCH] [media] coda: implement encoder stop command

There is no need to call v4l2_m2m_try_schedule to kick off draining the bitstream buffer for the encoder, but we have to wake up the destination queue in case there are no new OUTPUT buffers to be encoded and userspace is already polling for new CAPTURE buffers. Signed-off-by: Philipp Zabel <p

[PATCH] [media] coda: restore original firmware locations

mware compatibility location") Cc: Baruch Siach <bar...@tkos.co.il> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/media/platform/coda/coda-common.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/coda/co

<    1   2   3   4   5   6   7   8   9   10   >