Re: [RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling

Hi, On 06/16/2017 02:58 PM, Sakari Ailus wrote: > Hi Hans, > > Cc Sylwester and Marek as well. > > On Mon, May 08, 2017 at 04:35:05PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The type field in struct v4l2_selection is supposed to never use the >> _MPLANE

Re: [PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

On 06/16/2017 06:38 PM, Jose Abreu wrote: > This is an initial submission for the Synopsys Designware HDMI RX > Controller Driver. This driver interacts with a phy driver so that > a communication between them is created and a video pipeline is > configured. > > The controller + phy pipeline can

Re: [PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

Hi Jose, On 06/16/2017 06:38 PM, Jose Abreu wrote: > Document the bindings for the Synopsys Designware HDMI RX. > > Signed-off-by: Jose Abreu > new file mode 100644 > index 000..d30cc1e > --- /dev/null > +++

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

, and if detected manually creates the platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman <khil...@baylibre.com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Regards, Sylwester

Re: [PATCH 2/2] dt-bindings: media/s5p-cec.txt, media/stih-cec.txt: refer to cec.txt

off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester

Re: [PATCH 1/2] dt-bindings: add media/cec.txt

On 06/09/2017 07:54 PM, Hans Verkuil wrote: From: Hans Verkuil <hans.verk...@cisco.com> Document common HDMI CEC bindings. Add this to the MAINTAINERS file as well. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro

Re: [PATCH 8/9] s5p_cec: set the CEC_CAP_NEEDS_HPD flag if needed

On 06/07/2017 04:46 PM, Hans Verkuil wrote: From: Hans Verkuil <hans.verk...@cisco.com> Use the needs-hpd DT property to determine if the CEC_CAP_NEEDS_HPD should be set. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro

Re: [Patch v4 00/12] Add MFC v10.10 support

On 04/06/2017 08:11 AM, Smitha T Murthy wrote: This patch series adds MFC v10.10 support. MFC v10.10 is used in some of Exynos7 variants. This adds support for following: * Add support for HEVC encoder and decoder * Add support for VP9 decoder * Update Documentation for control id definitions

[GIT PULL] Samsung SoC updates for v4.13

Hi Mauro, The following changes since commit 36bcba973ad478042d1ffc6e89afd92e8bd17030: [media] mtk_vcodec_dec: return error at mtk_vdec_pic_info_update() (2017-05-19 07:12:05 -0300) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.13/media/next for

Re: [PATCH 5/9] [media] s5p-jpeg: Add IOMMU support

On 06/02/2017 06:02 PM, Thierry Escande wrote: From: Tony K Nadackal This patch adds support for IOMMU s5p-jpeg driver if the Exynos IOMMU and ARM DMA IOMMU configurations are supported. The address space is created with size limited to 256M and base address set to

Re: [PATCH 7/9] [media] s5p-jpeg: Change sclk_jpeg to 166MHz for Exynos5250

On 06/02/2017 11:58 PM, Jacek Anaszewski wrote: On 06/02/2017 06:02 PM, Thierry Escande wrote: From: henryhsu The default clock parent of jpeg on Exynos5250 is fin_pll, which is 24MHz. We have to change the clock parent to CPLL, which is 333MHz, and set sclk_jpeg to

Re: [PATCH] media: platform: s3c-camif: fix arguments position in function call

On 06/02/2017 05:43 AM, Gustavo A. R. Silva wrote: Hi Sylwester, Here is another patch in case you decide that it is better to apply this one. Thanks, I applied this patch. In future please put any comments only after the scissors ("---") line, the comments can be then discarded

Re: [PATCH] media: platform: s3c-camif: fix function prototype

On 05/22/2017 11:02 AM, Hans Verkuil wrote: >> --- a/drivers/media/platform/s3c-camif/camif-regs.c >> +++ b/drivers/media/platform/s3c-camif/camif-regs.c >> @@ -58,7 +58,7 @@ void camif_hw_set_test_pattern(struct camif_dev *camif, >> unsigned int pattern) >> } >> >> void

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

Hi, On 05/29/2017 09:08 PM, Jacek Anaszewski wrote: This patch seems to have lost somehow. Could you help merging it? It's not lost, it has been on my todo queue. I have applied it now. -- Thanks, Sylwester

Re: [PATCH v4] dw9714: Initial driver for dw9714 VCM

On 05/11/2017 04:59 PM, Sakari Ailus wrote: On 05/11/2017 08:30 AM, Tomasz Figa wrote: [...] rval = pm_runtime_get_sync(dev); if (rval < 0) { pm_runtime_put(dev); return rval; } Aren't we supposed to call pm_runtime_put() only when corresponding pm_runtime_get()

Re: [PATCH v4] dw9714: Initial driver for dw9714 VCM

Hi, On 05/11/2017 08:30 AM, Tomasz Figa wrote: >> +static int dw9714_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) >> +{ >> + struct dw9714_device *dw9714_dev = container_of(sd, >> + struct dw9714_device, >> +

Re: [media-s3c-camif] question about arguments position

Hi Gustavo, On 05/04/2017 09:05 PM, Gustavo A. R. Silva wrote: > The issue here is that the position of arguments in the call to > camif_hw_set_effect() function do not match the order of the parameters: > > camif->colorfx_cb is passed to cr > camif->colorfx_cr is passed to cb > > This is the

Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)

On 04/11/2017 11:23 AM, Julia Lawall wrote: On Tue, 11 Apr 2017, Sylwester Nawrocki wrote: Hi, On 04/03/2017 08:17 AM, Smitha T Murthy wrote: On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote: See line 2101 julia Thank you for bringing it to my notice, I had not checked on this git. I

Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)

Hi, On 04/03/2017 08:17 AM, Smitha T Murthy wrote: On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote: See line 2101 julia Thank you for bringing it to my notice, I had not checked on this git. I will upload the next version of patches soon corresponding to this git. In general please

Re: [PATCH 09/12] [media] s5p-mfc: use setup_timer

On 04/09/2017 03:34 AM, Geliang Tang wrote: Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang Applied, thanks.

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

On 04/07/2017 12:03 PM, Smitha T Murthy wrote: +``V4L2_CID_MPEG_VIDEO_HEVC_LF`` +Indicates loop filtering. Control ID 0 indicates loop filtering +is enabled and when set to 1 indicates no filter. >> "Setting this control to 0 enables loop filtering, setting this control to 1 disables

Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

On 04/07/2017 10:31 AM, Smitha T Murthy wrote: On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: On 04/06/2017 08:11 AM, Smitha T Murthy wrote: @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP:return "

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

On 04/06/2017 08:11 AM, Smitha T Murthy wrote: Added V4l2 controls for HEVC encoder s/HEVC/H.265/HEVC ? Signed-off-by: Smitha T Murthy --- Documentation/media/uapi/v4l/extended-controls.rst | 391 + 1 file changed, 391 insertions(+) diff --git

Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP:return "VPX > P-Frame QP Value"; > case V4L2_CID_MPEG_VIDEO_VPX_PROFILE: return "VPX > Profile"; >

[GIT PULL] Samsung SoC related updates

Hi Mauro, The following changes since commit c3d4fb0fb41f4b5eafeee51173c14e50be12f839: [media] rc: sunxi-cir: simplify optional reset handling (2017-03-24 08:30:03 -0300) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.12/media/next for you to fetch

Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C

On 12/13/2016 06:44 AM, Nicholas Mc Guire wrote: The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS driver can not be found. Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c")

Re: [PATCH v2 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

On 02/22/2017 05:22 PM, Shuah Khan wrote: On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski wrote: Internal MFC driver device structure contains two pointers to devices used for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the mem_dev[] array and

Re: [PATCH 15/15] ARM: dts: exynos: Remove MFC reserved buffersg

On 02/14/2017 06:03 PM, Krzysztof Kozlowski wrote: > On Tue, Feb 14, 2017 at 08:52:08AM +0100, Marek Szyprowski wrote: >> During my research I found that some of the requirements for the memory >> buffers for MFC v6+ devices were blindly copied from the previous (v5) >> version and simply turned

Re: [PATCH 2/2] [media] exynos-gsc: Add support for NV{16,21,61}M pixel formats

Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 1/2] [media] exynos-gsc: Do not swap cb/cr for semi planar formats

er the (packed) order of those components are. > > Suggested-by: Nicolas Dufresne <nicolas.dufre...@collabora.com> > Signed-off-by: Thibault Saunier <thibault.saun...@osg.samsung.com> > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

Hi Javier, On 02/13/2017 01:53 PM, Javier Martinez Canillas wrote: > Any comments on this series? The patches look good to me, I will Ack the patches in case Mauro wants to apply them directly. Alternatively I will add them to my tree for v4.12 after the merge window. -- Thanks, Sylwester

[GIT PULL FOR v4.11] Samsung SoC related updates

Hi Mauro, It's just a few clean up and one fix patch this time. The following changes since commit 40eca140c404505c09773d1c6685d818cb55ab1a: [media] mn88473: add DVB-T2 PLP support (2016-12-27 14:00:15 -0200) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git

Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0

On 12/15/2016 02:14 AM, Nicholas Mc Guire wrote: > if its actually unused then it might be best to completely drop the code > raher than fixing up dead-code. Is the EXYNOS the only system that had > this device in use ? If it shold stay in then setting it to the above > proposed 3000, 4000 would

Re: [PATCH] media: platform: s3c-camif: constify v4l2_subdev_ops structures

off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0

Hi Laurent, On 12/13/2016 03:10 PM, Laurent Pinchart wrote: > As pointed out by Ian Arkver, the datasheet states the delay should be >50µs. > Would it make sense to reduce the sleep duration to (3000, 4000) for instance > (or possibly even lower), instead of increasing it ? Theoretically it

Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0

driver for S5K6AAFX > sensor") > Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> > --- Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> I'm not sure the "Fixes" tag is needed here. > Patch is against 4.9.0 (localversion-next is next-20161212) Ideal

Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

expecting. Change to > use of_node_cmp() so that we continue matching after the overlay has > been removed and reapplied. > > Signed-off-by: Javi Merino <javi.mer...@kernel.org> Thanks, there is clearly a bug in current code as it assumed static representation of DT in the kern

[GIT PULL] Samsung SoC related updates

Mauro, this change set adds support for the Exynos5433 SoC variant of the MFC subsystem, it also includes related clean up and fixes/improvements. The following changes since commit 36f94a5cf0f9afb527f18166ae56bd3cc7204f63: Merge tag 'v4.9-rc5' into patchwork (2016-11-16 16:42:27 -0200)

Re: [GIT PULL] Samsung fixes for 4.8

On 11/16/2016 03:46 PM, Mauro Carvalho Chehab wrote: Marek Szyprowski (1): > >> s5p-mfc: fix failure path of s5p_mfc_alloc_memdev() >> > >> > Mauro, this patch seems to had slipped through the cracks, I can't see it >> > in neither media fixes nor the master branch. Could you

Re: [GIT PULL] Samsung fixes for 4.8

On 10/21/2016 02:26 PM, Mauro Carvalho Chehab wrote: > Em Fri, 16 Sep 2016 15:33:33 +0200 > Sylwester Nawrocki <s.nawro...@samsung.com> escreveu: > >> Hi Mauro, >> >> The following changes since commit 7892a1f64a447b6f65fe288863b7c26d81d3: >> >>

[GIT PULL] Samsung SoC driver updates for 4.10

Hi Mauro, This includes mostly clean up and fixes of the s5p-mfc and exynos-gsc drivers. Support for the Exynos5433 (64-bit ARM) SoC is added to the exynos-gsc driver. The following changes since commit 669c6141ea78dff885b5bf025456c7dffb669a61: [media] mtk-mdp: fix double mutex_unlock

Re: [PATCH] media: s5p-mfc include buffer size in error message

On 10/18/2016 02:43 AM, Shuah Khan wrote: > Include buffer size in s5p_mfc_alloc_priv_buf() the error message when it > fails to allocate the buffer. Remove the debug message that does the same. > > Signed-off-by: Shuah Khan > --- >

Re: [GIT PULL] Samsung fixes for 4.8

On 10/21/2016 02:26 PM, Mauro Carvalho Chehab wrote: >> Sylwester Nawrocki (1): >> > exynos4-is: Clear I2C_ISP adapter's power.ignore_children flag > > This patch didn't apply fine. Could you please rebase it? > > Applying patch > patches/0002-exyn

[GIT PULL] Samsung SoC updates for v4.9, part 2

Szyprowski (4): s5p-jpeg: fix system and runtime PM integration s5p-cec: fix system and runtime PM integration exynos4-is: Add support for all required clocks exynos4-is: Improve clock management Sylwester Nawrocki (5): exynos4-is: Add missing entity function initialization

[GIT PULL] Samsung fixes for 4.8

of s5p_mfc_alloc_memdev() Sylwester Nawrocki (1): exynos4-is: Clear I2C_ISP adapter's power.ignore_children flag drivers/media/platform/exynos4-is/fimc-is-i2c.c | 25 ++--- drivers/media/platform/s5p-mfc/s5p_mfc.c| 1 + 2 files changed, 19 insertions(+), 7 deletions

[PATCH] exynos4-is: add of_platform_populate() call for FIMC-IS child devices

r applying some pending Exynos IOMMU driver patches improving runtime PM. Now the I2C_ISP child devices will be instantiated only when required parent device drivers are initialized and ready. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Signed-off-by: Sylwester N

Re: [PATCH 1/4] exynos4-is: Clear isp-i2c adapter power.ignore_children flag

On 09/07/2016 10:38 PM, Linus Walleij wrote: > On Thu, Sep 1, 2016 at 1:47 PM, Wolfram Sang <w...@the-dreams.de> wrote: >> On Thu, Sep 01, 2016 at 01:39:16PM +0200, Sylwester Nawrocki wrote: > >>> Since commit 04f59143b571161d25315dd52d7a2ecc022cb71a >&g

[PATCH 1/3] exynos4-is: Add missing entity function initialization

s5p-mipi-csis.1 was not initialized! s5p-fimc-md camera: Entity type for entity FIMC-LITE.0 was not initialized! s5p-fimc-md camera: Entity type for entity FIMC-LITE.1 was not initialized! s5p-fimc-md camera: Entity type for entity FIMC-IS-ISP was not initialized! Signed-off-by: Sylwester Nawrocki

[PATCH 2/3] s5k6a3: Add missing entity function initialization

Suppresses warning like: s5p-fimc-md camera: Entity type for entity S5K6A3 13-0010 was not initialized! Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/i2c/s5k6a3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/med

[PATCH 3/3] s5c73m3: Fix entity function assignment for the OIF subdev

Suppresses warnings like: s5p-fimc-md camera: Entity type for entity S5C73M3-OIF was not initialized! Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/med

[PATCH 1/4] exynos4-is: Clear isp-i2c adapter power.ignore_children flag

tering I2C adapter. Cc: <sta...@vger.kernel.org> # 4.7+ Reported-by: Marek Szyprowski <m.szyprow...@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/platform/exynos4-is/fimc-is-i2c.c | 25 ++--- 1 file changed, 18 inserti

[GIT PULL] Samsung media driver updates

Hi Mauro, this includes Samsung SoC media driver fixes and cleanups for v4.9. The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git

Re: [PATCHv2] s5p-tv: remove obsolete driver

kuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] exynos4-is: Fix buffer release issue on fimc m2m video nodes

xb4) [ 2498.331545] [] (do_work_pending) from [] (slow_work_pending+0xc/0x20) Reported-by: Marek Szyprowski <m.szyprow...@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/platform/exynos4-is/fimc-m2m.c | 24 ++-- 1 file changed

Re: [PATCH] of: reserved_mem: restore old behavior when no region is defined

; Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than >one region for given device") > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com> I think this needs to be added

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

On 05/24/2016 01:19 PM, Pavel Machek wrote: >> +/* >> > + * Write a list of registers to i2c device. >> > + * >> > + * The list of registers is terminated by ET8EK8_REG_TERM. >> > + * Returns zero if successful, or non-zero otherwise. >> > + */ >> > +static int et8ek8_i2c_write_regs(struct

Re: [PATCH] [media] exynos-gsc: remove an always false condition

; gsc->id is an u16, so it can never be a negative number. So, > remove the always false condition. > > Fixes: c1ac057173ba "[media] exynos-gsc: remove non-device-tree init code" > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Signed-off-by: Mauro Carvalho Cheh

[GIT PULL] Exynos/S5P SoC driver updates

Hi Mauro, This includes a few minor fixes and some long awaiting clean up patches for exynos/s5p drivers. The following changes since commit de08b5a8be0df1eb7c796b0fe6b30cf1d03d14a6: [media] v4l: exynos4-is: Drop unneeded check when setting up fimc-lite links (2016-03-05 09:10:01 -0300) are

Re: [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)"

On 12/06/2015 11:44 AM, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu The patch looks OK, but could you also provide a proper commit message? > Signed-off-by: Zeng Zhaoxiu > --- > drivers/media/platform/exynos4-is/fimc-is-regs.c | 3 ++- > 1 file

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all

Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: > The fimc_md_parse_port_node() function return 0 if an endpoint node is > not found but according to Documentation/devicetree/bindings/graph.txt, > a port must always have at least one enpoint. > > So return an -EINVAL errno code to the

Re: [RFT 2/2] [media] exynos4-is: Add missing port parent of_node_put on error paths

On 01/26/2016 01:41 AM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() remote port parent node is get with > of_graph_get_remote_port_parent() but it is not put on error path. > > Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for > asynchronous subdevices registration") >

Re: [RFT 1/2] [media] exynos4-is: Add missing endpoint of_node_put on error paths

On 01/26/2016 01:41 AM, Krzysztof Kozlowski wrote: > In fimc_md_parse_port_node() endpoint node is get with of_get_next_child() > but it is not put on error path. "is get" doesn't sound right to me, how about rephrasing this to: "In fimc_md_parse_port_node() reference count of the endpoint node

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

Hi Javier, Krzysztof, On 03/05/2016 05:35 AM, Krzysztof Kozlowski wrote: > 2016-03-05 5:20 GMT+09:00 Javier Martinez Canillas : >> > Hello, >> > >> > This series have two trivial fixes for issues that I noticed while >> > reading as a reference the driver's functions that

Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting > it avoid unmet direct dependencies. > diff --git a/drivers/media/platform/exynos4-is/Kconfig > b/drivers/media/platform/exynos4-is/Kconfig > index 57d42c6172c5..c4317b99d257 100644 > ---

Re: [PATCH 5/7] [media] mipi-csis: make sparse happy

On 05/10/15 13:07, Arnd Bergmann wrote: > On Monday 05 October 2015 12:24:40 Sylwester Nawrocki wrote: >> > On 03/10/15 00:25, Arnd Bergmann wrote: >>> > > On Thursday 01 October 2015 19:17:27 Mauro Carvalho Chehab wrote: >>>>> > >> > diff

Re: [PATCH 5/7] [media] mipi-csis: make sparse happy

On 03/10/15 00:25, Arnd Bergmann wrote: > On Thursday 01 October 2015 19:17:27 Mauro Carvalho Chehab wrote: >> > diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c >> > b/drivers/media/platform/exynos4-is/mipi-csis.c >> > index d74e1bec3d86..4b85105dc159 100644 >> > ---

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

Hi Mauro, On 21/09/15 13:41, Mauro Carvalho Chehab wrote: > Btw, I just got a Samsung TM1 device, with seems to be using an arm64 > SoC. Is this driver providing support for its camera? The TM1 device (Z3) is based on a Qualcomm 64-bit SoC. The $subject patch adds support for a standalone JPEG

Re: [PATCH 5/7] [media] use v4l2_get_timestamp where possible

> > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- For: drivers/media/platform/exynos4-is/fimc-lite.c drivers/media/platform/s3c-camif/camif-capture.c Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-m

Re: [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized

for timestamps across suspend or settimeofday(). > > This changes the driver to use the normal v4l2_get_timestamp() > function like all other drivers. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- To unsubscribe

[GIT PULL] Samsung SoC media driver updates for 4.3

Hi Mauro, The following changes since commit 4dc102b2f53d63207fa12a6ad49c7b6448bc3301: [media] dvb_core: Replace memset with eth_zero_addr (2015-07-22 13:32:21 -0300) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.3/media/next-1 for you to fetch

Re: [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does

Hi Philipp, On 25/06/15 17:12, Philipp Zabel wrote: Am Donnerstag, den 25.06.2015, 15:11 +0200 schrieb Sylwester Nawrocki: On 25/06/15 12:01, Philipp Zabel wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/v4l2-mem2mem.c | 9 - 1 file changed, 8

Re: [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does

On 26/06/15 11:02, Philipp Zabel wrote: Am Freitag, den 26.06.2015, 10:28 +0200 schrieb Sylwester Nawrocki: [...] How about modifying v4l2_m2m_ioctl_reqbufs() instead ? The coda, gsc-m2m, m2m-deinterlace, mx2_emmaprp, and sh_veu drivers all have their own implementation

Re: [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does

Hello Philipp, On 25/06/15 12:01, Philipp Zabel wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/v4l2-core/v4l2-mem2mem.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c

Re: [PATCH 05/12] media/i2c/sr030pc30: Remove compat control ops

in this code. Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Regards, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

...@broadcom.com Need your ACK for this patch. For drivers/media/platform/exynos4-is/Kconfig drivers/video/fbdev/exynos/Kconfig Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH v9 8/8] exynos4-is: Add support for v4l2-flash subdevs

On 25/05/15 17:14, Jacek Anaszewski wrote: This patch adds support for external v4l2-flash devices. The support includes parsing camera-flashes DT property samsung,camera-flashes ? and asynchronous sub-device registration. +static int fimc_md_register_flash_entities(struct fimc_md *fmd) +{

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

Hi, On 23/05/15 14:03, Sakari Ailus wrote: On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote: flash-leds = flash_xx image_sensor_x, ...; One more matter to consider: xenon flash devices. How about samsung,camera-flashes (and ti,camera-flashes)? After pondering

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

On 25/05/15 14:50, Jacek Anaszewski wrote: On 23/05/15 14:03, Sakari Ailus wrote: On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote: flash-leds = flash_xx image_sensor_x, ...; One more matter to consider: xenon flash devices. How about samsung,camera-flashes (and ti

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

On 21/05/15 13:32, Sakari Ailus wrote: @@ -147,6 +149,8 @@ Example: clocks = camera 0; clock-names = mclk; + samsung,flash-led = rear_cam_flash; + port {

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

Hi Sakari, On 21/05/15 16:20, Sakari Ailus wrote: On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote: On 21/05/15 13:32, Sakari Ailus wrote: @@ -147,6 +149,8 @@ Example: clocks = camera 0; clock-names = mclk

Re: [PATCH] v4l: of: Correct pclk-sample for BT656 bus

after the bus_type is selected. Only when hsync or vsync properties are specified, the bus_type should be set to V4L2_MBUS_PARALLEL. Signed-off-by: Nikhil Devshatwar nikhil...@ti.com Thanks for the patch. Acked-by: Sylwester Nawrocki s.nawro...@samsung.com I'd say this should be backported

Re: [PATCH 10/14] s3c-camif: Check if fmt is NULL before use

On 28/04/15 17:43, Mauro Carvalho Chehab wrote: As reported by smatch: drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup() warn: variable dereferenced before check 'fmt' (see line 460) Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Sylwester

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

Hello, On 31/03/15 15:52, Jacek Anaszewski wrote: Description of flash LEDs related properties was not precise regarding the state of corresponding settings in case a property is missing. Add relevant statements. Removed is also the requirement making the flash-max-microamp property

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

Hi Jacek, On 08/04/15 13:58, Jacek Anaszewski wrote: --- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt @@ -29,13 +29,15 @@ Optional properties for child nodes: ide-disk - LED indicates disk activity timer - LED

Re: [PATCH v1 09/11] DT: Add documentation for exynos4-is 'flashes' property

...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro...@samsung.com --- .../devicetree/bindings/media/samsung-fimc.txt |8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation

[GIT PULL] s5p-jpeg updates

Hi Mauro, The following changes since commit 8a56b6b5fd6ff92b7e27d870b803b11b751660c2: [media] v4l2-subdev: remove enum_framesizes/intervals (2015-03-23 12:02:41 -0700) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.1/media/next for you to fetch

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

On 23/03/15 16:59, Lee Jones wrote: On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 15:02:13, Lee Jones wrote: On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 12:07:43, Lee Jones wrote: This patch requires a DT Ack. No, it requires DT people to be

Re: [PATCH] v4l: mt9v032: Add OF support

On 09/03/15 12:29, Laurent Pinchart wrote: On Monday 09 March 2015 11:35:52 Sylwester Nawrocki wrote: On 08/03/15 14:45, Laurent Pinchart wrote: +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt @@ -0,0 +1,41 @@ +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor + +The Aptina

Re: [PATCH] v4l: mt9v032: Add OF support

Hi Sakari, On 09/03/15 11:57, Sakari Ailus wrote: +static struct mt9v032_platform_data * +mt9v032_get_pdata(struct i2c_client *client) +{ + struct mt9v032_platform_data *pdata; + struct v4l2_of_endpoint endpoint; + struct device_node *np; + struct property *prop; + + if

Re: [PATCH] v4l: mt9v032: Add OF support

Hi Laurent, On 08/03/15 14:45, Laurent Pinchart wrote: +++ b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt @@ -0,0 +1,41 @@ +* Aptina 1/3-Inch WVGA CMOS Digital Image Sensor + +The Aptina MT9V032 is a 1/3-inch CMOS active pixel digital image sensor with +an active array size of

Re: [PATCHv2 6/8] DocBook media: document the new 'which' field.

laurent.pinch...@ideasonboard.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 5/8] v4l2-subdev: add support for the new enum_frame_size 'which' field.

Verkuil hans.verk...@cisco.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com For s5c73m3: Acked-by: Sylwester Nawrocki s.nawro

Re: [PATCHv2 2/8] v4l2-subdev.h: add 'which' field for the enum structs

remains TRY (applications need to set reserved to 0). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sylwester

Re: [PATCHv2 1/8] v4l2-subdev: replace v4l2_subdev_fh by v4l2_subdev_pad_config

-subdev.h| 53 -- Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Sylwester Nawrocki Samsung RD Institute Poland -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCHv2 3/8] v4l2-subdev.c: add 'which' checks for enum ops.

...@gmail.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] s5p-jpeg: Fix possible NULL pointer dereference in s_fmt

Hi Jacek, On 28/11/14 14:10, Jacek Anaszewski wrote: Some formats are not supported in encoding or decoding mode for given type of buffer (e.g. V4L2_PIX_FMT_JPEG is supported on output buffer only while in decoding mode). Make S_FMT failing if not suitable format is found. Signed-off-by:

[GIT PULL] s5p fixes

Hi Mauro, Please pull the following s5p driver fixes. The following changes since commit ce037f19aaef992c634af653b17e61eee30a9404: [media] media: atmel-isi: increase the burst length to improve the performance (2015-03-02 13:27:11 -0300) are available in the git repository at:

Re: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function

Hi, On 17/12/14 07:22, Tony K Nadackal wrote: Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on software reset. These bits need to be cleared explicitly. Signed-off-by: Tony K Nadackal tony...@samsung.com --- This patch is created and tested on top of linux-next-20141210.

Re: [PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.

On 17/12/14 07:25, Tony K Nadackal wrote: In case of corrupt images, multiple interrupts may occur due to different error scenarios. Since we are removing the src and dest buffers in the first interrupt itself, crash occurs in the second error interrupts. Disable the global interrupt

<    1   2   3   4   5   6   7   8   9   10   >