Hi,
We've found a couple of issues in VSP1 driver. Each issue is described
in each patch. They can be applied separetely.
Takanari Hayama (2):
v4l: vsp1: Reset VSP1 RPF source address
v4l: vsp1: Always enable virtual RPF when BRU is in use
drivers/media/platform/vsp1/vsp1_rpf.c | 15
Source address of VSP1 RPF needs to be reset whenever crop offsets are
recalculated.
This correctly reflects a crop setting even VIDIOC_QBUF is called
before VIDIOIC_STREAMON is called.
Signed-off-by: Takanari Hayama t...@igel.co.jp
---
drivers/media/platform/vsp1/vsp1_rpf.c | 15
Regardless of a number of inputs, we should always enable virtual RPF
when BRU is used. This allows the case when there's only one input to
BRU, and a size of the input is smaller than a size of an output of BRU.
Signed-off-by: Takanari Hayama t...@igel.co.jp
---
drivers/media/platform/vsp1
Hi Geert,
On 11/26/14, 5:59 PM, Geert Uytterhoeven wrote:
Hi Hayama-san,
On Wed, Nov 26, 2014 at 7:19 AM, Takanari Hayama t...@igel.co.jp wrote:
@@ -179,6 +190,10 @@ static void rpf_vdev_queue(struct vsp1_video *video,
struct vsp1_video_buffer *buf
Hi Sergei,
On 11/26/14, 9:55 PM, Sergei Shtylyov wrote:
Hello.
On 11/26/2014 9:19 AM, Takanari Hayama wrote:
Regardless of a number of inputs, we should always enable virtual RPF
when BRU is used. This allows the case when there's only one input to
BRU, and a size of the input is smaller
Hi,
I've updated patches to reflect comments from Geert and Sergei.
Hope this version could be given a go.
Takanari Hayama (2):
v4l: vsp1: Reset VSP1 RPF source address
v4l: vsp1: Always enable virtual RPF when BRU is in use
drivers/media/platform/vsp1/vsp1_rpf.c | 15
Source address of VSP1 RPF needs to be reset whenever crop offsets are
recalculated.
This correctly reflects a crop setting even VIDIOC_QBUF is called
before VIDIOIC_STREAMON is called.
Signed-off-by: Takanari Hayama t...@igel.co.jp
---
drivers/media/platform/vsp1/vsp1_rpf.c | 15
Regardless of a number of inputs, we should always enable virtual RPF
when BRU is used. This allows the case when there's only one input to
BRU, and a size of the input is smaller than a size of an output of BRU.
Signed-off-by: Takanari Hayama t...@igel.co.jp
---
drivers/media/platform/vsp1
Hi Laurent,
Thank you for your comments.
On 11/28/14, 4:11 AM, Laurent Pinchart wrote:
Hi Hayama-san,
Thank you for the patch.
On Thursday 27 November 2014 10:25:01 Takanari Hayama wrote:
Source address of VSP1 RPF needs to be reset whenever crop offsets are
recalculated
Hi Laurent,
On 11/28/14, 5:03 AM, Laurent Pinchart wrote:
Hi Hayama-san,
Thank you for the patch.
On Thursday 27 November 2014 10:25:02 Takanari Hayama wrote:
Regardless of a number of inputs, we should always enable virtual RPF
when BRU is used. This allows the case when there's only
According to the spec, the minimum input pixel size for BRU is 1px,
not 4px.
Signed-off-by: Takanari Hayama t...@igel.co.jp
---
drivers/media/platform/vsp1/vsp1_bru.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_bru.c
b/drivers/media
11 matches
Mail list logo