Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Takashi Iwai
At Tue, 14 Dec 2010 14:31:55 +0100, Clemens Ladisch wrote: Should we have an AUDIO category ? Probably not, because there are combined audio/video jacks, any maybe other entities. Yes, nowadays HDMI / DP are pretty common, for example. Takashi -- To unsubscribe from this list: send the

Re: BUG at mm/mmap.c:2309 when cx18.ko and cx18-alsa.ko loaded

2011-03-07 Thread Takashi Iwai
At Fri, 04 Mar 2011 12:13:04 -0500, Andy Walls wrote: On Fri, 2011-03-04 at 10:50 -0500, Devin Heitmueller wrote: On Thu, Mar 3, 2011 at 9:06 PM, Andy Walls awa...@md.metrocast.net wrote: Hi, I got a BUG when loading the cx18.ko module (which in turn requests the cx18-alsa.ko

Re: [alsa-devel] radio-maestro broken (conflicts with snd-es1968)

2011-03-14 Thread Takashi Iwai
At Sat, 12 Mar 2011 19:19:00 +0100, Ondrej Zary wrote: Hello, the radio-maestro driver is badly broken. It's intended to drive the radio on MediaForte ESS Maestro-based sound cards with integrated radio (like SF64-PCE2-04). But it conflicts with snd_es1968, ALSA driver for the sound chip

Re: [alsa-devel] radio-maestro broken (conflicts with snd-es1968)

2011-03-14 Thread Takashi Iwai
At Sat, 12 Mar 2011 19:52:39 +0100, Hans Verkuil wrote: On Saturday, March 12, 2011 19:19:00 Ondrej Zary wrote: Hello, the radio-maestro driver is badly broken. It's intended to drive the radio on MediaForte ESS Maestro-based sound cards with integrated radio (like SF64-PCE2-04).

Re: [alsa-devel] radio-maestro broken (conflicts with snd-es1968)

2011-03-14 Thread Takashi Iwai
At Mon, 14 Mar 2011 11:28:01 +0100, Ondrej Zary wrote: On Monday 14 March 2011, Hans Verkuil wrote: At Sat, 12 Mar 2011 19:52:39 +0100, Hans Verkuil wrote: On Saturday, March 12, 2011 19:19:00 Ondrej Zary wrote: Hello, the radio-maestro driver is badly broken. It's intended

Re: [RFC PATCH 1/3] tea575x-tuner: various improvements

2011-03-21 Thread Takashi Iwai
At Sat, 19 Mar 2011 16:32:53 +0100, Ondrej Zary wrote: Improve tea575x-tuner with various good things from radio-maestro: - extend frequency range to 50-150MHz - fix querycap(): card name, CAP_RADIO - improve g_tuner(): CAP_STEREO, stereo and tuned indication - improve g_frequency(): tuner

Re: [RFC PATCH 4/3] remove radio-maestro

2011-03-23 Thread Takashi Iwai
At Tue, 22 Mar 2011 15:44:05 -0300, Mauro Carvalho Chehab wrote: Hi Takashi, Em 19-03-2011 13:23, Ondrej Zary escreveu: Remove broken radio-maestro driver as the radio functionality is now integrated in the es1968 driver. I prefer if you could also add it on your tree, as we want to

Re: [alsa-devel] [PATCH 1/3] tea575x: unify read/write functions

2011-05-10 Thread Takashi Iwai
At Mon, 9 May 2011 23:39:26 +0200, Ondrej Zary wrote: Implement generic read/write functions to access TEA575x tuners. They're now implemented 4 times (once in es1968 and 3 times in fm801). This also allows mute to work on all cards. Also improve tuner detection/initialization.

Re: [alsa-devel] fm801: implement TEA575x tuner autodetection

2011-05-11 Thread Takashi Iwai
At Tue, 10 May 2011 23:24:15 +0200, Ondrej Zary wrote: Autodetect TEA575x tuner connection type during init. This allows tuner to work out-of-the box. tea575x_tuner module parameter remains functional to force tuner type. Tested with SF256-PCP and SF64-PCR. Signed-off-by: Ondrej Zary

Re: [alsa-devel] [PATCH] fm801: clean-up radio-related Kconfig

2011-05-14 Thread Takashi Iwai
At Fri, 13 May 2011 20:26:38 +0200, Ondrej Zary wrote: Change the weird SND_FM801_TEA575X_BOOL define in Kconfig to SND_FM801_RADIO and remove TEA575X_RADIO define from fm801.c. Well, this config is used over years, and if it's about only renaming, it won't be worth enough. Removing

Re: [alsa-devel] [PATCH 1/3] tea575x: remove freq_fixup from struct

2011-05-14 Thread Takashi Iwai
At Thu, 12 May 2011 22:17:56 +0200, Ondrej Zary wrote: freq_fixup is a constant, no need to hold it in struct snd_tea575x and set in each driver. Signed-off-by: Ondrej Zary li...@rainbow-software.org Thanks, applied all three patches. Takashi ---

Re: [alsa-devel] [PATCH RFC] radio-sf16fmr2: convert to generic TEA575x interface

2011-05-14 Thread Takashi Iwai
At Sat, 14 May 2011 00:17:23 +0200, Ondrej Zary wrote: Hello, the SF16-FMR2 radio card is basically a TEA5757 tuner connected to ISA bus but the driver currently uses its own implementation. I converted the driver to use generic tea575x-tuner implementation (see patch below) and it works

Re: [PATCH v2] fm801: clean-up radio-related Kconfig

2011-05-15 Thread Takashi Iwai
At Sat, 14 May 2011 22:51:01 +0200, Ondrej Zary wrote: Remove TEA575X_RADIO define from fm801.c. Also update Kconfig help text to include all supported cards. Signed-off-by: Ondrej Zary li...@rainbow-software.org Thanks, applied now. Takashi --- linux-2.6.39-rc2-/sound/pci/Kconfig

Re: [alsa-devel] [PATCH v5] [resend] radio-sf16fmr2: convert to generic TEA575x interface

2011-05-26 Thread Takashi Iwai
that Mauro or Hans applies these through V4L tree. In that case, you can take my acks for both patches. Acked-by: Takashi Iwai ti...@suse.de Of if it's preferred through sound tree, I can take them later. thanks, Takashi Thanks, Mauro. Signed-off-by: Ondrej Zary li...@rainbow

Re: [alsa-devel] [PATCH] tea575x: allow multiple opens

2011-06-12 Thread Takashi Iwai
At Sat, 11 Jun 2011 15:36:39 +0200, Hans Verkuil wrote: On Saturday, June 11, 2011 15:28:59 Ondrej Zary wrote: Change locking to allow tea575x-radio device to be opened multiple times. Very nice! Signed-off-by: Hans Verkuil hverk...@xs4all.nl Hans, would you apply this and another one

Re: [alsa-devel] [PATCH] tea575x: allow multiple opens

2011-06-12 Thread Takashi Iwai
At Sun, 12 Jun 2011 19:48:47 +0200, Hans Verkuil wrote: On Sunday, June 12, 2011 18:52:56 Takashi Iwai wrote: At Sat, 11 Jun 2011 15:36:39 +0200, Hans Verkuil wrote: On Saturday, June 11, 2011 15:28:59 Ondrej Zary wrote: Change locking to allow tea575x-radio device to be opened

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Thu, 23 Jun 2011 15:47:50 +0100, Ralf Baechle wrote: A build with ISA ISA_DMA !ISA_DMA_API results in: CC sound/isa/es18xx.o sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’: sound/isa/es18xx.c:501:9: error: implicit declaration of function ‘snd_dma_program’

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Fri, 24 Jun 2011 12:16:08 +0100, Ralf Baechle wrote: On Fri, Jun 24, 2011 at 10:26:13AM +0200, Takashi Iwai wrote: Hrm... I still don't understand why ES18XX or others were selected at the first place. Isn't it covered by the conditional in sound/isa/Kconfig like below

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Fri, 24 Jun 2011 14:08:18 +0100, Ralf Baechle wrote: On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote: o The drivers/media/radio/Kconfig part should be applied for 3.0 and maybe -stable. Yes, this will be good. I just tested that segment only and it works

Re: [alsa-devel] [PATCH] MEDIA: Fix non-ISA_DMA_API link failure of sound code

2011-06-25 Thread Takashi Iwai
...@linux-mips.org Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi drivers/media/radio/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index e4c97fd..0aeed28 100644 --- a/drivers/media/radio

Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)

2011-08-06 Thread Takashi Iwai
At Fri, 5 Aug 2011 16:56:11 -0700, Randy Dunlap wrote: On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote: Hi all, [The kernel.org mirroring is running slowly today] Is media/radio/radio-sf16fmr2 an ISA driver or a PCI driver? ugh. Or is it an I2C driver? linux-next

Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)

2011-08-07 Thread Takashi Iwai
At Sat, 6 Aug 2011 09:50:04 -0700, Randy Dunlap wrote: On Sat, 06 Aug 2011 10:33:39 +0200 Takashi Iwai wrote: At Fri, 5 Aug 2011 16:56:11 -0700, Randy Dunlap wrote: On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote: Hi all, [The kernel.org mirroring

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-25 Thread Takashi Iwai
At Tue, 24 Nov 2009 22:12:36 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found on Miro PCM20 sound cards. This driver was removed around the 2.6.2x kernels because it relied on the removed OSS module. Now, it uses a

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-25 Thread Takashi Iwai
At Wed, 25 Nov 2009 10:13:53 +0100, I wrote: At Tue, 24 Nov 2009 22:12:36 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found on Miro PCM20 sound cards. This driver was removed around the 2.6.2x kernels because it

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-26 Thread Takashi Iwai
At Thu, 26 Nov 2009 13:50:17 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found on Miro PCM20 sound cards. This driver was removed around the 2.6.2x kernels because it relied on the removed OSS module. Now, it uses a

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-26 Thread Takashi Iwai
At Thu, 26 Nov 2009 18:38:27 +0100, Krzysztof Helt wrote: On Thu, 26 Nov 2009 16:43:15 +0100 Takashi Iwai ti...@suse.de wrote: At Thu, 26 Nov 2009 13:50:17 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-27 Thread Takashi Iwai
pointed by Takashi Iwai. Thanks, I merged now this to sound tree exceptionally since it's purely depends on snd-miro driver. Will appear in the next linux-next. Takashi drivers/media/radio/Kconfig | 18 +++ drivers/media/radio/Makefile |1 + drivers/media/radio

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread Takashi Iwai
At Sun, 13 Dec 2009 10:22:44 -0500, Devin Heitmueller wrote: On Sat, Dec 12, 2009 at 5:34 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi Devin, It is better to submit the RFC patches to alsa ML for they to take a look. Cheers, Mauro Is there something specific you

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-22 Thread Takashi Iwai
At Mon, 21 Dec 2009 12:30:48 -0500, Devin Heitmueller wrote: On Mon, Dec 21, 2009 at 12:21 PM, Takashi Iwai ti...@suse.de wrote: Just a very quick look through the files, here are some comments: - snd_card_free() can't be called with NULL, but the error path in  snd_cx18_init() may

Re: [PATCH v6] media: Add stk1160 new driver

2012-07-27 Thread Takashi Iwai
...@redhat.com Cc: Takashi Iwai ti...@suse.de Cc: Hans Verkuil hverk...@xs4all.nl Cc: Sylwester Nawrocki sylvester.nawro...@gmail.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- Here we are once again, As stk1160 allows communication with an ac97 codec chip, this driver

Re: [Ksummit-2012-discuss] [MINI SUMMIT] media mini-summit at KS/2012

2012-08-02 Thread Takashi Iwai
KS/LPC that work on those subsystems are welcome. The names that came up during our discussions for those panels are: Rob Clark rob.cl...@linaro.org (HDMI CEC, ALSA, ARM) Takashi Iwai ti...@suse.de (ALSA) Catalin Marinas catalin.mari...@arm.com (ARM) Mark Brown broo

Re: [PATCH 6/8] ALSA: ppc: keywest: Don't use i2c_client-driver

2013-09-30 Thread Takashi Iwai
Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi --- sound/ppc/keywest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c index 01aecc2..0d1c27e 100644 --- a/sound/ppc/keywest.c +++ b/sound/ppc/keywest.c @@ -65,7

Re: [PATCH][RESEND 6/8] ALSA: memalloc: use gen_pool_dma_alloc() to allocate iram buffer

2013-11-04 Thread Takashi Iwai
At Fri, 1 Nov 2013 19:48:19 +0800, Nicolin Chen wrote: Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by: Nicolin Chen b42...@freescale.com Acked-by: Takashi Iwai ti...@suse.de --- sound/core/memalloc.c | 6 +- 1 file changed, 1 insertion

Re: [patch] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-22 Thread Takashi Iwai
At Fri, 19 Mar 2010 14:49:57 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter erro...@gmail.com This should rather a string without spaces because this string is used as an identifier in

Re: [patch v2] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 08:43:47 -0700, Joe Perches wrote: On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL, the original code could cause a buffer overflow. In version 2, I used a better name that Takashi Iwai suggested. Perhaps it's

Re: [patch v2] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 19:54:30 +0300, Dan Carpenter wrote: On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: At Mon, 22 Mar 2010 08:43:47 -0700, Joe Perches wrote: On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL

Re: [patch v2] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-23 Thread Takashi Iwai
At Mon, 22 Mar 2010 18:39:09 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter erro...@gmail.com --- In version 2, I used a better name that Takashi Iwai suggested. Acked-by: Takashi Iwai

Re: [alsa-devel] NULL pointer dereference in ALSA triggered through saa7134-alsa

2009-08-10 Thread Takashi Iwai
At Mon, 10 Aug 2009 16:50:55 +0300, Ozan Çağlayan wrote: Hi, I've finally succesfully compiled and linked saa7134-alsa driver using an external alsa-driver and its Module.symvers file. Everything seems okay, no undefined symbol or something else: - An installed 2.6.30.4 kernel which

Re: [alsa-devel] NULL pointer dereference in ALSA triggered through saa7134-alsa

2009-08-10 Thread Takashi Iwai
At Mon, 10 Aug 2009 18:42:20 +0300, Ozan Çağlayan wrote: Takashi Iwai wrote: At Mon, 10 Aug 2009 16:50:55 +0300, Ozan Çağlayan wrote: Hi, I've finally succesfully compiled and linked saa7134-alsa driver using an external alsa-driver and its Module.symvers file. Everything seems

Re: [alsa-devel] NULL pointer dereference in ALSA triggered through saa7134-alsa

2009-08-10 Thread Takashi Iwai
At Mon, 10 Aug 2009 19:06:29 +0300, Ozan Çağlayan wrote: Takashi Iwai wrote: But /usr/include/sound isn't used for building kernel modules normally. Unless any hack is added, these files have to be installed to the kernel header directory. Ah you're right, I totally missed

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

2013-07-11 Thread Takashi Iwai
: Takashi Iwai ti...@suse.de Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei ming@canonical.com --- sound/usb/usx2y/usbusx2yaudio.c |4 1 file changed, 4 insertions(+) diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c index 4967fe9

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

2013-07-11 Thread Takashi Iwai
At Thu, 11 Jul 2013 22:13:35 +0800, Ming Lei wrote: On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai ti...@suse.de wrote: At Thu, 11 Jul 2013 17:08:30 +0400, Sergei Shtylyov wrote: On 11-07-2013 13:06, Ming Lei wrote: Complete() will be run with interrupt enabled, so change

Re: [alsa-devel] [PATCH 0/2] tea575x: Move from sound to media

2013-07-29 Thread Takashi Iwai
patches, Acked-by: Takashi Iwai ti...@suse.de Feel free to move them into media git tree for 3.12 kernel. thanks, Takashi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] [media] sound/pci/Kconfig: select RADIO_ADAPTERS if needed

2013-08-26 Thread Takashi Iwai
) That happens because a radio driver is selected, without selecting the RADIO_ADAPTERS menu. Reported-by: kbuild test robot fengguang...@intel.com Cc: Takashi Iwai ti...@suse.de Feel free to take my ACK, if any. Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi Signed-off-by: Mauro

[PATCH] [media] ivtv: Fix Oops when no firmware is loaded

2014-05-05 Thread Takashi Iwai
of this driver. Bugzilla: https://apibugzilla.novell.com/show_bug.cgi?id=875440 Cc: sta...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/media/pci/ivtv/ivtv-alsa-pcm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c b

[ANNOUNCE] Linux Audio Mini Summit 2014, Oct. 14, Düsseldorf, Germany

2014-09-05 Thread Takashi Iwai
Hi, like previous years, we're going to hold a meeting to discuss lowlevel audio on Linux. This time it's along with Linux Plumbers conference, but for avoiding the conflicts with other LPC mini conferences (including Media Mini-summit, of course :), it'll be held on Tuesday October 14, at the

Re: [PATCH v2 0/6] media token resource framework

2014-10-15 Thread Takashi Iwai
At Tue, 14 Oct 2014 08:58:36 -0600, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non-media sound drivers that control media hardware. The Media token resource is created at the main struct

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-15 Thread Takashi Iwai
At Tue, 14 Oct 2014 08:58:37 -0600, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non-media sound drivers that control media hardware. The Media token resource is created at the main struct

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-16 Thread Takashi Iwai
At Wed, 15 Oct 2014 18:53:28 -0600, Shuah Khan wrote: On 10/15/2014 11:05 AM, Takashi Iwai wrote: +#if defined(CONFIG_MEDIA_SUPPORT) +extern int media_tknres_create(struct device *dev); +extern int media_tknres_destroy(struct device *dev); + +extern int media_get_tuner_tkn(struct

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-16 Thread Takashi Iwai
At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: On 10/14/2014 04:58 PM, Shuah Khan wrote: [...] switch (cmd) { case SNDRV_PCM_TRIGGER_START: +err = media_get_audio_tkn(subs-dev-dev); +if (err ==

Re: [PATCH v2 0/6] media token resource framework

2014-10-16 Thread Takashi Iwai
At Wed, 15 Oct 2014 14:21:34 -0600, Shuah Khan wrote: On 10/15/2014 10:48 AM, Takashi Iwai wrote: At Tue, 14 Oct 2014 08:58:36 -0600, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers and non

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-16 Thread Takashi Iwai
At Thu, 16 Oct 2014 08:10:52 -0600, Shuah Khan wrote: On 10/16/2014 08:01 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: On 10/14/2014 04:58 PM, Shuah Khan wrote: [...] switch (cmd

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-16 Thread Takashi Iwai
At Thu, 16 Oct 2014 08:39:14 -0600, Shuah Khan wrote: On 10/16/2014 08:16 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:10:52 -0600, Shuah Khan wrote: On 10/16/2014 08:01 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: On 10/16/2014 06:00 AM, Lars

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-19 Thread Takashi Iwai
At Sat, 18 Oct 2014 20:49:58 +0200, Mauro Carvalho Chehab wrote: Em Thu, 16 Oct 2014 08:59:29 -0600 Shuah Khan shua...@osg.samsung.com escreveu: On 10/16/2014 08:48 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:39:14 -0600, Shuah Khan wrote: On 10/16/2014 08:16 AM, Takashi

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-21 Thread Takashi Iwai
At Tue, 21 Oct 2014 12:46:03 +0200, Hans Verkuil wrote: Hi Shuah, As promised, here is my review for this patch series. On 10/14/2014 04:58 PM, Shuah Khan wrote: Add media token device resource framework to allow sharing resources such as tuner, dma, audio etc. across media drivers

Re: [PATCH v2 1/6] media: add media token device resource framework

2014-10-21 Thread Takashi Iwai
At Tue, 21 Oct 2014 13:58:59 +0200, Hans Verkuil wrote: On 10/21/2014 01:51 PM, Takashi Iwai wrote: At Tue, 21 Oct 2014 12:46:03 +0200, Hans Verkuil wrote: Hi Shuah, As promised, here is my review for this patch series. On 10/14/2014 04:58 PM, Shuah Khan wrote: Add media

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-21 Thread Takashi Iwai
At Tue, 21 Oct 2014 17:42:51 +0200, Hans Verkuil wrote: On 10/16/2014 04:48 PM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:39:14 -0600, Shuah Khan wrote: On 10/16/2014 08:16 AM, Takashi Iwai wrote: At Thu, 16 Oct 2014 08:10:52 -0600, Shuah Khan wrote: On 10/16/2014 08:01 AM

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-21 Thread Takashi Iwai
At Tue, 21 Oct 2014 12:08:59 -0400, Devin Heitmueller wrote: Sorry, I'm not convinced by that. If the device has to be controlled exclusively, the right position is the open/close. Otherwise, the program cannot know when it becomes inaccessible out of sudden during its operation. I

[PATCH] DocBook: Reduce noise from make cleandocs

2014-10-21 Thread Takashi Iwai
I've got a harmless warning when running make cleandocs on an already cleaned tree: Documentation/DocBook/media/Makefile:28: recipe for target 'cleanmediadocs' failed make[1]: [cleanmediadocs] Error 1 (ignored) Suppress this by passing -f to rm. Signed-off-by: Takashi Iwai ti...@suse.de

[PATCH] [media] uvc: Fix destruction order in uvc_delete()

2014-10-24 Thread Takashi Iwai
orders in uvc_delete() so that the child is removed before the parent. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=897736 Reported-and-tested-by: Martin Pluskal mplus...@suse.com Cc: sta...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/media/usb/uvc/uvc_driver.c | 6

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-26 Thread Takashi Iwai
At Sat, 25 Oct 2014 11:41:15 -0200, Mauro Carvalho Chehab wrote: (re-sending from my third e-mail - somehow, the two emails I have at Samsung didn't seem to be delivering to vger.kernel.org today) Em Wed, 22 Oct 2014 14:26:41 -0500 Pierre-Louis Bossart pierre-louis.boss...@linux.intel.com

Re: [PATCH 1/2] [media] sound: simplify au0828 quirk table

2014-10-30 Thread Takashi Iwai
At Thu, 30 Oct 2014 08:53:04 -0200, Mauro Carvalho Chehab wrote: From: Mauro Carvalho Chehab m.che...@samsung.com Add a macro to simplify au0828 quirk table. That makes easier to check it against the USB IDs at drivers/media/usb/au0828-card.c Cc: sta...@vger.kernel.org Signed-off-by:

Re: DVB suspend/resume regression on 3.19

2015-02-16 Thread Takashi Iwai
At Fri, 13 Feb 2015 16:12:40 +0100, Takashi Iwai wrote: At Fri, 13 Feb 2015 12:41:25 -0200, Mauro Carvalho Chehab wrote: Em Fri, 13 Feb 2015 15:02:42 +0100 Takashi Iwai ti...@suse.de escreveu: At Mon, 09 Feb 2015 11:59:07 +0100, Takashi Iwai wrote: Hi, we've

Re: DVB suspend/resume regression on 3.19

2015-02-13 Thread Takashi Iwai
At Mon, 09 Feb 2015 11:59:07 +0100, Takashi Iwai wrote: Hi, we've got a bug report about the suspend/resume regression of DVB device with 3.19. The symptom is VLC doesn't work after S3 or S4 resume. strace shows that /dev/dvb/adaptor0/dvr returns -ENODEV. The reporter confirmed

Re: DVB suspend/resume regression on 3.19

2015-02-13 Thread Takashi Iwai
At Fri, 13 Feb 2015 12:41:25 -0200, Mauro Carvalho Chehab wrote: Em Fri, 13 Feb 2015 15:02:42 +0100 Takashi Iwai ti...@suse.de escreveu: At Mon, 09 Feb 2015 11:59:07 +0100, Takashi Iwai wrote: Hi, we've got a bug report about the suspend/resume regression of DVB device

DVB suspend/resume regression on 3.19

2015-02-09 Thread Takashi Iwai
Hi, we've got a bug report about the suspend/resume regression of DVB device with 3.19. The symptom is VLC doesn't work after S3 or S4 resume. strace shows that /dev/dvb/adaptor0/dvr returns -ENODEV. The reporter confirmed that 3.18 works fine, so the regression must be in 3.19. There is a

Re: [PATCH 2/2] sound/usb: Update ALSA driver to use media controller API

2015-05-27 Thread Takashi Iwai
At Fri, 8 May 2015 13:31:31 -0600, Shuah Khan wrote: Change ALSA driver to use media controller API to share tuner with DVB and V4L2 drivers that control AU0828 media device. Media device is created based on a newly added field value in the struct snd_usb_audio_quirk. Using this approach,

Re: [PATCH 7/7] sound/usb: Update ALSA driver to use Managed Media Controller API

2015-07-20 Thread Takashi Iwai
On Mon, 20 Jul 2015 10:47:46 +0200, Dan Carpenter wrote: On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote: + ret = media_entity_setup_link(link, flags); + if (ret) { + dev_err(mctl-media_dev-dev, + Couldn't change

Re: [PATCH MC Next Gen v2 2/3] sound/usb: Create media mixer function and control interface entities

2015-10-22 Thread Takashi Iwai
On Wed, 21 Oct 2015 01:25:15 +0200, Shuah Khan wrote: > > Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for > each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface > entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL > entity corresponds to the control device for the

Re: [PATCH MC Next Gen v2 2/3] sound/usb: Create media mixer function and control interface entities

2015-11-03 Thread Takashi Iwai
On Tue, 03 Nov 2015 17:06:45 +0100, Shuah Khan wrote: > > On 10/25/2015 03:37 PM, Shuah Khan wrote: > > On 10/22/2015 01:16 AM, Takashi Iwai wrote: > >> On Wed, 21 Oct 2015 01:25:15 +0200, > >> Shuah Khan wrote: > >>> > >>> Add support for

[PATCH] [media] c8sectpfe: Remove select on CONFIG_FW_LOADER_USER_HELPER_FALLBACK

2015-10-19 Thread Takashi Iwai
selects by itself. Let's remove it. Fixes: 850a3f7d5911 ('[media] c8sectpfe: Add Kconfig and Makefile for the driver') Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/media/platform/sti/c8sectpfe/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platfo

Re: Linux 4.2 ALSA snd-usb-audio inconsistent lock state warn in PCM nonatomic mode

2015-08-31 Thread Takashi Iwai
On Tue, 01 Sep 2015 00:48:30 +0200, Shuah Khan wrote: > > Hi Takashi, > > I am seeing the following inconsistent lock state warning when PCM > is run in nonatomic mode. This is on 4.2.0 and with the following > change to force PCM on nonatomic mode: > > diff --git a/sound/usb/stream.c

Re: [alsa-devel] [PATCH MC Next Gen] sound/usb: Fix out of bounds access in media_entity_init()

2015-12-07 Thread Takashi Iwai
On Sat, 05 Dec 2015 01:00:29 +0100, Shuah Khan wrote: > > Fix the out of bounds access in media_entity_init() found > by KASan. This is a result of media_mixer_init() failing > to allocate memory for all 3 of its pads before calling > media_entity_init(). Fix it to allocate memory for the > right

Re: [PATCH 26/31] sound/usb: Update ALSA driver to use Managed Media Controller API

2016-01-07 Thread Takashi Iwai
On Wed, 06 Jan 2016 22:05:35 +0100, Shuah Khan wrote: > > diff --git a/sound/usb/Makefile b/sound/usb/Makefile > index 2d2d122..665fdd9 100644 > --- a/sound/usb/Makefile > +++ b/sound/usb/Makefile > @@ -2,6 +2,18 @@ > # Makefile for ALSA > # > > +# Media Controller > +ifeq

Re: [PATCH] media, sound: tea575x: constify snd_tea575x_ops structures

2015-11-22 Thread Takashi Iwai
On Sun, 22 Nov 2015 11:32:53 +0100, Julia Lawall wrote: > > The snd_tea575x_ops structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Reviewed-by: Takashi Iwai <ti.

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-20 Thread Takashi Iwai
On Mon, 20 Jun 2016 17:21:26 +0200, Richard Cochran wrote: > > On Mon, Jun 20, 2016 at 02:31:48PM +0200, Richard Cochran wrote: > > Where is this "audio_time" program of which you speak? > > Never mind, found it in alsa-lib. > > I still would appreciate an answer to my other questions,

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-21 Thread Takashi Iwai
On Tue, 21 Jun 2016 08:38:57 +0200, Richard Cochran wrote: > > On Tue, Jun 21, 2016 at 07:54:32AM +0200, Takashi Iwai wrote: > > > I still would appreciate an answer to my other questions, though... > > > > Currently HD-audio (both ASoC and legacy ones) are the

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Takashi Iwai
On Mon, 14 Mar 2016 11:13:58 +0100, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 09:22:37 +0200 > Sakari Ailus escreveu: > > > Hi Shuah, > > > > On Sat, Mar 12, 2016 at 06:48:09PM -0700, Shuah Khan wrote: > > > Add GFP flags to media_create_pad_link(),

Re: [RFC PATCH v2 0/5] Media Device Allocator API

2016-04-05 Thread Takashi Iwai
On Tue, 05 Apr 2016 05:35:55 +0200, Shuah Khan wrote: > > There are known problems with media device life time management. When media > device is released while an media ioctl is in progress, ioctls fail with > use-after-free errors and kernel hangs in some cases. > > Media Device can be in any

Re: [alsa-devel] [PATCH] sound/usb: Fix memory leak in media_snd_stream_delete() during unbind

2016-03-19 Thread Takashi Iwai
unpoison_shadow+0x36/0x50 > [ 1445.086890] [] ? kasan_unpoison_shadow+0x36/0x50 > [ 1445.086895] [] ? kasan_kmalloc+0x5e/0x70 > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Mauro, please take it through your tree. Acked-by: Takashi Iwai <ti...@suse.de> thanks, Ta

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

2016-09-10 Thread Takashi Iwai
On Sat, 10 Sep 2016 06:50:14 +0200, Takashi Sakamoto wrote: > > Hi, > > Currently, TLV related protocol is not shared to user land. This is not > good in a point of application interfaces, because application developers > can't realize the protocol just to see UAPI headers. > > For this

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

2016-09-10 Thread Takashi Iwai
On Sat, 10 Sep 2016 09:25:31 +0200, Takashi Sakamoto wrote: > > On Sep 10 2016 15:44, Takashi Iwai wrote: > > On Sat, 10 Sep 2016 06:50:14 +0200, > > Takashi Sakamoto wrote: > >> > >> Hi, > >> > >> Currently, TLV related protocol is not

Re: [RFC][PATCH 0/2] ALSA: control: export all of TLV related macros to user land

2016-09-11 Thread Takashi Iwai
On Sun, 11 Sep 2016 05:06:41 +0200, Takashi Sakamoto wrote: > > On Sep 10 2016 22:41, Takashi Iwai wrote: > > On Sat, 10 Sep 2016 09:25:31 +0200, > > Takashi Sakamoto wrote: > >> > >> On Sep 10 2016 15:44, Takashi Iwai wrote: > >>> On Sat, 10 Sep 2

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

2016-12-06 Thread Takashi Iwai
On Tue, 06 Dec 2016 19:41:37 +0100, Shuah Khan wrote: > > Hi Takashi, > > On 12/05/2016 11:50 PM, Takashi Iwai wrote: > > On Wed, 30 Nov 2016 23:01:16 +0100, > > Shuah Khan wrote: > >> > >> --- a/sound/usb/card.c > >> +++ b/sound/usb/car

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

2016-12-05 Thread Takashi Iwai
On Wed, 30 Nov 2016 23:01:16 +0100, Shuah Khan wrote: > > --- a/sound/usb/card.c > +++ b/sound/usb/card.c (snip) > @@ -616,6 +617,11 @@ static int usb_audio_probe(struct usb_interface *intf, > if (err < 0) > goto __error; > > + if (quirk && quirk->media_device) { > +

Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

2016-12-05 Thread Takashi Iwai
On Mon, 05 Dec 2016 23:44:30 +0100, Shuah Khan wrote: > > On 11/30/2016 03:01 PM, Shuah Khan wrote: > > Change ALSA driver to use Media Controller API to share media resources > > with DVB, and V4L2 drivers on a AU0828 media device. > > > > Media Controller specific initialization is done after

Re: [alsa-devel] [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk

2017-06-01 Thread Takashi Iwai
On Thu, 01 Jun 2017 22:58:24 +0200, Takashi Iwai wrote: > > The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk > for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec > quirk for a MSI mobo. But it turned out that this isn't applied > properly

[PATCH v2 07/27] ALSA: rme32: Convert to the new PCM copy ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new ops. The conversion is straightforward with standard helper functions, and now we can drop the bytes <-> frames conversions in callbacks. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/

[PATCH v2 08/27] ALSA: rme96: Convert to the new PCM ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new PCM ops. The conversion is straightforward with standard helper functions, and now we can drop the bytes <-> frames conversions in callbacks. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/

[PATCH v2 04/27] ALSA: es1938: Convert to the new PCM copy ops

2017-06-01 Thread Takashi Iwai
Replace the copy ops with the new copy_user and copy_kernel ops. It's used only for a capture stream (for some hardware workaround), thus we need no silence operation. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/pci/es1938.c | 33 + 1 file chang

[PATCH v2 12/27] ALSA: sb: Convert to the new PCM ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new PCM ops. For avoiding the code redundancy, slightly hackish macros are introduced. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/isa/sb/emu8000_pcm.c | 190 ++--- 1 file changed, 109 inse

[PATCH v2 19/27] ALSA: pcm: Call directly the common read/write helpers

2017-06-01 Thread Takashi Iwai
Make snd_pcm_lib_read() and *_write() static inline functions that call the common helper functions directly. This reduces a slight amount of codes, and at the same time, it's a preparation for the further cleanups / fixes. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound

[PATCH v2 14/27] ASoC: blackfin: Convert to the new PCM ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new PCM ops. In AC97 and I2S-TDM mode, we need to convert back to frames, but otherwise the conversion is pretty straightforward. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/soc/blackfin/bf5xx-ac97-pcm.

[PATCH v2 13/27] ALSA: sh: Convert to the new PCM ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new PCM ops. Fixed also the user-space buffer copy with the proper copy_from_user*() variant. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/sh/sh_dac_audio.c | 54 +++-- 1 file chang

[PATCH v2 11/27] ALSA: gus: Convert to the new PCM ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new PCM ops. For simplifying the code a bit, two local helpers are introduced here: get_bpos() and playback_copy_ack(). Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/isa/gus/gus_pcm.c | 97 ++

[PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support

2017-06-01 Thread Takashi Iwai
. I'm Cc'ing the media and the USB people since it touches solo6x10 and usb-gadget drivers. The previous ACK was dropped as each patch was rewritten again. Sorry for the doubly patch-review labours. thanks, Takashi === Takashi Iwai (26): ALSA: pcm: Introduce copy_user, copy_kernel

[PATCH v2 15/27] [media] solo6x10: Convert to the new PCM ops

2017-06-01 Thread Takashi Iwai
Replace the copy and the silence ops with the new PCM ops. The device supports only 1 channel and 8bit sample, so it's always bytes=frames, and we need no conversion of unit in the callback. Also, it's a capture stream, thus no silence is needed. Signed-off-by: Takashi Iwai <ti...@suse

[PATCH v2 17/27] ALSA: pcm: Check PCM state by a common helper function

2017-06-01 Thread Takashi Iwai
Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/core/pcm_lib.c | 81 +++- 1 file changed, 29 insertions(+), 52 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 0db8d4e0fca2..e4f5c43b6448 100644 --- a/soun

[PATCH v2 03/27] ALSA: dummy: Convert to new PCM copy ops

2017-06-01 Thread Takashi Iwai
It's a dummy ops, so just replacing it. Signed-off-by: Takashi Iwai <ti...@suse.de> --- sound/drivers/dummy.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 172dacd925f5..dd5ed037adf2

[PATCH v2 16/27] ALSA: pcm: Drop the old copy and silence ops

2017-06-01 Thread Takashi Iwai
Now that all users of old copy and silence ops have been converted to the new PCM ops, the old stuff can be retired and go away. Signed-off-by: Takashi Iwai <ti...@suse.de> --- include/sound/pcm.h | 5 - sound/core/pcm_lib.c | 38 +- sound/soc/soc

  1   2   >