Re: [Linux-kernel] [PATCH 03/13] media: adv7604: fix probe of ADV7611/7612

2015-07-24 Thread Ben Dooks
the Signed-off-by: line here. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v6 3/6] rcar_vin: add devicetree support

2014-07-25 Thread Ben Dooks
On 23/07/14 19:23, Guennadi Liakhovetski wrote: Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk [g.liakhovet...@gmx.de fix a typo, sort headers alphabetically] Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Ben

Re: [Linux-kernel] [PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues.

2014-07-07 Thread Ben Dooks
the original authors as well as the linux-sh list and possibly Magnus and Horms. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-media

rcar-vin soc-camera device tree updates

2014-07-05 Thread Ben Dooks
This is a new patch, with most of the issues from the previous reviews now fixed. If there is anything that I have missed then please let me know. The only issues remaining is what to do about multiple subdevices and/or multiple ports on drivers. I have yet to do either of erroring out or

[PATCH 1/6] adv7180: Remove duplicate unregister call

2014-07-05 Thread Ben Dooks
From: Ian Molton ian.mol...@codethink.co.uk This driver moved over to v4l2_async_unregister_subdev() but still retained a call to v4l2_unregister_subdev(). Remove. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media/i2c

[PATCH 2/6] rcar_vin: copy flags from pdata

2014-07-05 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media

[PATCH 4/6] [V3] soc_camera: add support for dt binding soc_camera drivers

2014-07-05 Thread Ben Dooks
been tested on the Renesas Lager board. It currently only supports one input device per driver as this seems to be the standard connection for these devices. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Fixes since v1: - Fix i2c mclk name compatible with other drivers

[PATCH 6/6] [PATCH v2] ARM: lager: add vin1 node

2014-07-05 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Fixes since v1: - Whitespace fixes as suggested by Sergei --- arch/arm/boot/dts/r8a7790-lager.dts | 36 1 file changed, 36

[PATCH 5/6] r8a7790.dtsi: add vin[0-3] nodes

2014-07-05 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790

[PATCH 3/6] rcar_vin: add devicetree support

2014-07-05 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- .../devicetree/bindings/media/rcar_vin.txt | 86 ++ drivers/media/platform/soc_camera/rcar_vin.c | 72 -- 2 files changed, 151

Re: [PATCH 7/9] soc_camera: add support for dt binding soc_camera drivers

2014-06-23 Thread Ben Dooks
On 19/06/14 08:28, Guennadi Liakhovetski wrote: Hi Ben, Thanks for an update. On Sun, 15 Jun 2014, Ben Dooks wrote: Add initial support for OF based soc-camera devices that may be used by any of the soc-camera drivers. The driver itself will need converting to use OF. These changes

[PATCH 1/2] r8a7790.dtsi: add vin[0-3] nodes

2014-06-23 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790

resend: device tree updates for r8a7790 vin

2014-06-23 Thread Ben Dooks
I've gone through and hopefully cleaned up Sergei's issues. Is there any chance Simon could queue these in his tree? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 2/2] [PATCH v2] ARM: lager: add vin1 node

2014-06-23 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Fixes since v1: - Whitespace fixes as suggested by Sergei --- arch/arm/boot/dts/r8a7790-lager.dts | 36 1 file changed, 36

Re: [PATCH 2/9] ARM: lager: add i2c1, i2c2 pins

2014-06-18 Thread Ben Dooks
On 16/06/14 13:33, Sergei Shtylyov wrote: Hello. On 06/15/2014 11:56 PM, Ben Dooks wrote: Add pinctrl definitions for i2c1 and i2c2 busses on the Lager board to ensure these are setup correctly at initialisation time. The i2c0 and i2c3 busses are connected to single function pins

Re: soc_camera and device-tree

2014-06-15 Thread Ben Dooks
. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH 2/9] ARM: lager: add i2c1, i2c2 pins

2014-06-15 Thread Ben Dooks
Add pinctrl definitions for i2c1 and i2c2 busses on the Lager board to ensure these are setup correctly at initialisation time. The i2c0 and i2c3 busses are connected to single function pins. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790-lager.dts | 14

[PATCH 1/9] ARM: lager: enable i2c devices

2014-06-15 Thread Ben Dooks
Add i2c0, i2c1, i2c2 and i2c3 nodes to the Lager reference device tree as these busses all have devices on them that can be probed even if they are no drivers yet. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790-lager.dts | 16 1 file changed, 16

[PATCH 4/9] adv7180: add of match table

2014-06-15 Thread Ben Dooks
Add a proper of match id for use when the device is being bound via device tree, to avoid having to use the i2c old-style binding of the device. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Since original submission: - Fixed of_match_table typo --- drivers/media/i2c/adv7180.c

RFC: new soc_camera/rcar_vin patch series

2014-06-15 Thread Ben Dooks
This is a new series for the rcar_vin and soc_camera layer to support using OF. It should incorporate most of the feedback from the previous series, but please let me know if there's anything missed. As a note, we have skipped over multiple eps for this release as there are few scenarios for the

[PATCH 6/9] rcar_vin: add devicetree support

2014-06-15 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- .../devicetree/bindings/media/rcar_vin.txt | 86 ++ drivers/media/platform/soc_camera/rcar_vin.c | 72 -- 2 files changed, 151

[PATCH 3/9] adv7180: Remove duplicate unregister call

2014-06-15 Thread Ben Dooks
From: Ian Molton ian.mol...@codethink.co.uk This driver moved over to v4l2_async_unregister_subdev() but still retained a call to v4l2_unregister_subdev(). Remove. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media/i2c

[PATCH 5/9] rcar_vin: copy flags from pdata

2014-06-15 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media

[PATCH 7/9] soc_camera: add support for dt binding soc_camera drivers

2014-06-15 Thread Ben Dooks
been tested on the Renesas Lager board. It currently only supports one input device per driver as this seems to be the standard connection for these devices. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Fixes since v1: - Fix i2c mclk name compatible with other drivers

[PATCH 9/9] ARM: lager: add vin1 node

2014-06-15 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790-lager.dts | 38 + 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm

[PATCH 8/9] r8a7790.dtsi: add vin[0-3] nodes

2014-06-15 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790

Re: soc_camera and device-tree

2014-06-15 Thread Ben Dooks
soc_camera. And I don't have a clear idea on how it should be done. New series is on the list. Let me know if there are any issues. I am pushing the series up to git.codethink.co.uk. http://git.codethink.co.uk/linux.git bjdooks/v315/vin-of -- Ben Dooks http

Re: [Linux-kernel] RFC: new soc_camera/rcar_vin patch series

2014-06-15 Thread Ben Dooks
On 15/06/14 20:56, Ben Dooks wrote: This is a new series for the rcar_vin and soc_camera layer to support using OF. It should incorporate most of the feedback from the previous series, but please let me know if there's anything missed. As a note, we have skipped over multiple eps

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Ben Dooks
On 05/06/14 13:55, Mauro Carvalho Chehab wrote: Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media topic/adv76xx For adv7604 driver updates, including DT support. Can we use the adv7611 for the adv7612 with these? -- Ben Dooks

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Ben Dooks
On 06/06/14 16:51, Lars-Peter Clausen wrote: On 06/06/2014 05:49 PM, Ben Dooks wrote: On 05/06/14 13:55, Mauro Carvalho Chehab wrote: Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media topic/adv76xx For adv7604 driver updates, including DT

Re: [PATCH v2 48/48] adv7604: Add endpoint properties to DT bindings

2014-04-17 Thread Ben Dooks
and will be unusable. I will document ports node usage though, that's currently missing in the DT bindings documentation. Doesn't the v4l2 helper code have standard parsing for the endpoint sync configurations? -- Ben Dooks http://www.codethink.co.uk/ Senior

Re: [v2] media: soc-camera: OF cameras

2014-04-14 Thread Ben Dooks
OF patches to compare them and compare them with my early code (hopefully this coming weekend), but so far it looks like only Ben's solution has a complete working stack. Am I missing something? My bad. I missed the conversation and patches from Ben Dooks and you guys. I have no problem for merging

Re: [v2] media: soc-camera: OF cameras

2014-04-11 Thread Ben Dooks
this coming weekend), but so far it looks like only Ben's solution has a complete working stack. Am I missing something? I am looking in to fix the comments from Josh to get the atmel to work and hope to have them out this weekend. -- Ben Dooks http

Re: [RFCv3,3/3] soc_camera: initial of code

2014-04-01 Thread Ben Dooks
On 01/04/14 07:39, Josh Wu wrote: Hi, Ben On 3/31/2014 6:10 PM, Ben Dooks wrote: On 31/03/14 10:28, Josh Wu wrote: Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the mclk registered in soc-camera driver cannot be find by the soc-camera sensors. See comment

Re: [RFCv3,3/3] soc_camera: initial of code

2014-03-31 Thread Ben Dooks
and be handled by the clk system instead. [snip] -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
probe, it is just the soc_camera that needs sorting. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[RFC 1/3] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media

[RFC 3/3] soc_camera: initial of code

2014-03-30 Thread Ben Dooks
been tested on the Renesas Lager board. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media/platform/soc_camera/soc_camera.c | 111 - 1 file changed, 110 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media

[RFC 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -- 2 files changed, 140

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:17, Guennadi Liakhovetski wrote: On Sun, 30 Mar 2014, Ben Dooks wrote: On 30/03/14 22:04, Guennadi Liakhovetski wrote: Hi Ben, Since I never received a reply to this my query, I consider this your patch series suspended. Thanks Guennadi I meant to send out a patch series

Re: [RFC 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:26, Ben Dooks wrote: Add support for devicetree probe for the rcar-vin driver. Sorry, this was an older branch and needed a fix for the pdev-id field. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink

[RFCv2] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media

[RFCv3 1/3] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media

[RFCv3 3/3] soc_camera: initial of code

2014-03-30 Thread Ben Dooks
been tested on the Renesas Lager board. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media/platform/soc_camera/soc_camera.c | 111 - 1 file changed, 110 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media

[RFCv3 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Changes since v1: - fix pdev-id handling via usage of alias property Changes since v2: - fix documentation for v1 updates --- .../devicetree/bindings/media

Re: [PATCH v2] media: soc-camera: OF cameras

2014-03-07 Thread Ben Dooks
to the previous, in the use-case we have the device that we link to the soc_camera is /not/ an soc-camera, it is a standard v4l2 subdev device (adv7180). -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius

[PATCH 5/5] rcar_vin: add devicetree support

2014-03-07 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -- 2 files changed, 140

[PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- arch/arm/boot/dts/r8a7790.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi

[PATCH 4/5] rcar_vin: copy flags from pdata

2014-03-07 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/media

soc_camera rcar_vin support for device-tree binding

2014-03-07 Thread Ben Dooks
This is a series of patches to get towards the point the renesas rcar_vin driver can be bound via device-tree. Patches 1 and 2 add the device tree nodes, patch 3 is one which has been in my tree for a while and the last two modify the rcar_vin driver. -- To unsubscribe from this list: send the

Re: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Ben Dooks
On 07/03/14 16:45, Sergei Shtylyov wrote: Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk This patch should have been preceded by the VIN driver patch and bindings

Re: [PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Ben Dooks
On 07/03/14 16:50, Sergei Shtylyov wrote: Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk This patch should have been preceded by the VIN driver patch and bindings

Re: How to efficiently handle DMA and cache on ARMv7 ? (was Is get_user_pages() enough to prevent pages from being swapped out ?)

2009-08-06 Thread Ben Dooks
On Thu, Aug 06, 2009 at 12:08:21PM +0200, Laurent Pinchart wrote: [Resent with an updated subject, this time CC'ing linux-arm-kernel] I've spent the last few days playing with get_user_pages() and mlock() and got some interesting results. It turned out that cache coherency comes into play