Re: [PATCH] [media] coda: drop dma_sync_single_for_device in coda_bitstream_queue

2015-03-27 Thread Ian Molton
...@pengutronix.de Tested-by: Ian Molton imol...@ad-holdings.co.uk --- drivers/media/platform/coda/coda-bit.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index d39789d..d336cb6 100644 --- a/drivers/media/platform/coda

Scaling and rounding issues

2015-03-24 Thread Ian Molton
Hi folks, I've been discussing some issues with the CODA driver on gstreamer-devel and the thread seems better suited to this list; Here's a copy of what's been said thus far: I wrote: I've located the cause of the giant oops I noted a couple of days ago. because

Re: [PATCH 2/2] media: adv7604: Add ability to read default input port from DT

2014-08-13 Thread Ian Molton
, 0-1 for 7612, I expect there are other chips in the family with differing numbers of inputs. +if (!of_property_read_u32(endpoint, default_input, v)) This doesn't match the binding ('_' vs '-'). Good catch! -- Ian Molton ian.mol...@codethink.co.uk -- To unsubscribe from this list: send

Re: [PATCH 2/4] media: rcar_vin: Ensure all in-flight buffers are returned to error state before stopping.

2014-08-13 Thread Ian Molton
Fixed kernel WARNINGs for me! \o/ Ian, perhaps it makes sense for me to take these patches into my hands? I'm planning to respin these tomorrow - is that OK? I have test hardware with two different frontends here. -Ian -- To unsubscribe from this list: send the line unsubscribe

rcar_vin: rcar_vin_get_formats()

2014-08-12 Thread Ian Molton
of formats, to allow the 7180 driver to select a YUV mode?? but I cant for the life of me understand what. I'm fairly new to v4l2, so I dont really know whats legit and what isnt. particularly, the code appears to abuse one code to provide several (incompatible?) formats. Help? -- Ian Molton

Re: [PATCH 3/4] media: rcar_vin: Fix race condition terminating stream

2014-08-11 Thread Ian Molton
) if (vq-bufs[i]-state == VB2_BUF_STATE_ACTIVE) vb2_buffer_done(vq-bufs[i], VB2_BUF_STATE_ERROR); list_for_each_safe(buf_head, tmp, priv-capture) list_del_init(buf_head); + spin_unlock_irq(priv-lock); } -- Ian Molton

[PATCH 0/1 v1] adv7604: Add adv7612 support

2014-08-11 Thread Ian Molton
This small patch series adds initial support for the adv7612 dual HDMI input decoder chip and adds a device-tree option allowing the default input to be selected. Please review / apply, -Ian -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

[PATCH 2/2] media: adv7604: Add ability to read default input port from DT

2014-08-11 Thread Ian Molton
This patch adds support to the adv7604 driver for reading the default selected input from the Device tree. If none is provided, the driver will not select an input without help from userspace. Tested-by: William Towle william.to...@codethink.co.uk Signed-off-by: Ian Molton ian.mol

[PATCH 1/2] media: adv7604: Add support for ADV7612 dual HDMI input decoder.

2014-08-11 Thread Ian Molton
This patch adds necessary support for the ADV7612 dual HDMI decoder / repeater chip. This was tested using a heavily modified rcar_vin/soc_camera capture driver. Tested-by: William Towle william.to...@codethink.co.uk Signed-off-by: Ian Molton ian.mol...@codethink.co.uk --- .../devicetree

Re: RFC: soc_camera, rcar_vin, and adv7604

2014-07-10 Thread Ian Molton
able to select mutually acceptable data formats, but the calls to get/set resolution seem to use fh's I will persist with approach 2 then for now. -- Ian Molton ian.mol...@codethink.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 3/4] media: rcar_vin: Fix race condition terminating stream

2014-07-10 Thread Ian Molton
On Tue, 08 Jul 2014 20:09:58 +0400 Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. Hi, Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 43

RFC: soc_camera, rcar_vin, and adv7604

2014-07-09 Thread Ian Molton
to see a clear path through this. Whatever we do, we would like to be acceptable upstream, so we'd like to open a discussion. Perhaps a soc_camera2 with pads support? -- Ian Molton ian.mol...@codethink.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Resend: [PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues.

2014-07-08 Thread Ian Molton
Resent to include the author and a couple of other interested parties :) This patch series provides fixes that allow the rcar_vin driver to function without triggering dozens of warnings from the videobuf2 and soc_camera layers. Patches 2/3 should probably be merged into a single, atomic change,

[PATCH 2/4] media: rcar_vin: Ensure all in-flight buffers are returned to error state before stopping.

2014-07-08 Thread Ian Molton
at this point. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media

[PATCH 1/4] media: rcar_vin: Dont aggressively retire buffers

2014-07-08 Thread Ian Molton
rcar_vin_videobuf_release() is called once per buffer from the buf_cleanup hook. There is no need to look up the queue and free all buffers at this point. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform

[PATCH 3/4] media: rcar_vin: Fix race condition terminating stream

2014-07-08 Thread Ian Molton
to finish prior to finalising these buffers. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 43 ++-- 1 file changed, 28 insertions(+), 15 deletions(-) diff

[PATCH 4/4] media: rcar_vin: Clean up rcar_vin_irq

2014-07-08 Thread Ian Molton
This patch makes the rcar_vin IRQ handler a little more readable. Removes an else clause, and simplifies the buffer handling. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Reviewed-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 24

[PATCH 3/4] media: rcar_vin: Fix race condition terminating stream

2014-07-07 Thread Ian Molton
to finish prior to finalising these buffers. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 43 ++-- 1 file changed, 28 insertions(+), 15 deletions(-) diff

[PATCH 4/4] media: rcar_vin: Clean up rcar_vin_irq

2014-07-07 Thread Ian Molton
This patch makes the rcar_vin IRQ handler a little more readable. Removes an else clause, and simplifies the buffer handling. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Reviewed-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 24

[PATCH 2/4] media: rcar_vin: Ensure all in-flight buffers are returned to error state before stopping.

2014-07-07 Thread Ian Molton
at this point. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media

[PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues.

2014-07-07 Thread Ian Molton
This patch series provides fixes that allow the rcar_vin driver to function without triggering dozens of warnings from the videobuf2 and soc_camera layers. Patches 2/3 should probably be merged into a single, atomic change, although patch 2 does not make the existing situation /worse/ in and of

[PATCH 1/4] media: rcar_vin: Dont aggressively retire buffers

2014-07-07 Thread Ian Molton
rcar_vin_videobuf_release() is called once per buffer from the buf_cleanup hook. There is no need to look up the queue and free all buffers at this point. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform

rcar_vin, soc_camera and videobuf2

2014-06-06 Thread Ian Molton
the state machine is being violated here, but I'm at a loss as to how its actually *supposed* to operate. Is there any good documentation? -- Ian Molton ian.mol...@codethink.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: rcar_vin, soc_camera and videobuf2

2014-06-06 Thread Ian Molton
guidance on how to proceed? Clearly the state machine is being violated here, but I'm at a loss as to how its actually *supposed* to operate. Is there any good documentation? -- Ian Molton ian.mol...@codethink.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH/RFC] tmio_mmc: keep card-detect interrupts enabled

2009-11-09 Thread Ian Molton
dropped ML) On Mon, 9 Nov 2009, Ian Molton wrote: Well, I presume we want to know when the card gets removed :) Sure, that's why we shouldn't mask those interrupts:-) If they do get masked and missed, I do not know, if the interrupt remains pending in this case, because they never get