Re: [RESEND RFC/PATCH 1/8] dt-bindings: Add a binding for Mediatek Video Processor Unit

2015-11-17 Thread Mark Rutland
On Tue, Nov 17, 2015 at 08:54:38PM +0800, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add a DT binding documentation of Video Processor Unit for the > MT8173 SoC from Mediatek. > > Signed-off-by: Andrew-CT Chen > --- >

Re: [PATCH v3] DT: Add documentation for the mfd Maxim max77693

2015-03-30 Thread Mark Rutland
Hi, +Optional properties: +- maxim,trigger-type : Flash trigger type. + Possible trigger types: + LEDS_TRIG_TYPE_EDGE (0) - Rising edge of the signal triggers + the flash, + LEDS_TRIG_TYPE_LEVEL (1) - Strobe pulse length controls duration +

Re: [PATCH v3] DT: Add documentation for the mfd Maxim max77693

2015-03-30 Thread Mark Rutland
On Mon, Mar 30, 2015 at 10:52:28AM +0100, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com

Re: [REVIEW PATCH v2.1 08/11] of: smiapp: Add documentation

2014-12-01 Thread Mark Rutland
On Sun, Nov 30, 2014 at 04:26:48PM +, Sakari Ailus wrote: Document the smiapp device tree properties. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- since v2: - Cleanups - Removed clock-names property documentation - Port node documentation was really endpoint node documentation

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Mark Rutland
...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga...@codeaurora.org Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/media/samsung-fimc.txt |7

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Mark Rutland
On Fri, Nov 28, 2014 at 12:09:14PM +, Jacek Anaszewski wrote: On 11/28/2014 12:14 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 09:18:00AM +, Jacek Anaszewski wrote: This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Mark Rutland
On Fri, Nov 28, 2014 at 02:11:04PM +, Jacek Anaszewski wrote: On 11/28/2014 01:30 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 12:09:14PM +, Jacek Anaszewski wrote: On 11/28/2014 12:14 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 09:18:00AM +, Jacek Anaszewski wrote

Re: [PATCH 2/2] adv7604: Use DT parsing in dummy creation

2014-08-29 Thread Mark Rutland
Hi, On Fri, Aug 29, 2014 at 02:28:17PM +0100, Jean-Michel Hautbois wrote: This patch uses DT in order to parse addresses for dummy devices of adv7604. If nothing is defined, it uses default addresses. The main prupose is using two adv76xx on the same i2c bus. This is rather opaque. It seems

Re: [PATCH 2/2] media: adv7604: Add ability to read default input port from DT

2014-08-13 Thread Mark Rutland
On Wed, Aug 13, 2014 at 01:14:35PM +0100, Ian Molton wrote: On Mon, 11 Aug 2014 13:19:02 +0100 Mark Rutland mark.rutl...@arm.com wrote: - - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge. + - pclk-sample: Pixel clock polarity. Defaults to output

Re: [PATCH 2/2] media: adv7604: Add ability to read default input port from DT

2014-08-11 Thread Mark Rutland
On Mon, Aug 11, 2014 at 01:05:19PM +0100, Ian Molton wrote: This patch adds support to the adv7604 driver for reading the default selected input from the Device tree. If none is provided, the driver will not select an input without help from userspace. Tested-by: William Towle

Re: [PATCH v2 8/9] Documentation: devicetree: Document sclk-jpeg clock for exynos3250 SoC

2014-07-14 Thread Mark Rutland
...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga...@codeaurora.org Cc: devicet...@vger.kernel.org --- .../bindings/media/exynos-jpeg-codec.txt |9

Re: [PATCH v2 1/2] media: soc_camera: pxa_camera documentation device-tree support

2014-06-26 Thread Mark Rutland
On Wed, Jun 25, 2014 at 08:44:31PM +0100, Robert Jarzmik wrote: Mark Rutland mark.rutl...@arm.com writes: On Sat, Jun 21, 2014 at 11:21:46PM +0100, Robert Jarzmik wrote: +Required properties: + - compatible: Should be marvell,pxa27x-qci Is that x a wildcard? Or is 'x' part of the name

Re: [PATCH v2 2/2] media: soc_camera: pxa_camera device-tree support

2014-06-25 Thread Mark Rutland
On Sat, Jun 21, 2014 at 11:21:47PM +0100, Robert Jarzmik wrote: Add device-tree support to pxa_camera host driver. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/media/platform/soc_camera/pxa_camera.c | 77 +- 1 file changed, 75 insertions(+), 2

Re: [PATCH v2 1/2] media: soc_camera: pxa_camera documentation device-tree support

2014-06-25 Thread Mark Rutland
On Sat, Jun 21, 2014 at 11:21:46PM +0100, Robert Jarzmik wrote: Add device-tree bindings documentation for pxa_camera driver. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- .../devicetree/bindings/media/pxa-camera.txt | 39 ++ 1 file changed, 39

Re: [PATCH v8 3/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-03-18 Thread Mark Rutland
On Tue, Mar 11, 2014 at 04:34:30PM +, Sylwester Nawrocki wrote: This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells and clock-output-names properties to 'camera' node - these are now needed so the image sensor

Re: [PATCH v4 02/10] Documentation: dt: Add DT binding documentation for S5C73M3 camera

2014-02-21 Thread Mark Rutland
; + }; + }; + }; +}; + +spi@1392000 { + ... + s5c73m3_spi: s5c73m3 { Nit: this should have a 0 unit-address to match the reg. + compatible = samsung,s5c73m3; + reg = 0; + ... + }; +}; Otherwise I don't see anything problematic about the binding. Acked-by: Mark

Re: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 07:40:30PM +, Sylwester Nawrocki wrote: This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells property to 'camera' node - the #clock-cells property is needed when the sensor sub-devices use

Re: [PATCH v4 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 07:40:34PM +, Sylwester Nawrocki wrote: This patch adds clock provider so the the SCLK_CAM0/1 output clocks can be accessed by image sensor devices through the clk API. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Kyungmin Park

Re: [PATCH] V4L: s5k6a3: Add DT binding documentation

2014-02-19 Thread Mark Rutland
kyungmin.p...@samsung.com --- This patch adds missing documentation [1] for the samsung,s5k6a3 compatible. Rob, can you please merge it through your tree if it looks OK ? Anyone cares to Ack this patch so it can be merged through the media tree ? It looks fine to me: Acked-by: Mark

Re: [PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-02-07 Thread Mark Rutland
Hi Rob, On Fri, Feb 07, 2014 at 02:33:27PM +, Rob Herring wrote: On Thu, Feb 6, 2014 at 8:41 AM, James Hogan james.ho...@imgtec.com wrote: Hi Rob, On 06/02/14 14:33, Rob Herring wrote: On Fri, Jan 17, 2014 at 7:58 AM, James Hogan james.ho...@imgtec.com wrote: +Required

Re: [PATCH v10 1/2] [media] exynos5-is: Adds DT binding documentation

2014-02-06 Thread Mark Rutland
://www.spinics.net/lists/devicetree/msg11550.html Please check this and give an ack if it is fine to be merged. Apologies for the delay. As far as I can tell this looks ok: Acked-by: Mark Rutland mark.rutl...@arm.com Regards Arun On Fri, Dec 13, 2013 at 10:42 AM, Arun Kumar K arun

Re: [PATCH v9] s5k5baf: add camera sensor driver

2013-12-05 Thread Mark Rutland
: Acked-by: Mark Rutland mark.rutl...@arm.com I think we still need to move the DT binding into a separate patch. If you're going to post the patch again, then please do split the binding into a separate patch. [...] diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt b

Re: [early RFC] Device Tree bindings for OMAP3 Camera Subsystem

2013-11-15 Thread Mark Rutland
On Sun, Nov 03, 2013 at 10:03:15PM +, Sebastian Reichel wrote: Hi, This is an early RFC for omap3isp DT support. For now i just created a potential DT binding documentation based on the existing platform data: Binding for the OMAP3 Camera subsystem with the image signal processor

Re: [PATCH v9 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-11-11 Thread Mark Rutland
On Fri, Sep 27, 2013 at 11:59:06AM +0100, Arun Kumar K wrote: From: Shaik Ameer Basha shaik.am...@samsung.com This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. [...] diff --git

Re: [PATCH v9 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-11-11 Thread Mark Rutland
On Fri, Sep 27, 2013 at 11:59:07AM +0100, Arun Kumar K wrote: The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC-IS). Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

Re: [PATCH v10 01/12] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-10-28 Thread Mark Rutland
link of these image sensors must be specified using the common video +interfaces bindings, defined in video-interfaces.txt. These don't seem to be in the example and probably should be. Otherwise, this looks fine. With those points fixed up: Acked-by: Mark Rutland mark.rutl...@arm.com Thanks

Re: [PATCH v10 11/12] V4L: Add DT binding doc for s5k4e5 image sensor

2013-10-28 Thread Mark Rutland
: should contain the sensor's EXTCLK clock specifier, from + the common clock bindings I would reword this to reference clock-names so as to make the ordering relationship explicit. With that, as everything else looks sane: Acked-by: Mark Rutland mark.rutl...@arm.com Thanks Mark

Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

2013-10-18 Thread Mark Rutland
On Wed, Oct 09, 2013 at 01:17:30PM +0100, srinivas kandagatla wrote: .../devicetree/bindings/media/remote-control.txt | 31 1 files changed, 31 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/remote-control.txt

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-30 Thread Mark Rutland
diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt new file mode 100644 index 000..7704a1e --- /dev/null +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt @@ -0,0 +1,58 @@

Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

2013-09-30 Thread Mark Rutland
On Fri, Sep 27, 2013 at 02:47:19PM +0100, Mauro Carvalho Chehab wrote: Em Fri, 27 Sep 2013 12:34:58 +0100 Mark Rutland mark.rutl...@arm.com escreveu: On Fri, Sep 27, 2013 at 10:33:11AM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch

Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

2013-09-27 Thread Mark Rutland
On Fri, Sep 27, 2013 at 10:33:11AM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch attempts to collate generic bindings which can be used by the remote control hardwares. Currently the list is not long as there are only 2 drivers which are

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-20 Thread Mark Rutland
On Fri, Sep 06, 2013 at 11:31:06AM +0100, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, no controls. - S5K5BAF-ISP -

Re: [PATCH v3] media: st-rc: Add ST remote control driver

2013-09-18 Thread Mark Rutland
On Wed, Sep 18, 2013 at 11:11:29AM +0100, Srinivas KANDAGATLA wrote: Thanks Mark, On 16/09/13 15:10, Mark Rutland wrote: + +Required properties: + - compatible: should be st,comms-irb. This should probably say should contain rather than should be. There may be future vairants

Re: [PATCH v3] media: st-rc: Add ST remote control driver

2013-09-16 Thread Mark Rutland
On Thu, Aug 29, 2013 at 01:06:52PM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch adds support to ST RC driver, which is basically a IR/UHF receiver and transmitter. This IP (IRB) is common across all the ST parts for settop box platforms.

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-09-04 Thread Mark Rutland
On Wed, Sep 04, 2013 at 08:13:38AM +0100, Prabhakar Lad wrote: Hi Mark, Hi Prabhakar, On Mon, Sep 2, 2013 at 9:47 PM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Aug 28, 2013 at 03:43:04AM +0100, Prabhakar Lad wrote: Hi Mark, On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-09-02 Thread Mark Rutland
On Wed, Aug 28, 2013 at 03:43:04AM +0100, Prabhakar Lad wrote: Hi Mark, On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland mark.rutl...@arm.com wrote: [fixing up devicetree list address] Thanks! On Mon, Aug 26, 2013 at 03:41:45AM +0100, Prabhakar Lad wrote: Hi Sylwester, On Fri, Aug

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-09-02 Thread Mark Rutland
On Mon, Sep 02, 2013 at 05:21:58PM +0100, Sylwester Nawrocki wrote: Hi Mark, Hi Sylwester, On 08/27/2013 11:14 AM, Mark Rutland wrote: +endpoint node +- + +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in + video-interfaces.txt. This property can

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-27 Thread Mark Rutland
Hi, [trimming down to relevant context] +endpoint node +- + +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in + video-interfaces.txt. This property can be only used to specify number + of data lanes, i.e. the array's content is unused, only its length

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-27 Thread Mark Rutland
On Mon, Aug 26, 2013 at 03:41:45AM +0100, Prabhakar Lad wrote: Hi Sylwester, On Fri, Aug 23, 2013 at 11:33 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Cc: DT binding maintainers Cheers! On 07/20/2013 08:21 AM, Lad, Prabhakar wrote: From: Lad, Prabhakar

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-27 Thread Mark Rutland
[fixing up devicetree list address] On Mon, Aug 26, 2013 at 03:41:45AM +0100, Prabhakar Lad wrote: Hi Sylwester, On Fri, Aug 23, 2013 at 11:33 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Cc: DT binding maintainers Cheers! On 07/20/2013 08:21 AM, Lad, Prabhakar wrote: From:

Re: [PATCH RFC v5] s5k5baf: add camera sensor driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 02:18:27PM +0100, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, no controls. - S5K5BAF-ISP -

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Mark Rutland
On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch adds support to ST RC driver, which is basically a IR/UHF receiver and transmitter. This IP is common across all the ST parts for settop box platforms. IRB is

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Mark Rutland
On Thu, Aug 15, 2013 at 01:57:13PM +0100, Srinivas KANDAGATLA wrote: Thanks Mark for your comments. On 15/08/13 09:49, Mark Rutland wrote: On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch adds support

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Mark Rutland
On Thu, Aug 15, 2013 at 03:06:14PM +0100, Srinivas KANDAGATLA wrote: On 15/08/13 14:29, Mark Rutland wrote: On Thu, Aug 15, 2013 at 01:57:13PM +0100, Srinivas KANDAGATLA wrote: Thanks Mark for your comments. On 15/08/13 09:49, Mark Rutland wrote: On Wed, Aug 14, 2013 at 06:27:01PM +0100