On Mon, Feb 20, 2017 at 09:46:58PM -0600, Gustavo A. R. Silva wrote:
> Remove unnecessary variable 'loop'.
>
Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com>
> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
> ---
> drivers/media/pci/saa7164/saa7
On Mon, Feb 20, 2017 at 09:49:59PM -0600, Gustavo A. R. Silva wrote:
> Remove dead code. The following line of code is never reached:
> return SAA_OK;
>
> Addresses-Coverity-ID: 114283
Reviewed-by: Peter Senna Tschudin <peter.se...@gmail.com>
> Signed-off-by: Gusta
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/ngene/ngene-core.c | 11 ++-
drivers/media/usb/cx231xx/cx231xx-video.c | 11 +--
2 files changed, 7
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/usbvision/usbvision-core.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Do not remove comment after the definition of return variable
drivers/media/pci/ngene/ngene-core.c | 11
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/media/as102/as102_usb_drv.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/as102
Hi,
I'm being blamed for some bugs for more than one year, and this
weekend I was able to reproduce the error for the first time. I have
the impression that the issue is related to Kconfig because when
compiling the Kernel for x86(not x86_64), and
when:
CONFIG_VIDEO_CX23885=y
and
Check the file: drivers/media/tuners/Kconfig
On Thu, Dec 26, 2013 at 12:03 PM, Jahn jana1...@centrum.cz wrote:
Is there available a list of tuners that are supported in Linux ( those
that have a driver)
preferably in MIPS Linux ?
Thanks
--
To unsubscribe from this list: send the line
On Tue, Oct 15, 2013 at 4:56 AM, Буди Романто b...@are.ma wrote:
Hello
I've developed a DVB device driver for Earthsoft PT3 (PCIE) card
want to ask where/how to submit it.
Usually drivers are sent in a list of incremental patches, but this is
not a rule. After sending the first version, there
-by: Peter Senna Tschudin peter.se...@gmail.com
---
This fails at checkpatch due initializing static variable to false.
I haven't changed the assignment.
drivers/media/usb/cpia2/cpia2_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/cpia2/cpia2_usb.c
b
-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/tuners/fc0012.c | 2 +-
drivers/media/tuners/fc0013.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/tuners/fc0012.c b/drivers/media/tuners/fc0012.c
index f4d0e79..d74e920 100644
--- a/drivers
Hi Randy,
I've tried to download the .config file from the link on the forum,
but it tries to install something in my browser and the file is not
downloadable for me. Can you provide it over an simpler interface such
as pastebin.com?
Thanks
On Wed, Sep 18, 2013 at 4:59 PM, Randy Dunlap
Hi Mauro,
I'll love to join the media mini-summit.
Thanks,
Peter
On Sat, Aug 31, 2013 at 4:29 PM, Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Mauro,
On Fri, Aug 30, 2013 at 08:39:23AM -0300, Mauro Carvalho Chehab wrote:
Hi media developers,
This year, we're planning to do a media
Any one know any linux-media compatible camera capable of recording at
480 fps or more?
--
Peter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that vivi was substantially improved
recently
when it comes to the image generation. That will be in the upcoming 3.9
kernel.
This should reduce CPU load by quite a bit if memory serves.
Regards,
Hans
On Mon, Apr 8, 2013 at 9:42 AM, Peter Senna Tschudin
peter.se...@gmail.com
Dear Michal,
The CPU intensive part of the vivi driver is the image generation.
This is not an issue for real drivers.
Regards,
Peter
On Sun, Apr 7, 2013 at 9:32 PM, Michal Lazo michal.l...@mdragon.org wrote:
Hi
V4L2 driver vivi
generate 25% cpu load on raspberry pi(linux 3.6.11) or 8% on
05:33 PM, Peter Senna Tschudin wrote:
replace:
#if defined(CONFIG_VIDEO_CX88_DVB) || \
defined(CONFIG_VIDEO_CX88_DVB_MODULE)
with:
#if IS_ENABLED(CONFIG_VIDEO_CX88_DVB)
This change was made for: CONFIG_VIDEO_CX88_DVB,
CONFIG_VIDEO_CX88_BLACKBIRD, CONFIG_VIDEO_CX88_VP3054
Reported
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/cx88/cx88.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
index ba0dba4..feff53c 100644
--- a/drivers/media/pci/cx88/cx88.h
replace:
#if defined(CONFIG_VIDEO_SAA7134_DVB) || \
defined(CONFIG_VIDEO_SAA7134_DVB_MODULE)
with:
#if IS_ENABLED(CONFIG_VIDEO_SAA7134_DVB)
This change was made for: CONFIG_VIDEO_SAA7134_DVB
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
replace:
#if defined(CONFIG_INPUT_EVDEV) || \
defined(CONFIG_INPUT_EVDEV_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT_EVDEV)
This change was made for: CONFIG_INPUT_EVDEV,
CONFIG_DVB_SP8870
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/platform/marvell-ccic/mcam-core.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.h
b/drivers/media/platform/marvell-ccic/mcam-core.h
index
replace:
#if defined(CONFIG_USB_SI470X) || \
defined(CONFIG_USB_SI470X_MODULE)
with:
#if IS_ENABLED(CONFIG_USB_SI470X)
This change was made for: CONFIG_USB_SI470X,
CONFIG_I2C_SI470X
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca/cpia1
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca/ov519
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca/t613
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca
replace:
#if defined(CONFIG_I2C) || \
defined(CONFIG_I2C_MODULE)
with:
#if IS_ENABLED(CONFIG_I2C)
This change was made for: CONFIG_I2C
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/hdpvr/hdpvr-core.c
replace:
#if defined(CONFIG_I2C) || \
defined(CONFIG_I2C_MODULE)
with:
#if IS_ENABLED(CONFIG_I2C)
This change was made for: CONFIG_I2C
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/hdpvr/hdpvr-i2c.c
-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/v4l2-core/v4l2-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-common.c
b/drivers/media/v4l2-core/v4l2-common.c
index 614316f..aa044f4 100644
--- a/drivers/media/v4l2-core
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/gspca/se401
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Also replaced:
with:
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
commit message of patch 24/24
Peter Senna Tschudin (24):
pci/cx88/cx88.h: use IS_ENABLED() macro
pci/saa7134/saa7134.h: use IS_ENABLED() macro
pci/ttpci/av7110.c: use IS_ENABLED() macro
platform/marvell-ccic/mcam-core.h: use IS_ENABLED() macro
radio/si470x/radio-si470x.h: use IS_ENABLED
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated subject
drivers/media/pci/cx88/cx88.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
index ba0dba4..feff53c 100644
replace:
#if defined(CONFIG_VIDEO_SAA7134_DVB) || \
defined(CONFIG_VIDEO_SAA7134_DVB_MODULE)
with:
#if IS_ENABLED(CONFIG_VIDEO_SAA7134_DVB)
This change was made for: CONFIG_VIDEO_SAA7134_DVB
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
replace:
#if defined(CONFIG_INPUT_EVDEV) || \
defined(CONFIG_INPUT_EVDEV_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT_EVDEV)
This change was made for: CONFIG_INPUT_EVDEV,
CONFIG_DVB_SP8870
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated subject
drivers/media/platform/marvell-ccic/mcam-core.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.h
b/drivers/media
replace:
#if defined(CONFIG_USB_SI470X) || \
defined(CONFIG_USB_SI470X_MODULE)
with:
#if IS_ENABLED(CONFIG_USB_SI470X)
This change was made for: CONFIG_USB_SI470X,
CONFIG_I2C_SI470X
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated subject
Fixed commit message
drivers/media/usb/gspca/sonixb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/gspca/sonixb.c
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
replace:
#if defined(CONFIG_I2C) || \
defined(CONFIG_I2C_MODULE)
with:
#if IS_ENABLED(CONFIG_I2C)
This change was made for: CONFIG_I2C
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated subject
replace:
#if defined(CONFIG_I2C) || \
defined(CONFIG_I2C_MODULE)
with:
#if IS_ENABLED(CONFIG_I2C)
This change was made for: CONFIG_I2C
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated subject
))
with:
#if IS_ENABLED(CONFIG_I2C)
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated subject
Fixed commit message
drivers/media/v4l2-core/v4l2-common.c | 4 ++--
1 file changed, 2 insertions(+), 2
replace:
#if defined(CONFIG_INPUT) || \
defined(CONFIG_INPUT_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT)
This change was made for: CONFIG_INPUT
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated
...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/dvb-frontends/bcm3510.h | 2 +-
drivers/media/dvb-frontends/cx22700.h | 2 +-
drivers/media/dvb-frontends/cx24110.h | 2 +-
drivers/media/dvb-frontends/dib0070.h | 2 +-
drivers/media/dvb
replace:
#if defined(CONFIG_INPUT_EVDEV) || defined(CONFIG_INPUT_EVDEV_MODULE)
with:
#if IS_ENABLED(CONFIG_INPUT_EVDEV)
This change was made for: CONFIG_INPUT_EVDEV, CONFIG_DVB_SP8870
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se
replace:
#if defined(CONFIG_VIDEO_CX88_DVB) || defined(CONFIG_VIDEO_CX88_DVB_MODULE)
with:
#if IS_ENABLED(CONFIG_VIDEO_CX88_DVB)
This change was made for: CONFIG_VIDEO_SAA7134_DVB
Reported-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/cx88/cx88.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
index ba0dba4..feff53c 100644
--- a/drivers/media/pci/cx88/cx88.h
+++ b
On Fri, Nov 2, 2012 at 1:08 PM, YAMANE Toshiaki yamaneto...@gmail.com wrote:
fixed below checkpatch error.
- ERROR: that open brace { should be on the previous line
Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com
Tested-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging
(... to printk(KERN_ERR ...
Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com
Tested-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/media/go7007/wis-ov7640.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/go7007/wis
(... to printk(KERN_INFO ...
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then
pr_warn(... to printk(KERN_WARNING ...
Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com
Tested-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/media/cxd2099/cxd2099.c
= videobuf_dvb_get_frontend(...);
... when != if (!i) S
* if (i-a.b)
S2
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/saa7134/saa7134-dvb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/pci/saa7134/saa7134-dvb.c
b/drivers/media/pci
-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
Updated commit message
drivers/media/v4l2-core/videobuf2-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
b/drivers/media/v4l2-core/videobuf2
On Thu, Oct 18, 2012 at 5:28 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Thu, Oct 18, 2012 at 11:47 AM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
This patch fixes a NULL pointer dereference bug at __vb2_init_fileio().
The NULL pointer deference happens at videobuf2-core.c
On Sat, Oct 6, 2012 at 1:17 PM, Mauro Carvalho Chehab
mche...@infradead.org wrote:
Em Thu, 6 Sep 2012 17:23:57 +0200
Peter Senna Tschudin peter.se...@gmail.com escreveu:
From: Peter Senna Tschudin peter.se...@gmail.com
Convert a nonnegative error return code to a negative one, as returned
;
@@
-;@p
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from v2:
Include semantic patch in the commit message.
The full version of the semantic patch can be found at:
http://comments.gmane.org/gmane.comp.version-control.coccinelle/2724
drivers/media/dvb-core
Remove unnecessary semicolon
And:
drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace
before a
quoted newline
Found by http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/dvb-core/dvb_frontend.c |2
Remove unnecessary semicolon
And:
drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace
before a
quoted newline
Found by http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/dvb-core/dvb_frontend.c | 2 +-
drivers
On Thu, Sep 27, 2012 at 1:55 PM, Prabhakar Lad
prabhakar.cse...@gmail.com wrote:
Hi Peter,
Thanks for the patch.
On Thu, Sep 27, 2012 at 5:00 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Remove unnecessary semicolon
And:
drivers/media/dvb-frontends/stv0900_core.c: remove
Remove unnecessary semicolon
And:
drivers/media/dvb-frontends/stv0900_core.c: remove unnecessary whitespace
before a
quoted newline
Found by http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/dvb-core/dvb_frontend.c | 2 +-
drivers
From: Peter Senna Tschudin peter.se...@gmail.com
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
(
if@p1 (\(ret 0\|ret != 0
next time. Thanks!
Regards,
Mauro
Mensagem original
Assunto: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return
code
Data: Tue, 4 Sep 2012 18:14:25 +0200
De: Peter Senna Tschudin peter.se...@gmail.com
Para: Mauro Carvalho Chehab mche...@infradead.org
Replace kmemdup for kstrdup and cleanup related code.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/cx25821/cx25821-audio-upstream.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/media/pci/cx25821/cx25821-audio
(_defaultAudioName,
GFP_KERNEL);
if (!dev-_audiofilename) {
err = -ENOMEM;
goto error;
}
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/cx25821/cx25821-audio-upstream.c | 21 ++---
1 file changed, 6
From: Peter Senna Tschudin peter.se...@gmail.com
The function cx25821_sram_channel_setup_upstream_audio always return zero,
so the return value is not saved any more.
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version
From: Peter Senna Tschudin peter.se...@gmail.com
Remove unused label and rename remaining labels
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Depends on patch [v2,7/8] drivers/media/platform/davinci/vpbe.c: Removes
useless kfree() - http://patchwork.linuxtv.org/patch/14307
I'll split this patch in one patch for file and resend.
On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote:
diff --git a/drivers/media/dvb-frontends/lg2160.c
b/drivers/media/dvb-frontends/lg2160
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x
Marcos,
Now that you removed this kfree, you could remove this label too. Very
nice your cleanup :)
Thanks!
vpbe_fail_sd_register:
kfree(vpbe_dev-encoders);
vpbe_fail_v4l2_device:
The problem removing the label is that it will require some more work
naming the labels. See:
if
From: Peter Senna Tschudin peter.se...@gmail.com
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@
position r.p1,r.p2;
expression e
You're replacing kmemdup for kstrdup, which is great,
but that's not anywhere in the commit message.
Sorry for that.
I'm not sure if you should re-send, but you should definitely
try to have better commit messages in the future!
I'll kindly ask to ignore the V2 of this patch. I'll send
1 - 100 of 163 matches
Mail list logo
