Re: [v3] [media] Use common error handling code in 19 functions

> @@ -656,18 +656,18 @@ static int dvb_dmxdev_start_feed(struct dmxdev *dmxdev, > tsfeed->priv = filter; > > ret = tsfeed->set(tsfeed, feed->pid, ts_type, ts_pes, timeout); > - if (ret < 0) { > - dmxdev->demux->release_ts_feed(dmxdev->demux, tsfeed); > -

Re: [v3] [media] Use common error handling code in 19 functions

> Adjust jump targets so that a bit of exception handling can be better > reused at the end of these functions. Why was this update suggestion rejected once more a moment ago? https://patchwork.linuxtv.org/patch/47827/

Re: [media] ov5645: Move an error code assignment in ov5645_probe()

>> Move an assignment for a specific error code so that it is stored only once >> in this function implementation. >> >> This issue was detected by using the Coccinelle software. > > How? Would you like to experiment a bit more with the following approach for the semantic patch language?

[PATCH] [media] ov5645: Move an error code assignment in ov5645_probe()

From: Markus Elfring Date: Wed, 14 Mar 2018 22:02:52 +0100 Move an assignment for a specific error code so that it is stored only once in this function implementation. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH v3] [media] Use common error handling code in 19 functions

From: Markus Elfring Date: Fri, 9 Mar 2018 21:00:12 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of these functions. This issue was partly detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [v2] [media] Use common error handling code in 20 functions

I got the following notification. - http://patchwork.linuxtv.org/patch/47270/ - for: Linux Media kernel patches was: New now: Rejected Would you like to clarify still any other variant for this change proposal? Regards, Markus

Re: [v2] [media] Use common error handling code in 20 functions

>> +put_isp: >> +omap3isp_put(video->isp); >> +delete_fh: >> +v4l2_fh_del(>vfh); >> +v4l2_fh_exit(>vfh); >> +kfree(handle); > > Please prefix the error labels with error_. How often do you really need such an extra prefix? >> +++ b/drivers/media/usb/uvc/uvc_v4l2.c >> @@ -994,10

[PATCH v2] [media] Delete unnecessary variable initialisations in seven functions

From: Markus Elfring Date: Thu, 22 Feb 2018 21:45:47 +0100 Some local variables will be set to an appropriate value before usage. Thus omit explicit initialisations at the beginning of these functions. Signed-off-by: Markus Elfring

[PATCH v2] [media] Use common error handling code in 20 functions

From: Markus Elfring Date: Mon, 19 Feb 2018 18:50:40 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of these functions. This issue was partly detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: Adjustments for a lot of function implementations

>> Do any contributors get into the mood to take another look at software >> updates >> from my selection of change possibilities in a more constructive way? >> >> Do you need any additional development resources? > > One last time: either post per-driver patches with all the cleanups for a >

Re: Adjustments for a lot of function implementations

> One last time: either post per-driver patches with all the cleanups for a > driver > in a single patch, I preferred to offer source code adjustments according to specific transformation patterns mostly for each software module separately (also in small patch series). > or a per-directory

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Do any contributors get into the mood to take another look at software updates from my selection of change possibilities in a more constructive way?

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Are you going to answer any of my remaining questions in a more constructive way? Regards, Markus

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Would you like to answer my still remaining questions in any more constructive ways? Regards, Markus

[PATCH] staging/media/davinci_vpfe: Use common error handling code in vpfe_attach_irq()

From: Markus Elfring Date: Fri, 3 Nov 2017 10:45:31 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: Adjustments for a lot of function implementations

but will reject the others, not just this driver but all of them that are currently pending in our patchwork (https://patchwork.linuxtv.org). I find it very surprising that you rejected 146 useful update suggestions so easily. Feel free to repost, but only if you organize

Re: Adjustments for a lot of function implementations

> Yes, and you were told not to do it I have got an other impression. > like that again. I continued with the presentation of suggestions from my selection of change possibilities. It seems that there are very different expectations for the preferred patch granularity. Can it happen again

Re: Adjustments for a lot of function implementations

Feel free to repost, but only if you organize the patch as either fixing the same type of issue for a whole subdirectory (media/usb, media/pci, etc) >> >> Just for the record, while this may work for media, it won't work for all >> subsystems. One will quickly get a complaint that

Re: Adjustments for a lot of function implementations

> While we do not mind cleanup patches, the way you post them (one fix per file) I find it safer in this way while I was browsing through the landscape of Linux software components. > is really annoying and takes us too much time to review. It is just the case that there are so many remaining

Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

>> @@ -129,18 +129,18 @@ static int tda8261_set_params(struct dvb_frontend *fe) >> >> /* Set params */ >> err = tda8261_write(state, buf); >> -if (err < 0) { >> -pr_err("%s: I/O Error\n", __func__); >> -return err; >> -} >> +err =

[PATCH 2/2] [media] dmxdev: Improve a size determination in dvb_dmxdev_add_pid()

From: Markus Elfring Date: Tue, 26 Sep 2017 15:22:57 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 0/2] [media] dmxdev: Fine-tuning for two function implementations

From: Markus Elfring Date: Tue, 26 Sep 2017 15:30:03 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code in dvb_dmxdev_start_feed() Improve a size determination in

[PATCH 1/2] [media] dmxdev: Use common error handling code in dvb_dmxdev_start_feed()

From: Markus Elfring Date: Tue, 26 Sep 2017 15:12:47 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 6/6] [media] tda8261: Delete an unnecessary variable initialisation in three functions

From: Markus Elfring Date: Tue, 26 Sep 2017 12:55:16 +0200 The local variable "err" is reassigned by a statement at the beginning. Thus omit the explicit initialisation in these functions. Signed-off-by: Markus Elfring ---

[PATCH 4/6] [media] tda8261: Delete an unnecessary variable initialisation in tda8261_attach()

From: Markus Elfring Date: Tue, 26 Sep 2017 12:24:57 +0200 The local variable "state" is reassigned by a statement at the beginning. Thus omit the explicit initialisation. Signed-off-by: Markus Elfring ---

[PATCH 5/6] [media] tda8261: Adjust three function calls together with a variable assignment

From: Markus Elfring Date: Tue, 26 Sep 2017 12:52:24 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 3/6] [media] tda8261: Return directly after a failed kzalloc() in tda8261_attach()

From: Markus Elfring Date: Tue, 26 Sep 2017 12:20:33 +0200 * Return directly after a call of the function "kzalloc" failed at the beginning. * Delete a call of the function "kfree" and the jump target "exit" which became unnecessary with this refactoring.

[PATCH 2/6] [media] tda8261: Improve a size determination in tda8261_attach()

From: Markus Elfring Date: Tue, 26 Sep 2017 12:06:19 +0200 * The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix an affected source code place. * Replace the specification of a data

[PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

From: Markus Elfring Date: Tue, 26 Sep 2017 11:01:44 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * The script "checkpatch.pl" pointed

[PATCH 0/6] [media] TDA8261: Fine-tuning for five function implementations

From: Markus Elfring Date: Tue, 26 Sep 2017 13:20:12 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Use common error handling code in tda8261_set_params() Improve a size determination in

[PATCH] [media] bt8xx: Use common error handling code in two functions

From: Markus Elfring Date: Mon, 25 Sep 2017 22:10:17 +0200 Adjust jump targets so that a bit of exception handling can be better reused at the end of these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] [media] cx88: Use common error handling code in get_key_pvr2000()

From: Markus Elfring Date: Mon, 25 Sep 2017 21:03:57 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 4/4] [media] omap3isp: Delete an unnecessary variable initialisation in isp_video_open()

From: Markus Elfring Date: Sun, 24 Sep 2017 19:43:06 +0200 The variable "ret" will eventually be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 3/4] [media] omap3isp: Use common error handling code in isp_video_open()

From: Markus Elfring Date: Sun, 24 Sep 2017 19:30:52 +0200 * Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * Delete a repeated check (for the

[PATCH 2/4] [media] omap3isp: Adjust 53 checks for null pointers

From: Markus Elfring Date: Sun, 24 Sep 2017 18:56:33 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 1/4] [media] omap3isp: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Sun, 24 Sep 2017 18:25:44 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/4] [media] OMAP3 ISP: Adjustments for some function implementations

From: Markus Elfring Date: Sun, 24 Sep 2017 19:57:34 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in three functions Adjust 53 checks for null

[PATCH 6/6] [media] omap_vout: Delete two unnecessary variable initialisations in omap_vout_probe()

From: Markus Elfring Date: Sun, 24 Sep 2017 11:33:39 +0200 The variables "dssdev" and "vid_dev" will eventually be set to appropriate pointers a bit later. Thus omit the explicit initialisations at the beginning. Signed-off-by: Markus Elfring

[PATCH 5/6] [media] omap_vout: Delete an unnecessary variable initialisation in omap_vout_open()

From: Markus Elfring Date: Sun, 24 Sep 2017 11:20:11 +0200 The local variable "vout" is reassigned by a statement at the beginning. Thus omit the explicit initialisation. Signed-off-by: Markus Elfring ---

[PATCH 4/6] [media] omap_vout: Fix a possible null pointer dereference in omap_vout_open()

From: Markus Elfring Date: Sun, 24 Sep 2017 11:00:57 +0200 Move a debug message so that a null pointer access can not happen for the variable "vout" in this function. Fixes: 5c7ab6348e7b3fcca2b8ee548306c774472971e2 ("V4L/DVB: V4L2: Add support for OMAP2/3 V4L2

[PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two functions

From: Markus Elfring Date: Sun, 24 Sep 2017 10:30:29 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 2/6] [media] omap_vout: Improve a size determination in two functions

From: Markus Elfring Date: Sun, 24 Sep 2017 10:18:26 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices()

From: Markus Elfring Date: Sun, 24 Sep 2017 10:08:22 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/6] [media] omap_vout: Adjustments for three function implementations

From: Markus Elfring Date: Sun, 24 Sep 2017 12:06:54 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete an error message for a failed memory allocation in omap_vout_create_video_devices()

Re: [GIT PULL FOR v4.15] Cleanup fixes

> Then change patch granularity: one patch per subsystem or per > directory (e. g. pci, usb, platform, others). I imagine that the risks for disagreements can grow with such a bigger scope. > That's the usual criteria most maintainers use for cleanups. I picked some update candidates up where

[PATCH 3/3] [media] camss-csid: Adjust a null pointer check in two functions

From: Markus Elfring Date: Sat, 23 Sep 2017 21:10:02 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!format" Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 2/3] [media] camss-csid: Reduce the scope for a variable in csid_set_power()

From: Markus Elfring Date: Sat, 23 Sep 2017 21:00:30 +0200 Move the definition for the local variable "dev" into an if branch so that the corresponding setting will only be performed if it was selected by the parameter "on" of this function. Signed-off-by: Markus

[PATCH 1/3] [media] camss-csid: Use common error handling code in csid_set_power()

From: Markus Elfring Date: Sat, 23 Sep 2017 20:48:33 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/3] [media] camss-csid: Fine-tuning for three function implementations

From: Markus Elfring Date: Sat, 23 Sep 2017 21:24:56 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in csid_set_power() Reduce the scope for a variable in

Re: [media] v4l2-core: Fine-tuning for some function implementations

>> Will the software evolution be continued for related source files? >> Are there any update candidates left over in the directory “v4l2-core”? > > Sorry, I don't understand the question. I try to explain my view again. > We don't want to touch the videobuf-* files unless there is a very good

Re: [GIT PULL FOR v4.15] Cleanup fixes

>> coccinelle, checkpatch, coverity, etc. … > It **really** doesn't makes any sense to send patch bombs like that! I got an other impression for this software development aspect. > That pisses me off, as it requires a considerable amount of time from > my side that could be used handling

Re: [git:media_tree/master] media: dvb-frontends: delete jump targets

> * Return directly after a call of the function "kzalloc" failed Is this wording still appropriate in the commit description for such a combination of changes for 4 source files? Regards, Markus … > buf = kmalloc(len + 1, GFP_KERNEL); > - if (buf == NULL) { …

Re: [git:media_tree/master] media: drivers: improve size determinations

> This is an automatic generated email to let you know that the following patch > were queued: Thanks for your information about another software evolution which you would like to integrate also. > Subject: media: drivers: improve a size determination … > Replace the specification of a data

Re: [git:media_tree/master] media: drivers: delete error messages for failed memory allocation

> This is an automatic generated email to let you know that the following patch > were queued: Thanks for your information about another software evolution which you would like to integrate also. > Omit an extra message for a memory allocation failure in this function. > > This issue was

Re: [media] spca500: Use common error handling code in spca500_synch310()

> No one needs to argue about keeping it the way it is. I got an other impression in this case after a bit of information was presented which seems to be contradictory. > I don't see any improvement brought by the proposed change, Do you care if the source code for an error message is present

Re: [PATCH 0/8] [media] v4l2-core: Fine-tuning for some function implementations

> Sorry Markus, just stay away from the videobuf-* sources. Will the software evolution be continued for related source files? Are there any update candidates left over in the directory “v4l2-core”? Regards, Markus

Re: [media] spca500: Use common error handling code in spca500_synch310()

>>> They are both equally uninformative. >> >> Which identifier would you find appropriate there? > > error was fine. How do the different views fit together? Regards, Markus

Re: [media] spca500: Use common error handling code in spca500_synch310()

>> return 0; >> -error: >> + >> +report_failure: >> +PERR("Set packet size: set interface error"); >> return -EBUSY; >> } > > Why change the label name? I find the suggested variant a bi better. > They are both equally uninformative. Which identifier would you find appropriate

[PATCH] [media] spca500: Use common error handling code in spca500_synch310()

From: Markus Elfring Date: Fri, 22 Sep 2017 18:45:07 +0200 Adjust a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] [media] sn9c20x: Use common error handling code in sd_init()

From: Markus Elfring Date: Fri, 22 Sep 2017 17:45:33 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [media] usbvision-core: Delete unnecessary braces in 11 functions

> No. Multi-line indents get curly braces for readability. Which of the proposed change possibilities do you not like especially at the moment? Regards, Markus

Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()

>> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct >> usb_usbvision *usbvision) >> USB_DIR_OUT | USB_TYPE_VENDOR | >> USB_RECIP_ENDPOINT, 0, >> (__u16) USBVISION_PCM_THR1, value, 6, HZ); >> +

[PATCH 3/3] [media] uvcvideo: Add some spaces for better code readability

From: Markus Elfring Date: Thu, 21 Sep 2017 21:12:29 +0200 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_v4l2.c | 13

[PATCH 2/3] [media] uvcvideo: Adjust 14 checks for null pointers

From: Markus Elfring Date: Thu, 21 Sep 2017 21:00:21 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 1/3] [media] uvcvideo: Use common error handling code in uvc_ioctl_g_ext_ctrls()

From: Markus Elfring Date: Thu, 21 Sep 2017 20:47:02 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/3] [media] uvcvideo: Fine-tuning for some function implementations

From: Markus Elfring Date: Thu, 21 Sep 2017 21:20:12 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in uvc_ioctl_g_ext_ctrls() Adjust 14 checks for null pointers Add

[PATCH 4/4] [media] usbvision-core: Replace four printk() calls by dev_err()

From: Markus Elfring Date: Thu, 21 Sep 2017 16:47:28 +0200 * Replace the local variable "proc" by the identifier "__func__". * Use the interface "dev_err" instead of "printk" in these functions. Signed-off-by: Markus Elfring ---

[PATCH 3/4] [media] usbvision-core: Delete unnecessary braces in 11 functions

From: Markus Elfring Date: Thu, 21 Sep 2017 16:24:20 +0200 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring ---

[PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()

From: Markus Elfring Date: Thu, 21 Sep 2017 12:45:49 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Replace the local variable "proc" by the identifier "__func__". * Use the interface "dev_err"

[PATCH 1/4] [media] usbvision-core: Use common error handling code in usbvision_set_input()

From: Markus Elfring Date: Thu, 21 Sep 2017 11:50:54 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * Replace the local variable "proc"

[PATCH 0/4] [media] usbvision-core: Fine-tuning for some function implementations

From: Markus Elfring Date: Thu, 21 Sep 2017 17:00:17 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use common error handling code in usbvision_set_input() Use common error handling code in

Re: [media] s2255drv: Adjust 13 checks for null pointers

>> Would you like to clarify corresponding concerns any more? >> > > Look at the `git log` I did this also for a moment. > and it just copies those lines: The Git software preserves these three message fields (when special characters were used in the commit message). Can you accept such

Re: [media] s2255drv: Adjust 13 checks for null pointers

>> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> > > You've been told several times that this stuff doesn't work. This functionality might not exactly work in the way that you expect so far. > Try applying this patch with `git am` and you'll

[PATCH 3/3] [media] dvb-ttusb-budget: Adjust eight checks for null pointers

From: Markus Elfring Date: Wed, 20 Sep 2017 20:53:13 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 2/3] [media] dvb-ttusb-budget: Improve two size determinations in ttusb_probe()

From: Markus Elfring Date: Wed, 20 Sep 2017 20:46:11 +0200 * The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix an affected source code place. * Replace the specification of data

[PATCH 1/3] [media] dvb-ttusb-budget: Use common error handling code in ttusb_probe()

From: Markus Elfring Date: Wed, 20 Sep 2017 20:25:24 +0200 Add two jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/3] [media] TTUSB DVB Budget: Fine-tuning for three function implementations

From: Markus Elfring Date: Wed, 20 Sep 2017 21:03:45 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in ttusb_probe() Improve two size determinations in ttusb_probe()

Re: [media] Siano: Use common error handling code in smsusb_init_device()

> If smscore_register_device() succeeds then mdev is freed when we call > smsusb_term_device(intf); The call tree is: Thanks for your constructive information. How do you think about another implementation detail in this function then? May the statement “kfree(mdev);” be executed before

[PATCH 5/5] [media] s2255drv: Delete an unnecessary return statement in five functions

From: Markus Elfring Date: Wed, 20 Sep 2017 17:50:36 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions.

[PATCH 4/5] [media] s2255drv: Use common error handling code in read_pipe_completion()

From: Markus Elfring Date: Wed, 20 Sep 2017 17:45:13 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/media/usb/s2255/s2255drv.c

[PATCH 3/5] [media] s2255drv: Improve two size determinations in s2255_probe()

From: Markus Elfring Date: Wed, 20 Sep 2017 16:56:20 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/5] [media] s2255drv: Adjust 13 checks for null pointers

From: Markus Elfring Date: Wed, 20 Sep 2017 16:46:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 1/5] [media] s2255drv: Delete three error messages for a failed memory allocation in s2255_probe()

From: Markus Elfring Date: Wed, 20 Sep 2017 16:30:13 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/5] [media] s2255drv: Fine-tuning for some function implementations

From: Markus Elfring Date: Wed, 20 Sep 2017 18:18:28 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete three error messages for a failed memory allocation in s2255_probe() Adjust 13 checks for

[PATCH] [media] Siano: Use common error handling code in smsusb_init_device()

From: Markus Elfring Date: Wed, 20 Sep 2017 14:30:55 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This refactoring might fix also an error situation where the function "kfree" was not called after a

Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()

>> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client, >> /* initialize the audio */ >> if (write_regs(audio, aud_regs) < 0) { >> dev_err(>dev, "error initializing audio\n"); >> -goto fail; >> +goto e_io; > > Preserve the error

[PATCH 3/3] [media] pvrusb2-ioread: Delete unnecessary braces in six functions

From: Markus Elfring Date: Wed, 20 Sep 2017 08:15:51 +0200 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring ---

[PATCH 2/3] [media] pvrusb2-ioread: Delete an unnecessary check before kfree() in two functions

From: Markus Elfring Date: Tue, 19 Sep 2017 22:12:49 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: kfree(NULL) is safe and this check is probably not required Thus fix the affected source code places. Signed-off-by: Markus

[PATCH 1/3] [media] pvrusb2-ioread: Use common error handling code in pvr2_ioread_get_buffer()

From: Markus Elfring Date: Tue, 19 Sep 2017 21:50:05 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/3] [media] pvrusb2-ioread: Fine-tuning for eight function implementations

From: Markus Elfring Date: Wed, 20 Sep 2017 08:28:48 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in pvr2_ioread_get_buffer() Delete an unnecessary check before

[PATCH 3/3] [media] hdpvr: Return an error code only as a constant in hdpvr_alloc_buffers()

From: Markus Elfring Date: Tue, 19 Sep 2017 19:32:36 +0200 * Return an error code without storing it in an intermediate variable. * Delete the local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

[PATCH 2/3] [media] hdpvr: Improve a size determination in hdpvr_alloc_buffers()

From: Markus Elfring Date: Tue, 19 Sep 2017 19:27:53 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/3] [media] hdpvr: Delete three error messages for a failed memory allocation

From: Markus Elfring Date: Tue, 19 Sep 2017 09:33:26 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] [media] HD PVR USB: Adjustments for two function implementations

From: Markus Elfring Date: Tue, 19 Sep 2017 20:21:23 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete three error messages for a failed memory allocation Improve a size determination in

[PATCH 2/2] [media] vicam: Return directly after a failed kmalloc() in vicam_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 21:56:55 +0200 * Return directly after a call of the function "kmalloc" failed at the beginning. * Delete the jump target "exit" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

[PATCH 1/2] [media] vicam: Delete an error message for a failed memory allocation in vicam_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 21:48:55 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] ViCam: Adjustments for vicam_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 22:05:22 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Return directly after a failed kmalloc()

[PATCH] [media] sq905: Delete an error message for a failed memory allocation in sq905_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 21:30:58 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] [media] jl2005bcd: Delete an error message for a failed memory allocation in jl2005c_dostream()

From: Markus Elfring Date: Mon, 18 Sep 2017 19:24:24 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] [media] gspca: Use common error handling code in gspca_init_transfer()

From: Markus Elfring Date: Mon, 18 Sep 2017 18:40:05 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

  1   2   3   4   5   6   >