Re: [PATCH] MAINTAINERS fixups

On 11/08/2018 02:23 PM, Hans Verkuil wrote: > Update file paths in MAINTAINERS. > > Signed-off-by: Hans Verkuil > Reported-by: Joe Perches Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

s2 so it covers the s5p-mfc and exynos4-is (fimc-m2m) drivers. Well done, I couldn't see any breakage. You can add "Tested-by: Sylwester Nawrocki " to patches: 1, 2, 3, 7, 8, 10. -- Regards, Sylwester

Re: [RFC PATCH 10/11] v4l2-ioctl: remove unused vidioc_g/s_crop

On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Now that all drivers have dropped vidioc_g/s_crop we can remove > support for them in the V4L2 core. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 08/11] exynos4-is: convert g/s_crop to g/s_selection

lly shouldn't have since > g_crop returns a compose rectangle instead of a crop rectangle for the > CAPTURE stream, and vice versa for the OUTPUT stream. > > Also drop the now unused vidioc_cropcap. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 09/11] s5p-g2d: convert g/s_crop to g/s_selection

lly shouldn't have since > g_crop returns a compose rectangle instead of a crop rectangle for the > CAPTURE stream, and vice versa for the OUTPUT stream. > > Also drop the now unused vidioc_cropcap. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 07/11] s5p_mfc_dec.c: convert g_crop to g_selection

s the selection > API. Those old drivers allowed g_crop when it really shouldn't have > since g_crop returns a compose rectangle instead of a crop rectangle. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 06/11] exynos-gsc: replace v4l2_crop by v4l2_selection

On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Replace the use of struct v4l2_crop by struct v4l2_selection. > Also drop the unused gsc_g_crop function. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 03/11] v4l2-ioctl: add QUIRK_INVERTED_CROP

y is ensured and we can convert the > Samsung drivers to the selection API. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 01/11] v4l2-ioctl: don't use CROP/COMPOSE_ACTIVE

On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > Drop the deprecated _ACTIVE part. > > Signed-off-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

Hi Hans, On Fri, 5 Oct 2018 at 09:49, Hans Verkuil wrote: > > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. Thank you for this clean up! I remember attempting conversion of those remaining drivers to selection API

Re: [RESEND PATCH 1/1] v4l: samsung, ov9650: Rely on V4L2-set sub-device names

Hi Sakari, On 09/16/2018 12:52 AM, Sakari Ailus wrote: > v4l2_i2c_subdev_init() sets the name of the sub-devices (as well as > entities) to what is fairly certainly known to be unique in the system, > even if there were more devices of the same kind. > > These drivers (m5mols, noon010pc30,

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

On 09/20/2018 06:49 PM, Grant Grundler wrote: > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen >> wrote: >>> +/* Digital gain control */ >>> +#define IMX208_DGTL_GAIN_MIN 0 >>> +#define IMX208_DGTL_GAIN_MAX 4096 >>>

Re: [RFC 1/1] v4l: samsung, ov9650: Rely on V4L2-set sub-device names

Hi Sakari, On Thu, 13 Sep 2018 at 11:21, Sakari Ailus wrote: [...] > diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > index ce196b60f917..64212551524e 100644 > --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > +++

Re: [PATCH v2 2/3] s5p-g2d: Remove unrequired wait in .job_abort

On 07/06/2018 03:43 PM, Ezequiel Garcia wrote: Could you elaborate how the core ensures DMA operation is not in progress after VIDIOC_STREAMOFF, VIDIOC_DQBUF with this patch applied? Well, .streamoff is handled by v4l2_m2m_streamoff, which guarantees that no job is running by calling

Re: [PATCH v2 2/3] s5p-g2d: Remove unrequired wait in .job_abort

Hi, On 07/04/2018 10:04 AM, Hans Verkuil wrote: > On 18/06/18 06:38, Ezequiel Garcia wrote: >> As per the documentation, job_abort is not required >> to wait until the current job finishes. It is redundant >> to do so, as the core will perform the wait operation. Could you elaborate how the core

Re: [PATCH] media: s3c-camif: ignore -ENOIOCTLCMD from v4l2_subdev_call for s_power

the v4l2_subdev_call should be ignored. Signed-off-by: Akinobu Mita Acked-by: Sylwester Nawrocki

[PATCH] s5p-mfc: Fix buffer look up in s5p_mfc_handle_frame_{new, copy_time} functions

atch are minimal as there is a larger patch series pending refactoring the whole driver. Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c

Re: [PATCH 3/7] s5p-mfc: fix two sparse warnings

strncpy(cap->card, dev->vfd_dec->name, sizeof(cap->card) - 1); > ^ > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 26/61] media: platform: exynos4-is: simplify getting .drvdata

On 04/19/2018 04:05 PM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 27/61] media: platform: s5p-mfc: simplify getting .drvdata

On 04/19/2018 04:05 PM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

[PATCH] exynos4-is: Prevent NULL pointer dereference in __isp_video_try_fmt()

xes: 34947b8aebe3: ("[media] exynos4-is: Add the FIMC-IS ISP capture DMA driver") Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/platform/exynos4-is/fimc-isp-video.c | 11 --- 1 file changed, 8 i

Re: [bug report] [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver

disabled anyway for other reasons. > Hello Sylwester Nawrocki, > > The patch 34947b8aebe3: "[media] exynos4-is: Add the FIMC-IS ISP > capture DMA driver" from Dec 20, 2013, leads to the following static > checker warning: > > drivers/media/

Re: [git:media_tree/master] media: include/media: fix missing | operator when setting cfg

Hi Mauro, On 05/05/2018 03:01 PM, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued: > > Subject: media: include/media: fix missing | operator when setting cfg I intended to submit this patch in a pull request, with

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:24 PM, Colin Ian King wrote: > Oops, shall I re-send? There is no need to, thanks.

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

d actually be instead the |= operator. > > Detected by CoverityScan, CID#1467987 ("Unused value") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks for the patch. Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 07/16] media: exymos4-is: allow compile test for EXYNOS FIMC-LITE

lho Chehab <mche...@s-opensource.com> With s/exymos4-is/exynos4-is in the subject Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Regards, Sylwester

[GIT PULL] HEVC V4L2 controls and s5p-mfc update

: Support MFCv10.10 buffer requirements s5p-mfc: Add support for HEVC decoder s5p-mfc: Add VP9 decoder support s5p-mfc: Add support for HEVC encoder Sylwester Nawrocki (2): s5p-mfc: Ensure HEVC QP controls range is properly updated s5p-mfc: Amend initial min, max values

[PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls

Valid range for those controls is specified in documentation as [0, 51], so initialize the controls to such range rather than [INT_MIN, INT_MAX]. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 28 ++--

[PATCH] s5p-mfc: Ensure HEVC QP controls range is properly updated

When value of V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP or V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP controls is changed we should update range of a set of HEVC quantization parameter v4l2 controls as specified in the HEVC controls documentation. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.

Re: [GIT PULL] HEVC V4L2 controls and s5p-mfc update

On 03/12/2018 05:49 PM, Hans Verkuil wrote: > On 03/12/2018 09:35 AM, Sylwester Nawrocki wrote: >> On 03/12/2018 05:19 PM, Hans Verkuil wrote: >>> Does this include this __v4l2_ctrl_modify_range() request: >>> >>> https://patchwork.kernel.org/patch/10196

Re: [GIT PULL] HEVC V4L2 controls and s5p-mfc update

Hi Hans, On 03/12/2018 05:19 PM, Hans Verkuil wrote: > Does this include this __v4l2_ctrl_modify_range() request: > > https://patchwork.kernel.org/patch/10196605/ > > I haven't seen anything for that. I'd like to see that implemented before this > is merged, otherwise this typically will never

[GIT PULL] HEVC V4L2 controls and s5p-mfc update

Hi Mauro, The following changes since commit 3f127ce11353fd1071cae9b65bc13add6aec6b90: media: em28xx-cards: fix em28xx_duplicate_dev() (2018-03-08 06:06:51 -0500) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git tags/for-v4.17/media/samsung for you to fetch

Re: [PATCH v3 2/3] media: MAINTAINERS: add entry for ov9650 driver

s a person who has the hardware and can test the patches > > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Cc: Jacopo Mondi <jac...@jmondi.org> > Cc: H. Nikolaus Schaller <h...@goldelico.com> > Cc: Hugues Fruchet <hugues.fruc...@st.com> > Cc: Sakari Ailus <

Re: [PATCH] [media] s3c-camif: array underflow in __camif_subdev_try_format()

On 01/22/2018 11:37 AM, Dan Carpenter wrote: > The while loop is a post op, "while (i-- >= 0)" so the last iteration > will read camif_mbus_formats[-1] and then the loop will exit with "i" > set to -2 and so we do: "mf->code = camif_mbus_formats[-2];". > > I've changed it to a pre-op, I've added

Re: [PATCH v2 2/2] media: ov9650: add device tree binding

On 01/08/2018 10:35 AM, Sakari Ailus wrote: > I was going to say you're missing the MAINTAINERS entry for this newly > added file but then I noticed that the entire driver is missing an entry. > Still this file should have a MAINTAINERS entry added for it independently > of that, in the same

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

> > sd = >sd; > v4l2_i2c_subdev_init(sd, client, _subdev_ops); > @@ -1502,10 +1550,6 @@ static int ov965x_probe(struct i2c_client *client, > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | >V4L2_SUBDEV_FL_HAS_EVENTS; > > - ret = ov965x_configure_gpios(ov965x, pdata); > - if (ret < 0) > - goto err_mutex; > - > ov965x->pad.flags = MEDIA_PAD_FL_SOURCE; > sd->entity.function = MEDIA_ENT_F_CAM_SENSOR; > ret = media_entity_pads_init(>entity, 1, >pad); > @@ -1561,9 +1605,19 @@ static const struct i2c_device_id ov965x_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, ov965x_id); > > +#if IS_ENABLED(CONFIG_OF) Is there any advantage in using IS_ENABLED() rather than just #ifdef CONFIG_OF ? of_match_ptr() is defined with just #idef CONFIG_OF/ #else/#endif. I would use simply #ifdef CONFIG_OF here. Otherwise looks good. Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Regards, Sylwester

[GIT PULL] Samsung SoC related updates

: Fix lock contention - request_firmware() once Simon Shields (1): exynos4-is: Check pipe is valid before calling subdev Sylwester Nawrocki (1): s5p-mfc: Fix encoder menu controls initialization drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +--- drivers/media/platform/exynos4

[PATCH] s5p-mfc: Fix encoder menu controls initialization

-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c index 2a5fd7c42cd5..0d5d465561be

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

On 12/12/2017 03:34 AM, Smitha T Murthy wrote: >> s/Lay/Layer here and below >> > Ok I will change it. While it's fine to make such change for controls up to V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP... >>> + case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP:return "HEVC >>>

Re: [PATCH 12/22] media: s3c-camif: add missing description at s3c_camif_find_format()

On 11/29/2017 08:08 PM, Mauro Carvalho Chehab wrote: > Fix this warning: > drivers/media/platform/s3c-camif/camif-core.c:112: warning: No > description found for parameter 'vp' > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Sylwes

Re: [PATCH 4/7] media: exynos4-is: Remove dependency on obsolete SoC support

-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

[GIT PULL] Exynos/S5P updates for 4.15

Hi Mauro, The following changes since commit 8382e556b1a2f30c4bf866f021b33577a64f9ebf: Simplify major/minor non-dynamic logic (2017-10-11 15:32:11 -0400) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.15/media/next for you to fetch changes up to

Re: [PATCH v15 01/32] v4l: async: Remove re-probing support

Hi Sakari, On 10/09/2017 04:18 PM, Sakari Ailus wrote: > Sure, how about this at the end of the current commit message: > > If there is a need to support removing the clock provider in the future, > this should be implemented in the clock framework instead, not in V4L2. I find it a little bit

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

ts. > > At drivers, this makes even clearer about the match criteria. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

hehab <mche...@s-opensource.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: as3645a flash userland interface

On 09/14/2017 01:53 PM, Pavel Machek wrote: On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote: On 09/14/2017 12:07 PM, Pavel Machek wrote: Isn't the V4L2 subdev/Media Controller API supposed to provide means for associating flash LEDs with camera sensors? You seem to be insisting on using

Re: as3645a flash userland interface

On 09/14/2017 12:07 PM, Pavel Machek wrote: Isn't the V4L2 subdev/Media Controller API supposed to provide means for associating flash LEDs with camera sensors? You seem to be insisting on using the sysfs leds interface for that, which is not a primary interface for camera flash AFAICT. > a)

Re: as3645a flash userland interface

Hi, On 09/13/2017 07:53 PM, Jacek Anaszewski wrote: On 09/12/2017 11:55 PM, Pavel Machek wrote: On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote: On 09/12/2017 12:36 PM, Pavel Machek wrote: What directory are the flash controls in? /sys/class/leds/led-controller:flash ? Could we

Re: [PATCH] [media] s3c-camif: fix out-of-bounds array access

On 09/13/2017 04:03 PM, Arnd Bergmann wrote: On Wed, Sep 13, 2017 at 11:25 AM, Sylwester Nawrocki <s.nawro...@samsung.com> wrote: On 09/12/2017 10:09 PM, Arnd Bergmann wrote: { const struct s3c_camif_variant *variant = camif->variant; const struct vp_pix_limits

Re: [PATCH] s5p-cec: add NACK detection support

status to userspace. This was the only driver that couldn't tell a NACK from another error, and that was very unusual. And a potential problem for applications as well. Tested with my Odroid-U3. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki &l

Re: [PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits

On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: Hoegeun Kwon (4): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits [media] exynos-gsc: Add hardware rotation

Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) .num_clocks = 1, }; +static struct gsc_driverdata gsc_v_5250_drvdata = { + .variant = { + [0] = _v_5250_variant, + [1] =

Re: [PATCH] [media] s3c-camif: fix out-of-bounds array access

On 09/12/2017 10:09 PM, Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > > drivers/media/platform/s3c-camif/camif-capture.c: In function > '__camif_subdev_try_format': >

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

Hi Hoegeun, On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: >>> @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, >>> void *priv) >>> static const struct of_device_id exynos_gsc_match[] = { >>>{ >>> -.compatible = "samsung,exynos5-gsc", >>> -.data =

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

On 09/12/2017 05:00 PM, SF Markus Elfring wrote: * Do you care to preserve an information like the author date? In this case not, but actually the Date line is not an issue. Thanks for your information. It seems then that you quoted a line too much. Anyway the patch is malformed, … > I

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

On 09/11/2017 09:21 PM, SF Markus Elfring wrote: Date: Fri, 8 Sep 2017 22:37:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Can you resend with that 4 lines removed? * Do you care to preserve an information like the author date? In this

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

On 09/08/2017 08:02 AM, Hoegeun Kwon wrote: The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon --- drivers/media/platform/exynos-gsc/gsc-core.c | 96

Re: [PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions

On 09/08/2017 10:53 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 8 Sep 2017 22:37:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Can you resend with that 4 lines removed? Are you using git

Re: [PATCH 2/3] [media] s5p-mfc: Improve a size determination in s5p_mfc_alloc_memdev()

s detected by using the Coccinelle software. Signed-off-by: Markus Elfring<elfr...@users.sourceforge.net> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

o keep it below 70 characters [1]? With that changed feel free to add Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Regards, Sylwester [1] Documentation/process/submitting-patches.rst

Re: [PATCH 3/5] s5p-cec: use CEC_CAP_DEFAULTS

On 08/04/2017 12:41 PM, Hans Verkuil wrote: Use the new CEC_CAP_DEFAULTS define in the s5p-cec driver. Signed-off-by: Hans Verkuil<hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 1/5] media/cec.h: add CEC_CAP_DEFAULTS

com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

[GIT PULL] s5p-jpeg fixes for v4.14-rc1

Hi Mauro, The following changes since commit ec0c3ec497cabbf3bfa03a9eb5edcc252190a4e0: media: ddbridge: split code into multiple files (2017-08-09 12:17:01 -0400) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.14/media/next-2 for you to fetch

Re: [PATCH 4/5] media: platform: s5p-jpeg: fix number of components macro

On 08/08/2017 01:27 PM, Andrzej Pietrasiewicz wrote: The value to be processed must be first masked and then shifted, not the other way round. Signed-off-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH 5/6] [media] exynos4-is: constify video_subdev structures

.fr> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 03/12] [media] s5p-g2d: constify v4l2_m2m_ops structures

law...@lip6.fr> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 11/12] [media] exynos4-is: constify v4l2_m2m_ops structures

law...@lip6.fr> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 06/12] [media] exynos-gsc: constify v4l2_m2m_ops structures

ip6.fr> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCHv2 5/5] media-device: remove driver_version

On 07/21/2017 12:57 PM, Hans Verkuil wrote: From: Hans Verkuil Since the driver_version field in struct media_device is no longer used, just remove it. Signed-off-by: Hans Verkuil --- drivers/media/media-device.c | 3 ---

Re: [PATCHv2 5/5] media-device: remove driver_version

On 07/21/2017 12:57 PM, Hans Verkuil wrote: From: Hans Verkuil <hans.verk...@cisco.com> Since the driver_version field in struct media_device is no longer used, just remove it. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCHv2 2/5] s3c-camif: don't set driver_version

On 07/21/2017 12:57 PM, Hans Verkuil wrote: From: Hans Verkuil<hans.verk...@cisco.com> This field will be removed as it is not needed anymore. Signed-off-by: Hans Verkuil<hans.verk...@cisco.com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH v2] media: Convert to using %pOF instead of full_name

--- v2: - Fix missing to_of_node() in xilinx-vipp.c - Drop v4l2-async.c changes. Doing as revert instead. - Add acks Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

[GIT PULL FOR 4.14] Samsung SoC related updates

Hi Mauro, The following changes since commit 6538b02d210f52ef2a2e67d59fcb58be98451fbd: media: Make parameter of media_entity_remote_pad() const (2017-07-20 16:54:04 -0400) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.14/media/next for you to

Re: [PATCH] media: Convert to using %pOF instead of full_name

On 07/19/2017 06:02 PM, Rob Herring wrote: diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index 851f128eba22..0a385d1ff28c 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -47,9 +47,7 @@ static bool

Re: [PATCH] media: Convert to using %pOF instead of full_name

On 07/18/2017 11:43 PM, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > --- >

Re: [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera

Hi Hugues, On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > This patchset enables OV9655 camera support. > > OV9655 support has been tested using STM32F4DIS-CAM extension board > plugged on connector P1 of STM32F746G-DISCO board. > Due to lack of OV9650/52 hardware support, the modified related

Re: [PATCH v2 3/7] [media] ov9650: add device tree support

On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > Allows use of device tree configuration data. > If no device tree data is there, configuration is taken from platform data. > In order to keep GPIOs configuration compatible between both way of doing, > GPIOs are switched to descriptor-based

Re: [PATCH v2 2/7] [media] ov9650: switch i2c device id to lower case

hat so it is clear why we break any non-dt platform that could be already using this driver. There seem to be none in the mainline kernel tree though. > Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com> Reviewed-by: Sylwester Nawrocki <snawro...@kernel.org> > Signed-off-by: Hug

Re: [PATCH v2 0/7] [PATCH v2 0/7] Add support of OV9655 camera

Hi Hugues, On 07/06/2017 09:51 AM, Hugues FRUCHET wrote: Hi Sylwester, Do you have the possibility to check for non-regression of this patchset on 9650/52 camera ? I will try to test your patch set once I find the camera module for my Micro2440SDK board. I've spent already a day on setting

Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

On 07/06/2017 12:24 PM, Jose Abreu wrote: >>> +- edid-phandle: phandle to the EDID handler block. >> >> Could you make this property optional and when it is missing assume that >> device >> corresponding to the parent node of this node handles EDID? This way we could >> avoid having property

Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

On 07/04/2017 04:11 PM, Jose Abreu wrote: > Document the bindings for the Synopsys Designware HDMI RX. > > Signed-off-by: Jose Abreu > --- > .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 70 > ++ > 1 file changed, 70 insertions(+) > create

Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi, On 06/28/2017 03:31 PM, Sakari Ailus wrote: IMO VB2/V4L2 could better support conversion between single and multi-planar buffer types so that the applications could just use any and drivers could manage with one. I don't have a strong opinion either way, but IMO this could be well

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

On 06/28/2017 11:12 AM, H. Nikolaus Schaller wrote: >> Am 28.06.2017 um 00:57 schrieb Sylwester Nawrocki <snawro...@kernel.org>: >> On 06/27/2017 07:48 AM, H. Nikolaus Schaller wrote: >>>> Am 26.06.2017 um 22:04 schrieb Sylwester Nawrocki <snawro...@kernel.org>:

Re: [PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Hi Jose, On 06/28/2017 11:25 AM, Jose Abreu wrote: On 27-06-2017 21:34, Sylwester Nawrocki wrote: On 06/27/2017 10:43 AM, Jose Abreu wrote: On 25-06-2017 22:13, Sylwester Nawrocki wrote: On 06/20/2017 07:26 PM, Jose Abreu wrote: This is an initial submission for the Synopsys Designware HDMI

Re: [PATCH 2/3] media: ti-vpe: cal: use of_graph_get_remote_endpoint()

On 06/28/2017 02:33 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto <kuninori.morimoto...@renesas.com> Now, we can use of_graph_get_remote_endpoint(). Let's use it. Signed-off-by: Kuninori Morimoto<kuninori.morimoto...@renesas.com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

On 06/27/2017 07:48 AM, H. Nikolaus Schaller wrote: >> Am 26.06.2017 um 22:04 schrieb Sylwester Nawrocki <snawro...@kernel.org>: >> >> On 06/26/2017 12:35 PM, Hugues FRUCHET wrote: >>>> What I am missing to support the GTA04 camera is the control of the

Re: [PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Hi Jose, On 06/27/2017 10:43 AM, Jose Abreu wrote: > On 25-06-2017 22:13, Sylwester Nawrocki wrote: >> On 06/20/2017 07:26 PM, Jose Abreu wrote: >>> This is an initial submission for the Synopsys Designware HDMI RX >>> Controller Driver. This driver int

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

On 06/26/2017 12:35 PM, Hugues FRUCHET wrote: >> What I am missing to support the GTA04 camera is the control of the optional >> "vana-supply". >> So the driver does not power up the camera module when needed and therefore >> probing fails. >> >> - vana-supply: a regulator to power up the

Re: [PATCH v3 2/2] v4l: async: add subnotifier registration for subdevices

()/unregistered() callbacks are called. Signed-off-by: Niklas Söderlund<niklas.soderlund+rene...@ragnatech.se> Acked-by: Hans Verkuil<hans.verk...@cisco.com> Acked-by: Sakari Ailus<sakari.ai...@linux.intel.com> Acked-by: Sylwester Nawrocki <snawro...@kernel.org>

Re: [PATCH v3 1/2] v4l: async: check for v4l2_dev in v4l2_async_notifier_register()

Ailus<sakari.ai...@linux.intel.com> Acked-by: Hans Verkuil<hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <snawro...@kernel.org>

Re: [PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

ose Abreu <joab...@synopsys.com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sylwester Nawrocki <snawro...@kernel.org> > > Changes from v3: >

Re: [PATCH v4 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

Hi Jose, Thank you for addressing my review comments. Couple more suggestions below. On 06/20/2017 07:26 PM, Jose Abreu wrote: > This adds support for the Synopsys Designware HDMI RX PHY e405. This > phy receives and decodes HDMI video that is delivered to a controller. > +static int

Re: [PATCH 2/4] media: s3c-camif: use LINUX_VERSION_CODE for driver's version

com> Acked-by: Sylwester Nawrocki <snawro...@kernel.org>

Re: [PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior

es, we messed up:-( Signed-off-by: Hans Verkuil<hans.verk...@cisco.com> Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester

Re: [PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling

: Hans Verkuil <hansv...@cisco.com> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester

Re: [PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

On 06/19/2017 11:33 AM, Jose Abreu wrote: > On 18-06-2017 19:04, Sylwester Nawrocki wrote: >> On 06/16/2017 06:38 PM, Jose Abreu wrote: >>> This is an initial submission for the Synopsys Designware HDMI RX >>> Controller Driver. This driver interacts with a phy driver

Re: [PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

On 06/19/2017 11:01 AM, Jose Abreu wrote: > Using fixed-clock was already in my todo list. Regarding phy I > need to pass pdata so that the callbacks between controller and > phy are established. I also need to make sure that phy driver > will be loaded by the controller driver. Hmm, and also

Re: [RFC PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior

Hi Hans, On 06/19/2017 09:35 AM, Hans Verkuil wrote: diff --git a/Documentation/media/uapi/v4l/vidioc-cropcap.rst b/Documentation/media/uapi/v4l/vidioc-cropcap.rst index f21a69b554e1..d354216846e6 100644 --- a/Documentation/media/uapi/v4l/vidioc-cropcap.rst +++

Re: [RFC PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior

On 06/16/2017 03:08 PM, Sakari Ailus wrote: > On Mon, May 08, 2017 at 04:35:06PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Unfortunately the use of 'type' was inconsistent for multiplanar >> buffer types. Starting with 4.12 both the normal and _MPLANE variants

  1   2   3   4   5   6   7   8   9   10   >