Re: [PATCH v2] [media] mt9p031: fixed calculation of clk_div

2015-02-05 Thread Laurent Pinchart
Hi Enrico,

Thank you for the patch.

On Wednesday 04 February 2015 18:51:10 Enrico Scholz wrote:
 There must be used 'min_t', not 'max_t' for calculating the divider.
 
 Signed-off-by: Enrico Scholz enrico.sch...@sigma-chemnitz.de
 Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com

Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

and applied to my tree. I'll send a pull request for v3.21.

 ---
  drivers/media/i2c/mt9p031.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
 index 0cabf91..43ee299 100644
 --- a/drivers/media/i2c/mt9p031.c
 +++ b/drivers/media/i2c/mt9p031.c
 @@ -254,7 +254,7 @@ static int mt9p031_clk_setup(struct mt9p031 *mt9p031)
   div = DIV_ROUND_UP(ext_freq, pdata-target_freq);
   div = roundup_pow_of_two(div) / 2;
 
 - mt9p031-clk_div = max_t(unsigned int, div, 64);
 + mt9p031-clk_div = min_t(unsigned int, div, 64);
   mt9p031-use_pll = false;
 
   return 0;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2] [media] mt9p031: fixed calculation of clk_div

2015-02-04 Thread Enrico Scholz
There must be used 'min_t', not 'max_t' for calculating the divider.

Signed-off-by: Enrico Scholz enrico.sch...@sigma-chemnitz.de
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
 drivers/media/i2c/mt9p031.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
index 0cabf91..43ee299 100644
--- a/drivers/media/i2c/mt9p031.c
+++ b/drivers/media/i2c/mt9p031.c
@@ -254,7 +254,7 @@ static int mt9p031_clk_setup(struct mt9p031 *mt9p031)
div = DIV_ROUND_UP(ext_freq, pdata-target_freq);
div = roundup_pow_of_two(div) / 2;
 
-   mt9p031-clk_div = max_t(unsigned int, div, 64);
+   mt9p031-clk_div = min_t(unsigned int, div, 64);
mt9p031-use_pll = false;
 
return 0;
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html