Re: [PATCH] adv7611: Set HPD GPIO direction to output

2014-03-26 Thread Hans Verkuil
Hi Laurent, Stupid question perhaps, but why is gpiod_set_value_cansleep() removed? Does setting the output direction force the value to 0 as well? Regards, Hans On 03/26/14 03:28, Laurent Pinchart wrote: The HPD GPIO is used as an output but its direction is never set. Fix it.

Re: [PATCH] adv7611: Set HPD GPIO direction to output

2014-03-26 Thread Laurent Pinchart
Hi Hans, On Wednesday 26 March 2014 10:52:30 Hans Verkuil wrote: Hi Laurent, Stupid question perhaps, but why is gpiod_set_value_cansleep() removed? Does setting the output direction force the value to 0 as well? The last argument to gpiod_direction_output() sets the initial output level,

Re: [PATCH] adv7611: Set HPD GPIO direction to output

2014-03-26 Thread Hans Verkuil
In that case: Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans On 03/26/14 11:03, Laurent Pinchart wrote: Hi Hans, On Wednesday 26 March 2014 10:52:30 Hans Verkuil wrote: Hi Laurent, Stupid question perhaps, but why is gpiod_set_value_cansleep() removed? Does setting

[PATCH] adv7611: Set HPD GPIO direction to output

2014-03-25 Thread Laurent Pinchart
The HPD GPIO is used as an output but its direction is never set. Fix it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/adv7604.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This patch applies on top of the ADV7611 support series queued for