Re: [PATCH 03/13] media: adv7604: fix probe of ADV7611/7612

2015-07-27 Thread William Towle
On Fri, 24 Jul 2015, Hans Verkuil wrote: - val2 |= val; + val |= val2; Oops. Added to my TODO list, I'll probably pick this up on Tuesday for a pull request. And an oops from me: a keen-eyed local correspondent spotted that I'd omitted the S-o-b :( Wills. ...

Re: [PATCH 03/13] media: adv7604: fix probe of ADV7611/7612

2015-07-24 Thread Hans Verkuil
On 07/23/2015 02:21 PM, William Towle wrote: Prior to commit f862f57d ([media] media: i2c: ADV7604: Migrate to regmap), the local variable 'val' contained the combined register reads used in the chipset version ID test. Restore this expectation so that the comparison works as it used to. ---

Re: [Linux-kernel] [PATCH 03/13] media: adv7604: fix probe of ADV7611/7612

2015-07-24 Thread Ben Dooks
On 23/07/15 13:21, William Towle wrote: Prior to commit f862f57d ([media] media: i2c: ADV7604: Migrate to regmap), the local variable 'val' contained the combined register reads used in the chipset version ID test. Restore this expectation so that the comparison works as it used to. Forgot

[PATCH 03/13] media: adv7604: fix probe of ADV7611/7612

2015-07-23 Thread William Towle
Prior to commit f862f57d ([media] media: i2c: ADV7604: Migrate to regmap), the local variable 'val' contained the combined register reads used in the chipset version ID test. Restore this expectation so that the comparison works as it used to. --- drivers/media/i2c/adv7604.c |2 +- 1 file