Re: [PATCH 1/4] v4l: add support for selection api

2011-10-17 Thread Tomasz Stanislawski
Hi Sakari, On 10/14/2011 07:19 PM, Sakari Ailus wrote: On Wed, Oct 12, 2011 at 05:08:20PM +0200, Tomasz Stanislawski wrote: On 10/12/2011 01:48 PM, Sakari Ailus wrote: Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... diff --git a/include/linux/videodev2.h

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-17 Thread Sakari Ailus
On Mon, Oct 17, 2011 at 03:31:17PM +0200, Tomasz Stanislawski wrote: Hi Sakari, On 10/14/2011 07:19 PM, Sakari Ailus wrote: On Wed, Oct 12, 2011 at 05:08:20PM +0200, Tomasz Stanislawski wrote: On 10/12/2011 01:48 PM, Sakari Ailus wrote: Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-14 Thread Sakari Ailus
On Wed, Oct 12, 2011 at 05:08:20PM +0200, Tomasz Stanislawski wrote: On 10/12/2011 01:48 PM, Sakari Ailus wrote: Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index fca24cc..b7471fe

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-12 Thread Sakari Ailus
Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index fca24cc..b7471fe 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -738,6 +738,48 @@ struct v4l2_crop {

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-12 Thread Tomasz Stanislawski
On 10/12/2011 01:48 PM, Sakari Ailus wrote: Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index fca24cc..b7471fe 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-12 Thread Sakari Ailus
On Wed, Oct 12, 2011 at 05:08:20PM +0200, Tomasz Stanislawski wrote: On 10/12/2011 01:48 PM, Sakari Ailus wrote: Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index fca24cc..b7471fe

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-29 Thread Tomasz Stanislawski
Hi Hans, On 09/27/2011 10:28 AM, Hans Verkuil wrote: Here is my 'better late than never' review :-) On Wednesday, August 31, 2011 14:28:20 Tomasz Stanislawski wrote: This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-27 Thread Hans Verkuil
Here is my 'better late than never' review :-) On Wednesday, August 31, 2011 14:28:20 Tomasz Stanislawski wrote: This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are VIDIOC_S_SELECTION and VIDIOC_G_SELECTION.

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-23 Thread Laurent Pinchart
Hi Tomasz, Thanks for the patch, and sorry for the late reply. On Wednesday 31 August 2011 14:28:20 Tomasz Stanislawski wrote: This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are VIDIOC_S_SELECTION and

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-05 Thread Sakari Ailus
Hi Tomasz, Thanks for the patch! On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are VIDIOC_S_SELECTION and VIDIOC_G_SELECTION. Signed-off-by:

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-05 Thread Laurent Pinchart
Hi Sakari, On Monday 05 September 2011 12:25:08 Sakari Ailus wrote: On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are VIDIOC_S_SELECTION and

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-05 Thread Sakari Ailus
On Mon, Sep 05, 2011 at 02:52:03PM +0200, Laurent Pinchart wrote: Hi Sakari, On Monday 05 September 2011 12:25:08 Sakari Ailus wrote: On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: This patch introduces new api for a precise control of cropping and composing

[PATCH 1/4] v4l: add support for selection api

2011-08-31 Thread Tomasz Stanislawski
This patch introduces new api for a precise control of cropping and composing features for video devices. The new ioctls are VIDIOC_S_SELECTION and VIDIOC_G_SELECTION. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---