Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Linus Walleij
On Wed, Nov 27, 2013 at 5:40 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: (CC'ing Linus Walleij, Wolfram Sang and LAKML) On Wednesday 27 November 2013 16:32:01 Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: Yes, of course. Although the adv7604 has two interrupt

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Lars-Peter Clausen
On 11/29/2013 11:37 AM, Linus Walleij wrote: On Wed, Nov 27, 2013 at 5:40 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: (CC'ing Linus Walleij, Wolfram Sang and LAKML) On Wednesday 27 November 2013 16:32:01 Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: Yes, of

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Valentine
On 11/29/2013 02:45 PM, Lars-Peter Clausen wrote: On 11/29/2013 11:37 AM, Linus Walleij wrote: On Wed, Nov 27, 2013 at 5:40 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: (CC'ing Linus Walleij, Wolfram Sang and LAKML) On Wednesday 27 November 2013 16:32:01 Valentine wrote: On

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Linus Walleij
On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen l...@metafoo.de wrote: On 11/29/2013 11:37 AM, Linus Walleij wrote: (...) Specifically you should be able to request an IRQ from the irq_chip portions of the driver without first requesting the GPIO line. Some drivers already support this.

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Linus Walleij
On Fri, Nov 29, 2013 at 1:14 PM, Valentine valentine.bars...@cogentembedded.com wrote: On 11/29/2013 02:45 PM, Lars-Peter Clausen wrote: On 11/29/2013 11:37 AM, Linus Walleij wrote: So I guess the answer to the question is something like, fix the GPIO driver to stop requiring the GPIO lines

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Lars-Peter Clausen
On 11/29/2013 02:42 PM, Linus Walleij wrote: On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen l...@metafoo.de wrote: On 11/29/2013 11:37 AM, Linus Walleij wrote: (...) Specifically you should be able to request an IRQ from the irq_chip portions of the driver without first requesting the

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Linus Walleij
On Fri, Nov 29, 2013 at 2:48 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 11/29/2013 02:42 PM, Linus Walleij wrote: On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen l...@metafoo.de wrote: As far as I understand it this already works more or less with the driver. The problem is that

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Laurent Pinchart
Hi Linus, On Friday 29 November 2013 20:52:17 Linus Walleij wrote: On Fri, Nov 29, 2013 at 2:48 PM, Lars-Peter Clausen wrote: On 11/29/2013 02:42 PM, Linus Walleij wrote: On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen wrote: As far as I understand it this already works more or less

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Lars-Peter Clausen
On 11/29/2013 08:52 PM, Linus Walleij wrote: On Fri, Nov 29, 2013 at 2:48 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 11/29/2013 02:42 PM, Linus Walleij wrote: On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen l...@metafoo.de wrote: As far as I understand it this already works more

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Linus Walleij
On Fri, Nov 29, 2013 at 9:05 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 11/29/2013 08:52 PM, Linus Walleij wrote: I guess you may be referring to the problem of instatiating a dynamic IRQ chip in *board code* and then passing the obtained dynamic IRQ numbers as resources to the devices

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-29 Thread Lars-Peter Clausen
On 11/26/2013 11:06 PM, Lars-Peter Clausen wrote: On 11/26/2013 11:03 PM, Laurent Pinchart wrote: On Tuesday 26 November 2013 23:03:19 Lars-Peter Clausen wrote: On 11/26/2013 11:00 PM, Laurent Pinchart wrote: On Tuesday 26 November 2013 22:43:32 Lars-Peter Clausen wrote: On 11/26/2013 10:28

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
[...] I had to implement the IRQ handler since the soc_camera model does not use interrupt_service_routine subdevice callback and R-Car VIN knows nothing about adv7612 interrupt routed to a GPIO pin. So I had to schedule a workqueue and call adv7604_isr from there in case an interrupt

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 12:21 PM, Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/27/13 11:29, Valentine wrote: On 11/27/2013 12:21 PM, Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
On 11/27/13 10:59, Lars-Peter Clausen wrote: [...] I had to implement the IRQ handler since the soc_camera model does not use interrupt_service_routine subdevice callback and R-Car VIN knows nothing about adv7612 interrupt routed to a GPIO pin. So I had to schedule a workqueue and call

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Hans Verkuil
Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 04:14 PM, Hans Verkuil wrote: Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
On 11/27/2013 01:32 PM, Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Valentine
On 11/27/2013 05:07 PM, Lars-Peter Clausen wrote: On 11/27/2013 01:32 PM, Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: Hi Laurent, On 11/27/13 12:39, Laurent Pinchart wrote: Hi Hans, On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM,

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
On 11/27/2013 01:14 PM, Hans Verkuil wrote: [...] For our systems the adv7604 interrupts is not always hooked up to a gpio irq, instead a register has to be read to figure out which device actually produced the irq. Where is that register located ? Shouldn't it be modeled as an interrupt

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Hans, On Wednesday 27 November 2013 13:14:41 Hans Verkuil wrote: On 11/27/13 12:39, Laurent Pinchart wrote: On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
Hi Valentine, (CC'ing Linus Walleij, Wolfram Sang and LAKML) On Wednesday 27 November 2013 16:32:01 Valentine wrote: On 11/27/2013 04:14 PM, Hans Verkuil wrote: On 11/27/13 12:39, Laurent Pinchart wrote: On Wednesday 27 November 2013 09:21:22 Hans Verkuil wrote: On 11/26/2013 10:28 PM,

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Lars-Peter Clausen
[...] The driver enables multiple interrupts on the chip, however, the adv7604_isr callback doesn't seem to handle them correctly. According to the docs: If an interrupt event occurs, and then a second interrupt event occurs before the system controller has cleared or masked the first

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-27 Thread Laurent Pinchart
On Wednesday 27 November 2013 15:50:18 Lars-Peter Clausen wrote: On 11/27/2013 01:14 PM, Hans Verkuil wrote: [...] For our systems the adv7604 interrupts is not always hooked up to a gpio irq, instead a register has to be read to figure out which device actually produced the irq.

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Valentine
On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I missed that one somehow, although I did search

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Lars-Peter Clausen
On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Valentine
On 11/27/2013 01:43 AM, Lars-Peter Clausen wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Laurent Pinchart
Hi Lars, On Tuesday 26 November 2013 22:43:32 Lars-Peter Clausen wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look at this adv7611 driver:

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Lars-Peter Clausen
On 11/26/2013 10:57 PM, Valentine wrote: [...] [...] I'd also appreciate your thoughts about the issues I've described, which have been replaced by [...] here. Those seem to be mostly issues that also apply to the adv7604 and should be fixed anyway. Hans knows the code much better than me

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Lars-Peter Clausen
On 11/26/2013 11:00 PM, Laurent Pinchart wrote: Hi Lars, On Tuesday 26 November 2013 22:43:32 Lars-Peter Clausen wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, Did you ever look

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Laurent Pinchart
On Tuesday 26 November 2013 23:03:19 Lars-Peter Clausen wrote: On 11/26/2013 11:00 PM, Laurent Pinchart wrote: On Tuesday 26 November 2013 22:43:32 Lars-Peter Clausen wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM, Valentine wrote: On 11/20/2013 07:42 PM, Hans

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-26 Thread Lars-Peter Clausen
On 11/26/2013 11:03 PM, Laurent Pinchart wrote: On Tuesday 26 November 2013 23:03:19 Lars-Peter Clausen wrote: On 11/26/2013 11:00 PM, Laurent Pinchart wrote: On Tuesday 26 November 2013 22:43:32 Lars-Peter Clausen wrote: On 11/26/2013 10:28 PM, Valentine wrote: On 11/20/2013 07:53 PM,

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
On 11/19/2013 01:50 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, thanks for your review. I don't entirely understand how you use this driver with soc-camera. Since soc-camera doesn't support FMT_CHANGE notifies it can't really act on it. Did you hack soc-camera to do this? I did not.

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Hans Verkuil
Hi Valentine, On 11/20/13 11:14, Valentine wrote: On 11/19/2013 01:50 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, thanks for your review. I don't entirely understand how you use this driver with soc-camera. Since soc-camera doesn't support FMT_CHANGE notifies it can't really act on

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
On 11/20/2013 03:19 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, On 11/20/13 11:14, Valentine wrote: On 11/19/2013 01:50 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, thanks for your review. I don't entirely understand how you use this driver with soc-camera. Since soc-camera

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Hans Verkuil
Hi Valentine, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 It adds adv761x support to the adv7604 in a pretty clean way. Thinking it over I prefer to use that code (although you will have to add the soc-camera

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-20 Thread Valentine
On 11/20/2013 07:42 PM, Hans Verkuil wrote: Hi Valentine, Did you ever look at this adv7611 driver: https://github.com/Xilinx/linux-xlnx/commit/610b9d5de22ae7c0047c65a07e4afa42af2daa12 No, I missed that one somehow, although I did search for the adv7611/7612 before implementing this one.

Re: [PATCH V2] media: i2c: Add ADV761X support

2013-11-19 Thread Hans Verkuil
Hi Valentine, I don't entirely understand how you use this driver with soc-camera. Since soc-camera doesn't support FMT_CHANGE notifies it can't really act on it. Did you hack soc-camera to do this? The way it stands I would prefer to see a version of the driver without soc-camera support. I

[PATCH V2] media: i2c: Add ADV761X support

2013-11-15 Thread Valentine Barshak
This adds ADV7611/ADV7612 Xpressview HDMI Receiver base support. Only one HDMI port is supported on ADV7612. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Changes in version 2: * Used platform data for I2C addresses setup. The driver