Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-13 Thread Tomi Valkeinen
On 13/04/17 12:12, Hans Verkuil wrote: >> Is there anything else CEC needs to access or control (besides the CEC >> IP itself)? > > The CEC framework needs to be informed about the physical address contained > in the EDID (part of the CEA-861 block). And when the HPD goes down it needs > to be

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-13 Thread Hans Verkuil
On 04/13/2017 10:43 AM, Tomi Valkeinen wrote: > On 12/04/17 17:04, Hans Verkuil wrote: > >>> So is some other driver supporting this already? Or is the omap4 the >>> first platform you're trying this on? >> >> No, there are quite a few CEC drivers by now, but typically the CEC block is >> a

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-13 Thread Tomi Valkeinen
On 12/04/17 17:04, Hans Verkuil wrote: >> So is some other driver supporting this already? Or is the omap4 the >> first platform you're trying this on? > > No, there are quite a few CEC drivers by now, but typically the CEC block is > a totally independent IP block with its own power, irq, etc.

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-12 Thread Hans Verkuil
On 04/12/2017 03:21 PM, Tomi Valkeinen wrote: > On 12/04/17 16:03, Hans Verkuil wrote: > >> I noticed while experimenting with this that tpd_disconnect() in >> drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c isn't called when >> I disconnect the HDMI cable. Is that a bug somewhere? >> >> I

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-12 Thread Tomi Valkeinen
On 12/04/17 16:03, Hans Verkuil wrote: > I noticed while experimenting with this that tpd_disconnect() in > drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c isn't called when > I disconnect the HDMI cable. Is that a bug somewhere? > > I would expect that tpd_connect and tpd_disconnect are

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-12 Thread Hans Verkuil
On 04/12/2017 03:03 PM, Hans Verkuil wrote: > Hi Tomi, > > On 04/10/2017 01:59 PM, Tomi Valkeinen wrote: >> On 08/04/17 13:11, Hans Verkuil wrote: >> >>> So, this is a bit of a blast from the past since the omap4 CEC development >>> has been on hold for almost a year. But I am about to resume my

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-12 Thread Hans Verkuil
Hi Tomi, On 04/10/2017 01:59 PM, Tomi Valkeinen wrote: > On 08/04/17 13:11, Hans Verkuil wrote: > >> So, this is a bit of a blast from the past since the omap4 CEC development >> has been on hold for almost a year. But I am about to resume my work on this >> now that the CEC framework was

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-10 Thread Tomi Valkeinen
On 08/04/17 13:11, Hans Verkuil wrote: > So, this is a bit of a blast from the past since the omap4 CEC development > has been on hold for almost a year. But I am about to resume my work on this > now that the CEC framework was merged. > > The latest code is here, if you are interested: > >

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-08 Thread Hans Verkuil
On 04/08/2017 12:11 PM, Hans Verkuil wrote: > Hi Tomi, > > On 05/10/2016 01:36 PM, Tomi Valkeinen wrote: >> Hi Hans, >> >> On 29/04/16 12:39, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> As long as there is a valid physical address in the EDID and the omap >>> CEC

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2017-04-08 Thread Hans Verkuil
Hi Tomi, On 05/10/2016 01:36 PM, Tomi Valkeinen wrote: > Hi Hans, > > On 29/04/16 12:39, Hans Verkuil wrote: >> From: Hans Verkuil >> >> As long as there is a valid physical address in the EDID and the omap >> CEC support is enabled, then we keep ls_oe_gpio on to ensure

Re: [RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2016-05-10 Thread Tomi Valkeinen
Hi Hans, On 29/04/16 12:39, Hans Verkuil wrote: > From: Hans Verkuil > > As long as there is a valid physical address in the EDID and the omap > CEC support is enabled, then we keep ls_oe_gpio on to ensure the CEC > signal is passed through the tpd12s015. > >

[RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil As long as there is a valid physical address in the EDID and the omap CEC support is enabled, then we keep ls_oe_gpio on to ensure the CEC signal is passed through the tpd12s015. Signed-off-by: Hans Verkuil Suggested-by: Tomi